From: Baruch Siach <baruch@tkos.co.il> To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Cc: linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Date: Wed, 18 May 2022 07:16:01 +0300 [thread overview] Message-ID: <87tu9nqxtk.fsf@tarshish> (raw) In-Reply-To: <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> Hi Ilpo, On Tue, May 17 2022, Ilpo Järvinen wrote: > Only CS7 and CS8 seem supported but CSIZE is not sanitized to CS8 in > the default: block. > > Set CSIZE correctly so that userspace knows the effective value. > Incorrect CSIZE also results in miscalculation of the frame bits in > tty_get_char_size() or in its predecessor where the roughly the same > code is directly within uart_update_timeout(). > > Cc: Baruch Siach <baruch@tkos.co.il> > Fixes: 5930cb3511df (serial: driver for Conexant Digicolor USART) > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c > index 6d70fea76bb3..65e653eb5026 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -309,6 +309,8 @@ static void digicolor_uart_set_termios(struct uart_port *port, > case CS8: > default: > config |= UA_CONFIG_CHAR_LEN; > + termios->c_cflag &= ~CSIZE; > + termios->c_cflag |= CS8; > break; > } -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il> To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Cc: linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Date: Wed, 18 May 2022 07:16:01 +0300 [thread overview] Message-ID: <87tu9nqxtk.fsf@tarshish> (raw) In-Reply-To: <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> Hi Ilpo, On Tue, May 17 2022, Ilpo Järvinen wrote: > Only CS7 and CS8 seem supported but CSIZE is not sanitized to CS8 in > the default: block. > > Set CSIZE correctly so that userspace knows the effective value. > Incorrect CSIZE also results in miscalculation of the frame bits in > tty_get_char_size() or in its predecessor where the roughly the same > code is directly within uart_update_timeout(). > > Cc: Baruch Siach <baruch@tkos.co.il> > Fixes: 5930cb3511df (serial: driver for Conexant Digicolor USART) > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c > index 6d70fea76bb3..65e653eb5026 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -309,6 +309,8 @@ static void digicolor_uart_set_termios(struct uart_port *port, > case CS8: > default: > config |= UA_CONFIG_CHAR_LEN; > + termios->c_cflag &= ~CSIZE; > + termios->c_cflag |= CS8; > break; > } -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-18 4:17 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-17 11:07 [PATCH 0/9] tty/serial: Termios flag fixes Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 1/9] serial: uartline: Fix BRKINT clearing Ilpo Järvinen 2022-05-17 14:33 ` Sean Anderson 2022-05-18 12:18 ` Shubhrajyoti Datta 2022-05-18 12:25 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-18 4:16 ` Baruch Siach [this message] 2022-05-18 4:16 ` Baruch Siach 2022-05-17 11:07 ` [PATCH 3/9] serial: rda-uart: " Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 4/9] serial: txx9: " Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 5/9] serial: sh-sci: " Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 6/9] serial: sifive: Sanitize CSIZE and c_iflag Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 7/9] serial: st-asc: Sanitize CSIZE and correct PARENB for CS7 Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 8/9] serial: stm32-usart: Correct CSIZE, bits, and parity Ilpo Järvinen 2022-05-17 11:07 ` Ilpo Järvinen 2022-05-17 11:07 ` [PATCH 9/9] pcmcia: synclink_cs: Don't allow CS5-6 Ilpo Järvinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87tu9nqxtk.fsf@tarshish \ --to=baruch@tkos.co.il \ --cc=gregkh@linuxfoundation.org \ --cc=ilpo.jarvinen@linux.intel.com \ --cc=jirislaby@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.