* [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
@ 2022-05-20 21:38 ` Douglas Anderson
2022-05-22 7:54 ` Krzysztof Kozlowski
2022-05-20 21:38 ` [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Douglas Anderson
` (3 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Douglas Anderson @ 2022-05-20 21:38 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree,
Douglas Anderson, Stephen Boyd, linux-kernel
The qcom.yaml bindings file has a whole description of what the
top-level compatible should look like for Qualcomm devices. It doesn't
match what Chromebooks do, so add a link to the Chromebook docs.
Reported-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
The link added here will (obviously) not function until the
documentation patch makes it to mainline. Presumably folks who want to
read it in the meantime can find it pretty easily. If there's a better
way to link this then please let me know.
Changes in v4:
- Use docs.kernel.org link.
Changes in v3:
- ("Mention that Chromebooks use a different scheme") split out for v3.
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5c06d1bfc046..5ac28e11ea7b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -90,6 +90,11 @@ description: |
A dragonboard board v0.1 of subtype 1 with an apq8074 SoC version 2, made in
foundry 2.
+ There are many devices in the list below that run the standard ChromeOS
+ bootloader setup and use the open source depthcharge bootloader to boot the
+ OS. These devices do not use the scheme described above. For details, see:
+ https://docs.kernel.org/arm/google/chromebook-boot-flow.html
+
properties:
$nodename:
const: "/"
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme
2022-05-20 21:38 ` [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme Douglas Anderson
@ 2022-05-22 7:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-22 7:54 UTC (permalink / raw)
To: Douglas Anderson, Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree, Stephen Boyd,
linux-kernel
On 20/05/2022 23:38, Douglas Anderson wrote:
> The qcom.yaml bindings file has a whole description of what the
> top-level compatible should look like for Qualcomm devices. It doesn't
> match what Chromebooks do, so add a link to the Chromebook docs.
>
> Reported-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
2022-05-20 21:38 ` [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme Douglas Anderson
@ 2022-05-20 21:38 ` Douglas Anderson
2022-05-22 7:57 ` Krzysztof Kozlowski
2022-05-20 21:38 ` [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 " Douglas Anderson
` (2 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Douglas Anderson @ 2022-05-20 21:38 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree,
Douglas Anderson, Stephen Boyd, linux-kernel
This copy-pastes compatibles from sc7180-based boards from the device
trees to the yaml file so that `make dtbs_check` will be happy.
NOTES:
- I make no attempt to try to share an "item" for all sc7180 based
Chromebooks. Because of the revision matching scheme used by the
Chromebook bootloader, at times we need a different number of
revisions listed.
- Some of the odd entries in here (like google,homestar-rev23 or the
fact that "Google Lazor Limozeen without Touchscreen" changed from
sku5 to sku6) are not typos but simply reflect reality.
- Many revisions of boards here never actually went to consumers, but
they are still in use within various companies that were involved in
Chromebook development. Since Chromebooks are developed with an
"upstream first" methodology, having these revisions supported with
upstream Linux is important. Making it easy for Chromebooks to be
developed with an "upstream first" methodology is valuable to the
upstream community because it improves the quality of upstream and
gets Chromebooks supported with vanilla upstream faster.
One other note here is that, though the bootloader effectively treats
the list of compatibles in a given device tree as unordered, some
people would prefer future boards to list higher-numbered revisions
first in the list. Chromebooks here are not changing and typically
list lower revisions first just to avoid churn.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
(no changes since v3)
Changes in v3:
- Split link to Chromebook boot doc into a separate patch.
- Added a note to desc about revision ordering within a device tree.
Changes in v2:
- Add link to doc about how Chromebook devicetrees work.
- Use a "description" instead of a comment for each item.
- Use the marketing name instead of the code name where possible.
.../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
1 file changed, 181 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5ac28e11ea7b..01e40ea40724 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -219,11 +219,191 @@ properties:
- qcom,ipq8074-hk10-c2
- const: qcom,ipq8074
- - items:
+ - description: Qualcomm Technologies, Inc. SC7180 IDP
+ items:
- enum:
- qcom,sc7180-idp
- const: qcom,sc7180
+ - description: HP Chromebook x2 11c (rev1 - 2)
+ items:
+ - const: google,coachz-rev1
+ - const: google,coachz-rev2
+ - const: qcom,sc7180
+
+ - description: HP Chromebook x2 11c (newest rev)
+ items:
+ - const: google,coachz
+ - const: qcom,sc7180
+
+ - description: HP Chromebook x2 11c with LTE (rev1 - 2)
+ items:
+ - const: google,coachz-rev1-sku0
+ - const: google,coachz-rev2-sku0
+ - const: qcom,sc7180
+
+ - description: HP Chromebook x2 11c with LTE (newest rev)
+ items:
+ - const: google,coachz-sku0
+ - const: qcom,sc7180
+
+ - description: Lenovo Chromebook Duet 5 13 (rev2)
+ items:
+ - const: google,homestar-rev2
+ - const: google,homestar-rev23
+ - const: qcom,sc7180
+
+ - description: Lenovo Chromebook Duet 5 13 (rev3)
+ items:
+ - const: google,homestar-rev3
+ - const: qcom,sc7180
+
+ - description: Lenovo Chromebook Duet 5 13 (newest rev)
+ items:
+ - const: google,homestar
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 (rev0)
+ items:
+ - const: google,lazor-rev0
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 (rev1 - 2)
+ items:
+ - const: google,lazor-rev1
+ - const: google,lazor-rev2
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 (rev3 - 8)
+ items:
+ - const: google,lazor-rev3
+ - const: google,lazor-rev4
+ - const: google,lazor-rev5
+ - const: google,lazor-rev6
+ - const: google,lazor-rev7
+ - const: google,lazor-rev8
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 (newest rev)
+ items:
+ - const: google,lazor
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
+ items:
+ - const: google,lazor-rev1-sku2
+ - const: google,lazor-rev2-sku2
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
+ items:
+ - const: google,lazor-rev3-sku2
+ - const: google,lazor-rev4-sku2
+ - const: google,lazor-rev5-sku2
+ - const: google,lazor-rev6-sku2
+ - const: google,lazor-rev7-sku2
+ - const: google,lazor-rev8-sku2
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
+ items:
+ - const: google,lazor-sku2
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
+ items:
+ - const: google,lazor-rev1-sku0
+ - const: google,lazor-rev2-sku0
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
+ items:
+ - const: google,lazor-rev3-sku0
+ - const: google,lazor-rev4-sku0
+ - const: google,lazor-rev5-sku0
+ - const: google,lazor-rev6-sku0
+ - const: google,lazor-rev7-sku0
+ - const: google,lazor-rev8-sku0
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook Spin 513 with LTE (newest rev)
+ items:
+ - const: google,lazor-sku0
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook 511 (rev4 - rev8)
+ items:
+ - const: google,lazor-rev4-sku4
+ - const: google,lazor-rev5-sku4
+ - const: google,lazor-rev6-sku4
+ - const: google,lazor-rev7-sku4
+ - const: google,lazor-rev8-sku4
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook 511 (newest rev)
+ items:
+ - const: google,lazor-sku4
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook 511 without Touchscreen (rev4)
+ items:
+ - const: google,lazor-rev4-sku5
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
+ items:
+ - const: google,lazor-rev5-sku5
+ - const: google,lazor-rev5-sku6
+ - const: google,lazor-rev6-sku6
+ - const: google,lazor-rev7-sku6
+ - const: google,lazor-rev8-sku6
+ - const: qcom,sc7180
+
+ - description: Acer Chromebook 511 without Touchscreen (newest rev)
+ items:
+ - const: google,lazor-sku6
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 (rev1)
+ items:
+ - const: google,pompom-rev1
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 (rev2)
+ items:
+ - const: google,pompom-rev2
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 (newest rev)
+ items:
+ - const: google,pompom
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 with LTE (rev1)
+ items:
+ - const: google,pompom-rev1-sku0
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 with LTE (rev2)
+ items:
+ - const: google,pompom-rev2-sku0
+ - const: qcom,sc7180
+
+ - description: Sharp Dynabook Chromebook C1 with LTE (newest rev)
+ items:
+ - const: google,pompom-sku0
+ - const: qcom,sc7180
+
+ - description: Google Trogdor (newest rev)
+ items:
+ - const: google,trogdor
+ - const: qcom,sc7180
+
+ - description: Google Trogdor with LTE (newest rev)
+ items:
+ - const: google,trogdor-sku0
+ - const: qcom,sc7180
+
- items:
- enum:
- qcom,sc7280-crd
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
2022-05-20 21:38 ` [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Douglas Anderson
@ 2022-05-22 7:57 ` Krzysztof Kozlowski
2022-05-23 16:16 ` Doug Anderson
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-22 7:57 UTC (permalink / raw)
To: Douglas Anderson, Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree, Stephen Boyd,
linux-kernel
On 20/05/2022 23:38, Douglas Anderson wrote:
> This copy-pastes compatibles from sc7180-based boards from the device
> trees to the yaml file so that `make dtbs_check` will be happy.
>
> NOTES:
> - I make no attempt to try to share an "item" for all sc7180 based
> Chromebooks. Because of the revision matching scheme used by the
> Chromebook bootloader, at times we need a different number of
> revisions listed.
> - Some of the odd entries in here (like google,homestar-rev23 or the
> fact that "Google Lazor Limozeen without Touchscreen" changed from
> sku5 to sku6) are not typos but simply reflect reality.
> - Many revisions of boards here never actually went to consumers, but
> they are still in use within various companies that were involved in
> Chromebook development. Since Chromebooks are developed with an
> "upstream first" methodology, having these revisions supported with
> upstream Linux is important. Making it easy for Chromebooks to be
> developed with an "upstream first" methodology is valuable to the
> upstream community because it improves the quality of upstream and
> gets Chromebooks supported with vanilla upstream faster.
>
> One other note here is that, though the bootloader effectively treats
> the list of compatibles in a given device tree as unordered, some
> people would prefer future boards to list higher-numbered revisions
> first in the list. Chromebooks here are not changing and typically
> list lower revisions first just to avoid churn.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - Split link to Chromebook boot doc into a separate patch.
> - Added a note to desc about revision ordering within a device tree.
>
> Changes in v2:
> - Add link to doc about how Chromebook devicetrees work.
> - Use a "description" instead of a comment for each item.
> - Use the marketing name instead of the code name where possible.
>
> .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
> 1 file changed, 181 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5ac28e11ea7b..01e40ea40724 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -219,11 +219,191 @@ properties:
> - qcom,ipq8074-hk10-c2
> - const: qcom,ipq8074
>
> - - items:
> + - description: Qualcomm Technologies, Inc. SC7180 IDP
> + items:
> - enum:
> - qcom,sc7180-idp
> - const: qcom,sc7180
>
> + - description: HP Chromebook x2 11c (rev1 - 2)
> + items:
> + - const: google,coachz-rev1
> + - const: google,coachz-rev2
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c (newest rev)
> + items:
> + - const: google,coachz
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c with LTE (rev1 - 2)
> + items:
> + - const: google,coachz-rev1-sku0
> + - const: google,coachz-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c with LTE (newest rev)
> + items:
> + - const: google,coachz-sku0
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (rev2)
> + items:
> + - const: google,homestar-rev2
> + - const: google,homestar-rev23
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (rev3)
> + items:
> + - const: google,homestar-rev3
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (newest rev)
> + items:
> + - const: google,homestar
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev0)
> + items:
> + - const: google,lazor-rev0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev1 - 2)
> + items:
> + - const: google,lazor-rev1
> + - const: google,lazor-rev2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev3 - 8)
> + items:
> + - const: google,lazor-rev3
> + - const: google,lazor-rev4
> + - const: google,lazor-rev5
> + - const: google,lazor-rev6
> + - const: google,lazor-rev7
> + - const: google,lazor-rev8
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (newest rev)
> + items:
> + - const: google,lazor
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
> + items:
> + - const: google,lazor-rev1-sku2
> + - const: google,lazor-rev2-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
> + items:
> + - const: google,lazor-rev3-sku2
> + - const: google,lazor-rev4-sku2
> + - const: google,lazor-rev5-sku2
> + - const: google,lazor-rev6-sku2
> + - const: google,lazor-rev7-sku2
> + - const: google,lazor-rev8-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> + items:
> + - const: google,lazor-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
> + items:
> + - const: google,lazor-rev1-sku0
> + - const: google,lazor-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
> + items:
> + - const: google,lazor-rev3-sku0
> + - const: google,lazor-rev4-sku0
> + - const: google,lazor-rev5-sku0
> + - const: google,lazor-rev6-sku0
> + - const: google,lazor-rev7-sku0
> + - const: google,lazor-rev8-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (newest rev)
> + items:
> + - const: google,lazor-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 (rev4 - rev8)
> + items:
> + - const: google,lazor-rev4-sku4
> + - const: google,lazor-rev5-sku4
> + - const: google,lazor-rev6-sku4
> + - const: google,lazor-rev7-sku4
> + - const: google,lazor-rev8-sku4
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 (newest rev)
> + items:
> + - const: google,lazor-sku4
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (rev4)
> + items:
> + - const: google,lazor-rev4-sku5
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
> + items:
> + - const: google,lazor-rev5-sku5
> + - const: google,lazor-rev5-sku6
> + - const: google,lazor-rev6-sku6
> + - const: google,lazor-rev7-sku6
> + - const: google,lazor-rev8-sku6
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (newest rev)
> + items:
> + - const: google,lazor-sku6
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (rev1)
> + items:
> + - const: google,pompom-rev1
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (rev2)
> + items:
> + - const: google,pompom-rev2
I understand why you do not share "item" (your first notes) for some of
boards, but I don't get why "google,pompom-rev1" cannot be combined with
"google,pompom-rev2". Do you see any chances to alter the bindings for
these two boards?
The same for other such cases (not newest revision).
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (newest rev)
> + items:
> + - const: google,pompom
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (rev1)
> + items:
> + - const: google,pompom-rev1-sku0
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (rev2)
> + items:
> + - const: google,pompom-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (newest rev)
> + items:
> + - const: google,pompom-sku0
> + - const: qcom,sc7180
> +
> + - description: Google Trogdor (newest rev)
> + items:
> + - const: google,trogdor
> + - const: qcom,sc7180
> +
> + - description: Google Trogdor with LTE (newest rev)
> + items:
> + - const: google,trogdor-sku0
> + - const: qcom,sc7180
> +
> - items:
> - enum:
> - qcom,sc7280-crd
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
2022-05-22 7:57 ` Krzysztof Kozlowski
@ 2022-05-23 16:16 ` Doug Anderson
2022-05-24 9:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Doug Anderson @ 2022-05-23 16:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
Hi,
On Sun, May 22, 2022 at 12:57 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/05/2022 23:38, Douglas Anderson wrote:
> > This copy-pastes compatibles from sc7180-based boards from the device
> > trees to the yaml file so that `make dtbs_check` will be happy.
> >
> > NOTES:
> > - I make no attempt to try to share an "item" for all sc7180 based
> > Chromebooks. Because of the revision matching scheme used by the
> > Chromebook bootloader, at times we need a different number of
> > revisions listed.
> > - Some of the odd entries in here (like google,homestar-rev23 or the
> > fact that "Google Lazor Limozeen without Touchscreen" changed from
> > sku5 to sku6) are not typos but simply reflect reality.
> > - Many revisions of boards here never actually went to consumers, but
> > they are still in use within various companies that were involved in
> > Chromebook development. Since Chromebooks are developed with an
> > "upstream first" methodology, having these revisions supported with
> > upstream Linux is important. Making it easy for Chromebooks to be
> > developed with an "upstream first" methodology is valuable to the
> > upstream community because it improves the quality of upstream and
> > gets Chromebooks supported with vanilla upstream faster.
> >
> > One other note here is that, though the bootloader effectively treats
> > the list of compatibles in a given device tree as unordered, some
> > people would prefer future boards to list higher-numbered revisions
> > first in the list. Chromebooks here are not changing and typically
> > list lower revisions first just to avoid churn.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >
> > (no changes since v3)
> >
> > Changes in v3:
> > - Split link to Chromebook boot doc into a separate patch.
> > - Added a note to desc about revision ordering within a device tree.
> >
> > Changes in v2:
> > - Add link to doc about how Chromebook devicetrees work.
> > - Use a "description" instead of a comment for each item.
> > - Use the marketing name instead of the code name where possible.
> >
> > .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
> > 1 file changed, 181 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 5ac28e11ea7b..01e40ea40724 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -219,11 +219,191 @@ properties:
> > - qcom,ipq8074-hk10-c2
> > - const: qcom,ipq8074
> >
> > - - items:
> > + - description: Qualcomm Technologies, Inc. SC7180 IDP
> > + items:
> > - enum:
> > - qcom,sc7180-idp
> > - const: qcom,sc7180
> >
> > + - description: HP Chromebook x2 11c (rev1 - 2)
> > + items:
> > + - const: google,coachz-rev1
> > + - const: google,coachz-rev2
> > + - const: qcom,sc7180
> > +
> > + - description: HP Chromebook x2 11c (newest rev)
> > + items:
> > + - const: google,coachz
> > + - const: qcom,sc7180
> > +
> > + - description: HP Chromebook x2 11c with LTE (rev1 - 2)
> > + items:
> > + - const: google,coachz-rev1-sku0
> > + - const: google,coachz-rev2-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: HP Chromebook x2 11c with LTE (newest rev)
> > + items:
> > + - const: google,coachz-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: Lenovo Chromebook Duet 5 13 (rev2)
> > + items:
> > + - const: google,homestar-rev2
> > + - const: google,homestar-rev23
> > + - const: qcom,sc7180
> > +
> > + - description: Lenovo Chromebook Duet 5 13 (rev3)
> > + items:
> > + - const: google,homestar-rev3
> > + - const: qcom,sc7180
> > +
> > + - description: Lenovo Chromebook Duet 5 13 (newest rev)
> > + items:
> > + - const: google,homestar
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 (rev0)
> > + items:
> > + - const: google,lazor-rev0
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 (rev1 - 2)
> > + items:
> > + - const: google,lazor-rev1
> > + - const: google,lazor-rev2
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 (rev3 - 8)
> > + items:
> > + - const: google,lazor-rev3
> > + - const: google,lazor-rev4
> > + - const: google,lazor-rev5
> > + - const: google,lazor-rev6
> > + - const: google,lazor-rev7
> > + - const: google,lazor-rev8
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 (newest rev)
> > + items:
> > + - const: google,lazor
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
> > + items:
> > + - const: google,lazor-rev1-sku2
> > + - const: google,lazor-rev2-sku2
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
> > + items:
> > + - const: google,lazor-rev3-sku2
> > + - const: google,lazor-rev4-sku2
> > + - const: google,lazor-rev5-sku2
> > + - const: google,lazor-rev6-sku2
> > + - const: google,lazor-rev7-sku2
> > + - const: google,lazor-rev8-sku2
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> > + items:
> > + - const: google,lazor-sku2
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
> > + items:
> > + - const: google,lazor-rev1-sku0
> > + - const: google,lazor-rev2-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
> > + items:
> > + - const: google,lazor-rev3-sku0
> > + - const: google,lazor-rev4-sku0
> > + - const: google,lazor-rev5-sku0
> > + - const: google,lazor-rev6-sku0
> > + - const: google,lazor-rev7-sku0
> > + - const: google,lazor-rev8-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook Spin 513 with LTE (newest rev)
> > + items:
> > + - const: google,lazor-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook 511 (rev4 - rev8)
> > + items:
> > + - const: google,lazor-rev4-sku4
> > + - const: google,lazor-rev5-sku4
> > + - const: google,lazor-rev6-sku4
> > + - const: google,lazor-rev7-sku4
> > + - const: google,lazor-rev8-sku4
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook 511 (newest rev)
> > + items:
> > + - const: google,lazor-sku4
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook 511 without Touchscreen (rev4)
> > + items:
> > + - const: google,lazor-rev4-sku5
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
> > + items:
> > + - const: google,lazor-rev5-sku5
> > + - const: google,lazor-rev5-sku6
> > + - const: google,lazor-rev6-sku6
> > + - const: google,lazor-rev7-sku6
> > + - const: google,lazor-rev8-sku6
> > + - const: qcom,sc7180
> > +
> > + - description: Acer Chromebook 511 without Touchscreen (newest rev)
> > + items:
> > + - const: google,lazor-sku6
> > + - const: qcom,sc7180
> > +
> > + - description: Sharp Dynabook Chromebook C1 (rev1)
> > + items:
> > + - const: google,pompom-rev1
> > + - const: qcom,sc7180
> > +
> > + - description: Sharp Dynabook Chromebook C1 (rev2)
> > + items:
> > + - const: google,pompom-rev2
>
> I understand why you do not share "item" (your first notes) for some of
> boards, but I don't get why "google,pompom-rev1" cannot be combined with
> "google,pompom-rev2". Do you see any chances to alter the bindings for
> these two boards?
>
> The same for other such cases (not newest revision).
Yeah, I thought about it when I was writing the file and decided
against it. I guess it's just a style decision. If we combine these
two then I guess it raises the question: do we only combine entries
that list a single revision if they're the same board, or do we have
one uber entry at the end of the list that combines all
single-revision sc7180 Chromebooks? ...and in either case, what should
the description be?
Personally, though it takes up more lines of code, I prefer the
simplicity of having each entry here correspond to a single dts file.
Unless you feel really strongly about it, I'd tend to leave the
decision here to Bjorn.
-Doug
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
2022-05-23 16:16 ` Doug Anderson
@ 2022-05-24 9:34 ` Krzysztof Kozlowski
2022-05-24 23:00 ` Doug Anderson
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-24 9:34 UTC (permalink / raw)
To: Doug Anderson
Cc: Rob Herring, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
On 23/05/2022 18:16, Doug Anderson wrote:
> Hi,
>
> On Sun, May 22, 2022 at 12:57 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/05/2022 23:38, Douglas Anderson wrote:
>>> This copy-pastes compatibles from sc7180-based boards from the device
>>> trees to the yaml file so that `make dtbs_check` will be happy.
>>>
>>> NOTES:
>>> - I make no attempt to try to share an "item" for all sc7180 based
>>> Chromebooks. Because of the revision matching scheme used by the
>>> Chromebook bootloader, at times we need a different number of
>>> revisions listed.
>>> - Some of the odd entries in here (like google,homestar-rev23 or the
>>> fact that "Google Lazor Limozeen without Touchscreen" changed from
>>> sku5 to sku6) are not typos but simply reflect reality.
>>> - Many revisions of boards here never actually went to consumers, but
>>> they are still in use within various companies that were involved in
>>> Chromebook development. Since Chromebooks are developed with an
>>> "upstream first" methodology, having these revisions supported with
>>> upstream Linux is important. Making it easy for Chromebooks to be
>>> developed with an "upstream first" methodology is valuable to the
>>> upstream community because it improves the quality of upstream and
>>> gets Chromebooks supported with vanilla upstream faster.
>>>
>>> One other note here is that, though the bootloader effectively treats
>>> the list of compatibles in a given device tree as unordered, some
>>> people would prefer future boards to list higher-numbered revisions
>>> first in the list. Chromebooks here are not changing and typically
>>> list lower revisions first just to avoid churn.
>>>
>>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>>
>>> (no changes since v3)
>>>
>>> Changes in v3:
>>> - Split link to Chromebook boot doc into a separate patch.
>>> - Added a note to desc about revision ordering within a device tree.
>>>
>>> Changes in v2:
>>> - Add link to doc about how Chromebook devicetrees work.
>>> - Use a "description" instead of a comment for each item.
>>> - Use the marketing name instead of the code name where possible.
>>>
>>> .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
>>> 1 file changed, 181 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index 5ac28e11ea7b..01e40ea40724 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -219,11 +219,191 @@ properties:
>>> - qcom,ipq8074-hk10-c2
>>> - const: qcom,ipq8074
>>>
>>> - - items:
>>> + - description: Qualcomm Technologies, Inc. SC7180 IDP
>>> + items:
>>> - enum:
>>> - qcom,sc7180-idp
>>> - const: qcom,sc7180
>>>
>>> + - description: HP Chromebook x2 11c (rev1 - 2)
>>> + items:
>>> + - const: google,coachz-rev1
>>> + - const: google,coachz-rev2
>>> + - const: qcom,sc7180
>>> +
>>> + - description: HP Chromebook x2 11c (newest rev)
>>> + items:
>>> + - const: google,coachz
>>> + - const: qcom,sc7180
>>> +
>>> + - description: HP Chromebook x2 11c with LTE (rev1 - 2)
>>> + items:
>>> + - const: google,coachz-rev1-sku0
>>> + - const: google,coachz-rev2-sku0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: HP Chromebook x2 11c with LTE (newest rev)
>>> + items:
>>> + - const: google,coachz-sku0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Lenovo Chromebook Duet 5 13 (rev2)
>>> + items:
>>> + - const: google,homestar-rev2
>>> + - const: google,homestar-rev23
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Lenovo Chromebook Duet 5 13 (rev3)
>>> + items:
>>> + - const: google,homestar-rev3
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Lenovo Chromebook Duet 5 13 (newest rev)
>>> + items:
>>> + - const: google,homestar
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 (rev0)
>>> + items:
>>> + - const: google,lazor-rev0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 (rev1 - 2)
>>> + items:
>>> + - const: google,lazor-rev1
>>> + - const: google,lazor-rev2
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 (rev3 - 8)
>>> + items:
>>> + - const: google,lazor-rev3
>>> + - const: google,lazor-rev4
>>> + - const: google,lazor-rev5
>>> + - const: google,lazor-rev6
>>> + - const: google,lazor-rev7
>>> + - const: google,lazor-rev8
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 (newest rev)
>>> + items:
>>> + - const: google,lazor
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
>>> + items:
>>> + - const: google,lazor-rev1-sku2
>>> + - const: google,lazor-rev2-sku2
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
>>> + items:
>>> + - const: google,lazor-rev3-sku2
>>> + - const: google,lazor-rev4-sku2
>>> + - const: google,lazor-rev5-sku2
>>> + - const: google,lazor-rev6-sku2
>>> + - const: google,lazor-rev7-sku2
>>> + - const: google,lazor-rev8-sku2
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
>>> + items:
>>> + - const: google,lazor-sku2
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
>>> + items:
>>> + - const: google,lazor-rev1-sku0
>>> + - const: google,lazor-rev2-sku0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
>>> + items:
>>> + - const: google,lazor-rev3-sku0
>>> + - const: google,lazor-rev4-sku0
>>> + - const: google,lazor-rev5-sku0
>>> + - const: google,lazor-rev6-sku0
>>> + - const: google,lazor-rev7-sku0
>>> + - const: google,lazor-rev8-sku0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook Spin 513 with LTE (newest rev)
>>> + items:
>>> + - const: google,lazor-sku0
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook 511 (rev4 - rev8)
>>> + items:
>>> + - const: google,lazor-rev4-sku4
>>> + - const: google,lazor-rev5-sku4
>>> + - const: google,lazor-rev6-sku4
>>> + - const: google,lazor-rev7-sku4
>>> + - const: google,lazor-rev8-sku4
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook 511 (newest rev)
>>> + items:
>>> + - const: google,lazor-sku4
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook 511 without Touchscreen (rev4)
>>> + items:
>>> + - const: google,lazor-rev4-sku5
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
>>> + items:
>>> + - const: google,lazor-rev5-sku5
>>> + - const: google,lazor-rev5-sku6
>>> + - const: google,lazor-rev6-sku6
>>> + - const: google,lazor-rev7-sku6
>>> + - const: google,lazor-rev8-sku6
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Acer Chromebook 511 without Touchscreen (newest rev)
>>> + items:
>>> + - const: google,lazor-sku6
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Sharp Dynabook Chromebook C1 (rev1)
>>> + items:
>>> + - const: google,pompom-rev1
>>> + - const: qcom,sc7180
>>> +
>>> + - description: Sharp Dynabook Chromebook C1 (rev2)
>>> + items:
>>> + - const: google,pompom-rev2
>>
>> I understand why you do not share "item" (your first notes) for some of
>> boards, but I don't get why "google,pompom-rev1" cannot be combined with
>> "google,pompom-rev2". Do you see any chances to alter the bindings for
>> these two boards?
>>
>> The same for other such cases (not newest revision).
>
> Yeah, I thought about it when I was writing the file and decided
> against it. I guess it's just a style decision. If we combine these
> two then I guess it raises the question: do we only combine entries
> that list a single revision if they're the same board, or do we have
> one uber entry at the end of the list that combines all
> single-revision sc7180 Chromebooks? ...and in either case, what should
> the description be?
>
> Personally, though it takes up more lines of code, I prefer the
> simplicity of having each entry here correspond to a single dts file.
>
> Unless you feel really strongly about it, I'd tend to leave the
> decision here to Bjorn.
Sure. I would prefer to combine such obvious entries, so not everything
into one, but the same boards with revision/SKU difference.
For both cases:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
2022-05-24 9:34 ` Krzysztof Kozlowski
@ 2022-05-24 23:00 ` Doug Anderson
0 siblings, 0 replies; 16+ messages in thread
From: Doug Anderson @ 2022-05-24 23:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
Hi,
On Tue, May 24, 2022 at 2:34 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 23/05/2022 18:16, Doug Anderson wrote:
> > Hi,
> >
> > On Sun, May 22, 2022 at 12:57 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 20/05/2022 23:38, Douglas Anderson wrote:
> >>> This copy-pastes compatibles from sc7180-based boards from the device
> >>> trees to the yaml file so that `make dtbs_check` will be happy.
> >>>
> >>> NOTES:
> >>> - I make no attempt to try to share an "item" for all sc7180 based
> >>> Chromebooks. Because of the revision matching scheme used by the
> >>> Chromebook bootloader, at times we need a different number of
> >>> revisions listed.
> >>> - Some of the odd entries in here (like google,homestar-rev23 or the
> >>> fact that "Google Lazor Limozeen without Touchscreen" changed from
> >>> sku5 to sku6) are not typos but simply reflect reality.
> >>> - Many revisions of boards here never actually went to consumers, but
> >>> they are still in use within various companies that were involved in
> >>> Chromebook development. Since Chromebooks are developed with an
> >>> "upstream first" methodology, having these revisions supported with
> >>> upstream Linux is important. Making it easy for Chromebooks to be
> >>> developed with an "upstream first" methodology is valuable to the
> >>> upstream community because it improves the quality of upstream and
> >>> gets Chromebooks supported with vanilla upstream faster.
> >>>
> >>> One other note here is that, though the bootloader effectively treats
> >>> the list of compatibles in a given device tree as unordered, some
> >>> people would prefer future boards to list higher-numbered revisions
> >>> first in the list. Chromebooks here are not changing and typically
> >>> list lower revisions first just to avoid churn.
> >>>
> >>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> >>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> >>> ---
> >>>
> >>> (no changes since v3)
> >>>
> >>> Changes in v3:
> >>> - Split link to Chromebook boot doc into a separate patch.
> >>> - Added a note to desc about revision ordering within a device tree.
> >>>
> >>> Changes in v2:
> >>> - Add link to doc about how Chromebook devicetrees work.
> >>> - Use a "description" instead of a comment for each item.
> >>> - Use the marketing name instead of the code name where possible.
> >>>
> >>> .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
> >>> 1 file changed, 181 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> >>> index 5ac28e11ea7b..01e40ea40724 100644
> >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> >>> @@ -219,11 +219,191 @@ properties:
> >>> - qcom,ipq8074-hk10-c2
> >>> - const: qcom,ipq8074
> >>>
> >>> - - items:
> >>> + - description: Qualcomm Technologies, Inc. SC7180 IDP
> >>> + items:
> >>> - enum:
> >>> - qcom,sc7180-idp
> >>> - const: qcom,sc7180
> >>>
> >>> + - description: HP Chromebook x2 11c (rev1 - 2)
> >>> + items:
> >>> + - const: google,coachz-rev1
> >>> + - const: google,coachz-rev2
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: HP Chromebook x2 11c (newest rev)
> >>> + items:
> >>> + - const: google,coachz
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: HP Chromebook x2 11c with LTE (rev1 - 2)
> >>> + items:
> >>> + - const: google,coachz-rev1-sku0
> >>> + - const: google,coachz-rev2-sku0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: HP Chromebook x2 11c with LTE (newest rev)
> >>> + items:
> >>> + - const: google,coachz-sku0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Lenovo Chromebook Duet 5 13 (rev2)
> >>> + items:
> >>> + - const: google,homestar-rev2
> >>> + - const: google,homestar-rev23
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Lenovo Chromebook Duet 5 13 (rev3)
> >>> + items:
> >>> + - const: google,homestar-rev3
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Lenovo Chromebook Duet 5 13 (newest rev)
> >>> + items:
> >>> + - const: google,homestar
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 (rev0)
> >>> + items:
> >>> + - const: google,lazor-rev0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 (rev1 - 2)
> >>> + items:
> >>> + - const: google,lazor-rev1
> >>> + - const: google,lazor-rev2
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 (rev3 - 8)
> >>> + items:
> >>> + - const: google,lazor-rev3
> >>> + - const: google,lazor-rev4
> >>> + - const: google,lazor-rev5
> >>> + - const: google,lazor-rev6
> >>> + - const: google,lazor-rev7
> >>> + - const: google,lazor-rev8
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 (newest rev)
> >>> + items:
> >>> + - const: google,lazor
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
> >>> + items:
> >>> + - const: google,lazor-rev1-sku2
> >>> + - const: google,lazor-rev2-sku2
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
> >>> + items:
> >>> + - const: google,lazor-rev3-sku2
> >>> + - const: google,lazor-rev4-sku2
> >>> + - const: google,lazor-rev5-sku2
> >>> + - const: google,lazor-rev6-sku2
> >>> + - const: google,lazor-rev7-sku2
> >>> + - const: google,lazor-rev8-sku2
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> >>> + items:
> >>> + - const: google,lazor-sku2
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
> >>> + items:
> >>> + - const: google,lazor-rev1-sku0
> >>> + - const: google,lazor-rev2-sku0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
> >>> + items:
> >>> + - const: google,lazor-rev3-sku0
> >>> + - const: google,lazor-rev4-sku0
> >>> + - const: google,lazor-rev5-sku0
> >>> + - const: google,lazor-rev6-sku0
> >>> + - const: google,lazor-rev7-sku0
> >>> + - const: google,lazor-rev8-sku0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook Spin 513 with LTE (newest rev)
> >>> + items:
> >>> + - const: google,lazor-sku0
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook 511 (rev4 - rev8)
> >>> + items:
> >>> + - const: google,lazor-rev4-sku4
> >>> + - const: google,lazor-rev5-sku4
> >>> + - const: google,lazor-rev6-sku4
> >>> + - const: google,lazor-rev7-sku4
> >>> + - const: google,lazor-rev8-sku4
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook 511 (newest rev)
> >>> + items:
> >>> + - const: google,lazor-sku4
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook 511 without Touchscreen (rev4)
> >>> + items:
> >>> + - const: google,lazor-rev4-sku5
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
> >>> + items:
> >>> + - const: google,lazor-rev5-sku5
> >>> + - const: google,lazor-rev5-sku6
> >>> + - const: google,lazor-rev6-sku6
> >>> + - const: google,lazor-rev7-sku6
> >>> + - const: google,lazor-rev8-sku6
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Acer Chromebook 511 without Touchscreen (newest rev)
> >>> + items:
> >>> + - const: google,lazor-sku6
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Sharp Dynabook Chromebook C1 (rev1)
> >>> + items:
> >>> + - const: google,pompom-rev1
> >>> + - const: qcom,sc7180
> >>> +
> >>> + - description: Sharp Dynabook Chromebook C1 (rev2)
> >>> + items:
> >>> + - const: google,pompom-rev2
> >>
> >> I understand why you do not share "item" (your first notes) for some of
> >> boards, but I don't get why "google,pompom-rev1" cannot be combined with
> >> "google,pompom-rev2". Do you see any chances to alter the bindings for
> >> these two boards?
> >>
> >> The same for other such cases (not newest revision).
> >
> > Yeah, I thought about it when I was writing the file and decided
> > against it. I guess it's just a style decision. If we combine these
> > two then I guess it raises the question: do we only combine entries
> > that list a single revision if they're the same board, or do we have
> > one uber entry at the end of the list that combines all
> > single-revision sc7180 Chromebooks? ...and in either case, what should
> > the description be?
> >
> > Personally, though it takes up more lines of code, I prefer the
> > simplicity of having each entry here correspond to a single dts file.
> >
> > Unless you feel really strongly about it, I'd tend to leave the
> > decision here to Bjorn.
>
> Sure. I would prefer to combine such obvious entries, so not everything
> into one, but the same boards with revision/SKU difference.
>
> For both cases:
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
OK, thanks! For now, I'll wait for a tiebreaker. If Bjorn or Stephen
or Matthias wants to chime in and says they'd prefer things be
combined too then I'll spin like that. Otherwise, I'll leave it like
this.
-Doug
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 board bindings
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
2022-05-20 21:38 ` [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme Douglas Anderson
2022-05-20 21:38 ` [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Douglas Anderson
@ 2022-05-20 21:38 ` Douglas Anderson
2022-06-22 8:27 ` Krzysztof Kozlowski
2022-05-20 21:38 ` [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook " Douglas Anderson
2022-06-27 20:02 ` [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Bjorn Andersson
4 siblings, 1 reply; 16+ messages in thread
From: Douglas Anderson @ 2022-05-20 21:38 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree,
Douglas Anderson, Krzysztof Kozlowski, Stephen Boyd,
linux-kernel
This copy-pastes compatibles from sc7280-based boards from the device
trees to the yaml file. It also fixes the CRD/IDP bindings which had
gotten stale.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
It should be noted that these match the sc7280 boards as of the top of
the "for-next" branch of the tree
git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
(no changes since v2)
Changes in v2:
- Use a "description" instead of a comment for each item.
.../devicetree/bindings/arm/qcom.yaml | 42 +++++++++++++++----
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 01e40ea40724..3d150d1a93cd 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -404,14 +404,40 @@ properties:
- const: google,trogdor-sku0
- const: qcom,sc7180
- - items:
- - enum:
- - qcom,sc7280-crd
- - qcom,sc7280-idp
- - qcom,sc7280-idp2
- - google,hoglin
- - google,piglin
- - google,senor
+ - description: Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4)
+ items:
+ - const: qcom,sc7280-crd
+ - const: google,hoglin-rev3
+ - const: google,hoglin-rev4
+ - const: google,piglin-rev3
+ - const: google,piglin-rev4
+ - const: qcom,sc7280
+
+ - description: Qualcomm Technologies, Inc. sc7280 CRD platform (newest rev)
+ items:
+ - const: google,hoglin
+ - const: qcom,sc7280
+
+ - description: Qualcomm Technologies, Inc. sc7280 IDP SKU1 platform
+ items:
+ - const: qcom,sc7280-idp
+ - const: google,senor
+ - const: qcom,sc7280
+
+ - description: Qualcomm Technologies, Inc. sc7280 IDP SKU2 platform
+ items:
+ - const: qcom,sc7280-idp2
+ - const: google,piglin
+ - const: qcom,sc7280
+
+ - description: Google Herobrine (newest rev)
+ items:
+ - const: google,herobrine
+ - const: qcom,sc7280
+
+ - description: Google Villager (newest rev)
+ items:
+ - const: google,villager
- const: qcom,sc7280
- items:
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 board bindings
2022-05-20 21:38 ` [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 " Douglas Anderson
@ 2022-06-22 8:27 ` Krzysztof Kozlowski
2022-06-22 13:51 ` Doug Anderson
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-22 8:27 UTC (permalink / raw)
To: Douglas Anderson, Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree, Stephen Boyd,
linux-kernel
On 20/05/2022 23:38, Douglas Anderson wrote:
> This copy-pastes compatibles from sc7280-based boards from the device
> trees to the yaml file. It also fixes the CRD/IDP bindings which had
> gotten stale.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> It should be noted that these match the sc7280 boards as of the top of
> the "for-next" branch of the tree
> git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
>
> (no changes since v2)
>
> Changes in v2:
> - Use a "description" instead of a comment for each item.
What's the plan for these patches? This is one was reviewed, the 5/5 had
comments. Is there going to be resend or pick up?
Some other folks work depends on this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 board bindings
2022-06-22 8:27 ` Krzysztof Kozlowski
@ 2022-06-22 13:51 ` Doug Anderson
0 siblings, 0 replies; 16+ messages in thread
From: Doug Anderson @ 2022-06-22 13:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
Hi,
On Wed, Jun 22, 2022 at 1:27 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/05/2022 23:38, Douglas Anderson wrote:
> > This copy-pastes compatibles from sc7280-based boards from the device
> > trees to the yaml file. It also fixes the CRD/IDP bindings which had
> > gotten stale.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > It should be noted that these match the sc7280 boards as of the top of
> > the "for-next" branch of the tree
> > git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Use a "description" instead of a comment for each item.
>
> What's the plan for these patches? This is one was reviewed, the 5/5 had
> comments. Is there going to be resend or pick up?
>
> Some other folks work depends on this.
I thought patch 5/5 was waiting on Bjorn to say whether he wanted a
change or was happy the way it was.
In general this series, like all of the Qualcomm dts patches at the
moment, is blocked waiting for Bjorn to have time to land things. I'm
assuming that if Bjorn wants the 5th patch changed then he will still
land the first 4 patches and then I can make changes to 5/5 and send
it as a standalone patch.
-Doug
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
` (2 preceding siblings ...)
2022-05-20 21:38 ` [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 " Douglas Anderson
@ 2022-05-20 21:38 ` Douglas Anderson
2022-05-22 8:01 ` Krzysztof Kozlowski
2022-06-27 20:02 ` [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Bjorn Andersson
4 siblings, 1 reply; 16+ messages in thread
From: Douglas Anderson @ 2022-05-20 21:38 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree,
Douglas Anderson, Stephen Boyd, linux-kernel
This adds board bindings for boards that are downstream but not quite
upstream yet.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Normally this bindings doc would go together in the same series that
adds the device trees. In this case, Joe has been sending patches
supporting these Chromebooks. His most recent posting is:
https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/
If he were to add this patch to the end of his v6, however, it would
make things a bit more complicated simply becuase it would cause
conflicts with all the other patches in this series. ...so steady
state it would be correct to keep it in the series with the device
tree files, but for this one time I think it makes sense to keep all
the Chromebook board bindings patches together.
(no changes since v2)
Changes in v2:
- Use a "description" instead of a comment for each item.
- Use the marketing name instead of the code name where possible.
.../devicetree/bindings/arm/qcom.yaml | 92 +++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 3d150d1a93cd..277faf59db57 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -263,6 +263,16 @@ properties:
- const: google,homestar
- const: qcom,sc7180
+ - description: Google Kingoftown (rev0)
+ items:
+ - const: google,kingoftown-rev0
+ - const: qcom,sc7180
+
+ - description: Google Kingoftown (newest rev)
+ items:
+ - const: google,kingoftown
+ - const: qcom,sc7180
+
- description: Acer Chromebook Spin 513 (rev0)
items:
- const: google,lazor-rev0
@@ -364,6 +374,48 @@ properties:
- const: google,lazor-sku6
- const: qcom,sc7180
+ - description: Google Mrbland with AUO panel (rev0)
+ items:
+ - const: google,mrbland-rev0-sku0
+ - const: qcom,sc7180
+
+ - description: Google Mrbland with AUO panel (newest rev)
+ items:
+ - const: google,mrbland-sku1536
+ - const: qcom,sc7180
+
+ - description: Google Mrbland with BOE panel (rev0)
+ items:
+ - const: google,mrbland-rev0-sku16
+ - const: qcom,sc7180
+
+ - description: Google Mrbland with BOE panel (newest rev)
+ items:
+ - const: google,mrbland-sku1024
+ - const: google,mrbland-sku768
+ - const: qcom,sc7180
+
+ - description: Google Pazquel with Parade (newest rev)
+ items:
+ - const: google,pazquel-sku5
+ - const: qcom,sc7180
+
+ - description: Google Pazquel with TI (newest rev)
+ items:
+ - const: google,pazquel-sku1
+ - const: qcom,sc7180
+
+ - description: Google Pazquel with LTE and Parade (newest rev)
+ items:
+ - const: google,pazquel-sku4
+ - const: qcom,sc7180
+
+ - description: Google Pazquel with LTE and TI (newest rev)
+ items:
+ - const: google,pazquel-sku0
+ - const: google,pazquel-sku2
+ - const: qcom,sc7180
+
- description: Sharp Dynabook Chromebook C1 (rev1)
items:
- const: google,pompom-rev1
@@ -394,6 +446,16 @@ properties:
- const: google,pompom-sku0
- const: qcom,sc7180
+ - description: Google Quackingstick (newest rev)
+ items:
+ - const: google,quackingstick-sku1537
+ - const: qcom,sc7180
+
+ - description: Google Quackingstick with LTE (newest rev)
+ items:
+ - const: google,quackingstick-sku1536
+ - const: qcom,sc7180
+
- description: Google Trogdor (newest rev)
items:
- const: google,trogdor
@@ -404,6 +466,36 @@ properties:
- const: google,trogdor-sku0
- const: qcom,sc7180
+ - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel (rev0)
+ items:
+ - const: google,wormdingler-rev0-sku16
+ - const: qcom,sc7180
+
+ - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel (newest rev)
+ items:
+ - const: google,wormdingler-sku1024
+ - const: qcom,sc7180
+
+ - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel and rt5682s (newest rev)
+ items:
+ - const: google,wormdingler-sku1025
+ - const: qcom,sc7180
+
+ - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel (rev0)
+ items:
+ - const: google,wormdingler-rev0-sku0
+ - const: qcom,sc7180
+
+ - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel (newest rev)
+ items:
+ - const: google,wormdingler-sku0
+ - const: qcom,sc7180
+
+ - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel and rt5682s (newest rev)
+ items:
+ - const: google,wormdingler-sku1
+ - const: qcom,sc7180
+
- description: Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4)
items:
- const: qcom,sc7280-crd
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings
2022-05-20 21:38 ` [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook " Douglas Anderson
@ 2022-05-22 8:01 ` Krzysztof Kozlowski
2022-05-23 16:19 ` Doug Anderson
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-22 8:01 UTC (permalink / raw)
To: Douglas Anderson, Rob Herring, Bjorn Andersson
Cc: Matthias Kaehlcke, Alexandru M Stan, patches, linux-arm-msm,
Julius Werner, Andy Gross, Stephen Boyd, Krzysztof Kozlowski,
Rajendra Nayak, Joseph S . Barrera III, devicetree, Stephen Boyd,
linux-kernel
On 20/05/2022 23:38, Douglas Anderson wrote:
> This adds board bindings for boards that are downstream but not quite
> upstream yet.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Normally this bindings doc would go together in the same series that
> adds the device trees. In this case, Joe has been sending patches
> supporting these Chromebooks. His most recent posting is:
>
> https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/
>
> If he were to add this patch to the end of his v6, however, it would
> make things a bit more complicated simply becuase it would cause
> conflicts with all the other patches in this series. ...so steady
> state it would be correct to keep it in the series with the device
> tree files, but for this one time I think it makes sense to keep all
> the Chromebook board bindings patches together.
>
> (no changes since v2)
>
> Changes in v2:
> - Use a "description" instead of a comment for each item.
> - Use the marketing name instead of the code name where possible.
>
> .../devicetree/bindings/arm/qcom.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 3d150d1a93cd..277faf59db57 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -263,6 +263,16 @@ properties:
> - const: google,homestar
> - const: qcom,sc7180
>
> + - description: Google Kingoftown (rev0)
> + items:
> + - const: google,kingoftown-rev0
> + - const: qcom,sc7180
> +
> + - description: Google Kingoftown (newest rev)
> + items:
> + - const: google,kingoftown
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook Spin 513 (rev0)
> items:
> - const: google,lazor-rev0
> @@ -364,6 +374,48 @@ properties:
> - const: google,lazor-sku6
> - const: qcom,sc7180
>
> + - description: Google Mrbland with AUO panel (rev0)
> + items:
> + - const: google,mrbland-rev0-sku0
> + - const: qcom,sc7180
> +
> + - description: Google Mrbland with AUO panel (newest rev)
> + items:
> + - const: google,mrbland-sku1536
> + - const: qcom,sc7180
> +
> + - description: Google Mrbland with BOE panel (rev0)
> + items:
> + - const: google,mrbland-rev0-sku16
Similar question to patch #3, this could be:
+ - description: Google Mrbland
+ items:
+ - enum:
+ - google,mrbland-rev0-sku0 # AUO panel (rev0)
+ - google,mrbland-rev0-sku16 # BOE panel (rev0)
+ - const: qcom,sc7180
and the file gets smaller and easier to read.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings
2022-05-22 8:01 ` Krzysztof Kozlowski
@ 2022-05-23 16:19 ` Doug Anderson
2022-06-01 23:26 ` Rob Herring
0 siblings, 1 reply; 16+ messages in thread
From: Doug Anderson @ 2022-05-23 16:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
Hi,
On Sun, May 22, 2022 at 1:01 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/05/2022 23:38, Douglas Anderson wrote:
> > This adds board bindings for boards that are downstream but not quite
> > upstream yet.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > Normally this bindings doc would go together in the same series that
> > adds the device trees. In this case, Joe has been sending patches
> > supporting these Chromebooks. His most recent posting is:
> >
> > https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/
> >
> > If he were to add this patch to the end of his v6, however, it would
> > make things a bit more complicated simply becuase it would cause
> > conflicts with all the other patches in this series. ...so steady
> > state it would be correct to keep it in the series with the device
> > tree files, but for this one time I think it makes sense to keep all
> > the Chromebook board bindings patches together.
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Use a "description" instead of a comment for each item.
> > - Use the marketing name instead of the code name where possible.
> >
> > .../devicetree/bindings/arm/qcom.yaml | 92 +++++++++++++++++++
> > 1 file changed, 92 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 3d150d1a93cd..277faf59db57 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -263,6 +263,16 @@ properties:
> > - const: google,homestar
> > - const: qcom,sc7180
> >
> > + - description: Google Kingoftown (rev0)
> > + items:
> > + - const: google,kingoftown-rev0
> > + - const: qcom,sc7180
> > +
> > + - description: Google Kingoftown (newest rev)
> > + items:
> > + - const: google,kingoftown
> > + - const: qcom,sc7180
> > +
> > - description: Acer Chromebook Spin 513 (rev0)
> > items:
> > - const: google,lazor-rev0
> > @@ -364,6 +374,48 @@ properties:
> > - const: google,lazor-sku6
> > - const: qcom,sc7180
> >
> > + - description: Google Mrbland with AUO panel (rev0)
> > + items:
> > + - const: google,mrbland-rev0-sku0
> > + - const: qcom,sc7180
> > +
> > + - description: Google Mrbland with AUO panel (newest rev)
> > + items:
> > + - const: google,mrbland-sku1536
> > + - const: qcom,sc7180
> > +
> > + - description: Google Mrbland with BOE panel (rev0)
> > + items:
> > + - const: google,mrbland-rev0-sku16
>
> Similar question to patch #3, this could be:
>
>
> + - description: Google Mrbland
> + items:
> + - enum:
> + - google,mrbland-rev0-sku0 # AUO panel (rev0)
> + - google,mrbland-rev0-sku16 # BOE panel (rev0)
> + - const: qcom,sc7180
>
> and the file gets smaller and easier to read.
Ah, I guess this answers the question of the description that I asked
in the previous patch. Of course, this goes opposite of the feedback I
got from Stephen in previous versions of the patch where he requested
that I use "description" instead of comments for things. ;-)
In any case, for now I'll hold off waiting for other opinions here
since I still feel that the "one entry per dts" is easier to read /
reason about.
-Doug
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings
2022-05-23 16:19 ` Doug Anderson
@ 2022-06-01 23:26 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2022-06-01 23:26 UTC (permalink / raw)
To: Doug Anderson
Cc: Krzysztof Kozlowski, Bjorn Andersson, Matthias Kaehlcke,
Alexandru M Stan, patches, linux-arm-msm, Julius Werner,
Andy Gross, Stephen Boyd, Krzysztof Kozlowski, Rajendra Nayak,
Joseph S . Barrera III,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Stephen Boyd, LKML
On Mon, May 23, 2022 at 09:19:03AM -0700, Doug Anderson wrote:
> Hi,
>
> On Sun, May 22, 2022 at 1:01 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 20/05/2022 23:38, Douglas Anderson wrote:
> > > This adds board bindings for boards that are downstream but not quite
> > > upstream yet.
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > ---
> > > Normally this bindings doc would go together in the same series that
> > > adds the device trees. In this case, Joe has been sending patches
> > > supporting these Chromebooks. His most recent posting is:
> > >
> > > https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/
> > >
> > > If he were to add this patch to the end of his v6, however, it would
> > > make things a bit more complicated simply becuase it would cause
> > > conflicts with all the other patches in this series. ...so steady
> > > state it would be correct to keep it in the series with the device
> > > tree files, but for this one time I think it makes sense to keep all
> > > the Chromebook board bindings patches together.
> > >
> > > (no changes since v2)
> > >
> > > Changes in v2:
> > > - Use a "description" instead of a comment for each item.
> > > - Use the marketing name instead of the code name where possible.
> > >
> > > .../devicetree/bindings/arm/qcom.yaml | 92 +++++++++++++++++++
> > > 1 file changed, 92 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > index 3d150d1a93cd..277faf59db57 100644
> > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > @@ -263,6 +263,16 @@ properties:
> > > - const: google,homestar
> > > - const: qcom,sc7180
> > >
> > > + - description: Google Kingoftown (rev0)
> > > + items:
> > > + - const: google,kingoftown-rev0
> > > + - const: qcom,sc7180
> > > +
> > > + - description: Google Kingoftown (newest rev)
> > > + items:
> > > + - const: google,kingoftown
> > > + - const: qcom,sc7180
> > > +
> > > - description: Acer Chromebook Spin 513 (rev0)
> > > items:
> > > - const: google,lazor-rev0
> > > @@ -364,6 +374,48 @@ properties:
> > > - const: google,lazor-sku6
> > > - const: qcom,sc7180
> > >
> > > + - description: Google Mrbland with AUO panel (rev0)
> > > + items:
> > > + - const: google,mrbland-rev0-sku0
> > > + - const: qcom,sc7180
> > > +
> > > + - description: Google Mrbland with AUO panel (newest rev)
> > > + items:
> > > + - const: google,mrbland-sku1536
> > > + - const: qcom,sc7180
> > > +
> > > + - description: Google Mrbland with BOE panel (rev0)
> > > + items:
> > > + - const: google,mrbland-rev0-sku16
> >
> > Similar question to patch #3, this could be:
> >
> >
> > + - description: Google Mrbland
> > + items:
> > + - enum:
> > + - google,mrbland-rev0-sku0 # AUO panel (rev0)
> > + - google,mrbland-rev0-sku16 # BOE panel (rev0)
> > + - const: qcom,sc7180
> >
> > and the file gets smaller and easier to read.
>
> Ah, I guess this answers the question of the description that I asked
> in the previous patch. Of course, this goes opposite of the feedback I
> got from Stephen in previous versions of the patch where he requested
> that I use "description" instead of comments for things. ;-)
>
> In any case, for now I'll hold off waiting for other opinions here
> since I still feel that the "one entry per dts" is easier to read /
> reason about.
I leave it to the sub-arch maintainers to decide. I somewhat prefer as
Krzysztof suggested. Some platforms (and most of the ones I converted)
all the boards for an SoC are one entry (except for the 3 string cases).
So the above looks like a good middle ground grouping revs or variations
of boards.
Rob
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
` (3 preceding siblings ...)
2022-05-20 21:38 ` [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook " Douglas Anderson
@ 2022-06-27 20:02 ` Bjorn Andersson
4 siblings, 0 replies; 16+ messages in thread
From: Bjorn Andersson @ 2022-06-27 20:02 UTC (permalink / raw)
To: Rob Herring, Douglas Anderson
Cc: linux-kernel, Joseph S . Barrera III, Andy Gross, linux-arm-msm,
Rajendra Nayak, Alexandru M Stan, devicetree, Julius Werner,
linux-doc, Krzysztof Kozlowski, patches, Matthias Kaehlcke,
Jonathan Corbet, Stephen Boyd
On Fri, 20 May 2022 14:38:41 -0700, Douglas Anderson wrote:
> This documents how many Chromebooks pick the device tree that will be
> passed to the OS and can help understand the revisions / SKUs listed
> as the top-level "compatible" in many Chromebooks.
>
>
Applied, thanks!
[1/5] dt-bindings: Document how Chromebooks with depthcharge boot
commit: 59228d3b9060b0e5e6b37ceca078fd81a165cfc9
[2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme
commit: dbbccb3db122558b35ecb4c87a86bbad37c80862
[3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
commit: 3b8bfe002c4ba633b48cc497238a69eb88346a60
[4/5] dt-bindings: arm: qcom: Add / fix sc7280 board bindings
commit: 707b9b08789bf3312c9cf23c621ad942de9aa48c
[5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook board bindings
commit: 5069fe941f76c9f37abc98636a7db33a5ac72840
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 16+ messages in thread