[PATCH net] ptp: ocp: add EEPROM_AT24 dependency

[PATCH net] ptp: ocp: add EEPROM_AT24 dependency

[Vadim Fedorenko]

Various information which is provided via devlink is stored in
EEPROM and is not accessible unless at24 eeprom is supported.

Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
---
 drivers/ptp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 458218f88c5e..c86be47e69ed 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -171,7 +171,7 @@ config PTP_1588_CLOCK_OCP
 	tristate "OpenCompute TimeCard as PTP clock"
 	depends on PTP_1588_CLOCK
 	depends on HAS_IOMEM && PCI
-	depends on I2C && MTD
+	depends on I2C && EEPROM_AT24 && MTD
 	depends on SERIAL_8250
 	depends on !S390
 	depends on COMMON_CLK
-- 
2.27.0

Re: [PATCH net] ptp: ocp: add EEPROM_AT24 dependency

[Jonathan Lemon]

On Fri, Jun 24, 2022 at 02:31:41AM +0300, Vadim Fedorenko wrote:
> Various information which is provided via devlink is stored in
> EEPROM and is not accessible unless at24 eeprom is supported.
> 
> Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
> ---
>  drivers/ptp/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 458218f88c5e..c86be47e69ed 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -171,7 +171,7 @@ config PTP_1588_CLOCK_OCP
>  	tristate "OpenCompute TimeCard as PTP clock"
>  	depends on PTP_1588_CLOCK
>  	depends on HAS_IOMEM && PCI
> -	depends on I2C && MTD
> +	depends on I2C && EEPROM_AT24 && MTD
>  	depends on SERIAL_8250
>  	depends on !S390
>  	depends on COMMON_CLK

The intent was to list the minimum dependencies for the PTP clock to
operate and for the module to compile.

While EEPROM_AT24 is needed to read the chip, it can operate without it.

Full access to all features needs addtional configuration options, for
example, MTD_SPI_NOR, SPI_XILINX, I2C_XILINX.  These are not required
for the basic ptp clock operation.  

I think listing these configuration options would be more appropriate
in the Documentation entry.
-- 
Jonathan

Re: [PATCH net] ptp: ocp: add EEPROM_AT24 dependency

[Jakub Kicinski]

On Thu, 23 Jun 2022 16:53:08 -0700 Jonathan Lemon wrote:
> On Fri, Jun 24, 2022 at 02:31:41AM +0300, Vadim Fedorenko wrote:
> > Various information which is provided via devlink is stored in
> > EEPROM and is not accessible unless at24 eeprom is supported.
> > 
> > Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
> > ---
> >  drivers/ptp/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> > index 458218f88c5e..c86be47e69ed 100644
> > --- a/drivers/ptp/Kconfig
> > +++ b/drivers/ptp/Kconfig
> > @@ -171,7 +171,7 @@ config PTP_1588_CLOCK_OCP
> >  	tristate "OpenCompute TimeCard as PTP clock"
> >  	depends on PTP_1588_CLOCK
> >  	depends on HAS_IOMEM && PCI
> > -	depends on I2C && MTD
> > +	depends on I2C && EEPROM_AT24 && MTD
> >  	depends on SERIAL_8250
> >  	depends on !S390
> >  	depends on COMMON_CLK  
> 
> The intent was to list the minimum dependencies for the PTP clock to
> operate and for the module to compile.
> 
> While EEPROM_AT24 is needed to read the chip, it can operate without it.
> 
> Full access to all features needs addtional configuration options, for
> example, MTD_SPI_NOR, SPI_XILINX, I2C_XILINX.  These are not required
> for the basic ptp clock operation.  
> 
> I think listing these configuration options would be more appropriate
> in the Documentation entry.

You can try "imply".

Re: [PATCH net] ptp: ocp: add EEPROM_AT24 dependency

[Jonathan Lemon]

On Fri, Jun 24, 2022 at 10:45:30PM -0700, Jakub Kicinski wrote:
> On Thu, 23 Jun 2022 16:53:08 -0700 Jonathan Lemon wrote:
> > On Fri, Jun 24, 2022 at 02:31:41AM +0300, Vadim Fedorenko wrote:
> > > Various information which is provided via devlink is stored in
> > > EEPROM and is not accessible unless at24 eeprom is supported.
> > > 
> > > Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> > > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
> > > ---
> > >  drivers/ptp/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> > > index 458218f88c5e..c86be47e69ed 100644
> > > --- a/drivers/ptp/Kconfig
> > > +++ b/drivers/ptp/Kconfig
> > > @@ -171,7 +171,7 @@ config PTP_1588_CLOCK_OCP
> > >  	tristate "OpenCompute TimeCard as PTP clock"
> > >  	depends on PTP_1588_CLOCK
> > >  	depends on HAS_IOMEM && PCI
> > > -	depends on I2C && MTD
> > > +	depends on I2C && EEPROM_AT24 && MTD
> > >  	depends on SERIAL_8250
> > >  	depends on !S390
> > >  	depends on COMMON_CLK  
> > 
> > The intent was to list the minimum dependencies for the PTP clock to
> > operate and for the module to compile.
> > 
> > While EEPROM_AT24 is needed to read the chip, it can operate without it.
> > 
> > Full access to all features needs addtional configuration options, for
> > example, MTD_SPI_NOR, SPI_XILINX, I2C_XILINX.  These are not required
> > for the basic ptp clock operation.  
> > 
> > I think listing these configuration options would be more appropriate
> > in the Documentation entry.
> 
> You can try "imply".

We have been down this road before.

https://lore.kernel.org/netdev/CAK8P3a3QGF2=WZz6N8wQo2ZQxmVqKToHGmhT4wEtB7tAL+-ruQ@mail.gmail.com/

https://lore.kernel.org/netdev/20210825211733.264844-1-jonathan.lemon@gmail.com/

-- 
Jonathan