* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2021-09-16 14:18 Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
` (5 more replies)
0 siblings, 6 replies; 18+ messages in thread
From: Vidya Srinivas @ 2021-09-16 14:18 UTC (permalink / raw)
To: igt-dev; +Cc: Bhanuprakash.Modem, markyacoub, Vidya Srinivas
Staring commit fea0e38e690c30c6 "Making the test more generic"
test_resolution_with_output introduced setting igt_output_set_pipe
to PIPE_NONE. This is triggering atomic check failure resulting in
"enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
Patch fixes this issue.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_concurrent.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 25c67eb469d1..40096ea1c457 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
/* switch to lower resolution */
igt_output_override_mode(output, mode_lo);
- igt_output_set_pipe(output, PIPE_NONE);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
/* switch back to higher resolution */
--
2.33.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
@ 2021-09-16 15:36 ` Mark Yacoub
2021-09-17 15:03 ` Rodrigo Siqueira
2021-09-16 17:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 subsequent siblings)
5 siblings, 1 reply; 18+ messages in thread
From: Mark Yacoub @ 2021-09-16 15:36 UTC (permalink / raw)
To: Siqueira, Rodrigo
Cc: Development mailing list for IGT GPU Tools, Modem, Bhanuprakash,
Mark Yacoub, Vidya Srinivas
@Siquiera, I remember this also caused a regression on Qualcomm
devices as well.
Will removing this regress AMD? Any work around?
On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
<vidya.srinivas@intel.com> wrote:
>
> Staring commit fea0e38e690c30c6 "Making the test more generic"
> test_resolution_with_output introduced setting igt_output_set_pipe
> to PIPE_NONE. This is triggering atomic check failure resulting in
> "enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
> Patch fixes this issue.
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_concurrent.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 25c67eb469d1..40096ea1c457 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
>
> /* switch to lower resolution */
> igt_output_override_mode(output, mode_lo);
> - igt_output_set_pipe(output, PIPE_NONE);
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> /* switch back to higher resolution */
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
@ 2021-09-16 17:43 ` Patchwork
2021-09-20 8:17 ` [igt-dev] [PATCH i-g-t] " Vidya Srinivas
` (3 subsequent siblings)
5 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-09-16 17:43 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8046 bytes --]
== Series Details ==
Series: tests/kms_concurrent: Fix regression in test_resolution_with_output
URL : https://patchwork.freedesktop.org/series/94762/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10598 -> IGTPW_6230
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6230 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_6230, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6230:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-rkl-11600: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-rkl-11600/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_6230 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-skl-6700k2/igt@amdgpu/amd_basic@cs-gfx.html
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][3] ([i915#4130])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
- fi-kbl-7500u: [PASS][4] -> [INCOMPLETE][5] ([i915#4130])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
- fi-kbl-7567u: [PASS][6] -> [INCOMPLETE][7] ([i915#4130])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_module_load@reload:
- fi-rkl-11600: [PASS][9] -> [INCOMPLETE][10] ([i915#4136])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-rkl-11600/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-rkl-11600/igt@i915_module_load@reload.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#1155])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][12] ([fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([i915#4103]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][15] ([i915#1072]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][16] ([i915#3301])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-cml-u2: NOTRUN -> [FAIL][17] ([i915#2082] / [i915#2426] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-cml-u2/igt@runner@aborted.html
- fi-tgl-1115g4: NOTRUN -> [FAIL][18] ([i915#1602] / [i915#2722])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-tgl-1115g4/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-skl-6700k2: [INCOMPLETE][19] ([i915#4130] / [i915#4136]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-skl-6700k2/igt@i915_module_load@reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-skl-6700k2/igt@i915_module_load@reload.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [DMESG-WARN][21] ([i915#2868]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-cml-u2: [INCOMPLETE][23] ([i915#4136]) -> [INCOMPLETE][24] ([i915#4130] / [i915#4136])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-cml-u2/igt@i915_module_load@reload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-cml-u2/igt@i915_module_load@reload.html
- fi-kbl-soraka: [INCOMPLETE][25] ([i915#4130] / [i915#4136]) -> [INCOMPLETE][26] ([i915#4136])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-kbl-soraka/igt@i915_module_load@reload.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-kbl-soraka/igt@i915_module_load@reload.html
* igt@runner@aborted:
- fi-kbl-soraka: [FAIL][27] ([i915#2426] / [i915#3363]) -> [FAIL][28] ([i915#3363])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10598/fi-kbl-soraka/igt@runner@aborted.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/fi-kbl-soraka/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4130]: https://gitlab.freedesktop.org/drm/intel/issues/4130
[i915#4136]: https://gitlab.freedesktop.org/drm/intel/issues/4136
Participating hosts (37 -> 35)
------------------------------
Additional (1): fi-tgl-1115g4
Missing (3): fi-bsw-cyan fi-cfl-8109u fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6211 -> IGTPW_6230
CI-20190529: 20190529
CI_DRM_10598: 5b7e720d97fd94cf081daec8f9d09753cfbe1c31 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6230: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/index.html
IGT_6211: 7b275b3eb17ddf6e7c5b7b9ba359b7f5345a5311 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6230/index.html
[-- Attachment #2: Type: text/html, Size: 9988 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-16 15:36 ` Mark Yacoub
@ 2021-09-17 15:03 ` Rodrigo Siqueira
2021-09-17 16:35 ` Mark Yacoub
2021-09-20 8:29 ` Srinivas, Vidya
0 siblings, 2 replies; 18+ messages in thread
From: Rodrigo Siqueira @ 2021-09-17 15:03 UTC (permalink / raw)
To: Mark Yacoub
Cc: Development mailing list for IGT GPU Tools, Modem, Bhanuprakash,
Mark Yacoub, Vidya Srinivas, Nicholas Choi
Hi Mark,
Yes, this patch cause a regression in AMD.
I applied the original patch after the CI reported a complete pass. I
also tested it in a VC4 and VKMS; just for curiosity, why did we not get
this regression in the CI?
Thanks
On 09/16, Mark Yacoub wrote:
> @Siquiera, I remember this also caused a regression on Qualcomm
> devices as well.
> Will removing this regress AMD? Any work around?
>
> On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> <vidya.srinivas@intel.com> wrote:
> >
> > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > test_resolution_with_output introduced setting igt_output_set_pipe
> > to PIPE_NONE. This is triggering atomic check failure resulting in
> > "enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
> > Patch fixes this issue.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_concurrent.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> > index 25c67eb469d1..40096ea1c457 100644
> > --- a/tests/kms_concurrent.c
> > +++ b/tests/kms_concurrent.c
> > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
> >
> > /* switch to lower resolution */
> > igt_output_override_mode(output, mode_lo);
> > - igt_output_set_pipe(output, PIPE_NONE);
> > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > /* switch back to higher resolution */
> > --
> > 2.33.0
> >
--
Rodrigo Siqueira
https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-17 15:03 ` Rodrigo Siqueira
@ 2021-09-17 16:35 ` Mark Yacoub
2021-09-20 8:29 ` Srinivas, Vidya
1 sibling, 0 replies; 18+ messages in thread
From: Mark Yacoub @ 2021-09-17 16:35 UTC (permalink / raw)
To: Rodrigo Siqueira
Cc: Development mailing list for IGT GPU Tools, Modem, Bhanuprakash,
Mark Yacoub, Vidya Srinivas, Nicholas Choi
On Fri, Sep 17, 2021 at 11:03 AM Rodrigo Siqueira
<Rodrigo.Siqueira@amd.com> wrote:
>
> Hi Mark,
>
> Yes, this patch cause a regression in AMD.
>
> I applied the original patch after the CI reported a complete pass. I
> also tested it in a VC4 and VKMS; just for curiosity, why did we not get
> this regression in the CI?
The failure is seen on kernel 5.4 so this could be a reason?
Vidya do you have any idea why is this the case, like why it only
fails on volteer 5.4 and not on the CI?
worst case scenario, we can do `if (amd) {set_pipe(NONE)}`
>
> Thanks
>
> On 09/16, Mark Yacoub wrote:
> > @Siquiera, I remember this also caused a regression on Qualcomm
> > devices as well.
> > Will removing this regress AMD? Any work around?
> >
> > On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> > <vidya.srinivas@intel.com> wrote:
> > >
> > > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > > test_resolution_with_output introduced setting igt_output_set_pipe
> > > to PIPE_NONE. This is triggering atomic check failure resulting in
> > > "enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
> > > Patch fixes this issue.
> > >
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > ---
> > > tests/kms_concurrent.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> > > index 25c67eb469d1..40096ea1c457 100644
> > > --- a/tests/kms_concurrent.c
> > > +++ b/tests/kms_concurrent.c
> > > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
> > >
> > > /* switch to lower resolution */
> > > igt_output_override_mode(output, mode_lo);
> > > - igt_output_set_pipe(output, PIPE_NONE);
> > > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > >
> > > /* switch back to higher resolution */
> > > --
> > > 2.33.0
> > >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
2021-09-16 17:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2021-09-20 8:17 ` Vidya Srinivas
2021-09-23 17:55 ` Rodrigo Siqueira
2021-09-20 10:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 18+ messages in thread
From: Vidya Srinivas @ 2021-09-20 8:17 UTC (permalink / raw)
To: igt-dev; +Cc: Bhanuprakash.Modem, markyacoub, rodrigo.siqueira, Vidya Srinivas
Staring commit fea0e38e690c30c6 "Making the test more generic"
test_resolution_with_output introduced setting igt_output_set_pipe
to PIPE_NONE. This is triggering atomic check failure resulting in
"enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
Patch fixes this issue.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_concurrent.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 25c67eb469d1..47c441a5a3f7 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -268,7 +268,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
/* switch to lower resolution */
igt_output_override_mode(output, mode_lo);
- igt_output_set_pipe(output, PIPE_NONE);
+ if (is_amdgpu_device(data->drm_fd))
+ igt_output_set_pipe(output, PIPE_NONE);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
/* switch back to higher resolution */
--
2.33.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-17 15:03 ` Rodrigo Siqueira
2021-09-17 16:35 ` Mark Yacoub
@ 2021-09-20 8:29 ` Srinivas, Vidya
2021-09-20 15:27 ` Mark Yacoub
1 sibling, 1 reply; 18+ messages in thread
From: Srinivas, Vidya @ 2021-09-20 8:29 UTC (permalink / raw)
To: Rodrigo Siqueira, Mark Yacoub
Cc: Development mailing list for IGT GPU Tools, Modem, Bhanuprakash,
Mark Yacoub, Nicholas Choi
> -----Original Message-----
> From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Sent: Friday, September 17, 2021 8:34 PM
> To: Mark Yacoub <markyacoub@chromium.org>
> Cc: Development mailing list for IGT GPU Tools <igt-
> dev@lists.freedesktop.org>; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>; Mark Yacoub
> <markyacoub@google.com>; Srinivas, Vidya <vidya.srinivas@intel.com>;
> Nicholas Choi <nicholas.choi@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in
> test_resolution_with_output
>
> Hi Mark,
>
> Yes, this patch cause a regression in AMD.
>
> I applied the original patch after the CI reported a complete pass. I also
> tested it in a VC4 and VKMS; just for curiosity, why did we not get this
> regression in the CI?
Hello Mark/Siqueira,
I am not very sure. One possible reason could be the CI does not run all
the subtests sequentially? With this line, it triggers the condition
[ 7577.454215] [drm:drm_atomic_check_only] atomic driver check for 00000000bcb190f7 failed: -22
I observed the same message even with upstream kernel.
I have resubmitted the patch with is amd
https://patchwork.freedesktop.org/patch/454571/?series=94762&rev=2
Kindly have a check. Thank you.
Regards
Vidya
>
> Thanks
>
> On 09/16, Mark Yacoub wrote:
> > @Siquiera, I remember this also caused a regression on Qualcomm
> > devices as well.
> > Will removing this regress AMD? Any work around?
> >
> > On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> > <vidya.srinivas@intel.com> wrote:
> > >
> > > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > > test_resolution_with_output introduced setting igt_output_set_pipe
> > > to PIPE_NONE. This is triggering atomic check failure resulting in
> > > "enabled/connectors mismatch" under
> drm_atomic_helper_check_modeset.
> > > Patch fixes this issue.
> > >
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > ---
> > > tests/kms_concurrent.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index
> > > 25c67eb469d1..40096ea1c457 100644
> > > --- a/tests/kms_concurrent.c
> > > +++ b/tests/kms_concurrent.c
> > > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum
> > > pipe pipe, int max_planes, igt_ou
> > >
> > > /* switch to lower resolution */
> > > igt_output_override_mode(output, mode_lo);
> > > - igt_output_set_pipe(output, PIPE_NONE);
> > > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > >
> > > /* switch back to higher resolution */
> > > --
> > > 2.33.0
> > >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
` (2 preceding siblings ...)
2021-09-20 8:17 ` [igt-dev] [PATCH i-g-t] " Vidya Srinivas
@ 2021-09-20 10:40 ` Patchwork
2021-09-20 12:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-24 4:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
5 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-09-20 10:40 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 9631 bytes --]
== Series Details ==
Series: tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
URL : https://patchwork.freedesktop.org/series/94762/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10609 -> IGTPW_6238
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
Known issues
------------
Here are the changes found in IGTPW_6238 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-skl-guc: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-skl-guc/igt@amdgpu/amd_basic@cs-compute.html
* igt@amdgpu/amd_basic@cs-sdma:
- fi-cfl-8109u: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-cfl-8109u/igt@amdgpu/amd_basic@cs-sdma.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][4] ([i915#4130])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
- fi-rkl-11600: [PASS][5] -> [INCOMPLETE][6] ([i915#4130])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-rkl-11600/igt@core_hotunplug@unbind-rebind.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-rkl-11600/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@i915_module_load@reload:
- fi-kbl-r: [PASS][8] -> [INCOMPLETE][9] ([i915#4130])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-kbl-r/igt@i915_module_load@reload.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-kbl-r/igt@i915_module_load@reload.html
- fi-icl-y: [PASS][10] -> [INCOMPLETE][11] ([i915#4136])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-icl-y/igt@i915_module_load@reload.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-icl-y/igt@i915_module_load@reload.html
- fi-kbl-7500u: [PASS][12] -> [INCOMPLETE][13] ([i915#4130])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-kbl-7500u/igt@i915_module_load@reload.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-kbl-7500u/igt@i915_module_load@reload.html
* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([i915#1155])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][15] ([fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][16] ([i915#4103]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-modeset@c-dp1:
- fi-cfl-8109u: [PASS][17] -> [FAIL][18] ([i915#4165]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-cfl-8109u/igt@kms_flip@basic-flip-vs-modeset@c-dp1.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [PASS][20] -> [DMESG-WARN][21] ([i915#295]) +18 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][22] ([i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][23] ([i915#3301])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-kbl-8809g: NOTRUN -> [FAIL][24] ([i915#2722] / [i915#3363])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-kbl-8809g/igt@runner@aborted.html
- fi-kbl-7500u: NOTRUN -> [FAIL][25] ([i915#2426] / [i915#3363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-kbl-7500u/igt@runner@aborted.html
- fi-tgl-1115g4: NOTRUN -> [FAIL][26] ([i915#1602] / [i915#2722])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-tgl-1115g4/igt@runner@aborted.html
- fi-icl-y: NOTRUN -> [FAIL][27] ([i915#4136])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-icl-y/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-cfl-8109u: [INCOMPLETE][28] ([i915#4130]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-skl-6600u: [INCOMPLETE][30] ([i915#4130]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-skl-6600u/igt@i915_module_load@reload.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-skl-6600u/igt@i915_module_load@reload.html
- fi-skl-guc: [INCOMPLETE][32] ([i915#4130]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-skl-guc/igt@i915_module_load@reload.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-skl-guc/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-bxt-dsi: [DMESG-FAIL][34] ([i915#2291] / [i915#541]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-kbl-8809g: [INCOMPLETE][36] ([i915#4130]) -> [INCOMPLETE][37] ([i915#4136])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-kbl-8809g/igt@i915_module_load@reload.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-kbl-8809g/igt@i915_module_load@reload.html
- fi-glk-dsi: [INCOMPLETE][38] -> [INCOMPLETE][39] ([i915#4130])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/fi-glk-dsi/igt@i915_module_load@reload.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/fi-glk-dsi/igt@i915_module_load@reload.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4130]: https://gitlab.freedesktop.org/drm/intel/issues/4130
[i915#4136]: https://gitlab.freedesktop.org/drm/intel/issues/4136
[i915#4165]: https://gitlab.freedesktop.org/drm/intel/issues/4165
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (32 -> 29)
------------------------------
Additional (1): fi-tgl-1115g4
Missing (4): fi-ctg-p8600 fi-bdw-samus fi-rkl-guc bat-dg1-6
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6212 -> IGTPW_6238
CI-20190529: 20190529
CI_DRM_10609: fdc89163a79ec1a38f7a6240b9ec1d8e1ae85f39 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6238: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
IGT_6212: 0faa6b2533da9416a3428c34ca99661725577449 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
[-- Attachment #2: Type: text/html, Size: 11780 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
` (3 preceding siblings ...)
2021-09-20 10:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2) Patchwork
@ 2021-09-20 12:51 ` Patchwork
2021-09-24 4:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
5 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-09-20 12:51 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30292 bytes --]
== Series Details ==
Series: tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
URL : https://patchwork.freedesktop.org/series/94762/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10609_full -> IGTPW_6238_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6238_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_6238_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6238_full:
### IGT changes ###
#### Possible regressions ####
* igt@device_reset@unbind-reset-rebind:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk8/igt@device_reset@unbind-reset-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk2/igt@device_reset@unbind-reset-rebind.html
* igt@i915_pm_rpm@drm-resources-equal:
- shard-snb: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb2/igt@i915_pm_rpm@drm-resources-equal.html
Known issues
------------
Here are the changes found in IGTPW_6238_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries_display_off:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#262] / [i915#62] / [i915#92])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl7/igt@debugfs_test@read_all_entries_display_off.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@debugfs_test@read_all_entries_display_off.html
* igt@feature_discovery@display-2x:
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#1839])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@feature_discovery@display-2x.html
* igt@feature_discovery@psr2:
- shard-iclb: NOTRUN -> [SKIP][7] ([i915#658]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@feature_discovery@psr2.html
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][8] ([i915#3002])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@gem_create@create-massive.html
- shard-glk: NOTRUN -> [DMESG-WARN][9] ([i915#3002])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk1/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: NOTRUN -> [DMESG-WARN][10] ([i915#180]) +4 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [PASS][12] -> [TIMEOUT][13] ([i915#3063])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb1/igt@gem_eio@in-flight-contexts-1us.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2842]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][18] ([i915#2842]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109313])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109283])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@gem_exec_params@no-bsd.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [PASS][26] -> [DMESG-WARN][27] ([i915#118] / [i915#95])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk1/igt@gem_exec_whisper@basic-fds-priority-all.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk9/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@gem_mmap_gtt@coherency:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#111656])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gem_mmap_gtt@coherency.html
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][29] ([i915#2658])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@gem_pread@exhaustion.html
- shard-snb: NOTRUN -> [WARN][30] ([i915#2658])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb5/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109312]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][33] ([i915#3002])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#3297])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][35] ([i915#2724])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109289]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@gen7_exec_parse@basic-allowed.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109289]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][38] ([i915#2856]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@gen9_exec_parse@basic-rejected.html
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2856]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gen9_exec_parse@basic-rejected.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: NOTRUN -> [WARN][40] ([i915#2681])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@i915_pm_rc6_residency@rc6-fence.html
- shard-iclb: NOTRUN -> [WARN][41] ([i915#2684])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111644] / [i915#1397] / [i915#2411])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][43] ([i915#2373])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][44] ([i915#1759] / [i915#2291])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][45] -> [INCOMPLETE][46] ([i915#456])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb1/igt@i915_suspend@sysfs-reader.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111614])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-kbl: [PASS][48] -> [DMESG-WARN][49] ([i915#165] / [i915#62] / [i915#92]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3777]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3777]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3777]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#111615]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271]) +168 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271]) +216 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +13 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl2/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#3886]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#3886]) +5 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +14 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3689] / [i915#3886]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3689]) +8 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@dp-hpd-storm:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +9 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@kms_chamelium@dp-hpd-storm.html
* igt@kms_chamelium@dp-mode-timings:
- shard-glk: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +9 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109278] / [i915#1149])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@kms_color@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +24 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +14 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109284] / [fdo#111827]) +10 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +16 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][70] ([i915#1319])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl2/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- shard-iclb: [PASS][71] -> [FAIL][72] ([i915#3444]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#3444]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk1/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-tglb: [PASS][75] -> [FAIL][76] ([i915#2124] / [i915#4024]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-snb: [PASS][77] -> [FAIL][78] ([i915#4024])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
* igt@kms_cursor_crc@pipe-a-cursor-size-change:
- shard-snb: NOTRUN -> [FAIL][79] ([i915#4024])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb5/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
- shard-kbl: [PASS][80] -> [FAIL][81] ([i915#3444])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-iclb: [PASS][82] -> [INCOMPLETE][83] ([i915#2828])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3319]) +4 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109278] / [fdo#109279]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb1/igt@kms_cursor_crc@pipe-b-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109279] / [i915#3359]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][87] -> [DMESG-WARN][88] ([i915#180]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3359]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][90] ([fdo#109271]) +454 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109278]) +18 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109274] / [fdo#109278])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb5/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3788])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][94] ([i915#155] / [i915#180] / [i915#636])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-suspend:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109274]) +4 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@kms_flip@2x-flip-vs-suspend.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1:
- shard-kbl: [PASS][96] -> [DMESG-WARN][97] ([i915#62] / [i915#92]) +30 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][98] -> [DMESG-WARN][99] ([i915#180]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2587])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][101] -> [SKIP][102] ([i915#3701])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][103] -> [INCOMPLETE][104] ([i915#2411] / [i915#456])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][105] ([fdo#109271]) +65 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109280]) +14 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#111825]) +27 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@static-toggle:
- shard-iclb: NOTRUN -> [SKIP][108] ([i915#1187])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_hdr@static-toggle.html
- shard-tglb: NOTRUN -> [SKIP][109] ([i915#1187])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@kms_hdr@static-toggle.html
* igt@kms_lease@cursor_implicit_plane:
- shard-kbl: NOTRUN -> [DMESG-WARN][110] ([i915#62] / [i915#92]) +16 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_lease@cursor_implicit_plane.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#533]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: NOTRUN -> [DMESG-WARN][112] ([i915#180])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][113] ([fdo#108145] / [i915#265]) +3 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][115] ([i915#3536])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-kbl: NOTRUN -> [DMESG-WARN][116] ([i915#165] / [i915#62] / [i915#92])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_plane_lowres@pipe-c-tiling-y.html
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#3536])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_plane_lowres@pipe-c-tiling-y.html
* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#1836])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@kms_prime@basic-crc@first-to-second.html
- shard-tglb: NOTRUN -> [SKIP][119] ([i915#1836])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@kms_prime@basic-crc@first-to-second.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#658]) +4 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][121] ([i915#2920]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-apl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#658]) +4 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_su@frontbuffer:
- shard-glk: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#658]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk5/igt@kms_psr2_su@frontbuffer.html
- shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109642] / [fdo#111068] / [i915#658])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][125] ([fdo#109441])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
- shard-tglb: NOTRUN -> [FAIL][126] ([i915#132] / [i915#3467])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][127] -> [SKIP][128] ([fdo#109441])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][129] ([i915#180] / [i915#295])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][130] -> [INCOMPLETE][131] ([i915#155] / [i915#2828])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@nouveau_crc@pipe-c-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][132] ([i915#2530]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-i
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
[-- Attachment #2: Type: text/html, Size: 33845 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-20 8:29 ` Srinivas, Vidya
@ 2021-09-20 15:27 ` Mark Yacoub
2021-09-20 16:59 ` Srinivas, Vidya
0 siblings, 1 reply; 18+ messages in thread
From: Mark Yacoub @ 2021-09-20 15:27 UTC (permalink / raw)
To: Srinivas, Vidya
Cc: Rodrigo Siqueira, Development mailing list for IGT GPU Tools,
Modem, Bhanuprakash, Mark Yacoub, Nicholas Choi
On Mon, Sep 20, 2021 at 4:30 AM Srinivas, Vidya
<vidya.srinivas@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > Sent: Friday, September 17, 2021 8:34 PM
> > To: Mark Yacoub <markyacoub@chromium.org>
> > Cc: Development mailing list for IGT GPU Tools <igt-
> > dev@lists.freedesktop.org>; Modem, Bhanuprakash
> > <bhanuprakash.modem@intel.com>; Mark Yacoub
> > <markyacoub@google.com>; Srinivas, Vidya <vidya.srinivas@intel.com>;
> > Nicholas Choi <nicholas.choi@amd.com>
> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in
> > test_resolution_with_output
> >
> > Hi Mark,
> >
> > Yes, this patch cause a regression in AMD.
> >
> > I applied the original patch after the CI reported a complete pass. I also
> > tested it in a VC4 and VKMS; just for curiosity, why did we not get this
> > regression in the CI?
>
> Hello Mark/Siqueira,
> I am not very sure. One possible reason could be the CI does not run all
> the subtests sequentially? With this line, it triggers the condition
> [ 7577.454215] [drm:drm_atomic_check_only] atomic driver check for 00000000bcb190f7 failed: -22
Do we know why is this the case? I'm curious to know which check is
failing and why it is failing. Is it failing at the following atomic
commit? Cause it could be a kernel bug maybe?
> I observed the same message even with upstream kernel.
>
> I have resubmitted the patch with is amd
> https://patchwork.freedesktop.org/patch/454571/?series=94762&rev=2
> Kindly have a check. Thank you.
>
> Regards
> Vidya
> >
> > Thanks
> >
> > On 09/16, Mark Yacoub wrote:
> > > @Siquiera, I remember this also caused a regression on Qualcomm
> > > devices as well.
> > > Will removing this regress AMD? Any work around?
> > >
> > > On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> > > <vidya.srinivas@intel.com> wrote:
> > > >
> > > > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > > > test_resolution_with_output introduced setting igt_output_set_pipe
> > > > to PIPE_NONE. This is triggering atomic check failure resulting in
> > > > "enabled/connectors mismatch" under
> > drm_atomic_helper_check_modeset.
> > > > Patch fixes this issue.
> > > >
> > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > ---
> > > > tests/kms_concurrent.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index
> > > > 25c67eb469d1..40096ea1c457 100644
> > > > --- a/tests/kms_concurrent.c
> > > > +++ b/tests/kms_concurrent.c
> > > > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum
> > > > pipe pipe, int max_planes, igt_ou
> > > >
> > > > /* switch to lower resolution */
> > > > igt_output_override_mode(output, mode_lo);
> > > > - igt_output_set_pipe(output, PIPE_NONE);
> > > > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > > >
> > > > /* switch back to higher resolution */
> > > > --
> > > > 2.33.0
> > > >
> >
> > --
> > Rodrigo Siqueira
> > https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-20 15:27 ` Mark Yacoub
@ 2021-09-20 16:59 ` Srinivas, Vidya
0 siblings, 0 replies; 18+ messages in thread
From: Srinivas, Vidya @ 2021-09-20 16:59 UTC (permalink / raw)
To: Mark Yacoub
Cc: Rodrigo Siqueira, Development mailing list for IGT GPU Tools,
Modem, Bhanuprakash, Mark Yacoub, Nicholas Choi
> -----Original Message-----
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 20, 2021 8:57 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>; Development mailing list
> for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>; Mark Yacoub
> <markyacoub@google.com>; Nicholas Choi <nicholas.choi@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in
> test_resolution_with_output
>
> On Mon, Sep 20, 2021 at 4:30 AM Srinivas, Vidya <vidya.srinivas@intel.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Sent: Friday, September 17, 2021 8:34 PM
> > > To: Mark Yacoub <markyacoub@chromium.org>
> > > Cc: Development mailing list for IGT GPU Tools <igt-
> > > dev@lists.freedesktop.org>; Modem, Bhanuprakash
> > > <bhanuprakash.modem@intel.com>; Mark Yacoub
> <markyacoub@google.com>;
> > > Srinivas, Vidya <vidya.srinivas@intel.com>; Nicholas Choi
> > > <nicholas.choi@amd.com>
> > > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix
> > > regression in test_resolution_with_output
> > >
> > > Hi Mark,
> > >
> > > Yes, this patch cause a regression in AMD.
> > >
> > > I applied the original patch after the CI reported a complete pass.
> > > I also tested it in a VC4 and VKMS; just for curiosity, why did we
> > > not get this regression in the CI?
> >
> > Hello Mark/Siqueira,
> > I am not very sure. One possible reason could be the CI does not run
> > all the subtests sequentially? With this line, it triggers the
> > condition [ 7577.454215] [drm:drm_atomic_check_only] atomic driver
> > check for 00000000bcb190f7 failed: -22
> Do we know why is this the case? I'm curious to know which check is failing
> and why it is failing. Is it failing at the following atomic commit? Cause it
> could be a kernel bug maybe?
Hello Mark,
The condition which it fails for is DRM_DEBUG_ATOMIC("[CRTC:%d:%s] enabled/connectors mismatch\n")
Under new_crtc_state->enable != has_connectors
This loop is meant for CRTC changed its mode but has same set of connectors. But here,
Mismatch is getting triggered saying there is a mismatch between the CRTC that is being enabled and the number of connectors.
Function drm_atomic_helper_check_modeset
Regards
Vidya
> > I observed the same message even with upstream kernel.
> >
> > I have resubmitted the patch with is amd
> > https://patchwork.freedesktop.org/patch/454571/?series=94762&rev=2
> > Kindly have a check. Thank you.
> >
> > Regards
> > Vidya
> > >
> > > Thanks
> > >
> > > On 09/16, Mark Yacoub wrote:
> > > > @Siquiera, I remember this also caused a regression on Qualcomm
> > > > devices as well.
> > > > Will removing this regress AMD? Any work around?
> > > >
> > > > On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> > > > <vidya.srinivas@intel.com> wrote:
> > > > >
> > > > > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > > > > test_resolution_with_output introduced setting
> > > > > igt_output_set_pipe to PIPE_NONE. This is triggering atomic
> > > > > check failure resulting in "enabled/connectors mismatch" under
> > > drm_atomic_helper_check_modeset.
> > > > > Patch fixes this issue.
> > > > >
> > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > > ---
> > > > > tests/kms_concurrent.c | 1 -
> > > > > 1 file changed, 1 deletion(-)
> > > > >
> > > > > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> > > > > index
> > > > > 25c67eb469d1..40096ea1c457 100644
> > > > > --- a/tests/kms_concurrent.c
> > > > > +++ b/tests/kms_concurrent.c
> > > > > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data,
> > > > > enum pipe pipe, int max_planes, igt_ou
> > > > >
> > > > > /* switch to lower resolution */
> > > > > igt_output_override_mode(output, mode_lo);
> > > > > - igt_output_set_pipe(output, PIPE_NONE);
> > > > > igt_display_commit2(&data->display,
> > > > > COMMIT_ATOMIC);
> > > > >
> > > > > /* switch back to higher resolution */
> > > > > --
> > > > > 2.33.0
> > > > >
> > >
> > > --
> > > Rodrigo Siqueira
> > > https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-20 8:17 ` [igt-dev] [PATCH i-g-t] " Vidya Srinivas
@ 2021-09-23 17:55 ` Rodrigo Siqueira
2021-09-24 4:06 ` Srinivas, Vidya
0 siblings, 1 reply; 18+ messages in thread
From: Rodrigo Siqueira @ 2021-09-23 17:55 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev, Bhanuprakash.Modem, markyacoub
On 09/20, Vidya Srinivas wrote:
> Staring commit fea0e38e690c30c6 "Making the test more generic"
> test_resolution_with_output introduced setting igt_output_set_pipe
> to PIPE_NONE. This is triggering atomic check failure resulting in
> "enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
> Patch fixes this issue.
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_concurrent.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index 25c67eb469d1..47c441a5a3f7 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -268,7 +268,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
>
> /* switch to lower resolution */
> igt_output_override_mode(output, mode_lo);
> - igt_output_set_pipe(output, PIPE_NONE);
> + if (is_amdgpu_device(data->drm_fd))
> + igt_output_set_pipe(output, PIPE_NONE);
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> /* switch back to higher resolution */
> --
> 2.33.0
>
I checked this patch with AMD devices, and it works fine, for this
reason, feel free to add my:
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Tested-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Just a note, I think with this change, drivers based on tinyDrm might
pass this test.
Thanks
--
Rodrigo Siqueira
https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2021-09-23 17:55 ` Rodrigo Siqueira
@ 2021-09-24 4:06 ` Srinivas, Vidya
0 siblings, 0 replies; 18+ messages in thread
From: Srinivas, Vidya @ 2021-09-24 4:06 UTC (permalink / raw)
To: Rodrigo Siqueira, Modem, Bhanuprakash; +Cc: igt-dev, markyacoub
> -----Original Message-----
> From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Sent: Thursday, September 23, 2021 11:26 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: igt-dev@lists.freedesktop.org; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>; markyacoub@google.com
> Subject: Re: [PATCH i-g-t] tests/kms_concurrent: Fix regression in
> test_resolution_with_output
>
> On 09/20, Vidya Srinivas wrote:
> > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > test_resolution_with_output introduced setting igt_output_set_pipe to
> > PIPE_NONE. This is triggering atomic check failure resulting in
> > "enabled/connectors mismatch" under
> drm_atomic_helper_check_modeset.
> > Patch fixes this issue.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_concurrent.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index
> > 25c67eb469d1..47c441a5a3f7 100644
> > --- a/tests/kms_concurrent.c
> > +++ b/tests/kms_concurrent.c
> > @@ -268,7 +268,8 @@ test_resolution_with_output(data_t *data, enum
> > pipe pipe, int max_planes, igt_ou
> >
> > /* switch to lower resolution */
> > igt_output_override_mode(output, mode_lo);
> > - igt_output_set_pipe(output, PIPE_NONE);
> > + if (is_amdgpu_device(data->drm_fd))
> > + igt_output_set_pipe(output, PIPE_NONE);
> > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > /* switch back to higher resolution */
> > --
> > 2.33.0
> >
>
> I checked this patch with AMD devices, and it works fine, for this
> reason, feel free to add my:
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Tested-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Just a note, I think with this change, drivers based on tinyDrm might
> pass this test.
Hello Siqueira, thank you so much for the RB and test confirmation.
@Modem, Bhanuprakash, can you kindly help on this review and merge? Thank you.
Regards
Vidya
>
> Thanks
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
` (4 preceding siblings ...)
2021-09-20 12:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-09-24 4:59 ` Patchwork
5 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2021-09-24 4:59 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30290 bytes --]
== Series Details ==
Series: tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2)
URL : https://patchwork.freedesktop.org/series/94762/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10609_full -> IGTPW_6238_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
Known issues
------------
Here are the changes found in IGTPW_6238_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries_display_off:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#262] / [i915#62] / [i915#92])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl7/igt@debugfs_test@read_all_entries_display_off.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@debugfs_test@read_all_entries_display_off.html
* igt@device_reset@unbind-reset-rebind:
- shard-glk: [PASS][3] -> [INCOMPLETE][4] ([i915#4136])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk8/igt@device_reset@unbind-reset-rebind.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk2/igt@device_reset@unbind-reset-rebind.html
* igt@feature_discovery@display-2x:
- shard-iclb: NOTRUN -> [SKIP][5] ([i915#1839])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@feature_discovery@display-2x.html
* igt@feature_discovery@psr2:
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#658]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@feature_discovery@psr2.html
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@gem_create@create-massive.html
- shard-glk: NOTRUN -> [DMESG-WARN][8] ([i915#3002])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk1/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: NOTRUN -> [DMESG-WARN][9] ([i915#180]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1099]) +6 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#3063])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb1/igt@gem_eio@in-flight-contexts-1us.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-glk: NOTRUN -> [FAIL][14] ([i915#2842]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][17] ([i915#2842]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109313])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109283])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@gem_exec_params@no-bsd.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [PASS][25] -> [DMESG-WARN][26] ([i915#118] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk1/igt@gem_exec_whisper@basic-fds-priority-all.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk9/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@gem_mmap_gtt@coherency:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#111656])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gem_mmap_gtt@coherency.html
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][28] ([i915#2658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@gem_pread@exhaustion.html
- shard-snb: NOTRUN -> [WARN][29] ([i915#2658])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb5/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#768])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109312]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][32] ([i915#3002])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3297])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][34] ([i915#2724])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#109289]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@gen7_exec_parse@basic-allowed.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109289]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#2856]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@gen9_exec_parse@basic-rejected.html
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#2856]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@gen9_exec_parse@basic-rejected.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: NOTRUN -> [WARN][39] ([i915#2681])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@i915_pm_rc6_residency@rc6-fence.html
- shard-iclb: NOTRUN -> [WARN][40] ([i915#2684])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#111644] / [i915#1397] / [i915#2411])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@drm-resources-equal:
- shard-snb: NOTRUN -> [INCOMPLETE][42] ([i915#4179])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb2/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][43] ([i915#2373])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][44] ([i915#1759] / [i915#2291])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][45] -> [INCOMPLETE][46] ([i915#456])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb1/igt@i915_suspend@sysfs-reader.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111614])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-kbl: [PASS][48] -> [DMESG-WARN][49] ([i915#165] / [i915#62] / [i915#92]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3777]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3777]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3777]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#111615]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271]) +168 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271]) +217 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886]) +13 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl2/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#3886]) +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [i915#3886]) +5 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +14 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3689] / [i915#3886]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3689]) +8 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@dp-hpd-storm:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +9 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@kms_chamelium@dp-hpd-storm.html
* igt@kms_chamelium@dp-mode-timings:
- shard-glk: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +9 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109278] / [i915#1149])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb6/igt@kms_color@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +24 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +14 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl2/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109284] / [fdo#111827]) +10 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_color_chamelium@pipe-b-ctm-0-5.html
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +16 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][70] ([i915#1319])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl2/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- shard-iclb: [PASS][71] -> [FAIL][72] ([i915#3444]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#3444]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-glk1/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-tglb: [PASS][75] -> [FAIL][76] ([i915#2124] / [i915#4024]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
- shard-snb: [PASS][77] -> [FAIL][78] ([i915#4024])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html
* igt@kms_cursor_crc@pipe-a-cursor-size-change:
- shard-snb: NOTRUN -> [FAIL][79] ([i915#4024])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb5/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
- shard-kbl: [PASS][80] -> [FAIL][81] ([i915#3444])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-size-change.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-iclb: [PASS][82] -> [INCOMPLETE][83] ([i915#2828])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3319]) +4 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109278] / [fdo#109279]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb1/igt@kms_cursor_crc@pipe-b-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109279] / [i915#3359]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][87] -> [DMESG-WARN][88] ([i915#180]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3359]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][90] ([fdo#109271]) +456 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-snb7/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109278]) +18 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109274] / [fdo#109278])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb5/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3788])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][94] ([i915#155] / [i915#180] / [i915#636])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-suspend:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109274]) +4 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@kms_flip@2x-flip-vs-suspend.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1:
- shard-kbl: [PASS][96] -> [DMESG-WARN][97] ([i915#62] / [i915#92]) +30 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][98] -> [DMESG-WARN][99] ([i915#180]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2587])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][101] -> [SKIP][102] ([i915#3701])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][103] -> [INCOMPLETE][104] ([i915#2411] / [i915#456])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][105] ([fdo#109271]) +65 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109280]) +14 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#111825]) +27 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@static-toggle:
- shard-iclb: NOTRUN -> [SKIP][108] ([i915#1187])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_hdr@static-toggle.html
- shard-tglb: NOTRUN -> [SKIP][109] ([i915#1187])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb2/igt@kms_hdr@static-toggle.html
* igt@kms_lease@cursor_implicit_plane:
- shard-kbl: NOTRUN -> [DMESG-WARN][110] ([i915#62] / [i915#92]) +16 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_lease@cursor_implicit_plane.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#533]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: NOTRUN -> [DMESG-WARN][112] ([i915#180])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][113] ([fdo#108145] / [i915#265]) +3 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][115] ([i915#3536])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-kbl: NOTRUN -> [DMESG-WARN][116] ([i915#165] / [i915#62] / [i915#92])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl1/igt@kms_plane_lowres@pipe-c-tiling-y.html
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#3536])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb3/igt@kms_plane_lowres@pipe-c-tiling-y.html
* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#1836])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb7/igt@kms_prime@basic-crc@first-to-second.html
- shard-tglb: NOTRUN -> [SKIP][119] ([i915#1836])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb8/igt@kms_prime@basic-crc@first-to-second.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#658]) +4 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][121] ([i915#2920]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-apl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#658]) +4 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_su@frontbuffer:
- shard-glk: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#658]) +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-glk5/igt@kms_psr2_su@frontbuffer.html
- shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109642] / [fdo#111068] / [i915#658])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][125] ([fdo#109441])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
- shard-tglb: NOTRUN -> [FAIL][126] ([i915#132] / [i915#3467])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb5/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][127] -> [SKIP][128] ([fdo#109441])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][129] ([i915#180] / [i915#295])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][130] -> [INCOMPLETE][131] ([i915#155] / [i915#2828])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10609/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@nouveau_crc@pipe-c-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][132] ([i915#2530]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb5/igt@nouveau_crc@pipe-c-ctx-flip-detection.html
- shard-tglb: NOTRUN -> [SKIP][133] ([i915#2530])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-tglb1/igt@nouveau_crc@pipe-c-ctx-flip-detection.html
* igt@prime_nv_test@i915_nv_sharing:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109291])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/shard-iclb3/igt@prime_nv_test@i915_nv_sharing.html
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6238/index.html
[-- Attachment #2: Type: text/html, Size: 33873 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2022-06-24 5:00 Nidhi Gupta
@ 2022-06-24 8:11 ` Karthik B S
0 siblings, 0 replies; 18+ messages in thread
From: Karthik B S @ 2022-06-24 8:11 UTC (permalink / raw)
To: Nidhi Gupta, igt-dev
On 6/24/2022 10:30 AM, Nidhi Gupta wrote:
> Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
> to skip the subtest if the suitable resolution is not found.
>
> The kms_concurrent is about testing mode setting with
> reducing the resolution and then again increasing it,
> for this the test will take the high resolution supported
> by the connector and then calculate the lowest resolution,
> if the calculated resolution is not supported by the connector
> it will assign the default resolution of 1024x 768 without
> checking.
>
> Added check to skip the subtest if the current mode is smaller
> than 1024 mode (igt_skip_on_f(mode_default->hdisplay < 1024))
> becuase if the default resolution is greater then the highest
> resolution supported by the connector then the test should skip.
>
> Fixes: 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_concurrent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index d4536e3b..6f8ffd4a 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -252,7 +252,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
> return igt_memdup(mode, sizeof(*mode));
> }
>
> - igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
> + igt_skip_on_f(mode_default->hdisplay < 1024, "No suitable resolution was found\n");
> return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
> }
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2022-06-24 5:00 Nidhi Gupta
2022-06-24 8:11 ` Karthik B S
0 siblings, 1 reply; 18+ messages in thread
From: Nidhi Gupta @ 2022-06-24 5:00 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.
The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.
Added check to skip the subtest if the current mode is smaller
than 1024 mode (igt_skip_on_f(mode_default->hdisplay < 1024))
becuase if the default resolution is greater then the highest
resolution supported by the connector then the test should skip.
Fixes: 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_concurrent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..6f8ffd4a 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
return igt_memdup(mode, sizeof(*mode));
}
- igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
+ igt_skip_on_f(mode_default->hdisplay < 1024, "No suitable resolution was found\n");
return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
}
--
2.26.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
2022-05-31 5:14 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Nidhi Gupta
@ 2022-06-13 9:11 ` Karthik B S
0 siblings, 0 replies; 18+ messages in thread
From: Karthik B S @ 2022-06-13 9:11 UTC (permalink / raw)
To: Nidhi Gupta, igt-dev
On 5/31/2022 10:44 AM, Nidhi Gupta wrote:
> Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
> to skip the subtest if the suitable resolution is not found.
>
> -the test will calculate the high resolution and low resolution supported by
> the connector.
> -high resolution will be the default highest resolution supported by the connector
> and using that test calculates the lower resolution.
> -if the lower resolution is not supported by the connector it will assign the
> default resolution of 1024x768
> -if the default resolution value is higher than the high resolutin, skip in that
> situation to avoid failure of the test.
Hi,
Please update the commit message. The only issue is that instead of
checking hdisplay < 1024, currently vdisplay < 1024 is being checked.
So could you just update the igt_skip check with vdisplay instead of
hdisplay. No need to move the skip to a different functions.
Also, please add a fixes tag.
Thanks,
Karthik.B.S
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_concurrent.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index d4536e3b..f3cec242 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -252,7 +252,6 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
> return igt_memdup(mode, sizeof(*mode));
> }
>
> - igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
> return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
> }
>
> @@ -273,6 +272,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
> mode_hi = igt_output_get_mode(output);
> mode_lo = get_lowres_mode(data, mode_hi, output);
>
> + igt_skip_on_f(mode_lo->vdisplay > mode_hi->vdisplay, "No suitable resolution was found\n");
> +
> /* switch to lower resolution */
> igt_output_override_mode(output, mode_lo);
> free(mode_lo);
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
@ 2022-05-31 5:14 Nidhi Gupta
2022-06-13 9:11 ` Karthik B S
0 siblings, 1 reply; 18+ messages in thread
From: Nidhi Gupta @ 2022-05-31 5:14 UTC (permalink / raw)
To: igt-dev, karthik.b.s; +Cc: Nidhi Gupta
Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.
-the test will calculate the high resolution and low resolution supported by
the connector.
-high resolution will be the default highest resolution supported by the connector
and using that test calculates the lower resolution.
-if the lower resolution is not supported by the connector it will assign the
default resolution of 1024x768
-if the default resolution value is higher than the high resolutin, skip in that
situation to avoid failure of the test.
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_concurrent.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..f3cec242 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,6 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
return igt_memdup(mode, sizeof(*mode));
}
- igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
}
@@ -273,6 +272,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
mode_hi = igt_output_get_mode(output);
mode_lo = get_lowres_mode(data, mode_hi, output);
+ igt_skip_on_f(mode_lo->vdisplay > mode_hi->vdisplay, "No suitable resolution was found\n");
+
/* switch to lower resolution */
igt_output_override_mode(output, mode_lo);
free(mode_lo);
--
2.26.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-06-24 8:11 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 14:18 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Vidya Srinivas
2021-09-16 15:36 ` Mark Yacoub
2021-09-17 15:03 ` Rodrigo Siqueira
2021-09-17 16:35 ` Mark Yacoub
2021-09-20 8:29 ` Srinivas, Vidya
2021-09-20 15:27 ` Mark Yacoub
2021-09-20 16:59 ` Srinivas, Vidya
2021-09-16 17:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-09-20 8:17 ` [igt-dev] [PATCH i-g-t] " Vidya Srinivas
2021-09-23 17:55 ` Rodrigo Siqueira
2021-09-24 4:06 ` Srinivas, Vidya
2021-09-20 10:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Fix regression in test_resolution_with_output (rev2) Patchwork
2021-09-20 12:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-24 4:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-05-31 5:14 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output Nidhi Gupta
2022-06-13 9:11 ` Karthik B S
2022-06-24 5:00 Nidhi Gupta
2022-06-24 8:11 ` Karthik B S
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.