From: Bryan Brattlof <bb@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node
Date: Thu, 7 Jul 2022 09:44:00 -0500 [thread overview]
Message-ID: <20220707144400.tk3wmpeijdhuxpzv@bryanbrattlof.com> (raw)
In-Reply-To: <20220706190838.26074-1-afd@ti.com>
Hi Andrew
On July 6, 2022 thus sayeth Andrew Davis:
> The hardware random number generator is used by OP-TEE and is access is
> denied to other users with SoC level bus firewalls. Any access to this
> device from Linux will result in firewall errors. Disable this node.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Added comment in dtsi file
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index e749343accedd..9de5a8294acd6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -127,6 +127,7 @@ rng: rng@4e10000 {
> reg = <0x0 0x4e10000 0x0 0x7d>;
> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&k3_clks 136 1>;
> + status = "disabled"; /* Used by OP-TEE */
Just curious about how we should document disabling nodes. I was
assuming the reasoning should be described in the bindings?
I would like to start disabling nodes by default in our dtsi files and
enabling them in our top dts file, making it easier for others to use
our device tree for a more focused purpose than our dev boards. I just
didn't know where I should document why I disabled the nodes :)
~Bryan
WARNING: multiple messages have this Message-ID (diff)
From: Bryan Brattlof <bb@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node
Date: Thu, 7 Jul 2022 09:44:00 -0500 [thread overview]
Message-ID: <20220707144400.tk3wmpeijdhuxpzv@bryanbrattlof.com> (raw)
In-Reply-To: <20220706190838.26074-1-afd@ti.com>
Hi Andrew
On July 6, 2022 thus sayeth Andrew Davis:
> The hardware random number generator is used by OP-TEE and is access is
> denied to other users with SoC level bus firewalls. Any access to this
> device from Linux will result in firewall errors. Disable this node.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Added comment in dtsi file
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index e749343accedd..9de5a8294acd6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -127,6 +127,7 @@ rng: rng@4e10000 {
> reg = <0x0 0x4e10000 0x0 0x7d>;
> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&k3_clks 136 1>;
> + status = "disabled"; /* Used by OP-TEE */
Just curious about how we should document disabling nodes. I was
assuming the reasoning should be described in the bindings?
I would like to start disabling nodes by default in our dtsi files and
enabling them in our top dts file, making it easier for others to use
our device tree for a more focused purpose than our dev boards. I just
didn't know where I should document why I disabled the nodes :)
~Bryan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-07 14:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:08 [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node Andrew Davis
2022-07-06 19:08 ` Andrew Davis
2022-07-06 19:08 ` [PATCH v2 2/4] arm64: dts: ti: k3-am65-main: Move SA2UL to unused PSI-L thread ID Andrew Davis
2022-07-06 19:08 ` Andrew Davis
2022-07-06 19:08 ` [PATCH v2 3/4] arm64: dts: ti: k3-am65-main: Do not exclusively claim SA2UL Andrew Davis
2022-07-06 19:08 ` Andrew Davis
2022-07-06 19:08 ` [PATCH v2 4/4] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node Andrew Davis
2022-07-06 19:08 ` Andrew Davis
2022-07-07 14:44 ` Bryan Brattlof [this message]
2022-07-07 14:44 ` [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node Bryan Brattlof
2022-07-07 15:01 ` Andrew Davis
2022-07-07 15:01 ` Andrew Davis
2022-07-07 17:17 ` Nishanth Menon
2022-07-07 17:17 ` Nishanth Menon
2022-07-07 17:36 ` Andrew Davis
2022-07-07 17:36 ` Andrew Davis
2022-07-08 22:09 ` Nishanth Menon
2022-07-08 22:09 ` Nishanth Menon
2022-08-23 0:11 Andrew Davis
2022-08-23 0:11 ` Andrew Davis
2022-08-30 9:54 ` Jayesh Choudhary
2022-08-30 9:54 ` Jayesh Choudhary
2022-09-09 9:56 ` Vignesh Raghavendra
2022-09-09 9:56 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707144400.tk3wmpeijdhuxpzv@bryanbrattlof.com \
--to=bb@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.