* [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU
devices). Cleanup DPU schema files, so that they do not contain schema
for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema
afterwards.
Changes since v1:
- Renamed DPU device nodes from mdp@ to display-controller@
- Described removal of mistakenly mentioned "lut" clock
- Switched mdss.yaml to use $ref instead of fixing compatible strings
- Dropped mdp-opp-table description (renamed by Krzysztof in his
patchset)
- Reworked DPU's ports definitions. Dropped description of individual
ports, left only /ports $ref and description in dpu-common.yaml.
Dmitry Baryshkov (11):
arm64: dts: qcom: sdm845: rename DPU device node
arm64: dts: qcom: sc7180: rename DPU device node
arm64: dts: qcom: sm8250: rename DPU device node
dt-bindings: display/msm: split qcom, mdss bindings
dt-bindings: display/msm: move qcom,sdm845-mdss schema to mdss.yaml
dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
dt-bindings: display/msm: move qcom,sc7280-mdss schema to mdss.yaml
dt-bindings: display/msm: move qcom,qcm2290-mdss schema to mdss.yaml
dt-bindings: display/msm: move qcom,msm8998-mdss schema to mdss.yaml
dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845
dt-bindings: display/msm: move common DPU properties to
dpu-common.yaml
.../bindings/display/msm/dpu-common.yaml | 42 ++
.../bindings/display/msm/dpu-msm8998.yaml | 139 +------
.../bindings/display/msm/dpu-qcm2290.yaml | 143 +------
.../bindings/display/msm/dpu-sc7180.yaml | 148 +------
.../bindings/display/msm/dpu-sc7280.yaml | 147 +------
.../bindings/display/msm/dpu-sdm845.yaml | 139 +------
.../devicetree/bindings/display/msm/mdp5.txt | 30 +-
.../devicetree/bindings/display/msm/mdss.yaml | 361 ++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
11 files changed, 508 insertions(+), 647 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
--
2.35.1
^ permalink raw reply [flat|nested] 62+ messages in thread* [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 32ad5972a642..7c66f490e822 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4265,7 +4265,7 @@ mdss: mdss@ae00000 {
#size-cells = <2>;
ranges;
- mdss_mdp: mdp@ae01000 {
+ mdss_mdp: display-controller@ae01000 {
compatible = "qcom,sdm845-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 32ad5972a642..7c66f490e822 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4265,7 +4265,7 @@ mdss: mdss@ae00000 {
#size-cells = <2>;
ranges;
- mdss_mdp: mdp@ae01000 {
+ mdss_mdp: display-controller@ae01000 {
compatible = "qcom,sdm845-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-11 8:39 ` Konrad Dybcio
-1 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:39 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 32ad5972a642..7c66f490e822 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4265,7 +4265,7 @@ mdss: mdss@ae00000 {
> #size-cells = <2>;
> ranges;
>
> - mdss_mdp: mdp@ae01000 {
> + mdss_mdp: display-controller@ae01000 {
> compatible = "qcom,sdm845-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread* Re: [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node
@ 2022-07-11 8:39 ` Konrad Dybcio
0 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:39 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 32ad5972a642..7c66f490e822 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4265,7 +4265,7 @@ mdss: mdss@ae00000 {
> #size-cells = <2>;
> ranges;
>
> - mdss_mdp: mdp@ae01000 {
> + mdss_mdp: display-controller@ae01000 {
> compatible = "qcom,sdm845-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 72994f599825..e63b4515453f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2911,7 +2911,7 @@ mdss: mdss@ae00000 {
status = "disabled";
- mdp: mdp@ae01000 {
+ mdp: display-controller@ae01000 {
compatible = "qcom,sc7180-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 72994f599825..e63b4515453f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2911,7 +2911,7 @@ mdss: mdss@ae00000 {
status = "disabled";
- mdp: mdp@ae01000 {
+ mdp: display-controller@ae01000 {
compatible = "qcom,sc7180-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-11 8:39 ` Konrad Dybcio
-1 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:39 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 72994f599825..e63b4515453f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2911,7 +2911,7 @@ mdss: mdss@ae00000 {
>
> status = "disabled";
>
> - mdp: mdp@ae01000 {
> + mdp: display-controller@ae01000 {
> compatible = "qcom,sc7180-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread* Re: [PATCH v2 02/11] arm64: dts: qcom: sc7180: rename DPU device node
@ 2022-07-11 8:39 ` Konrad Dybcio
0 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:39 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 72994f599825..e63b4515453f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2911,7 +2911,7 @@ mdss: mdss@ae00000 {
>
> status = "disabled";
>
> - mdp: mdp@ae01000 {
> + mdp: display-controller@ae01000 {
> compatible = "qcom,sc7180-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 43c2d04b226f..48c60df59080 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3444,7 +3444,7 @@ mdss: mdss@ae00000 {
#size-cells = <2>;
ranges;
- mdss_mdp: mdp@ae01000 {
+ mdss_mdp: display-controller@ae01000 {
compatible = "qcom,sm8250-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Rename DPU device node to display-controller@ae01000 to follow the
DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 43c2d04b226f..48c60df59080 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3444,7 +3444,7 @@ mdss: mdss@ae00000 {
#size-cells = <2>;
ranges;
- mdss_mdp: mdp@ae01000 {
+ mdss_mdp: display-controller@ae01000 {
compatible = "qcom,sm8250-dpu";
reg = <0 0x0ae01000 0 0x8f000>,
<0 0x0aeb0000 0 0x2008>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-11 8:40 ` Konrad Dybcio
-1 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:40 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 43c2d04b226f..48c60df59080 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3444,7 +3444,7 @@ mdss: mdss@ae00000 {
> #size-cells = <2>;
> ranges;
>
> - mdss_mdp: mdp@ae01000 {
> + mdss_mdp: display-controller@ae01000 {
> compatible = "qcom,sm8250-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread* Re: [PATCH v2 03/11] arm64: dts: qcom: sm8250: rename DPU device node
@ 2022-07-11 8:40 ` Konrad Dybcio
0 siblings, 0 replies; 62+ messages in thread
From: Konrad Dybcio @ 2022-07-11 8:40 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark,
Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 10.07.2022 11:00, Dmitry Baryshkov wrote:
> Rename DPU device node to display-controller@ae01000 to follow the
> DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 43c2d04b226f..48c60df59080 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3444,7 +3444,7 @@ mdss: mdss@ae00000 {
> #size-cells = <2>;
> ranges;
>
> - mdss_mdp: mdp@ae01000 {
> + mdss_mdp: display-controller@ae01000 {
> compatible = "qcom,sm8250-dpu";
> reg = <0 0x0ae01000 0 0x8f000>,
> <0 0x0aeb0000 0 0x2008>;
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Split Mobile Display SubSystem (MDSS) root node bindings to the separate
yaml file. Changes to the existing (txt) schema:
- Added optional "vbif_nrt_phys" region used by msm8996
- Made "bus" and "vsync" clocks optional (they are not used by some
platforms)
- Added (optional) "core" clock added recently to the mdss driver
- Added optional resets property referencing MDSS reset
- Defined child nodes pointing to corresponding reference schema.
- Dropped the "lut" clock. It was added to the schema by mistake (it is
a part of mdp4 schema, not the mdss).
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../devicetree/bindings/display/msm/mdp5.txt | 30 +---
.../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
2 files changed, 162 insertions(+), 29 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/mdp5.txt b/Documentation/devicetree/bindings/display/msm/mdp5.txt
index 43d11279c925..65d03c58dee6 100644
--- a/Documentation/devicetree/bindings/display/msm/mdp5.txt
+++ b/Documentation/devicetree/bindings/display/msm/mdp5.txt
@@ -2,37 +2,9 @@ Qualcomm adreno/snapdragon MDP5 display controller
Description:
-This is the bindings documentation for the Mobile Display Subsytem(MDSS) that
-encapsulates sub-blocks like MDP5, DSI, HDMI, eDP etc, and the MDP5 display
+This is the bindings documentation for the MDP5 display
controller found in SoCs like MSM8974, APQ8084, MSM8916, MSM8994 and MSM8996.
-MDSS:
-Required properties:
-- compatible:
- * "qcom,mdss" - MDSS
-- reg: Physical base address and length of the controller's registers.
-- reg-names: The names of register regions. The following regions are required:
- * "mdss_phys"
- * "vbif_phys"
-- interrupts: The interrupt signal from MDSS.
-- interrupt-controller: identifies the node as an interrupt controller.
-- #interrupt-cells: specifies the number of cells needed to encode an interrupt
- source, should be 1.
-- power-domains: a power domain consumer specifier according to
- Documentation/devicetree/bindings/power/power_domain.txt
-- clocks: device clocks. See ../clocks/clock-bindings.txt for details.
-- clock-names: the following clocks are required.
- * "iface"
- * "bus"
- * "vsync"
-- #address-cells: number of address cells for the MDSS children. Should be 1.
-- #size-cells: Should be 1.
-- ranges: parent bus address space is the same as the child bus address space.
-
-Optional properties:
-- clock-names: the following clocks are optional:
- * "lut"
-
MDP5:
Required properties:
- compatible:
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
new file mode 100644
index 000000000000..ba674a261b18
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -0,0 +1,161 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Mobile Display SubSystem (MDSS)
+
+maintainers:
+ - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+ - Rob Clark <robdclark@gmail.com>
+
+description:
+ This is the bindings documentation for the Mobile Display Subsytem(MDSS) that
+ encapsulates sub-blocks like MDP5, DSI, HDMI, eDP, etc.
+
+properties:
+ compatible:
+ enum:
+ - qcom,mdss
+
+ reg:
+ minItems: 2
+ maxItems: 3
+
+ reg-names:
+ minItems: 2
+ items:
+ - const: mdss_phys
+ - const: vbif_phys
+ - const: vbif_nrt_phys
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller:
+ true
+
+ "#interrupt-cells":
+ const: 1
+
+ power-domains:
+ maxItems: 1
+ description: |
+ The MDSS power domain provided by GCC
+
+ clocks:
+ minItems: 1
+ maxItems: 4
+
+ clock-names:
+ minItems: 1
+ maxItems: 4
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges:
+ true
+
+ resets:
+ items:
+ - description: MDSS_CORE reset
+
+oneOf:
+ - properties:
+ clocks:
+ minItems: 3
+ maxItems: 4
+
+ clock-names:
+ minItems: 3
+ items:
+ - const: iface
+ - const: bus
+ - const: vsync
+ - const: core
+ - properties:
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ items:
+ - const: iface
+ - const: core
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+ - power-domains
+ - clocks
+ - clock-names
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+patternProperties:
+ "^mdp@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ # TODO: add reference once the mdp5 is converted
+
+ "^dsi@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: dsi-controller-main.yaml#
+
+ "^dsi-phy@(0|[1-9a-f][0-9a-f]*)$":
+ oneOf:
+ - $ref: dsi-phy-28nm.yaml#
+ - $ref: dsi-phy-20nm.yaml#
+ - $ref: dsi-phy-14nm.yaml#
+ - $ref: dsi-phy-10nm.yaml#
+ - $ref: dsi-phy-7nm.yaml#
+
+ "^hdmi-phy@(0|[1-9a-f][0-9a-f]*)$":
+ oneOf:
+ - $ref: /schemas/phy/qcom,hdmi-phy-qmp.yaml#
+ - $ref: /schemas/phy/qcom,hdmi-phy-other.yaml#
+
+ "^hdmi-tx@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: hdmi.yaml#
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,gcc-msm8916.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ mdss@1a00000 {
+ compatible = "qcom,mdss";
+ reg = <0x1a00000 0x1000>,
+ <0x1ac8000 0x3000>;
+ reg-names = "mdss_phys", "vbif_phys";
+
+ power-domains = <&gcc MDSS_GDSC>;
+
+ clocks = <&gcc GCC_MDSS_AHB_CLK>,
+ <&gcc GCC_MDSS_AXI_CLK>,
+ <&gcc GCC_MDSS_VSYNC_CLK>;
+ clock-names = "iface",
+ "bus",
+ "vsync";
+
+ interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
+
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ };
+...
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Split Mobile Display SubSystem (MDSS) root node bindings to the separate
yaml file. Changes to the existing (txt) schema:
- Added optional "vbif_nrt_phys" region used by msm8996
- Made "bus" and "vsync" clocks optional (they are not used by some
platforms)
- Added (optional) "core" clock added recently to the mdss driver
- Added optional resets property referencing MDSS reset
- Defined child nodes pointing to corresponding reference schema.
- Dropped the "lut" clock. It was added to the schema by mistake (it is
a part of mdp4 schema, not the mdss).
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../devicetree/bindings/display/msm/mdp5.txt | 30 +---
.../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
2 files changed, 162 insertions(+), 29 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/mdp5.txt b/Documentation/devicetree/bindings/display/msm/mdp5.txt
index 43d11279c925..65d03c58dee6 100644
--- a/Documentation/devicetree/bindings/display/msm/mdp5.txt
+++ b/Documentation/devicetree/bindings/display/msm/mdp5.txt
@@ -2,37 +2,9 @@ Qualcomm adreno/snapdragon MDP5 display controller
Description:
-This is the bindings documentation for the Mobile Display Subsytem(MDSS) that
-encapsulates sub-blocks like MDP5, DSI, HDMI, eDP etc, and the MDP5 display
+This is the bindings documentation for the MDP5 display
controller found in SoCs like MSM8974, APQ8084, MSM8916, MSM8994 and MSM8996.
-MDSS:
-Required properties:
-- compatible:
- * "qcom,mdss" - MDSS
-- reg: Physical base address and length of the controller's registers.
-- reg-names: The names of register regions. The following regions are required:
- * "mdss_phys"
- * "vbif_phys"
-- interrupts: The interrupt signal from MDSS.
-- interrupt-controller: identifies the node as an interrupt controller.
-- #interrupt-cells: specifies the number of cells needed to encode an interrupt
- source, should be 1.
-- power-domains: a power domain consumer specifier according to
- Documentation/devicetree/bindings/power/power_domain.txt
-- clocks: device clocks. See ../clocks/clock-bindings.txt for details.
-- clock-names: the following clocks are required.
- * "iface"
- * "bus"
- * "vsync"
-- #address-cells: number of address cells for the MDSS children. Should be 1.
-- #size-cells: Should be 1.
-- ranges: parent bus address space is the same as the child bus address space.
-
-Optional properties:
-- clock-names: the following clocks are optional:
- * "lut"
-
MDP5:
Required properties:
- compatible:
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
new file mode 100644
index 000000000000..ba674a261b18
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -0,0 +1,161 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Mobile Display SubSystem (MDSS)
+
+maintainers:
+ - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+ - Rob Clark <robdclark@gmail.com>
+
+description:
+ This is the bindings documentation for the Mobile Display Subsytem(MDSS) that
+ encapsulates sub-blocks like MDP5, DSI, HDMI, eDP, etc.
+
+properties:
+ compatible:
+ enum:
+ - qcom,mdss
+
+ reg:
+ minItems: 2
+ maxItems: 3
+
+ reg-names:
+ minItems: 2
+ items:
+ - const: mdss_phys
+ - const: vbif_phys
+ - const: vbif_nrt_phys
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller:
+ true
+
+ "#interrupt-cells":
+ const: 1
+
+ power-domains:
+ maxItems: 1
+ description: |
+ The MDSS power domain provided by GCC
+
+ clocks:
+ minItems: 1
+ maxItems: 4
+
+ clock-names:
+ minItems: 1
+ maxItems: 4
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges:
+ true
+
+ resets:
+ items:
+ - description: MDSS_CORE reset
+
+oneOf:
+ - properties:
+ clocks:
+ minItems: 3
+ maxItems: 4
+
+ clock-names:
+ minItems: 3
+ items:
+ - const: iface
+ - const: bus
+ - const: vsync
+ - const: core
+ - properties:
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ items:
+ - const: iface
+ - const: core
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+ - power-domains
+ - clocks
+ - clock-names
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+patternProperties:
+ "^mdp@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ # TODO: add reference once the mdp5 is converted
+
+ "^dsi@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: dsi-controller-main.yaml#
+
+ "^dsi-phy@(0|[1-9a-f][0-9a-f]*)$":
+ oneOf:
+ - $ref: dsi-phy-28nm.yaml#
+ - $ref: dsi-phy-20nm.yaml#
+ - $ref: dsi-phy-14nm.yaml#
+ - $ref: dsi-phy-10nm.yaml#
+ - $ref: dsi-phy-7nm.yaml#
+
+ "^hdmi-phy@(0|[1-9a-f][0-9a-f]*)$":
+ oneOf:
+ - $ref: /schemas/phy/qcom,hdmi-phy-qmp.yaml#
+ - $ref: /schemas/phy/qcom,hdmi-phy-other.yaml#
+
+ "^hdmi-tx@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: hdmi.yaml#
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,gcc-msm8916.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ mdss@1a00000 {
+ compatible = "qcom,mdss";
+ reg = <0x1a00000 0x1000>,
+ <0x1ac8000 0x3000>;
+ reg-names = "mdss_phys", "vbif_phys";
+
+ power-domains = <&gcc MDSS_GDSC>;
+
+ clocks = <&gcc GCC_MDSS_AHB_CLK>,
+ <&gcc GCC_MDSS_AXI_CLK>,
+ <&gcc GCC_MDSS_VSYNC_CLK>;
+ clock-names = "iface",
+ "bus",
+ "vsync";
+
+ interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
+
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ };
+...
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 16:54 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-10 16:54 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Stephen Boyd, David Airlie, linux-arm-msm, dri-devel, Andy Gross,
Sean Paul, freedreno, Krzysztof Kozlowski, Rob Clark, devicetree,
Konrad Dybcio, Rob Herring, Bjorn Andersson, Abhinav Kumar,
Daniel Vetter
On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote:
> Split Mobile Display SubSystem (MDSS) root node bindings to the separate
> yaml file. Changes to the existing (txt) schema:
> - Added optional "vbif_nrt_phys" region used by msm8996
> - Made "bus" and "vsync" clocks optional (they are not used by some
> platforms)
> - Added (optional) "core" clock added recently to the mdss driver
> - Added optional resets property referencing MDSS reset
> - Defined child nodes pointing to corresponding reference schema.
> - Dropped the "lut" clock. It was added to the schema by mistake (it is
> a part of mdp4 schema, not the mdss).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/mdp5.txt | 30 +---
> .../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
> 2 files changed, 162 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/display/msm/mdss.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
@ 2022-07-10 16:54 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-10 16:54 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: freedreno, devicetree, David Airlie, linux-arm-msm,
Konrad Dybcio, Abhinav Kumar, dri-devel, Stephen Boyd,
Rob Herring, Andy Gross, Krzysztof Kozlowski, Bjorn Andersson,
Sean Paul
On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote:
> Split Mobile Display SubSystem (MDSS) root node bindings to the separate
> yaml file. Changes to the existing (txt) schema:
> - Added optional "vbif_nrt_phys" region used by msm8996
> - Made "bus" and "vsync" clocks optional (they are not used by some
> platforms)
> - Added (optional) "core" clock added recently to the mdss driver
> - Added optional resets property referencing MDSS reset
> - Defined child nodes pointing to corresponding reference schema.
> - Dropped the "lut" clock. It was added to the schema by mistake (it is
> a part of mdp4 schema, not the mdss).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/mdp5.txt | 30 +---
> .../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
> 2 files changed, 162 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/display/msm/mdss.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
2022-07-10 16:54 ` Rob Herring
@ 2022-07-10 17:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 17:00 UTC (permalink / raw)
To: Rob Herring
Cc: Stephen Boyd, David Airlie, linux-arm-msm, dri-devel, Andy Gross,
Sean Paul, freedreno, Krzysztof Kozlowski, Rob Clark, devicetree,
Konrad Dybcio, Rob Herring, Bjorn Andersson, Abhinav Kumar,
Daniel Vetter
On 10/07/2022 19:54, Rob Herring wrote:
> On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote:
>> Split Mobile Display SubSystem (MDSS) root node bindings to the separate
>> yaml file. Changes to the existing (txt) schema:
>> - Added optional "vbif_nrt_phys" region used by msm8996
>> - Made "bus" and "vsync" clocks optional (they are not used by some
>> platforms)
>> - Added (optional) "core" clock added recently to the mdss driver
>> - Added optional resets property referencing MDSS reset
>> - Defined child nodes pointing to corresponding reference schema.
>> - Dropped the "lut" clock. It was added to the schema by mistake (it is
>> a part of mdp4 schema, not the mdss).
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../devicetree/bindings/display/msm/mdp5.txt | 30 +---
>> .../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
>> 2 files changed, 162 insertions(+), 29 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/display/msm/mdss.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml
The tree is based on linux-next (well, msm-next, which is a part of
linux-next).
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
@ 2022-07-10 17:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 17:00 UTC (permalink / raw)
To: Rob Herring
Cc: freedreno, devicetree, David Airlie, linux-arm-msm,
Konrad Dybcio, Abhinav Kumar, dri-devel, Stephen Boyd,
Rob Herring, Andy Gross, Krzysztof Kozlowski, Bjorn Andersson,
Sean Paul
On 10/07/2022 19:54, Rob Herring wrote:
> On Sun, 10 Jul 2022 12:00:33 +0300, Dmitry Baryshkov wrote:
>> Split Mobile Display SubSystem (MDSS) root node bindings to the separate
>> yaml file. Changes to the existing (txt) schema:
>> - Added optional "vbif_nrt_phys" region used by msm8996
>> - Made "bus" and "vsync" clocks optional (they are not used by some
>> platforms)
>> - Added (optional) "core" clock added recently to the mdss driver
>> - Added optional resets property referencing MDSS reset
>> - Defined child nodes pointing to corresponding reference schema.
>> - Dropped the "lut" clock. It was added to the schema by mistake (it is
>> a part of mdp4 schema, not the mdss).
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../devicetree/bindings/display/msm/mdp5.txt | 30 +---
>> .../devicetree/bindings/display/msm/mdss.yaml | 161 ++++++++++++++++++
>> 2 files changed, 162 insertions(+), 29 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/display/msm/mdss.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml
The tree is based on linux-next (well, msm-next, which is a part of
linux-next).
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-11 11:37 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-11 11:37 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 10/07/2022 11:00, Dmitry Baryshkov wrote:
Thank you for your patch. There is something to discuss/improve.
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> + - power-domains
> + - clocks
> + - clock-names
> + - "#address-cells"
> + - "#size-cells"
> + - ranges
> +
> +patternProperties:
> + "^mdp@(0|[1-9a-f][0-9a-f]*)$":
You used some unusual pattern. It's just "[0-9a-f]+" - the device
schema's job is not to validate patterns in unit addresses.
Another question - why do you allow "@0" alone?
> + type: object
> + # TODO: add reference once the mdp5 is converted
> +
> + "^dsi@(0|[1-9a-f][0-9a-f]*)$":
> + $ref: dsi-controller-main.yaml#
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
@ 2022-07-11 11:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-11 11:37 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 10/07/2022 11:00, Dmitry Baryshkov wrote:
Thank you for your patch. There is something to discuss/improve.
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> + - power-domains
> + - clocks
> + - clock-names
> + - "#address-cells"
> + - "#size-cells"
> + - ranges
> +
> +patternProperties:
> + "^mdp@(0|[1-9a-f][0-9a-f]*)$":
You used some unusual pattern. It's just "[0-9a-f]+" - the device
schema's job is not to validate patterns in unit addresses.
Another question - why do you allow "@0" alone?
> + type: object
> + # TODO: add reference once the mdp5 is converted
> +
> + "^dsi@(0|[1-9a-f][0-9a-f]*)$":
> + $ref: dsi-controller-main.yaml#
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
2022-07-11 11:37 ` Krzysztof Kozlowski
@ 2022-08-22 18:57 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 18:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 11/07/2022 14:37, Krzysztof Kozlowski wrote:
> On 10/07/2022 11:00, Dmitry Baryshkov wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - interrupts
>> + - interrupt-controller
>> + - "#interrupt-cells"
>> + - power-domains
>> + - clocks
>> + - clock-names
>> + - "#address-cells"
>> + - "#size-cells"
>> + - ranges
>> +
>> +patternProperties:
>> + "^mdp@(0|[1-9a-f][0-9a-f]*)$":
>
> You used some unusual pattern. It's just "[0-9a-f]+" - the device
> schema's job is not to validate patterns in unit addresses.
>
> Another question - why do you allow "@0" alone?
I think this was c&p from the other file. Dropped the @0 alternative.
>
>> + type: object
>> + # TODO: add reference once the mdp5 is converted
>> +
>> + "^dsi@(0|[1-9a-f][0-9a-f]*)$":
>> + $ref: dsi-controller-main.yaml#
>
>
> Best regards,
> Krzysztof
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings
@ 2022-08-22 18:57 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 18:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 11/07/2022 14:37, Krzysztof Kozlowski wrote:
> On 10/07/2022 11:00, Dmitry Baryshkov wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - interrupts
>> + - interrupt-controller
>> + - "#interrupt-cells"
>> + - power-domains
>> + - clocks
>> + - clock-names
>> + - "#address-cells"
>> + - "#size-cells"
>> + - ranges
>> +
>> +patternProperties:
>> + "^mdp@(0|[1-9a-f][0-9a-f]*)$":
>
> You used some unusual pattern. It's just "[0-9a-f]+" - the device
> schema's job is not to validate patterns in unit addresses.
>
> Another question - why do you allow "@0" alone?
I think this was c&p from the other file. Dropped the @0 alternative.
>
>> + type: object
>> + # TODO: add reference once the mdp5 is converted
>> +
>> + "^dsi@(0|[1-9a-f][0-9a-f]*)$":
>> + $ref: dsi-controller-main.yaml#
>
>
> Best regards,
> Krzysztof
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 05/11] dt-bindings: display/msm: move qcom,sdm845-mdss schema to mdss.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sdm845.yaml | 135 ++++-----------
.../devicetree/bindings/display/msm/mdss.yaml | 156 ++++++++++++++----
2 files changed, 160 insertions(+), 131 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 2bb8896beffc..2074e954372f 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -10,139 +10,74 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SDM845 target.
+ Device tree bindings for the DPU display controller for SDM845 target.
properties:
compatible:
items:
- - const: qcom,sdm845-mdss
+ - const: qcom,sdm845-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
+ - description: Display ahb clock
+ - description: Display axi clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
- const: iface
+ - const: bus
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
-
- ranges: true
-
- resets:
- items:
- - description: MDSS_CORE reset
+ power-domains:
+ maxItems: 1
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ operating-points-v2: true
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,sdm845-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display ahb clock
- - description: Display axi clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: iface
- - const: bus
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF2 (DSI2)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
+ - port@1
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index ba674a261b18..7d4ab3d71d2d 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,18 +17,16 @@ description:
properties:
compatible:
enum:
+ - qcom,sdm845-mdss
- qcom,mdss
reg:
- minItems: 2
+ minItems: 1
maxItems: 3
reg-names:
- minItems: 2
- items:
- - const: mdss_phys
- - const: vbif_phys
- - const: vbif_nrt_phys
+ minItems: 1
+ maxItems: 3
interrupts:
maxItems: 1
@@ -53,10 +51,10 @@ properties:
maxItems: 4
"#address-cells":
- const: 1
+ enum: [1, 2]
"#size-cells":
- const: 1
+ enum: [1, 2]
ranges:
true
@@ -65,29 +63,99 @@ properties:
items:
- description: MDSS_CORE reset
-oneOf:
- - properties:
- clocks:
- minItems: 3
- maxItems: 4
-
- clock-names:
- minItems: 3
- items:
- - const: iface
- - const: bus
- - const: vsync
- - const: core
- - properties:
- clocks:
- minItems: 1
- maxItems: 2
-
- clock-names:
- minItems: 1
- items:
- - const: iface
- - const: core
+ interconnects:
+ minItems: 2
+ items:
+ - description: MDP port 0
+ - description: MDP port 1
+ - description: Rotator
+
+ interconnect-names:
+ minItems: 2
+ items:
+ - const: mdp0-mem
+ - const: mdp1-mem
+ - const: rotator-mem
+
+ iommus:
+ items:
+ - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
+ - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,mdss
+ then:
+ properties:
+ reg-names:
+ minItems: 2
+ items:
+ - const: mdss_phys
+ - const: vbif_phys
+ - const: vbif_nrt_phys
+ oneOf:
+ - properties:
+ clocks:
+ minItems: 3
+ maxItems: 4
+
+ clock-names:
+ minItems: 3
+ items:
+ - const: iface
+ - const: bus
+ - const: vsync
+ - const: core
+ - properties:
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ items:
+ - const: iface
+ - const: core
+ else:
+ properties:
+ regs:
+ maxItems: 1
+
+ reg-names:
+ items:
+ - const: mdss
+
+ interconnects:
+ maxItems: 2
+
+ interconnect-names:
+ maxItems: 2
+
+ required:
+ - iommus
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sdm845-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: core
+
+ iommus:
+ minItems: 2
required:
- compatible
@@ -108,6 +176,9 @@ patternProperties:
type: object
# TODO: add reference once the mdp5 is converted
+ "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: dpu-sdm845.yaml
+
"^dsi@(0|[1-9a-f][0-9a-f]*)$":
$ref: dsi-controller-main.yaml#
@@ -158,4 +229,27 @@ examples:
ranges;
};
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+ display-subsystem@ae00000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "qcom,sdm845-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+ power-domains = <&dispcc MDSS_GDSC>;
+
+ clocks = <&gcc 19>,
+ <&dispcc 12>;
+ clock-names = "iface", "core";
+
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu 0x880 0x8>,
+ <&apps_smmu 0xc80 0x8>;
+ ranges;
+ };
...
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sdm845.yaml | 135 ++++-----------
.../devicetree/bindings/display/msm/mdss.yaml | 156 ++++++++++++++----
2 files changed, 160 insertions(+), 131 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 2bb8896beffc..2074e954372f 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -10,139 +10,74 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SDM845 target.
+ Device tree bindings for the DPU display controller for SDM845 target.
properties:
compatible:
items:
- - const: qcom,sdm845-mdss
+ - const: qcom,sdm845-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
+ - description: Display ahb clock
+ - description: Display axi clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
- const: iface
+ - const: bus
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
-
- ranges: true
-
- resets:
- items:
- - description: MDSS_CORE reset
+ power-domains:
+ maxItems: 1
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ operating-points-v2: true
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,sdm845-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display ahb clock
- - description: Display axi clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: iface
- - const: bus
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF2 (DSI2)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
+ - port@1
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index ba674a261b18..7d4ab3d71d2d 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,18 +17,16 @@ description:
properties:
compatible:
enum:
+ - qcom,sdm845-mdss
- qcom,mdss
reg:
- minItems: 2
+ minItems: 1
maxItems: 3
reg-names:
- minItems: 2
- items:
- - const: mdss_phys
- - const: vbif_phys
- - const: vbif_nrt_phys
+ minItems: 1
+ maxItems: 3
interrupts:
maxItems: 1
@@ -53,10 +51,10 @@ properties:
maxItems: 4
"#address-cells":
- const: 1
+ enum: [1, 2]
"#size-cells":
- const: 1
+ enum: [1, 2]
ranges:
true
@@ -65,29 +63,99 @@ properties:
items:
- description: MDSS_CORE reset
-oneOf:
- - properties:
- clocks:
- minItems: 3
- maxItems: 4
-
- clock-names:
- minItems: 3
- items:
- - const: iface
- - const: bus
- - const: vsync
- - const: core
- - properties:
- clocks:
- minItems: 1
- maxItems: 2
-
- clock-names:
- minItems: 1
- items:
- - const: iface
- - const: core
+ interconnects:
+ minItems: 2
+ items:
+ - description: MDP port 0
+ - description: MDP port 1
+ - description: Rotator
+
+ interconnect-names:
+ minItems: 2
+ items:
+ - const: mdp0-mem
+ - const: mdp1-mem
+ - const: rotator-mem
+
+ iommus:
+ items:
+ - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
+ - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,mdss
+ then:
+ properties:
+ reg-names:
+ minItems: 2
+ items:
+ - const: mdss_phys
+ - const: vbif_phys
+ - const: vbif_nrt_phys
+ oneOf:
+ - properties:
+ clocks:
+ minItems: 3
+ maxItems: 4
+
+ clock-names:
+ minItems: 3
+ items:
+ - const: iface
+ - const: bus
+ - const: vsync
+ - const: core
+ - properties:
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ items:
+ - const: iface
+ - const: core
+ else:
+ properties:
+ regs:
+ maxItems: 1
+
+ reg-names:
+ items:
+ - const: mdss
+
+ interconnects:
+ maxItems: 2
+
+ interconnect-names:
+ maxItems: 2
+
+ required:
+ - iommus
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sdm845-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: core
+
+ iommus:
+ minItems: 2
required:
- compatible
@@ -108,6 +176,9 @@ patternProperties:
type: object
# TODO: add reference once the mdp5 is converted
+ "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
+ $ref: dpu-sdm845.yaml
+
"^dsi@(0|[1-9a-f][0-9a-f]*)$":
$ref: dsi-controller-main.yaml#
@@ -158,4 +229,27 @@ examples:
ranges;
};
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+ display-subsystem@ae00000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "qcom,sdm845-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+ power-domains = <&dispcc MDSS_GDSC>;
+
+ clocks = <&gcc 19>,
+ <&dispcc 12>;
+ clock-names = "iface", "core";
+
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu 0x880 0x8>,
+ <&apps_smmu 0xc80 0x8>;
+ ranges;
+ };
...
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 05/11] dt-bindings: display/msm: move qcom,sdm845-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss " Dmitry Baryshkov
@ 2022-07-18 17:53 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:53 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: freedreno, Bjorn Andersson, devicetree, Stephen Boyd, Andy Gross,
Rob Clark, Rob Herring, Konrad Dybcio, Sean Paul,
Krzysztof Kozlowski, Abhinav Kumar, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel
On Sun, 10 Jul 2022 12:00:34 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sdm845.yaml | 135 ++++-----------
> .../devicetree/bindings/display/msm/mdss.yaml | 156 ++++++++++++++----
> 2 files changed, 160 insertions(+), 131 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss schema to mdss.yaml
@ 2022-07-18 17:53 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:53 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: devicetree, David Airlie, Sean Paul, Konrad Dybcio,
Abhinav Kumar, Rob Herring, Stephen Boyd, Andy Gross, dri-devel,
Krzysztof Kozlowski, linux-arm-msm, Bjorn Andersson, freedreno
On Sun, 10 Jul 2022 12:00:34 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sdm845-mdss from dpu-sdm845.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sdm845.yaml | 135 ++++-----------
> .../devicetree/bindings/display/msm/mdss.yaml | 156 ++++++++++++++----
> 2 files changed, 160 insertions(+), 131 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
2 files changed, 80 insertions(+), 114 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index d3c3e4b07897..9d4ec0b60c25 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -10,151 +10,78 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SC7180 target.
+ Device tree bindings for the DPU display controller for SC7180 target.
properties:
compatible:
items:
- - const: qcom,sc7180-mdss
+ - const: qcom,sc7180-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AHB clock from dispcc
+ - description: Display hf axi clock
+ - description: Display ahb clock
+ - description: Display rotator clock
+ - description: Display lut clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
+ - const: bus
- const: iface
- - const: ahb
+ - const: rot
+ - const: lut
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,sc7180-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display hf axi clock
- - description: Display ahb clock
- - description: Display rotator clock
- - description: Display lut clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: bus
- - const: iface
- - const: rot
- - const: lut
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF0 (DP)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@2:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF0 (DP)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 7d4ab3d71d2d..98f1f2501291 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,sc7180-mdss
- qcom,sdm845-mdss
- qcom,mdss
@@ -64,20 +65,21 @@ properties:
- description: MDSS_CORE reset
interconnects:
- minItems: 2
+ minItems: 1
items:
- description: MDP port 0
- description: MDP port 1
- description: Rotator
interconnect-names:
- minItems: 2
+ minItems: 1
items:
- const: mdp0-mem
- const: mdp1-mem
- const: rotator-mem
iommus:
+ minItems: 1
items:
- description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
@@ -129,9 +131,11 @@ allOf:
- const: mdss
interconnects:
+ minItems: 1
maxItems: 2
interconnect-names:
+ minItems: 1
maxItems: 2
required:
@@ -157,6 +161,29 @@ allOf:
iommus:
minItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7180-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display AHB clock from dispcc
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: ahb
+ - const: core
+
+ iommus:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -177,7 +204,19 @@ patternProperties:
# TODO: add reference once the mdp5 is converted
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
- $ref: dpu-sdm845.yaml
+ oneOf:
+ - $ref: dpu-sc7180.yaml
+ - $ref: dpu-sdm845.yaml
+
+ "^displayport-controller@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7180-dp
+ - qcom,sc7280-dp
+ - qcom,sc8180x-dp
+ - qcom,sm8350-dp
"^dsi@(0|[1-9a-f][0-9a-f]*)$":
$ref: dsi-controller-main.yaml#
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
2 files changed, 80 insertions(+), 114 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index d3c3e4b07897..9d4ec0b60c25 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -10,151 +10,78 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SC7180 target.
+ Device tree bindings for the DPU display controller for SC7180 target.
properties:
compatible:
items:
- - const: qcom,sc7180-mdss
+ - const: qcom,sc7180-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AHB clock from dispcc
+ - description: Display hf axi clock
+ - description: Display ahb clock
+ - description: Display rotator clock
+ - description: Display lut clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
+ - const: bus
- const: iface
- - const: ahb
+ - const: rot
+ - const: lut
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,sc7180-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display hf axi clock
- - description: Display ahb clock
- - description: Display rotator clock
- - description: Display lut clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: bus
- - const: iface
- - const: rot
- - const: lut
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF0 (DP)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@2:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF0 (DP)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 7d4ab3d71d2d..98f1f2501291 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,sc7180-mdss
- qcom,sdm845-mdss
- qcom,mdss
@@ -64,20 +65,21 @@ properties:
- description: MDSS_CORE reset
interconnects:
- minItems: 2
+ minItems: 1
items:
- description: MDP port 0
- description: MDP port 1
- description: Rotator
interconnect-names:
- minItems: 2
+ minItems: 1
items:
- const: mdp0-mem
- const: mdp1-mem
- const: rotator-mem
iommus:
+ minItems: 1
items:
- description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
@@ -129,9 +131,11 @@ allOf:
- const: mdss
interconnects:
+ minItems: 1
maxItems: 2
interconnect-names:
+ minItems: 1
maxItems: 2
required:
@@ -157,6 +161,29 @@ allOf:
iommus:
minItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7180-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display AHB clock from dispcc
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: ahb
+ - const: core
+
+ iommus:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -177,7 +204,19 @@ patternProperties:
# TODO: add reference once the mdp5 is converted
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
- $ref: dpu-sdm845.yaml
+ oneOf:
+ - $ref: dpu-sc7180.yaml
+ - $ref: dpu-sdm845.yaml
+
+ "^displayport-controller@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7180-dp
+ - qcom,sc7280-dp
+ - qcom,sc8180x-dp
+ - qcom,sm8350-dp
"^dsi@(0|[1-9a-f][0-9a-f]*)$":
$ref: dsi-controller-main.yaml#
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Dmitry Baryshkov
@ 2022-07-18 17:56 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Herring, Sean Paul, Konrad Dybcio, Stephen Boyd, devicetree,
Krzysztof Kozlowski, Andy Gross, Abhinav Kumar, Daniel Vetter,
dri-devel, linux-arm-msm, freedreno, David Airlie,
Bjorn Andersson, Rob Clark
On Sun, 10 Jul 2022 12:00:35 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
> 2 files changed, 80 insertions(+), 114 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml
@ 2022-07-18 17:56 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: devicetree, Abhinav Kumar, David Airlie, linux-arm-msm,
Konrad Dybcio, Andy Gross, dri-devel, Stephen Boyd, Rob Herring,
Bjorn Andersson, Krzysztof Kozlowski, freedreno, Sean Paul
On Sun, 10 Jul 2022 12:00:35 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
> 2 files changed, 80 insertions(+), 114 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Dmitry Baryshkov
@ 2022-08-11 8:25 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11 8:25 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 10/07/2022 12:00, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
> 2 files changed, 80 insertions(+), 114 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> index d3c3e4b07897..9d4ec0b60c25 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> @@ -10,151 +10,78 @@ maintainers:
> - Krishna Manikandan <quic_mkrishn@quicinc.com>
>
> description: |
> - Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
> - sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
> - bindings of MDSS and DPU are mentioned for SC7180 target.
> + Device tree bindings for the DPU display controller for SC7180 target.
>
> properties:
> compatible:
> items:
> - - const: qcom,sc7180-mdss
> + - const: qcom,sc7180-dpu
>
> reg:
> - maxItems: 1
> + items:
> + - description: Address offset and size for mdp register set
> + - description: Address offset and size for vbif register set
>
> reg-names:
> - const: mdss
> -
> - power-domains:
> - maxItems: 1
> + items:
> + - const: mdp
> + - const: vbif
>
> clocks:
> items:
> - - description: Display AHB clock from gcc
> - - description: Display AHB clock from dispcc
> + - description: Display hf axi clock
> + - description: Display ahb clock
> + - description: Display rotator clock
> + - description: Display lut clock
> - description: Display core clock
> + - description: Display vsync clock
>
> clock-names:
> items:
> + - const: bus
> - const: iface
> - - const: ahb
> + - const: rot
> + - const: lut
> - const: core
> + - const: vsync
>
> interrupts:
> maxItems: 1
>
> - interrupt-controller: true
> -
> - "#address-cells": true
> -
> - "#size-cells": true
> -
> - "#interrupt-cells":
> - const: 1
> -
> - iommus:
> - items:
> - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
> -
> - ranges: true
> -
> - interconnects:
> - items:
> - - description: Interconnect path specifying the port ids for data bus
> -
> - interconnect-names:
> - const: mdp0-mem
> + power-domains:
> + maxItems: 1
>
> - resets:
> - items:
> - - description: MDSS_CORE reset
> + operating-points-v2: true
>
> -patternProperties:
> - "^display-controller@[0-9a-f]+$":
> - type: object
> - description: Node containing the properties of DPU.
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + Contains the list of output ports from DPU device. These ports
> + connect to interfaces that are external to the DPU hardware,
> + such as DSI, DP etc. Each output port contains an endpoint that
> + describes how it is connected to an external interface.
>
> properties:
> - compatible:
> - items:
> - - const: qcom,sc7180-dpu
> -
> - reg:
> - items:
> - - description: Address offset and size for mdp register set
> - - description: Address offset and size for vbif register set
> -
> - reg-names:
> - items:
> - - const: mdp
> - - const: vbif
> -
> - clocks:
> - items:
> - - description: Display hf axi clock
> - - description: Display ahb clock
> - - description: Display rotator clock
> - - description: Display lut clock
> - - description: Display core clock
> - - description: Display vsync clock
> -
> - clock-names:
> - items:
> - - const: bus
> - - const: iface
> - - const: rot
> - - const: lut
> - - const: core
> - - const: vsync
> -
> - interrupts:
> - maxItems: 1
> -
> - power-domains:
> - maxItems: 1
> -
> - operating-points-v2: true
> -
> - ports:
> - $ref: /schemas/graph.yaml#/properties/ports
> - description: |
> - Contains the list of output ports from DPU device. These ports
> - connect to interfaces that are external to the DPU hardware,
> - such as DSI, DP etc. Each output port contains an endpoint that
> - describes how it is connected to an external interface.
> -
> - properties:
> - port@0:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: DPU_INTF1 (DSI1)
> -
> - port@2:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: DPU_INTF0 (DP)
> -
> - required:
> - - port@0
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: DPU_INTF1 (DSI1)
> +
> + port@2:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: DPU_INTF0 (DP)
>
> required:
> - - compatible
> - - reg
> - - reg-names
> - - clocks
> - - interrupts
> - - power-domains
> - - operating-points-v2
> - - ports
> + - port@0
>
> required:
> - compatible
> - reg
> - reg-names
> - - power-domains
> - clocks
> - interrupts
> - - interrupt-controller
> - - iommus
> - - ranges
> + - power-domains
> + - operating-points-v2
> + - ports
>
> additionalProperties: false
>
> diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
> index 7d4ab3d71d2d..98f1f2501291 100644
> --- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
> @@ -17,6 +17,7 @@ description:
> properties:
> compatible:
> enum:
> + - qcom,sc7180-mdss
> - qcom,sdm845-mdss
> - qcom,mdss
>
> @@ -64,20 +65,21 @@ properties:
> - description: MDSS_CORE reset
>
> interconnects:
> - minItems: 2
> + minItems: 1
> items:
> - description: MDP port 0
> - description: MDP port 1
> - description: Rotator
>
> interconnect-names:
> - minItems: 2
> + minItems: 1
> items:
> - const: mdp0-mem
> - const: mdp1-mem
> - const: rotator-mem
>
> iommus:
> + minItems: 1
> items:
> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
> @@ -129,9 +131,11 @@ allOf:
> - const: mdss
>
> interconnects:
> + minItems: 1
> maxItems: 2
>
> interconnect-names:
> + minItems: 1
> maxItems: 2
>
> required:
> @@ -157,6 +161,29 @@ allOf:
> iommus:
> minItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sc7180-mdss
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Display AHB clock from gcc
> + - description: Display AHB clock from dispcc
> + - description: Display core clock
> +
> + clock-names:
> + items:
> + - const: iface
> + - const: ahb
> + - const: core
> +
> + iommus:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -177,7 +204,19 @@ patternProperties:
> # TODO: add reference once the mdp5 is converted
>
> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
> - $ref: dpu-sdm845.yaml
> + oneOf:
> + - $ref: dpu-sc7180.yaml
> + - $ref: dpu-sdm845.yaml
I don't think this is good approach. These are strictly tied, so you
should have rather per SoC MDSS schema pulling in:
1. common MDSS
2. specific children schemas
This makes it quite obvious and specific. Your setup now allows putting
sc7180-dpu under sdm845-dpu.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml
@ 2022-08-11 8:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-11 8:25 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 10/07/2022 12:00, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
> 2 files changed, 80 insertions(+), 114 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> index d3c3e4b07897..9d4ec0b60c25 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> @@ -10,151 +10,78 @@ maintainers:
> - Krishna Manikandan <quic_mkrishn@quicinc.com>
>
> description: |
> - Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
> - sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
> - bindings of MDSS and DPU are mentioned for SC7180 target.
> + Device tree bindings for the DPU display controller for SC7180 target.
>
> properties:
> compatible:
> items:
> - - const: qcom,sc7180-mdss
> + - const: qcom,sc7180-dpu
>
> reg:
> - maxItems: 1
> + items:
> + - description: Address offset and size for mdp register set
> + - description: Address offset and size for vbif register set
>
> reg-names:
> - const: mdss
> -
> - power-domains:
> - maxItems: 1
> + items:
> + - const: mdp
> + - const: vbif
>
> clocks:
> items:
> - - description: Display AHB clock from gcc
> - - description: Display AHB clock from dispcc
> + - description: Display hf axi clock
> + - description: Display ahb clock
> + - description: Display rotator clock
> + - description: Display lut clock
> - description: Display core clock
> + - description: Display vsync clock
>
> clock-names:
> items:
> + - const: bus
> - const: iface
> - - const: ahb
> + - const: rot
> + - const: lut
> - const: core
> + - const: vsync
>
> interrupts:
> maxItems: 1
>
> - interrupt-controller: true
> -
> - "#address-cells": true
> -
> - "#size-cells": true
> -
> - "#interrupt-cells":
> - const: 1
> -
> - iommus:
> - items:
> - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
> -
> - ranges: true
> -
> - interconnects:
> - items:
> - - description: Interconnect path specifying the port ids for data bus
> -
> - interconnect-names:
> - const: mdp0-mem
> + power-domains:
> + maxItems: 1
>
> - resets:
> - items:
> - - description: MDSS_CORE reset
> + operating-points-v2: true
>
> -patternProperties:
> - "^display-controller@[0-9a-f]+$":
> - type: object
> - description: Node containing the properties of DPU.
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + Contains the list of output ports from DPU device. These ports
> + connect to interfaces that are external to the DPU hardware,
> + such as DSI, DP etc. Each output port contains an endpoint that
> + describes how it is connected to an external interface.
>
> properties:
> - compatible:
> - items:
> - - const: qcom,sc7180-dpu
> -
> - reg:
> - items:
> - - description: Address offset and size for mdp register set
> - - description: Address offset and size for vbif register set
> -
> - reg-names:
> - items:
> - - const: mdp
> - - const: vbif
> -
> - clocks:
> - items:
> - - description: Display hf axi clock
> - - description: Display ahb clock
> - - description: Display rotator clock
> - - description: Display lut clock
> - - description: Display core clock
> - - description: Display vsync clock
> -
> - clock-names:
> - items:
> - - const: bus
> - - const: iface
> - - const: rot
> - - const: lut
> - - const: core
> - - const: vsync
> -
> - interrupts:
> - maxItems: 1
> -
> - power-domains:
> - maxItems: 1
> -
> - operating-points-v2: true
> -
> - ports:
> - $ref: /schemas/graph.yaml#/properties/ports
> - description: |
> - Contains the list of output ports from DPU device. These ports
> - connect to interfaces that are external to the DPU hardware,
> - such as DSI, DP etc. Each output port contains an endpoint that
> - describes how it is connected to an external interface.
> -
> - properties:
> - port@0:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: DPU_INTF1 (DSI1)
> -
> - port@2:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: DPU_INTF0 (DP)
> -
> - required:
> - - port@0
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: DPU_INTF1 (DSI1)
> +
> + port@2:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: DPU_INTF0 (DP)
>
> required:
> - - compatible
> - - reg
> - - reg-names
> - - clocks
> - - interrupts
> - - power-domains
> - - operating-points-v2
> - - ports
> + - port@0
>
> required:
> - compatible
> - reg
> - reg-names
> - - power-domains
> - clocks
> - interrupts
> - - interrupt-controller
> - - iommus
> - - ranges
> + - power-domains
> + - operating-points-v2
> + - ports
>
> additionalProperties: false
>
> diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
> index 7d4ab3d71d2d..98f1f2501291 100644
> --- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
> @@ -17,6 +17,7 @@ description:
> properties:
> compatible:
> enum:
> + - qcom,sc7180-mdss
> - qcom,sdm845-mdss
> - qcom,mdss
>
> @@ -64,20 +65,21 @@ properties:
> - description: MDSS_CORE reset
>
> interconnects:
> - minItems: 2
> + minItems: 1
> items:
> - description: MDP port 0
> - description: MDP port 1
> - description: Rotator
>
> interconnect-names:
> - minItems: 2
> + minItems: 1
> items:
> - const: mdp0-mem
> - const: mdp1-mem
> - const: rotator-mem
>
> iommus:
> + minItems: 1
> items:
> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
> @@ -129,9 +131,11 @@ allOf:
> - const: mdss
>
> interconnects:
> + minItems: 1
> maxItems: 2
>
> interconnect-names:
> + minItems: 1
> maxItems: 2
>
> required:
> @@ -157,6 +161,29 @@ allOf:
> iommus:
> minItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sc7180-mdss
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Display AHB clock from gcc
> + - description: Display AHB clock from dispcc
> + - description: Display core clock
> +
> + clock-names:
> + items:
> + - const: iface
> + - const: ahb
> + - const: core
> +
> + iommus:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -177,7 +204,19 @@ patternProperties:
> # TODO: add reference once the mdp5 is converted
>
> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
> - $ref: dpu-sdm845.yaml
> + oneOf:
> + - $ref: dpu-sc7180.yaml
> + - $ref: dpu-sdm845.yaml
I don't think this is good approach. These are strictly tied, so you
should have rather per SoC MDSS schema pulling in:
1. common MDSS
2. specific children schemas
This makes it quite obvious and specific. Your setup now allows putting
sc7180-dpu under sdm845-dpu.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
2022-08-11 8:25 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Krzysztof Kozlowski
@ 2022-08-22 19:04 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 19:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 11/08/2022 11:25, Krzysztof Kozlowski wrote:
> On 10/07/2022 12:00, Dmitry Baryshkov wrote:
>> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
>> that the dpu file describes only the DPU schema.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
>> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
>> 2 files changed, 80 insertions(+), 114 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> index d3c3e4b07897..9d4ec0b60c25 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> @@ -10,151 +10,78 @@ maintainers:
>> - Krishna Manikandan <quic_mkrishn@quicinc.com>
>>
>> description: |
>> - Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
>> - sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
>> - bindings of MDSS and DPU are mentioned for SC7180 target.
>> + Device tree bindings for the DPU display controller for SC7180 target.
>>
>> properties:
>> compatible:
>> items:
>> - - const: qcom,sc7180-mdss
>> + - const: qcom,sc7180-dpu
>>
>> reg:
>> - maxItems: 1
>> + items:
>> + - description: Address offset and size for mdp register set
>> + - description: Address offset and size for vbif register set
>>
>> reg-names:
>> - const: mdss
>> -
>> - power-domains:
>> - maxItems: 1
>> + items:
>> + - const: mdp
>> + - const: vbif
>>
>> clocks:
>> items:
>> - - description: Display AHB clock from gcc
>> - - description: Display AHB clock from dispcc
>> + - description: Display hf axi clock
>> + - description: Display ahb clock
>> + - description: Display rotator clock
>> + - description: Display lut clock
>> - description: Display core clock
>> + - description: Display vsync clock
>>
>> clock-names:
>> items:
>> + - const: bus
>> - const: iface
>> - - const: ahb
>> + - const: rot
>> + - const: lut
>> - const: core
>> + - const: vsync
>>
>> interrupts:
>> maxItems: 1
>>
>> - interrupt-controller: true
>> -
>> - "#address-cells": true
>> -
>> - "#size-cells": true
>> -
>> - "#interrupt-cells":
>> - const: 1
>> -
>> - iommus:
>> - items:
>> - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
>> -
>> - ranges: true
>> -
>> - interconnects:
>> - items:
>> - - description: Interconnect path specifying the port ids for data bus
>> -
>> - interconnect-names:
>> - const: mdp0-mem
>> + power-domains:
>> + maxItems: 1
>>
>> - resets:
>> - items:
>> - - description: MDSS_CORE reset
>> + operating-points-v2: true
>>
>> -patternProperties:
>> - "^display-controller@[0-9a-f]+$":
>> - type: object
>> - description: Node containing the properties of DPU.
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> + description: |
>> + Contains the list of output ports from DPU device. These ports
>> + connect to interfaces that are external to the DPU hardware,
>> + such as DSI, DP etc. Each output port contains an endpoint that
>> + describes how it is connected to an external interface.
>>
>> properties:
>> - compatible:
>> - items:
>> - - const: qcom,sc7180-dpu
>> -
>> - reg:
>> - items:
>> - - description: Address offset and size for mdp register set
>> - - description: Address offset and size for vbif register set
>> -
>> - reg-names:
>> - items:
>> - - const: mdp
>> - - const: vbif
>> -
>> - clocks:
>> - items:
>> - - description: Display hf axi clock
>> - - description: Display ahb clock
>> - - description: Display rotator clock
>> - - description: Display lut clock
>> - - description: Display core clock
>> - - description: Display vsync clock
>> -
>> - clock-names:
>> - items:
>> - - const: bus
>> - - const: iface
>> - - const: rot
>> - - const: lut
>> - - const: core
>> - - const: vsync
>> -
>> - interrupts:
>> - maxItems: 1
>> -
>> - power-domains:
>> - maxItems: 1
>> -
>> - operating-points-v2: true
>> -
>> - ports:
>> - $ref: /schemas/graph.yaml#/properties/ports
>> - description: |
>> - Contains the list of output ports from DPU device. These ports
>> - connect to interfaces that are external to the DPU hardware,
>> - such as DSI, DP etc. Each output port contains an endpoint that
>> - describes how it is connected to an external interface.
>> -
>> - properties:
>> - port@0:
>> - $ref: /schemas/graph.yaml#/properties/port
>> - description: DPU_INTF1 (DSI1)
>> -
>> - port@2:
>> - $ref: /schemas/graph.yaml#/properties/port
>> - description: DPU_INTF0 (DP)
>> -
>> - required:
>> - - port@0
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: DPU_INTF1 (DSI1)
>> +
>> + port@2:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: DPU_INTF0 (DP)
>>
>> required:
>> - - compatible
>> - - reg
>> - - reg-names
>> - - clocks
>> - - interrupts
>> - - power-domains
>> - - operating-points-v2
>> - - ports
>> + - port@0
>>
>> required:
>> - compatible
>> - reg
>> - reg-names
>> - - power-domains
>> - clocks
>> - interrupts
>> - - interrupt-controller
>> - - iommus
>> - - ranges
>> + - power-domains
>> + - operating-points-v2
>> + - ports
>>
>> additionalProperties: false
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> index 7d4ab3d71d2d..98f1f2501291 100644
>> --- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> @@ -17,6 +17,7 @@ description:
>> properties:
>> compatible:
>> enum:
>> + - qcom,sc7180-mdss
>> - qcom,sdm845-mdss
>> - qcom,mdss
>>
>> @@ -64,20 +65,21 @@ properties:
>> - description: MDSS_CORE reset
>>
>> interconnects:
>> - minItems: 2
>> + minItems: 1
>> items:
>> - description: MDP port 0
>> - description: MDP port 1
>> - description: Rotator
>>
>> interconnect-names:
>> - minItems: 2
>> + minItems: 1
>> items:
>> - const: mdp0-mem
>> - const: mdp1-mem
>> - const: rotator-mem
>>
>> iommus:
>> + minItems: 1
>> items:
>> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
>> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
>> @@ -129,9 +131,11 @@ allOf:
>> - const: mdss
>>
>> interconnects:
>> + minItems: 1
>> maxItems: 2
>>
>> interconnect-names:
>> + minItems: 1
>> maxItems: 2
>>
>> required:
>> @@ -157,6 +161,29 @@ allOf:
>> iommus:
>> minItems: 2
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7180-mdss
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: Display AHB clock from gcc
>> + - description: Display AHB clock from dispcc
>> + - description: Display core clock
>> +
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: ahb
>> + - const: core
>> +
>> + iommus:
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -177,7 +204,19 @@ patternProperties:
>> # TODO: add reference once the mdp5 is converted
>>
>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
>> - $ref: dpu-sdm845.yaml
>> + oneOf:
>> + - $ref: dpu-sc7180.yaml
>> + - $ref: dpu-sdm845.yaml
>
> I don't think this is good approach. These are strictly tied, so you
> should have rather per SoC MDSS schema pulling in:
> 1. common MDSS
> 2. specific children schemas
>
> This makes it quite obvious and specific. Your setup now allows putting
> sc7180-dpu under sdm845-dpu.
Then we should probably also use very specific $ref and compat check for
all other entries in this file too. I understand your concern, however
I'd prefer to have the working schema which is not tight enough compared
to set of schema files that completely do not work. And current
dpu-*yaml do not work as they allow just the display-controller beneath
the mdss node.
If you absolutely insist on me making the binding tight enough, I'll
rework the bindings to clearly specify which SoC has which nodes.
>
> Best regards,
> Krzysztof
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml
@ 2022-08-22 19:04 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 19:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 11/08/2022 11:25, Krzysztof Kozlowski wrote:
> On 10/07/2022 12:00, Dmitry Baryshkov wrote:
>> Move schema for qcom,sc7180-mdss from dpu-sc7180.yaml to mdss.yaml so
>> that the dpu file describes only the DPU schema.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../bindings/display/msm/dpu-sc7180.yaml | 149 +++++-------------
>> .../devicetree/bindings/display/msm/mdss.yaml | 45 +++++-
>> 2 files changed, 80 insertions(+), 114 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> index d3c3e4b07897..9d4ec0b60c25 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> @@ -10,151 +10,78 @@ maintainers:
>> - Krishna Manikandan <quic_mkrishn@quicinc.com>
>>
>> description: |
>> - Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
>> - sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
>> - bindings of MDSS and DPU are mentioned for SC7180 target.
>> + Device tree bindings for the DPU display controller for SC7180 target.
>>
>> properties:
>> compatible:
>> items:
>> - - const: qcom,sc7180-mdss
>> + - const: qcom,sc7180-dpu
>>
>> reg:
>> - maxItems: 1
>> + items:
>> + - description: Address offset and size for mdp register set
>> + - description: Address offset and size for vbif register set
>>
>> reg-names:
>> - const: mdss
>> -
>> - power-domains:
>> - maxItems: 1
>> + items:
>> + - const: mdp
>> + - const: vbif
>>
>> clocks:
>> items:
>> - - description: Display AHB clock from gcc
>> - - description: Display AHB clock from dispcc
>> + - description: Display hf axi clock
>> + - description: Display ahb clock
>> + - description: Display rotator clock
>> + - description: Display lut clock
>> - description: Display core clock
>> + - description: Display vsync clock
>>
>> clock-names:
>> items:
>> + - const: bus
>> - const: iface
>> - - const: ahb
>> + - const: rot
>> + - const: lut
>> - const: core
>> + - const: vsync
>>
>> interrupts:
>> maxItems: 1
>>
>> - interrupt-controller: true
>> -
>> - "#address-cells": true
>> -
>> - "#size-cells": true
>> -
>> - "#interrupt-cells":
>> - const: 1
>> -
>> - iommus:
>> - items:
>> - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
>> -
>> - ranges: true
>> -
>> - interconnects:
>> - items:
>> - - description: Interconnect path specifying the port ids for data bus
>> -
>> - interconnect-names:
>> - const: mdp0-mem
>> + power-domains:
>> + maxItems: 1
>>
>> - resets:
>> - items:
>> - - description: MDSS_CORE reset
>> + operating-points-v2: true
>>
>> -patternProperties:
>> - "^display-controller@[0-9a-f]+$":
>> - type: object
>> - description: Node containing the properties of DPU.
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> + description: |
>> + Contains the list of output ports from DPU device. These ports
>> + connect to interfaces that are external to the DPU hardware,
>> + such as DSI, DP etc. Each output port contains an endpoint that
>> + describes how it is connected to an external interface.
>>
>> properties:
>> - compatible:
>> - items:
>> - - const: qcom,sc7180-dpu
>> -
>> - reg:
>> - items:
>> - - description: Address offset and size for mdp register set
>> - - description: Address offset and size for vbif register set
>> -
>> - reg-names:
>> - items:
>> - - const: mdp
>> - - const: vbif
>> -
>> - clocks:
>> - items:
>> - - description: Display hf axi clock
>> - - description: Display ahb clock
>> - - description: Display rotator clock
>> - - description: Display lut clock
>> - - description: Display core clock
>> - - description: Display vsync clock
>> -
>> - clock-names:
>> - items:
>> - - const: bus
>> - - const: iface
>> - - const: rot
>> - - const: lut
>> - - const: core
>> - - const: vsync
>> -
>> - interrupts:
>> - maxItems: 1
>> -
>> - power-domains:
>> - maxItems: 1
>> -
>> - operating-points-v2: true
>> -
>> - ports:
>> - $ref: /schemas/graph.yaml#/properties/ports
>> - description: |
>> - Contains the list of output ports from DPU device. These ports
>> - connect to interfaces that are external to the DPU hardware,
>> - such as DSI, DP etc. Each output port contains an endpoint that
>> - describes how it is connected to an external interface.
>> -
>> - properties:
>> - port@0:
>> - $ref: /schemas/graph.yaml#/properties/port
>> - description: DPU_INTF1 (DSI1)
>> -
>> - port@2:
>> - $ref: /schemas/graph.yaml#/properties/port
>> - description: DPU_INTF0 (DP)
>> -
>> - required:
>> - - port@0
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: DPU_INTF1 (DSI1)
>> +
>> + port@2:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: DPU_INTF0 (DP)
>>
>> required:
>> - - compatible
>> - - reg
>> - - reg-names
>> - - clocks
>> - - interrupts
>> - - power-domains
>> - - operating-points-v2
>> - - ports
>> + - port@0
>>
>> required:
>> - compatible
>> - reg
>> - reg-names
>> - - power-domains
>> - clocks
>> - interrupts
>> - - interrupt-controller
>> - - iommus
>> - - ranges
>> + - power-domains
>> + - operating-points-v2
>> + - ports
>>
>> additionalProperties: false
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> index 7d4ab3d71d2d..98f1f2501291 100644
>> --- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
>> @@ -17,6 +17,7 @@ description:
>> properties:
>> compatible:
>> enum:
>> + - qcom,sc7180-mdss
>> - qcom,sdm845-mdss
>> - qcom,mdss
>>
>> @@ -64,20 +65,21 @@ properties:
>> - description: MDSS_CORE reset
>>
>> interconnects:
>> - minItems: 2
>> + minItems: 1
>> items:
>> - description: MDP port 0
>> - description: MDP port 1
>> - description: Rotator
>>
>> interconnect-names:
>> - minItems: 2
>> + minItems: 1
>> items:
>> - const: mdp0-mem
>> - const: mdp1-mem
>> - const: rotator-mem
>>
>> iommus:
>> + minItems: 1
>> items:
>> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
>> - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
>> @@ -129,9 +131,11 @@ allOf:
>> - const: mdss
>>
>> interconnects:
>> + minItems: 1
>> maxItems: 2
>>
>> interconnect-names:
>> + minItems: 1
>> maxItems: 2
>>
>> required:
>> @@ -157,6 +161,29 @@ allOf:
>> iommus:
>> minItems: 2
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7180-mdss
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: Display AHB clock from gcc
>> + - description: Display AHB clock from dispcc
>> + - description: Display core clock
>> +
>> + clock-names:
>> + items:
>> + - const: iface
>> + - const: ahb
>> + - const: core
>> +
>> + iommus:
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -177,7 +204,19 @@ patternProperties:
>> # TODO: add reference once the mdp5 is converted
>>
>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
>> - $ref: dpu-sdm845.yaml
>> + oneOf:
>> + - $ref: dpu-sc7180.yaml
>> + - $ref: dpu-sdm845.yaml
>
> I don't think this is good approach. These are strictly tied, so you
> should have rather per SoC MDSS schema pulling in:
> 1. common MDSS
> 2. specific children schemas
>
> This makes it quite obvious and specific. Your setup now allows putting
> sc7180-dpu under sdm845-dpu.
Then we should probably also use very specific $ref and compat check for
all other entries in this file too. I understand your concern, however
I'd prefer to have the working schema which is not tight enough compared
to set of schema files that completely do not work. And current
dpu-*yaml do not work as they allow just the display-controller beneath
the mdss node.
If you absolutely insist on me making the binding tight enough, I'll
rework the bindings to clearly specify which SoC has which nodes.
>
> Best regards,
> Krzysztof
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml
2022-08-22 19:04 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Dmitry Baryshkov
@ 2022-08-23 11:00 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-23 11:00 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On 22/08/2022 22:04, Dmitry Baryshkov wrote:
>>> required:
>>> - compatible
>>> - reg
>>> @@ -177,7 +204,19 @@ patternProperties:
>>> # TODO: add reference once the mdp5 is converted
>>>
>>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
>>> - $ref: dpu-sdm845.yaml
>>> + oneOf:
>>> + - $ref: dpu-sc7180.yaml
>>> + - $ref: dpu-sdm845.yaml
>>
>> I don't think this is good approach. These are strictly tied, so you
>> should have rather per SoC MDSS schema pulling in:
>> 1. common MDSS
>> 2. specific children schemas
>>
>> This makes it quite obvious and specific. Your setup now allows putting
>> sc7180-dpu under sdm845-dpu.
>
> Then we should probably also use very specific $ref and compat check for
> all other entries in this file too. I understand your concern, however
> I'd prefer to have the working schema which is not tight enough compared
> to set of schema files that completely do not work.
Why they cannot be tight and working?
> And current
> dpu-*yaml do not work as they allow just the display-controller beneath
> the mdss node.
Sure, this can be fixed but not really in a relaxing way.
>
> If you absolutely insist on me making the binding tight enough, I'll
> rework the bindings to clearly specify which SoC has which nodes.
I do not see the drawbacks of specific/tight approach, so yes, please
make it tight.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss schema to mdss.yaml
@ 2022-08-23 11:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 62+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-23 11:00 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
On 22/08/2022 22:04, Dmitry Baryshkov wrote:
>>> required:
>>> - compatible
>>> - reg
>>> @@ -177,7 +204,19 @@ patternProperties:
>>> # TODO: add reference once the mdp5 is converted
>>>
>>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$":
>>> - $ref: dpu-sdm845.yaml
>>> + oneOf:
>>> + - $ref: dpu-sc7180.yaml
>>> + - $ref: dpu-sdm845.yaml
>>
>> I don't think this is good approach. These are strictly tied, so you
>> should have rather per SoC MDSS schema pulling in:
>> 1. common MDSS
>> 2. specific children schemas
>>
>> This makes it quite obvious and specific. Your setup now allows putting
>> sc7180-dpu under sdm845-dpu.
>
> Then we should probably also use very specific $ref and compat check for
> all other entries in this file too. I understand your concern, however
> I'd prefer to have the working schema which is not tight enough compared
> to set of schema files that completely do not work.
Why they cannot be tight and working?
> And current
> dpu-*yaml do not work as they allow just the display-controller beneath
> the mdss node.
Sure, this can be fixed but not really in a relaxing way.
>
> If you absolutely insist on me making the binding tight enough, I'll
> rework the bindings to clearly specify which SoC has which nodes.
I do not see the drawbacks of specific/tight approach, so yes, please
make it tight.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 07/11] dt-bindings: display/msm: move qcom,sc7280-mdss schema to mdss.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sc7280.yaml | 148 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 19 +++
2 files changed, 57 insertions(+), 110 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index f427eec3d3a4..349a454099ad 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -10,149 +10,77 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem (MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SC7280.
+ Device tree bindings for the DPU display controller for SC7280 target.
properties:
compatible:
- const: qcom,sc7280-mdss
+ const: qcom,sc7280-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AHB clock from dispcc
+ - description: Display hf axi clock
+ - description: Display sf axi clock
+ - description: Display ahb clock
+ - description: Display lut clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
+ - const: bus
+ - const: nrt_bus
- const: iface
- - const: ahb
+ - const: lut
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- const: qcom,sc7280-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display hf axi clock
- - description: Display sf axi clock
- - description: Display ahb clock
- - description: Display lut clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: bus
- - const: nrt_bus
- - const: iface
- - const: lut
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF5 (EDP)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF5 (EDP)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 98f1f2501291..b1c7193417be 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
enum:
- qcom,sc7180-mdss
+ - qcom,sc7280-mdss
- qcom,sdm845-mdss
- qcom,mdss
@@ -167,6 +168,7 @@ allOf:
contains:
enum:
- qcom,sc7180-mdss
+ - qcom,sc7280-mdss
then:
properties:
clocks:
@@ -206,6 +208,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
- $ref: dpu-sc7180.yaml
+ - $ref: dpu-sc7280.yaml
- $ref: dpu-sdm845.yaml
"^displayport-controller@(0|[1-9a-f][0-9a-f]*)$":
@@ -229,6 +232,14 @@ patternProperties:
- $ref: dsi-phy-10nm.yaml#
- $ref: dsi-phy-7nm.yaml#
+ "^edp@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-edp
+ - qcom,sc8180x-edp
+
"^hdmi-phy@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
- $ref: /schemas/phy/qcom,hdmi-phy-qmp.yaml#
@@ -237,6 +248,14 @@ patternProperties:
"^hdmi-tx@(0|[1-9a-f][0-9a-f]*)$":
$ref: hdmi.yaml#
+ "^phy@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-dsi-phy-7nm
+ - qcom,sc7280-edp-phy
+
additionalProperties: false
examples:
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss schema to mdss.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-sc7280.yaml | 148 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 19 +++
2 files changed, 57 insertions(+), 110 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index f427eec3d3a4..349a454099ad 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -10,149 +10,77 @@ maintainers:
- Krishna Manikandan <quic_mkrishn@quicinc.com>
description: |
- Device tree bindings for MSM Mobile Display Subsystem (MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for SC7280.
+ Device tree bindings for the DPU display controller for SC7280 target.
properties:
compatible:
- const: qcom,sc7280-mdss
+ const: qcom,sc7280-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AHB clock from dispcc
+ - description: Display hf axi clock
+ - description: Display sf axi clock
+ - description: Display ahb clock
+ - description: Display lut clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
+ - const: bus
+ - const: nrt_bus
- const: iface
- - const: ahb
+ - const: lut
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- const: qcom,sc7280-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display hf axi clock
- - description: Display sf axi clock
- - description: Display ahb clock
- - description: Display lut clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: bus
- - const: nrt_bus
- - const: iface
- - const: lut
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF5 (EDP)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF5 (EDP)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 98f1f2501291..b1c7193417be 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
enum:
- qcom,sc7180-mdss
+ - qcom,sc7280-mdss
- qcom,sdm845-mdss
- qcom,mdss
@@ -167,6 +168,7 @@ allOf:
contains:
enum:
- qcom,sc7180-mdss
+ - qcom,sc7280-mdss
then:
properties:
clocks:
@@ -206,6 +208,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
- $ref: dpu-sc7180.yaml
+ - $ref: dpu-sc7280.yaml
- $ref: dpu-sdm845.yaml
"^displayport-controller@(0|[1-9a-f][0-9a-f]*)$":
@@ -229,6 +232,14 @@ patternProperties:
- $ref: dsi-phy-10nm.yaml#
- $ref: dsi-phy-7nm.yaml#
+ "^edp@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-edp
+ - qcom,sc8180x-edp
+
"^hdmi-phy@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
- $ref: /schemas/phy/qcom,hdmi-phy-qmp.yaml#
@@ -237,6 +248,14 @@ patternProperties:
"^hdmi-tx@(0|[1-9a-f][0-9a-f]*)$":
$ref: hdmi.yaml#
+ "^phy@(0|[1-9a-f][0-9a-f]*)$":
+ type: object
+ properties:
+ compatible:
+ enum:
+ - qcom,sc7280-dsi-phy-7nm
+ - qcom,sc7280-edp-phy
+
additionalProperties: false
examples:
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 07/11] dt-bindings: display/msm: move qcom,sc7280-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss " Dmitry Baryshkov
@ 2022-07-18 17:56 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: dri-devel, Sean Paul, Daniel Vetter, devicetree, David Airlie,
Konrad Dybcio, Abhinav Kumar, Andy Gross, linux-arm-msm,
Rob Herring, freedreno, Rob Clark, Stephen Boyd, Bjorn Andersson,
Krzysztof Kozlowski
On Sun, 10 Jul 2022 12:00:36 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7280.yaml | 148 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 19 +++
> 2 files changed, 57 insertions(+), 110 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss schema to mdss.yaml
@ 2022-07-18 17:56 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:56 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: devicetree, Krzysztof Kozlowski, David Airlie, linux-arm-msm,
Konrad Dybcio, Abhinav Kumar, dri-devel, Stephen Boyd,
Rob Herring, Andy Gross, Bjorn Andersson, freedreno, Sean Paul
On Sun, 10 Jul 2022 12:00:36 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,sc7280-mdss from dpu-sc7280.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-sc7280.yaml | 148 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 19 +++
> 2 files changed, 57 insertions(+), 110 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 08/11] dt-bindings: display/msm: move qcom,qcm2290-mdss schema to mdss.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-qcm2290.yaml | 140 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 24 +++
2 files changed, 57 insertions(+), 107 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 734d14de966d..8027319b1aad 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -10,146 +10,72 @@ maintainers:
- Loic Poulain <loic.poulain@linaro.org>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller and DSI. Device tree bindings of MDSS
- and DPU are mentioned for QCM2290 target.
+ Device tree bindings for the DPU display controller for QCM2290 target.
properties:
compatible:
items:
- - const: qcom,qcm2290-mdss
+ - const: qcom,qcm2290-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AXI clock
- - description: Display core clock
+ - description: Display AXI clock from gcc
+ - description: Display AHB clock from dispcc
+ - description: Display core clock from dispcc
+ - description: Display lut clock from dispcc
+ - description: Display vsync clock from dispcc
clock-names:
items:
- - const: iface
- const: bus
+ - const: iface
- const: core
+ - const: lut
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,qcm2290-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display AXI clock from gcc
- - description: Display AHB clock from dispcc
- - description: Display core clock from dispcc
- - description: Display lut clock from dispcc
- - description: Display vsync clock from dispcc
-
- clock-names:
- items:
- - const: bus
- - const: iface
- - const: core
- - const: lut
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index b1c7193417be..7359b233f3eb 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,qcm2290-mdss
- qcom,sc7180-mdss
- qcom,sc7280-mdss
- qcom,sdm845-mdss
@@ -142,6 +143,28 @@ allOf:
required:
- iommus
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcm2290-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display AXI clock
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: bus
+ - const: core
+
+ iommus:
+ minItems: 2
+
- if:
properties:
compatible:
@@ -207,6 +230,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
+ - $ref: dpu-qcm2290.yaml
- $ref: dpu-sc7180.yaml
- $ref: dpu-sc7280.yaml
- $ref: dpu-sdm845.yaml
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 08/11] dt-bindings: display/msm: move qcom, qcm2290-mdss schema to mdss.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-qcm2290.yaml | 140 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 24 +++
2 files changed, 57 insertions(+), 107 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 734d14de966d..8027319b1aad 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -10,146 +10,72 @@ maintainers:
- Loic Poulain <loic.poulain@linaro.org>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller and DSI. Device tree bindings of MDSS
- and DPU are mentioned for QCM2290 target.
+ Device tree bindings for the DPU display controller for QCM2290 target.
properties:
compatible:
items:
- - const: qcom,qcm2290-mdss
+ - const: qcom,qcm2290-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: vbif
clocks:
items:
- - description: Display AHB clock from gcc
- - description: Display AXI clock
- - description: Display core clock
+ - description: Display AXI clock from gcc
+ - description: Display AHB clock from dispcc
+ - description: Display core clock from dispcc
+ - description: Display lut clock from dispcc
+ - description: Display vsync clock from dispcc
clock-names:
items:
- - const: iface
- const: bus
+ - const: iface
- const: core
+ - const: lut
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1
-
- ranges: true
-
- interconnects:
- items:
- - description: Interconnect path specifying the port ids for data bus
-
- interconnect-names:
- const: mdp0-mem
+ power-domains:
+ maxItems: 1
- resets:
- items:
- - description: MDSS_CORE reset
+ operating-points-v2: true
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,qcm2290-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: vbif
-
- clocks:
- items:
- - description: Display AXI clock from gcc
- - description: Display AHB clock from dispcc
- - description: Display core clock from dispcc
- - description: Display lut clock from dispcc
- - description: Display vsync clock from dispcc
-
- clock-names:
- items:
- - const: bus
- - const: iface
- - const: core
- - const: lut
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- required:
- - port@0
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index b1c7193417be..7359b233f3eb 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,qcm2290-mdss
- qcom,sc7180-mdss
- qcom,sc7280-mdss
- qcom,sdm845-mdss
@@ -142,6 +143,28 @@ allOf:
required:
- iommus
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcm2290-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock from gcc
+ - description: Display AXI clock
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: bus
+ - const: core
+
+ iommus:
+ minItems: 2
+
- if:
properties:
compatible:
@@ -207,6 +230,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
+ - $ref: dpu-qcm2290.yaml
- $ref: dpu-sc7180.yaml
- $ref: dpu-sc7280.yaml
- $ref: dpu-sdm845.yaml
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 08/11] dt-bindings: display/msm: move qcom,qcm2290-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 08/11] dt-bindings: display/msm: move qcom, qcm2290-mdss " Dmitry Baryshkov
@ 2022-07-18 17:57 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:57 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: linux-arm-msm, Konrad Dybcio, dri-devel, devicetree, Andy Gross,
freedreno, Rob Herring, Daniel Vetter, Abhinav Kumar, Sean Paul,
Bjorn Andersson, Krzysztof Kozlowski, David Airlie, Rob Clark,
Stephen Boyd
On Sun, 10 Jul 2022 12:00:37 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-qcm2290.yaml | 140 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 24 +++
> 2 files changed, 57 insertions(+), 107 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 08/11] dt-bindings: display/msm: move qcom,qcm2290-mdss schema to mdss.yaml
@ 2022-07-18 17:57 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:57 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Sean Paul, devicetree, Krzysztof Kozlowski, David Airlie,
linux-arm-msm, Konrad Dybcio, Abhinav Kumar, dri-devel,
Bjorn Andersson, Rob Herring, Andy Gross, Stephen Boyd,
freedreno
On Sun, 10 Jul 2022 12:00:37 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,qcm2290-mdss from dpu-qcm2290.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-qcm2290.yaml | 140 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 24 +++
> 2 files changed, 57 insertions(+), 107 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 09/11] dt-bindings: display/msm: move qcom,msm8998-mdss schema to mdss.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-msm8998.yaml | 142 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 24 +++
2 files changed, 64 insertions(+), 102 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 2df64afb76e6..5caf46a1dd88 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -10,142 +10,80 @@ maintainers:
- AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for MSM8998 target.
+ Device tree bindings for the DPU display controller for MSM8998 target.
properties:
compatible:
items:
- - const: qcom,msm8998-mdss
+ - const: qcom,msm8998-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for regdma register set
+ - description: Address offset and size for vbif register set
+ - description: Address offset and size for non-realtime vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: regdma
+ - const: vbif
+ - const: vbif_nrt
clocks:
items:
- - description: Display AHB clock
- - description: Display AXI clock
+ - description: Display ahb clock
+ - description: Display axi clock
+ - description: Display mem-noc clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
- const: iface
- const: bus
+ - const: mnoc
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
+ power-domains:
+ maxItems: 1
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ operating-points-v2: true
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,msm8998-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for regdma register set
- - description: Address offset and size for vbif register set
- - description: Address offset and size for non-realtime vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: regdma
- - const: vbif
- - const: vbif_nrt
-
- clocks:
- items:
- - description: Display ahb clock
- - description: Display axi clock
- - description: Display mem-noc clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: iface
- - const: bus
- - const: mnoc
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF2 (DSI2)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
+ - port@1
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 7359b233f3eb..87c7f9d8f49c 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,msm8998-mdss
- qcom,qcm2290-mdss
- qcom,sc7180-mdss
- qcom,sc7280-mdss
@@ -143,6 +144,28 @@ allOf:
required:
- iommus
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,msm8998-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock
+ - description: Display AXI clock
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: bus
+ - const: core
+
+ iommus:
+ maxItems: 1
+
- if:
properties:
compatible:
@@ -230,6 +253,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
+ - $ref: dpu-msm8998.yaml
- $ref: dpu-qcm2290.yaml
- $ref: dpu-sc7180.yaml
- $ref: dpu-sc7280.yaml
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 09/11] dt-bindings: display/msm: move qcom, msm8998-mdss schema to mdss.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so
that the dpu file describes only the DPU schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-msm8998.yaml | 142 +++++-------------
.../devicetree/bindings/display/msm/mdss.yaml | 24 +++
2 files changed, 64 insertions(+), 102 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 2df64afb76e6..5caf46a1dd88 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -10,142 +10,80 @@ maintainers:
- AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
description: |
- Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
- sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
- bindings of MDSS and DPU are mentioned for MSM8998 target.
+ Device tree bindings for the DPU display controller for MSM8998 target.
properties:
compatible:
items:
- - const: qcom,msm8998-mdss
+ - const: qcom,msm8998-dpu
reg:
- maxItems: 1
+ items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for regdma register set
+ - description: Address offset and size for vbif register set
+ - description: Address offset and size for non-realtime vbif register set
reg-names:
- const: mdss
-
- power-domains:
- maxItems: 1
+ items:
+ - const: mdp
+ - const: regdma
+ - const: vbif
+ - const: vbif_nrt
clocks:
items:
- - description: Display AHB clock
- - description: Display AXI clock
+ - description: Display ahb clock
+ - description: Display axi clock
+ - description: Display mem-noc clock
- description: Display core clock
+ - description: Display vsync clock
clock-names:
items:
- const: iface
- const: bus
+ - const: mnoc
- const: core
+ - const: vsync
interrupts:
maxItems: 1
- interrupt-controller: true
-
- "#address-cells": true
-
- "#size-cells": true
-
- "#interrupt-cells":
- const: 1
-
- iommus:
- items:
- - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
-
- ranges: true
+ power-domains:
+ maxItems: 1
-patternProperties:
- "^display-controller@[0-9a-f]+$":
- type: object
- description: Node containing the properties of DPU.
+ operating-points-v2: true
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc. Each output port contains an endpoint that
+ describes how it is connected to an external interface.
properties:
- compatible:
- items:
- - const: qcom,msm8998-dpu
-
- reg:
- items:
- - description: Address offset and size for mdp register set
- - description: Address offset and size for regdma register set
- - description: Address offset and size for vbif register set
- - description: Address offset and size for non-realtime vbif register set
-
- reg-names:
- items:
- - const: mdp
- - const: regdma
- - const: vbif
- - const: vbif_nrt
-
- clocks:
- items:
- - description: Display ahb clock
- - description: Display axi clock
- - description: Display mem-noc clock
- - description: Display core clock
- - description: Display vsync clock
-
- clock-names:
- items:
- - const: iface
- - const: bus
- - const: mnoc
- - const: core
- - const: vsync
-
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF1 (DSI1)
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: DPU_INTF2 (DSI2)
required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
+ - port@0
+ - port@1
required:
- compatible
- reg
- reg-names
- - power-domains
- clocks
- interrupts
- - interrupt-controller
- - iommus
- - ranges
+ - power-domains
+ - operating-points-v2
+ - ports
additionalProperties: false
diff --git a/Documentation/devicetree/bindings/display/msm/mdss.yaml b/Documentation/devicetree/bindings/display/msm/mdss.yaml
index 7359b233f3eb..87c7f9d8f49c 100644
--- a/Documentation/devicetree/bindings/display/msm/mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/mdss.yaml
@@ -17,6 +17,7 @@ description:
properties:
compatible:
enum:
+ - qcom,msm8998-mdss
- qcom,qcm2290-mdss
- qcom,sc7180-mdss
- qcom,sc7280-mdss
@@ -143,6 +144,28 @@ allOf:
required:
- iommus
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,msm8998-mdss
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Display AHB clock
+ - description: Display AXI clock
+ - description: Display core clock
+
+ clock-names:
+ items:
+ - const: iface
+ - const: bus
+ - const: core
+
+ iommus:
+ maxItems: 1
+
- if:
properties:
compatible:
@@ -230,6 +253,7 @@ patternProperties:
"^display-controller@(0|[1-9a-f][0-9a-f]*)$":
oneOf:
+ - $ref: dpu-msm8998.yaml
- $ref: dpu-qcm2290.yaml
- $ref: dpu-sc7180.yaml
- $ref: dpu-sc7280.yaml
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 09/11] dt-bindings: display/msm: move qcom,msm8998-mdss schema to mdss.yaml
2022-07-10 9:00 ` [PATCH v2 09/11] dt-bindings: display/msm: move qcom, msm8998-mdss " Dmitry Baryshkov
@ 2022-07-18 17:58 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:58 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, dri-devel, Krzysztof Kozlowski, linux-arm-msm,
Daniel Vetter, Sean Paul, Abhinav Kumar, David Airlie, freedreno,
Rob Herring, Stephen Boyd, devicetree, Konrad Dybcio,
Bjorn Andersson, Andy Gross
On Sun, 10 Jul 2022 12:00:38 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-msm8998.yaml | 142 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 24 +++
> 2 files changed, 64 insertions(+), 102 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 09/11] dt-bindings: display/msm: move qcom,msm8998-mdss schema to mdss.yaml
@ 2022-07-18 17:58 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:58 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: freedreno, Krzysztof Kozlowski, devicetree, David Airlie,
linux-arm-msm, Konrad Dybcio, Abhinav Kumar, dri-devel,
Stephen Boyd, Rob Herring, Andy Gross, Bjorn Andersson,
Sean Paul
On Sun, 10 Jul 2022 12:00:38 +0300, Dmitry Baryshkov wrote:
> Move schema for qcom,msm8998-mdss from dpu-msm8998.yaml to mdss.yaml so
> that the dpu file describes only the DPU schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-msm8998.yaml | 142 +++++-------------
> .../devicetree/bindings/display/msm/mdss.yaml | 24 +++
> 2 files changed, 64 insertions(+), 102 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Add gcc-bus clock required for the SDM845 DPU device tree node. This
change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845:
move bus clock to mdp node for sdm845 target"), but was not reflected in
the schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../devicetree/bindings/display/msm/dpu-sdm845.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 2074e954372f..42ff85e80f45 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -29,6 +29,7 @@ properties:
clocks:
items:
+ - description: Display GCC bus clock
- description: Display ahb clock
- description: Display axi clock
- description: Display core clock
@@ -36,6 +37,7 @@ properties:
clock-names:
items:
+ - const: gcc-bus
- const: iface
- const: bus
- const: core
@@ -114,11 +116,12 @@ examples:
<0x0aeb0000 0x2008>;
reg-names = "mdp", "vbif";
- clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ clocks = <&gcc GCC_DISP_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
<&dispcc DISP_CC_MDSS_AXI_CLK>,
<&dispcc DISP_CC_MDSS_MDP_CLK>,
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
- clock-names = "iface", "bus", "core", "vsync";
+ clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
interrupt-parent = <&mdss>;
interrupts = <0>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Add gcc-bus clock required for the SDM845 DPU device tree node. This
change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845:
move bus clock to mdp node for sdm845 target"), but was not reflected in
the schema.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../devicetree/bindings/display/msm/dpu-sdm845.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 2074e954372f..42ff85e80f45 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -29,6 +29,7 @@ properties:
clocks:
items:
+ - description: Display GCC bus clock
- description: Display ahb clock
- description: Display axi clock
- description: Display core clock
@@ -36,6 +37,7 @@ properties:
clock-names:
items:
+ - const: gcc-bus
- const: iface
- const: bus
- const: core
@@ -114,11 +116,12 @@ examples:
<0x0aeb0000 0x2008>;
reg-names = "mdp", "vbif";
- clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ clocks = <&gcc GCC_DISP_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
<&dispcc DISP_CC_MDSS_AXI_CLK>,
<&dispcc DISP_CC_MDSS_MDP_CLK>,
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
- clock-names = "iface", "bus", "core", "vsync";
+ clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
interrupt-parent = <&mdss>;
interrupts = <0>;
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-18 17:58 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:58 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: linux-arm-msm, Daniel Vetter, devicetree, Krzysztof Kozlowski,
dri-devel, freedreno, Konrad Dybcio, Andy Gross, Bjorn Andersson,
Stephen Boyd, Rob Clark, David Airlie, Abhinav Kumar,
Rob Herring, Sean Paul
On Sun, 10 Jul 2022 12:00:39 +0300, Dmitry Baryshkov wrote:
> Add gcc-bus clock required for the SDM845 DPU device tree node. This
> change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845:
> move bus clock to mdp node for sdm845 target"), but was not reflected in
> the schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dpu-sdm845.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread* Re: [PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845
@ 2022-07-18 17:58 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:58 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Sean Paul, devicetree, David Airlie, linux-arm-msm,
Konrad Dybcio, Abhinav Kumar, dri-devel, Bjorn Andersson,
Rob Herring, Andy Gross, Krzysztof Kozlowski, Stephen Boyd,
freedreno
On Sun, 10 Jul 2022 12:00:39 +0300, Dmitry Baryshkov wrote:
> Add gcc-bus clock required for the SDM845 DPU device tree node. This
> change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845:
> move bus clock to mdp node for sdm845 target"), but was not reflected in
> the schema.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dpu-sdm845.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 62+ messages in thread
* [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-10 9:00 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno
Move properties common to all DPU DT nodes to the dpu-common.yaml.
Note, this removes description of individual DPU port@ nodes. However
such definitions add no additional value. The reg values do not
correspond to hardware INTF indices. The driver discovers and binds
these ports not paying any care for the order of these items. Thus just
leave the reference to graph.yaml#/properties/ports and the description.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
.../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
.../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
6 files changed, 62 insertions(+), 191 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
new file mode 100644
index 000000000000..14eda883e149
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
@@ -0,0 +1,42 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display DPU dt properties (common properties)
+
+maintainers:
+ - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+ - Krishna Manikandan <quic_mkrishn@quicinc.com>
+ - Rob Clark <robdclark@gmail.com>
+
+description: |
+ Common properties for QCom DPU display controller.
+
+properties:
+ interrupts:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ operating-points-v2: true
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - interrupts
+ - power-domains
+ - operating-points-v2
+ - ports
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 5caf46a1dd88..158bd93a157f 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -47,45 +47,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 8027319b1aad..0364261bf3d2 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -43,41 +43,10 @@ properties:
- const: lut
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index 9d4ec0b60c25..5df1f2d987c9 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -45,45 +45,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF0 (DP)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index 349a454099ad..c822da588de0 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -44,45 +44,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF5 (EDP)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 42ff85e80f45..218c9d0f3fed 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -43,45 +43,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
@ 2022-07-10 9:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-07-10 9:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
Move properties common to all DPU DT nodes to the dpu-common.yaml.
Note, this removes description of individual DPU port@ nodes. However
such definitions add no additional value. The reg values do not
correspond to hardware INTF indices. The driver discovers and binds
these ports not paying any care for the order of these items. Thus just
leave the reference to graph.yaml#/properties/ports and the description.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
.../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
.../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
.../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
6 files changed, 62 insertions(+), 191 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
new file mode 100644
index 000000000000..14eda883e149
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
@@ -0,0 +1,42 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display DPU dt properties (common properties)
+
+maintainers:
+ - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+ - Krishna Manikandan <quic_mkrishn@quicinc.com>
+ - Rob Clark <robdclark@gmail.com>
+
+description: |
+ Common properties for QCom DPU display controller.
+
+properties:
+ interrupts:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ operating-points-v2: true
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - interrupts
+ - power-domains
+ - operating-points-v2
+ - ports
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 5caf46a1dd88..158bd93a157f 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -47,45 +47,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 8027319b1aad..0364261bf3d2 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -43,41 +43,10 @@ properties:
- const: lut
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index 9d4ec0b60c25..5df1f2d987c9 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -45,45 +45,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF0 (DP)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index 349a454099ad..c822da588de0 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -44,45 +44,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF5 (EDP)
-
- required:
- - port@0
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index 42ff85e80f45..218c9d0f3fed 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -43,45 +43,10 @@ properties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
-required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
-additionalProperties: false
+allOf:
+ - $ref: "/schemas/display/msm/dpu-common.yaml#"
+
+unevaluatedProperties: false
examples:
- |
--
2.35.1
^ permalink raw reply related [flat|nested] 62+ messages in thread* Re: [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-18 17:50 ` Rob Herring
-1 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:50 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Krzysztof Kozlowski, Stephen Boyd, David Airlie,
Daniel Vetter, linux-arm-msm, devicetree, dri-devel, freedreno
On Sun, Jul 10, 2022 at 12:00:40PM +0300, Dmitry Baryshkov wrote:
> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>
> Note, this removes description of individual DPU port@ nodes. However
> such definitions add no additional value. The reg values do not
> correspond to hardware INTF indices. The driver discovers and binds
> these ports not paying any care for the order of these items. Thus just
> leave the reference to graph.yaml#/properties/ports and the description.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
> .../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
> .../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
> 6 files changed, 62 insertions(+), 191 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
> new file mode 100644
> index 000000000000..14eda883e149
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
> @@ -0,0 +1,42 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Display DPU dt properties (common properties)
> +
> +maintainers:
> + - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> + - Krishna Manikandan <quic_mkrishn@quicinc.com>
> + - Rob Clark <robdclark@gmail.com>
> +
> +description: |
> + Common properties for QCom DPU display controller.
> +
> +properties:
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + operating-points-v2: true
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + Contains the list of output ports from DPU device. These ports
> + connect to interfaces that are external to the DPU hardware,
> + such as DSI, DP etc.
From the last version:
> In case of MDSS all ports are output, they are connected to the external
> interfaces (DSI, DP, HDMI, etc). The driver uses them to bind available
> interfaces (using components framework). The reg property of the port is
> completely ignored.
It doesn't matter what the driver does or doesn't do. Without
describing port nodes at all, you are not validating what port nodes
can contain. Just try adding any property under a port node. You need at
least:
'^port@[0-N]$':
$ref: graph.yaml#/properties/port
where N is the max number of ports.
Rob
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
@ 2022-07-18 17:50 ` Rob Herring
0 siblings, 0 replies; 62+ messages in thread
From: Rob Herring @ 2022-07-18 17:50 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: devicetree, David Airlie, linux-arm-msm, Konrad Dybcio,
Abhinav Kumar, dri-devel, Bjorn Andersson, freedreno, Andy Gross,
Krzysztof Kozlowski, Stephen Boyd, Sean Paul
On Sun, Jul 10, 2022 at 12:00:40PM +0300, Dmitry Baryshkov wrote:
> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>
> Note, this removes description of individual DPU port@ nodes. However
> such definitions add no additional value. The reg values do not
> correspond to hardware INTF indices. The driver discovers and binds
> these ports not paying any care for the order of these items. Thus just
> leave the reference to graph.yaml#/properties/ports and the description.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
> .../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
> .../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
> .../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
> 6 files changed, 62 insertions(+), 191 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
> new file mode 100644
> index 000000000000..14eda883e149
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
> @@ -0,0 +1,42 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Display DPU dt properties (common properties)
> +
> +maintainers:
> + - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> + - Krishna Manikandan <quic_mkrishn@quicinc.com>
> + - Rob Clark <robdclark@gmail.com>
> +
> +description: |
> + Common properties for QCom DPU display controller.
> +
> +properties:
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + operating-points-v2: true
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + Contains the list of output ports from DPU device. These ports
> + connect to interfaces that are external to the DPU hardware,
> + such as DSI, DP etc.
From the last version:
> In case of MDSS all ports are output, they are connected to the external
> interfaces (DSI, DP, HDMI, etc). The driver uses them to bind available
> interfaces (using components framework). The reg property of the port is
> completely ignored.
It doesn't matter what the driver does or doesn't do. Without
describing port nodes at all, you are not validating what port nodes
can contain. Just try adding any property under a port node. You need at
least:
'^port@[0-N]$':
$ref: graph.yaml#/properties/port
where N is the max number of ports.
Rob
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
2022-07-18 17:50 ` Rob Herring
@ 2022-08-22 20:13 ` Dmitry Baryshkov
-1 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 20:13 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Krzysztof Kozlowski, Stephen Boyd, David Airlie,
Daniel Vetter, linux-arm-msm, devicetree, dri-devel, freedreno
On 18/07/2022 20:50, Rob Herring wrote:
> On Sun, Jul 10, 2022 at 12:00:40PM +0300, Dmitry Baryshkov wrote:
>> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>>
>> Note, this removes description of individual DPU port@ nodes. However
>> such definitions add no additional value. The reg values do not
>> correspond to hardware INTF indices. The driver discovers and binds
>> these ports not paying any care for the order of these items. Thus just
>> leave the reference to graph.yaml#/properties/ports and the description.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
>> .../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
>> .../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
>> 6 files changed, 62 insertions(+), 191 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> new file mode 100644
>> index 000000000000..14eda883e149
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> @@ -0,0 +1,42 @@
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DPU dt properties (common properties)
>> +
>> +maintainers:
>> + - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> + - Krishna Manikandan <quic_mkrishn@quicinc.com>
>> + - Rob Clark <robdclark@gmail.com>
>> +
>> +description: |
>> + Common properties for QCom DPU display controller.
>> +
>> +properties:
>> + interrupts:
>> + maxItems: 1
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + operating-points-v2: true
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> + description: |
>> + Contains the list of output ports from DPU device. These ports
>> + connect to interfaces that are external to the DPU hardware,
>> + such as DSI, DP etc.
>
> From the last version:
>
>> In case of MDSS all ports are output, they are connected to the external
>> interfaces (DSI, DP, HDMI, etc). The driver uses them to bind available
>> interfaces (using components framework). The reg property of the port is
>> completely ignored.
>
> It doesn't matter what the driver does or doesn't do. Without
> describing port nodes at all, you are not validating what port nodes
> can contain. Just try adding any property under a port node. You need at
> least:
>
> '^port@[0-N]$':
> $ref: graph.yaml#/properties/port
Hmm, the graph.yaml already restricts the ports node to the
ports@[0-9a-f]+$ + #address-cells/#size-cells. I don't think we have to
add any additional restrictions/entries here. Do we?
>
> where N is the max number of ports.
>
> Rob
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
@ 2022-08-22 20:13 ` Dmitry Baryshkov
0 siblings, 0 replies; 62+ messages in thread
From: Dmitry Baryshkov @ 2022-08-22 20:13 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, David Airlie, linux-arm-msm, Konrad Dybcio,
Abhinav Kumar, dri-devel, Bjorn Andersson, freedreno, Andy Gross,
Krzysztof Kozlowski, Stephen Boyd, Sean Paul
On 18/07/2022 20:50, Rob Herring wrote:
> On Sun, Jul 10, 2022 at 12:00:40PM +0300, Dmitry Baryshkov wrote:
>> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>>
>> Note, this removes description of individual DPU port@ nodes. However
>> such definitions add no additional value. The reg values do not
>> correspond to hardware INTF indices. The driver discovers and binds
>> these ports not paying any care for the order of these items. Thus just
>> leave the reference to graph.yaml#/properties/ports and the description.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../bindings/display/msm/dpu-common.yaml | 42 ++++++++++++++++++
>> .../bindings/display/msm/dpu-msm8998.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-qcm2290.yaml | 39 ++---------------
>> .../bindings/display/msm/dpu-sc7180.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-sc7280.yaml | 43 ++-----------------
>> .../bindings/display/msm/dpu-sdm845.yaml | 43 ++-----------------
>> 6 files changed, 62 insertions(+), 191 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> new file mode 100644
>> index 000000000000..14eda883e149
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
>> @@ -0,0 +1,42 @@
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Display DPU dt properties (common properties)
>> +
>> +maintainers:
>> + - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> + - Krishna Manikandan <quic_mkrishn@quicinc.com>
>> + - Rob Clark <robdclark@gmail.com>
>> +
>> +description: |
>> + Common properties for QCom DPU display controller.
>> +
>> +properties:
>> + interrupts:
>> + maxItems: 1
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + operating-points-v2: true
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> + description: |
>> + Contains the list of output ports from DPU device. These ports
>> + connect to interfaces that are external to the DPU hardware,
>> + such as DSI, DP etc.
>
> From the last version:
>
>> In case of MDSS all ports are output, they are connected to the external
>> interfaces (DSI, DP, HDMI, etc). The driver uses them to bind available
>> interfaces (using components framework). The reg property of the port is
>> completely ignored.
>
> It doesn't matter what the driver does or doesn't do. Without
> describing port nodes at all, you are not validating what port nodes
> can contain. Just try adding any property under a port node. You need at
> least:
>
> '^port@[0-N]$':
> $ref: graph.yaml#/properties/port
Hmm, the graph.yaml already restricts the ports node to the
ports@[0-9a-f]+$ + #address-cells/#size-cells. I don't think we have to
add any additional restrictions/entries here. Do we?
>
> where N is the max number of ports.
>
> Rob
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 62+ messages in thread
* Re: (subset) [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings
2022-07-10 9:00 ` Dmitry Baryshkov
@ 2022-07-16 15:18 ` Bjorn Andersson
-1 siblings, 0 replies; 62+ messages in thread
From: Bjorn Andersson @ 2022-07-16 15:18 UTC (permalink / raw)
To: Rob Herring, Rob Clark, Sean Paul, Krzysztof Kozlowski,
Andy Gross, Dmitry Baryshkov, Abhinav Kumar, Konrad Dybcio
Cc: Stephen Boyd, dri-devel, Daniel Vetter, linux-arm-msm,
devicetree, freedreno, David Airlie
On Sun, 10 Jul 2022 12:00:29 +0300, Dmitry Baryshkov wrote:
> Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU
> devices). Cleanup DPU schema files, so that they do not contain schema
> for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema
> afterwards.
>
> Changes since v1:
> - Renamed DPU device nodes from mdp@ to display-controller@
> - Described removal of mistakenly mentioned "lut" clock
> - Switched mdss.yaml to use $ref instead of fixing compatible strings
> - Dropped mdp-opp-table description (renamed by Krzysztof in his
> patchset)
> - Reworked DPU's ports definitions. Dropped description of individual
> ports, left only /ports $ref and description in dpu-common.yaml.
>
> [...]
Applied, thanks!
[01/11] arm64: dts: qcom: sdm845: rename DPU device node
commit: 1d52eb6cc827d0f166c728a7577609de75b6b8b1
[02/11] arm64: dts: qcom: sc7180: rename DPU device node
commit: 37e3558b79392ab864fe887b4593c5f737e063a5
[03/11] arm64: dts: qcom: sm8250: rename DPU device node
commit: ce5cf986cdab1973df0042ac5b743d5df008c338
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 62+ messages in thread* Re: (subset) [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings
@ 2022-07-16 15:18 ` Bjorn Andersson
0 siblings, 0 replies; 62+ messages in thread
From: Bjorn Andersson @ 2022-07-16 15:18 UTC (permalink / raw)
To: Rob Herring, Rob Clark, Sean Paul, Krzysztof Kozlowski,
Andy Gross, Dmitry Baryshkov, Abhinav Kumar, Konrad Dybcio
Cc: devicetree, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd,
freedreno
On Sun, 10 Jul 2022 12:00:29 +0300, Dmitry Baryshkov wrote:
> Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU
> devices). Cleanup DPU schema files, so that they do not contain schema
> for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema
> afterwards.
>
> Changes since v1:
> - Renamed DPU device nodes from mdp@ to display-controller@
> - Described removal of mistakenly mentioned "lut" clock
> - Switched mdss.yaml to use $ref instead of fixing compatible strings
> - Dropped mdp-opp-table description (renamed by Krzysztof in his
> patchset)
> - Reworked DPU's ports definitions. Dropped description of individual
> ports, left only /ports $ref and description in dpu-common.yaml.
>
> [...]
Applied, thanks!
[01/11] arm64: dts: qcom: sdm845: rename DPU device node
commit: 1d52eb6cc827d0f166c728a7577609de75b6b8b1
[02/11] arm64: dts: qcom: sc7180: rename DPU device node
commit: 37e3558b79392ab864fe887b4593c5f737e063a5
[03/11] arm64: dts: qcom: sm8250: rename DPU device node
commit: ce5cf986cdab1973df0042ac5b743d5df008c338
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 62+ messages in thread