All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Shixin <liushixin2@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	David Hildenbrand <dhildenb@redhat.com>,
	Rafael Aquini <raquini@redhat.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Liu Shixin <liushixin2@huawei.com>
Subject: [PATCH 0/2] arm64: fix two bug about page table check
Date: Wed, 16 Nov 2022 16:38:09 +0800	[thread overview]
Message-ID: <20221116083811.464678-1-liushixin2@huawei.com> (raw)

Denys Vlasenko has reported two bug about page table check on arm64.       
On arm64, pmd_present() contains non-leaf pmd and invalid pmd too.         

When collapse hugepage, the pmd is non-leaf and should skip the check.
Use pmd_leaf() instead of pmd_present().
                                                                           
When split hugepage, the pmd will be marked as invalid and then populate.  
So we should decrease file_map_count when invalid pmd and then increase    
when populate the pmd.                                                     
                                                                           
Liu Shixin (2):
  arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud
  arm64/mm: fix incorrect file_map_count for invalid pmd/pud

 arch/arm64/include/asm/pgtable.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Liu Shixin <liushixin2@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	David Hildenbrand <dhildenb@redhat.com>,
	Rafael Aquini <raquini@redhat.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Liu Shixin <liushixin2@huawei.com>
Subject: [PATCH 0/2] arm64: fix two bug about page table check
Date: Wed, 16 Nov 2022 16:38:09 +0800	[thread overview]
Message-ID: <20221116083811.464678-1-liushixin2@huawei.com> (raw)

Denys Vlasenko has reported two bug about page table check on arm64.       
On arm64, pmd_present() contains non-leaf pmd and invalid pmd too.         

When collapse hugepage, the pmd is non-leaf and should skip the check.
Use pmd_leaf() instead of pmd_present().
                                                                           
When split hugepage, the pmd will be marked as invalid and then populate.  
So we should decrease file_map_count when invalid pmd and then increase    
when populate the pmd.                                                     
                                                                           
Liu Shixin (2):
  arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud
  arm64/mm: fix incorrect file_map_count for invalid pmd/pud

 arch/arm64/include/asm/pgtable.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-11-16  7:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  8:38 Liu Shixin [this message]
2022-11-16  8:38 ` [PATCH 0/2] arm64: fix two bug about page table check Liu Shixin
2022-11-16  8:38 ` [PATCH 1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud Liu Shixin
2022-11-16  8:38   ` Liu Shixin
2022-11-16  9:04   ` David Hildenbrand
2022-11-16  9:04     ` David Hildenbrand
2022-11-16 14:59   ` Pasha Tatashin
2022-11-16 14:59     ` Pasha Tatashin
2022-11-17  4:09   ` Anshuman Khandual
2022-11-17  4:09     ` Anshuman Khandual
2022-11-17  6:59     ` Liu Shixin
2022-11-17  6:59       ` Liu Shixin
2022-11-21 15:57   ` Denys Vlasenko
2022-11-21 15:57     ` Denys Vlasenko
2022-11-16  8:38 ` [PATCH 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud Liu Shixin
2022-11-16  8:38   ` Liu Shixin
2022-11-16  9:08   ` David Hildenbrand
2022-11-16  9:08     ` David Hildenbrand
2022-11-16 15:46     ` Mark Rutland
2022-11-16 15:46       ` Mark Rutland
2022-11-17  4:24       ` Anshuman Khandual
2022-11-17  4:24         ` Anshuman Khandual
2022-11-16 15:18   ` Pasha Tatashin
2022-11-16 15:18     ` Pasha Tatashin
2022-11-16 15:52   ` Mark Rutland
2022-11-16 15:52     ` Mark Rutland
2022-11-17  3:15     ` Liu Shixin
2022-11-17  3:15       ` Liu Shixin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116083811.464678-1-liushixin2@huawei.com \
    --to=liushixin2@huawei.com \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dhildenb@redhat.com \
    --cc=dvlasenk@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=raquini@redhat.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.