* [PATCH] memory: renesas-rpc-if: Fix missing setting address
@ 2022-11-23 2:51 JaimeLiao
2022-12-27 8:59 ` Krzysztof Kozlowski
2023-01-23 10:44 ` Geert Uytterhoeven
0 siblings, 2 replies; 8+ messages in thread
From: JaimeLiao @ 2022-11-23 2:51 UTC (permalink / raw)
To: linux-kernel, krzysztof.kozlowski
Cc: jaimeliao, leoyu, alvinzhou, juliensu, JaimeLiao
In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.
Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>
---
drivers/memory/renesas-rpc-if.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 4316988d791a..bdf0a7f68ff2 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
}
break;
default:
+ regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
regmap_write(rpc->regmap, RPCIF_SMCR,
rpc->smcr | RPCIF_SMCR_SPIE);
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2022-11-23 2:51 [PATCH] memory: renesas-rpc-if: Fix missing setting address JaimeLiao
@ 2022-12-27 8:59 ` Krzysztof Kozlowski
2023-01-23 10:47 ` Krzysztof Kozlowski
2023-01-23 10:44 ` Geert Uytterhoeven
1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-27 8:59 UTC (permalink / raw)
To: JaimeLiao, linux-kernel
Cc: Krzysztof Kozlowski, juliensu, leoyu, alvinzhou, jaimeliao
On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
>
>
Applied, thanks!
[1/1] memory: renesas-rpc-if: Fix missing setting address
https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2022-12-27 8:59 ` Krzysztof Kozlowski
@ 2023-01-23 10:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 10:47 UTC (permalink / raw)
To: JaimeLiao, linux-kernel; +Cc: juliensu, leoyu, alvinzhou, jaimeliao
On 27/12/2022 09:59, Krzysztof Kozlowski wrote:
> On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
>> In the RPC manual mode, if the data direction is not set
>> (such as the flash erase command), the address misses the
>> setting.
>>
>>
>
> Applied, thanks!
>
> [1/1] memory: renesas-rpc-if: Fix missing setting address
> https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3
And drop. Stop sending the same patch all over again...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2022-11-23 2:51 [PATCH] memory: renesas-rpc-if: Fix missing setting address JaimeLiao
2022-12-27 8:59 ` Krzysztof Kozlowski
@ 2023-01-23 10:44 ` Geert Uytterhoeven
1 sibling, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2023-01-23 10:44 UTC (permalink / raw)
To: JaimeLiao
Cc: linux-kernel, krzysztof.kozlowski, jaimeliao, leoyu, alvinzhou, juliensu
Hi Jaime,
CC linux-renesas-soc
Thanks for your patch!
On Wed, Nov 23, 2022 at 3:55 AM JaimeLiao <jaimeliao.tw@gmail.com> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.
See also
https://lore.kernel.org/all/CAMuHMdWpvuC2Cm41jCQm+rT8MZB5GN+Z0bPz941QzsHX17Ux-g@mail.gmail.com
> Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>
> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> }
> break;
> default:
> + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> regmap_write(rpc->regmap, RPCIF_SMCR,
> rpc->smcr | RPCIF_SMCR_SPIE);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] memory: renesas-rpc-if: Fix missing setting address
@ 2021-08-18 16:56 Zhengxun
2021-08-23 11:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 8+ messages in thread
From: Zhengxun @ 2021-08-18 16:56 UTC (permalink / raw)
To: sergei.shtylyov, broonie, linux-spi, linux-renesas-soc, zhengxunli
Cc: Zhengxun
In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.
Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
---
drivers/memory/renesas-rpc-if.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 45eed659b0c6..9dd27c6307f7 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
}
break;
default:
+ regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
regmap_write(rpc->regmap, RPCIF_SMCR,
rpc->smcr | RPCIF_SMCR_SPIE);
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2021-08-18 16:56 Zhengxun
@ 2021-08-23 11:59 ` Geert Uytterhoeven
2022-04-27 10:26 ` Geert Uytterhoeven
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2021-08-23 11:59 UTC (permalink / raw)
To: Zhengxun
Cc: Mark Brown, linux-spi, Linux-Renesas, zhengxunli, Sergey Shtylyov
CC sergey's new address
On Wed, Aug 18, 2021 at 10:57 AM Zhengxun <zhengxunli.mxic@gmail.com> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
>
> Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
> ---
> drivers/memory/renesas-rpc-if.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
> index 45eed659b0c6..9dd27c6307f7 100644
> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> }
> break;
> default:
> + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> regmap_write(rpc->regmap, RPCIF_SMCR,
> rpc->smcr | RPCIF_SMCR_SPIE);
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2021-08-23 11:59 ` Geert Uytterhoeven
@ 2022-04-27 10:26 ` Geert Uytterhoeven
2022-04-27 10:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2022-04-27 10:26 UTC (permalink / raw)
To: Zhengxun
Cc: Mark Brown, linux-spi, Linux-Renesas, zhengxunli,
Sergey Shtylyov, Wolfram Sang, Krzysztof Kozlowski
On Mon, Aug 23, 2021 at 1:59 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> CC sergey's new address
>
> On Wed, Aug 18, 2021 at 10:57 AM Zhengxun <zhengxunli.mxic@gmail.com> wrote:
> > In the RPC manual mode, if the data direction is not set
> > (such as the flash erase command), the address misses the
> > setting.
> >
> > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
> > ---
> > drivers/memory/renesas-rpc-if.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
> > index 45eed659b0c6..9dd27c6307f7 100644
> > --- a/drivers/memory/renesas-rpc-if.c
> > +++ b/drivers/memory/renesas-rpc-if.c
> > @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> > }
> > break;
> > default:
> > + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> > regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> > regmap_write(rpc->regmap, RPCIF_SMCR,
> > rpc->smcr | RPCIF_SMCR_SPIE);
This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
2022-04-27 10:26 ` Geert Uytterhoeven
@ 2022-04-27 10:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 10:49 UTC (permalink / raw)
To: Geert Uytterhoeven, Zhengxun
Cc: Mark Brown, linux-spi, Linux-Renesas, zhengxunli,
Sergey Shtylyov, Wolfram Sang
On 27/04/2022 12:26, Geert Uytterhoeven wrote:
> On Mon, Aug 23, 2021 at 1:59 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> CC sergey's new address
>>
>> On Wed, Aug 18, 2021 at 10:57 AM Zhengxun <zhengxunli.mxic@gmail.com> wrote:
>>> In the RPC manual mode, if the data direction is not set
>>> (such as the flash erase command), the address misses the
>>> setting.
>>>
>>> Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
>>> ---
>>> drivers/memory/renesas-rpc-if.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
>>> index 45eed659b0c6..9dd27c6307f7 100644
>>> --- a/drivers/memory/renesas-rpc-if.c
>>> +++ b/drivers/memory/renesas-rpc-if.c
>>> @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
>>> }
>>> break;
>>> default:
>>> + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
>>> regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
>>> regmap_write(rpc->regmap, RPCIF_SMCR,
>>> rpc->smcr | RPCIF_SMCR_SPIE);
>
> This patch never received review comments.
> As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
> data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
> before the switch() statement, hence this patch can be ignored.
Thanks Geert. The patch was not sent to proper folks and mailing lists
(only linux-renesas-soc@vger.kernel.org seams reasonable) so there is
little way it would be ever reviewed.
Zhengxun,
Please use scripts/get_maintainer.pl to get the list of people and lists
to CC/address.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-23 10:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23 2:51 [PATCH] memory: renesas-rpc-if: Fix missing setting address JaimeLiao
2022-12-27 8:59 ` Krzysztof Kozlowski
2023-01-23 10:47 ` Krzysztof Kozlowski
2023-01-23 10:44 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2021-08-18 16:56 Zhengxun
2021-08-23 11:59 ` Geert Uytterhoeven
2022-04-27 10:26 ` Geert Uytterhoeven
2022-04-27 10:49 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.