Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.

From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: jerome Neanne <jneanne@baylibre.com>,
	Wadim Egorov <W.Egorov@phytec.de>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"kristo@kernel.org" <kristo@kernel.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"marcel.ziswiler@toradex.com" <marcel.ziswiler@toradex.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jeff@labundy.com" <jeff@labundy.com>, "afd@ti.com" <afd@ti.com>,
	"khilman@baylibre.com" <khilman@baylibre.com>,
	"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"msp@baylibre.com" <msp@baylibre.com>,
	"j-keerthy@ti.com" <j-keerthy@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.
Date: Thu, 15 Dec 2022 11:54:11 -0600	[thread overview]
Message-ID: <20221215175411.znxy3d6ussq2iq5h@grieving> (raw)
In-Reply-To: <Y5tGzjgcAWPqdFNE@sirena.org.uk>

On 16:09-20221215, Mark Brown wrote:
> On Thu, Dec 15, 2022 at 04:51:40PM +0100, jerome Neanne wrote:
> > On 15/12/2022 16:09, Wadim Egorov wrote:
> 
> > > I am testing your PMIC patches on a AM62 based board with a similar setup and
> > > running into the following error
> 
> > >      VDDSHV5_SDIO: bypassed regulator has no supply!
> > >      VDDSHV5_SDIO: will resolve supply early: ldo1
> > >      VDDSHV5_SDIO: supplied by regulator-dummy
> > >      VDDSHV5_SDIO: failed to get the current voltage: -EINVAL
> 
> > > Have you noticed problems with LDO1 and bypass mode?
> 
> > I did not noticed this on am642 board but IIRC this rail was not used. I
> > heard about similar issue reported to me by Nishanth M with a fix proposal
> > here:
> > https://gist.github.com/nmenon/e4dd6ef6afe31bc9750fa6cbee8d3e25
> 
> That proposal looks really non-idiomatic and quite unusual, if there's a
> fixed voltage supply to the LDO I'd expect to see it modeled as a fixed
> voltage regulator.  I'm not sure what the use of bypass here is trying
> to accomplish TBH.

Correct - My hack was based on a time crunch hack ;)...

The problem is this - the default NVM in the PMIC is setup such that
VSET value =3.3v and bypass bit set (makes sense since the vin=3.3v).

Now the constraint is bypass bit cannot be changed without the LDO
being switched off.

regulator-allow-bypass property allows us to control bypass bit, but we
should'nt toggle it when LDO is active. Not providing the property
implies the bit wont be toggled by regulator core either.

What we need is a scheme that will disable the bypass bit with the
intent of operating the LDO with just the vset field. I did'nt find it
possible atm.. unless I am mistaken..

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D