All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: jerome Neanne <jneanne@baylibre.com>
Cc: Wadim Egorov <W.Egorov@phytec.de>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"nm@ti.com" <nm@ti.com>, "kristo@kernel.org" <kristo@kernel.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"marcel.ziswiler@toradex.com" <marcel.ziswiler@toradex.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jeff@labundy.com" <jeff@labundy.com>, "afd@ti.com" <afd@ti.com>,
	"khilman@baylibre.com" <khilman@baylibre.com>,
	"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"msp@baylibre.com" <msp@baylibre.com>,
	"j-keerthy@ti.com" <j-keerthy@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.
Date: Thu, 15 Dec 2022 16:09:50 +0000	[thread overview]
Message-ID: <Y5tGzjgcAWPqdFNE@sirena.org.uk> (raw)
In-Reply-To: <e2bc53fe-3a0c-cf24-8b29-ca377aba3721@baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

On Thu, Dec 15, 2022 at 04:51:40PM +0100, jerome Neanne wrote:
> On 15/12/2022 16:09, Wadim Egorov wrote:

> > I am testing your PMIC patches on a AM62 based board with a similar setup and
> > running into the following error

> >      VDDSHV5_SDIO: bypassed regulator has no supply!
> >      VDDSHV5_SDIO: will resolve supply early: ldo1
> >      VDDSHV5_SDIO: supplied by regulator-dummy
> >      VDDSHV5_SDIO: failed to get the current voltage: -EINVAL

> > Have you noticed problems with LDO1 and bypass mode?

> I did not noticed this on am642 board but IIRC this rail was not used. I
> heard about similar issue reported to me by Nishanth M with a fix proposal
> here:
> https://gist.github.com/nmenon/e4dd6ef6afe31bc9750fa6cbee8d3e25

That proposal looks really non-idiomatic and quite unusual, if there's a
fixed voltage supply to the LDO I'd expect to see it modeled as a fixed
voltage regulator.  I'm not sure what the use of bypass here is trying
to accomplish TBH.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: jerome Neanne <jneanne@baylibre.com>
Cc: Wadim Egorov <W.Egorov@phytec.de>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"nm@ti.com" <nm@ti.com>, "kristo@kernel.org" <kristo@kernel.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"marcel.ziswiler@toradex.com" <marcel.ziswiler@toradex.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jeff@labundy.com" <jeff@labundy.com>, "afd@ti.com" <afd@ti.com>,
	"khilman@baylibre.com" <khilman@baylibre.com>,
	"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"msp@baylibre.com" <msp@baylibre.com>,
	"j-keerthy@ti.com" <j-keerthy@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.
Date: Thu, 15 Dec 2022 16:09:50 +0000	[thread overview]
Message-ID: <Y5tGzjgcAWPqdFNE@sirena.org.uk> (raw)
In-Reply-To: <e2bc53fe-3a0c-cf24-8b29-ca377aba3721@baylibre.com>


[-- Attachment #1.1: Type: text/plain, Size: 999 bytes --]

On Thu, Dec 15, 2022 at 04:51:40PM +0100, jerome Neanne wrote:
> On 15/12/2022 16:09, Wadim Egorov wrote:

> > I am testing your PMIC patches on a AM62 based board with a similar setup and
> > running into the following error

> >      VDDSHV5_SDIO: bypassed regulator has no supply!
> >      VDDSHV5_SDIO: will resolve supply early: ldo1
> >      VDDSHV5_SDIO: supplied by regulator-dummy
> >      VDDSHV5_SDIO: failed to get the current voltage: -EINVAL

> > Have you noticed problems with LDO1 and bypass mode?

> I did not noticed this on am642 board but IIRC this rail was not used. I
> heard about similar issue reported to me by Nishanth M with a fix proposal
> here:
> https://gist.github.com/nmenon/e4dd6ef6afe31bc9750fa6cbee8d3e25

That proposal looks really non-idiomatic and quite unusual, if there's a
fixed voltage supply to the LDO I'd expect to see it modeled as a fixed
voltage regulator.  I'm not sure what the use of bypass here is trying
to accomplish TBH.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-15 16:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 15:23 [PATCH v7 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-11-04 15:23 ` Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-12-15 15:09   ` Wadim Egorov
2022-12-15 15:09     ` Wadim Egorov
2022-12-15 15:51     ` jerome Neanne
2022-12-15 15:51       ` jerome Neanne
2022-12-15 16:09       ` Mark Brown [this message]
2022-12-15 16:09         ` Mark Brown
2022-12-15 17:54         ` Nishanth Menon
2022-12-15 17:54           ` Nishanth Menon
2022-12-15 18:22           ` Mark Brown
2022-12-15 18:22             ` Mark Brown
2022-12-15 21:41             ` Nishanth Menon
2022-12-15 21:41               ` Nishanth Menon
2022-12-16  6:21               ` Vignesh Raghavendra
2022-12-16  6:21                 ` Vignesh Raghavendra
2022-12-16  7:28                 ` jerome Neanne
2022-12-16  7:28                   ` jerome Neanne
2022-12-16 13:41               ` Mark Brown
2022-12-16 13:41                 ` Mark Brown
2022-12-28 10:16                 ` Wadim Egorov
2022-12-28 10:16                   ` Wadim Egorov
2022-11-04 15:23 ` [PATCH v7 2/6] DONOTMERGE: arm64: dts: ti: Add pinmux and irq mapping for TPS65219 external interrupts Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 3/6] DONOTMERGE: arm64: dts: ti: k3-am642-sk: Enable tps65219 power-button Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-11-15 22:26   ` Kevin Hilman
2022-11-15 22:26     ` Kevin Hilman
2022-11-15 23:14   ` Kevin Hilman
2022-11-15 23:14     ` Kevin Hilman
2022-11-16 13:58     ` Lee Jones
2022-11-16 13:58       ` Lee Jones
2022-11-16 18:11   ` Lee Jones
2022-11-16 18:11     ` Lee Jones
2022-11-04 15:23 ` [PATCH v7 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-11-17 11:53   ` Lee Jones
2022-11-17 11:53     ` Lee Jones
2022-11-04 15:23 ` [PATCH v7 6/6] arm64: defconfig: Add tps65219 as modules Jerome Neanne
2022-11-04 15:23   ` Jerome Neanne
2022-11-15 22:23   ` Kevin Hilman
2022-11-15 22:23     ` Kevin Hilman
2022-11-17 16:00     ` Kevin Hilman
2022-11-17 16:00       ` Kevin Hilman
2022-12-05 18:08 ` [PATCH v7 0/6] Add support for TI TPS65219 PMIC Francesco Dolcini
2022-12-05 18:08   ` Francesco Dolcini
2022-12-06 19:22   ` jerome Neanne
2022-12-06 19:22     ` jerome Neanne
2023-05-22 11:57     ` jerome Neanne
2023-05-22 11:57       ` jerome Neanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5tGzjgcAWPqdFNE@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=W.Egorov@phytec.de \
    --cc=afd@ti.com \
    --cc=arnd@arndb.de \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=j-keerthy@ti.com \
    --cc=jeff@labundy.com \
    --cc=jneanne@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=msp@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.