From: Minda Chen <minda.chen@starfivetech.com> To: "Daire McNamara" <daire.mcnamara@microchip.com>, "Conor Dooley" <conor@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Emil Renner Berthing" <emil.renner.berthing@canonical.com> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>, <linux-pci@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Mason Huo <mason.huo@starfivetech.com>, Leyfoon Tan <leyfoon.tan@starfivetech.com>, Kevin Xie <kevin.xie@starfivetech.com>, Minda Chen <minda.chen@starfivetech.com> Subject: [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Date: Wed, 19 Jul 2023 18:20:48 +0800 [thread overview] Message-ID: <20230719102057.22329-1-minda.chen@starfivetech.com> (raw) This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the same IP and have commit their codes, which are mixed with PLDA controller codes and Microchip platform codes. For re-use the PLDA controller codes, I request refactoring microchip codes, move PLDA common codes to PLDA files. Desigware and Cadence is good example for refactoring codes. So first step is extract the PLDA common codes from microchip, and refactoring the microchip codes.(patch1 - 4) Then add the PLDA platform codes. (patch5, 6) At last, add Starfive codes. (patch7 - 9) This patchset is base on v6.5-rc1 patch1 is add PLDA XpressRICH PCIe host common properties dt-binding docs, most are extracted from microchip,pcie-host.yaml patch2 is add plda,xpressrich-pcie-common.yaml(patch1 file) reference and remove the PLDA common properties. patch3 is extracting the PLDA common codes from microchip Polarfire PCIe codes. The change list in the commit message. patch4 is move microchip driver to PLDA directory and remove the PLDA common codes. patch5 is add PLDA Xpressrich platform driver dt-binding doc. patch6 is PLDA Xpressrich platform driver. patch7 is add StarFive JH7110 PCIe dt-binding doc. patch8 is add StarFive JH7110 Soc PCIe platform codes. patch9 is StarFive JH7110 device tree configuration. I have noticed that Daire have changed microchip's codes. https://patchwork.kernel.org/project/linux-pci/cover/20230630154859.2049521-1-daire.mcnamara@microchip.com/ I have changed patch3 and patch4 base on their commits. StarFive PCIe driver still can work. But their codes is under reviewed and maybe changing. Do not base on their changes first. I will base on their commit to change patch3 and patch4 as soon as their commits are accepted. List below is old patchset and is dropped, which is non-refractored version. https://patchwork.kernel.org/project/linux-pci/cover/20230406111142.74410-1-minda.chen@starfivetech.com/ Minda Chen (9): dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties dt-bindings: PCI: microchip: Remove the PLDA common properties PCI: PLDA: Get PLDA common codes from Microchip PolarFire host PCI: microchip: Move PCIe driver to PLDA directory dt-bindings: PLDA: Add PLDA XpressRICH PCIe host controller PCI: PLDA: Add host conroller platform driver dt-bindings: PCI: Add StarFive JH7110 PCIe controller PCI: PLDA: starfive: Add JH7110 PCIe controller riscv: dts: starfive: add PCIe dts configuration for JH7110 .../bindings/pci/microchip,pcie-host.yaml | 45 +- .../pci/plda,xpressrich-pcie-common.yaml | 72 ++ .../pci/plda,xpressrich-pcie-host.yaml | 66 ++ .../bindings/pci/starfive,jh7110-pcie.yaml | 138 ++++ MAINTAINERS | 19 +- .../jh7110-starfive-visionfive-2.dtsi | 44 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 88 +++ drivers/pci/controller/Kconfig | 9 +- drivers/pci/controller/Makefile | 2 +- drivers/pci/controller/plda/Kconfig | 35 + drivers/pci/controller/plda/Makefile | 5 + .../{ => plda}/pcie-microchip-host.c | 594 ++-------------- drivers/pci/controller/plda/pcie-plda-host.c | 665 ++++++++++++++++++ drivers/pci/controller/plda/pcie-plda-plat.c | 64 ++ drivers/pci/controller/plda/pcie-plda.h | 230 ++++++ drivers/pci/controller/plda/pcie-starfive.c | 415 +++++++++++ 16 files changed, 1885 insertions(+), 606 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml create mode 100644 Documentation/devicetree/bindings/pci/starfive,jh7110-pcie.yaml create mode 100644 drivers/pci/controller/plda/Kconfig create mode 100644 drivers/pci/controller/plda/Makefile rename drivers/pci/controller/{ => plda}/pcie-microchip-host.c (50%) create mode 100644 drivers/pci/controller/plda/pcie-plda-host.c create mode 100644 drivers/pci/controller/plda/pcie-plda-plat.c create mode 100644 drivers/pci/controller/plda/pcie-plda.h create mode 100644 drivers/pci/controller/plda/pcie-starfive.c base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Minda Chen <minda.chen@starfivetech.com> To: "Daire McNamara" <daire.mcnamara@microchip.com>, "Conor Dooley" <conor@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Emil Renner Berthing" <emil.renner.berthing@canonical.com> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>, <linux-pci@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Mason Huo <mason.huo@starfivetech.com>, Leyfoon Tan <leyfoon.tan@starfivetech.com>, Kevin Xie <kevin.xie@starfivetech.com>, Minda Chen <minda.chen@starfivetech.com> Subject: [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Date: Wed, 19 Jul 2023 18:20:48 +0800 [thread overview] Message-ID: <20230719102057.22329-1-minda.chen@starfivetech.com> (raw) This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the same IP and have commit their codes, which are mixed with PLDA controller codes and Microchip platform codes. For re-use the PLDA controller codes, I request refactoring microchip codes, move PLDA common codes to PLDA files. Desigware and Cadence is good example for refactoring codes. So first step is extract the PLDA common codes from microchip, and refactoring the microchip codes.(patch1 - 4) Then add the PLDA platform codes. (patch5, 6) At last, add Starfive codes. (patch7 - 9) This patchset is base on v6.5-rc1 patch1 is add PLDA XpressRICH PCIe host common properties dt-binding docs, most are extracted from microchip,pcie-host.yaml patch2 is add plda,xpressrich-pcie-common.yaml(patch1 file) reference and remove the PLDA common properties. patch3 is extracting the PLDA common codes from microchip Polarfire PCIe codes. The change list in the commit message. patch4 is move microchip driver to PLDA directory and remove the PLDA common codes. patch5 is add PLDA Xpressrich platform driver dt-binding doc. patch6 is PLDA Xpressrich platform driver. patch7 is add StarFive JH7110 PCIe dt-binding doc. patch8 is add StarFive JH7110 Soc PCIe platform codes. patch9 is StarFive JH7110 device tree configuration. I have noticed that Daire have changed microchip's codes. https://patchwork.kernel.org/project/linux-pci/cover/20230630154859.2049521-1-daire.mcnamara@microchip.com/ I have changed patch3 and patch4 base on their commits. StarFive PCIe driver still can work. But their codes is under reviewed and maybe changing. Do not base on their changes first. I will base on their commit to change patch3 and patch4 as soon as their commits are accepted. List below is old patchset and is dropped, which is non-refractored version. https://patchwork.kernel.org/project/linux-pci/cover/20230406111142.74410-1-minda.chen@starfivetech.com/ Minda Chen (9): dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties dt-bindings: PCI: microchip: Remove the PLDA common properties PCI: PLDA: Get PLDA common codes from Microchip PolarFire host PCI: microchip: Move PCIe driver to PLDA directory dt-bindings: PLDA: Add PLDA XpressRICH PCIe host controller PCI: PLDA: Add host conroller platform driver dt-bindings: PCI: Add StarFive JH7110 PCIe controller PCI: PLDA: starfive: Add JH7110 PCIe controller riscv: dts: starfive: add PCIe dts configuration for JH7110 .../bindings/pci/microchip,pcie-host.yaml | 45 +- .../pci/plda,xpressrich-pcie-common.yaml | 72 ++ .../pci/plda,xpressrich-pcie-host.yaml | 66 ++ .../bindings/pci/starfive,jh7110-pcie.yaml | 138 ++++ MAINTAINERS | 19 +- .../jh7110-starfive-visionfive-2.dtsi | 44 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 88 +++ drivers/pci/controller/Kconfig | 9 +- drivers/pci/controller/Makefile | 2 +- drivers/pci/controller/plda/Kconfig | 35 + drivers/pci/controller/plda/Makefile | 5 + .../{ => plda}/pcie-microchip-host.c | 594 ++-------------- drivers/pci/controller/plda/pcie-plda-host.c | 665 ++++++++++++++++++ drivers/pci/controller/plda/pcie-plda-plat.c | 64 ++ drivers/pci/controller/plda/pcie-plda.h | 230 ++++++ drivers/pci/controller/plda/pcie-starfive.c | 415 +++++++++++ 16 files changed, 1885 insertions(+), 606 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-host.yaml create mode 100644 Documentation/devicetree/bindings/pci/starfive,jh7110-pcie.yaml create mode 100644 drivers/pci/controller/plda/Kconfig create mode 100644 drivers/pci/controller/plda/Makefile rename drivers/pci/controller/{ => plda}/pcie-microchip-host.c (50%) create mode 100644 drivers/pci/controller/plda/pcie-plda-host.c create mode 100644 drivers/pci/controller/plda/pcie-plda-plat.c create mode 100644 drivers/pci/controller/plda/pcie-plda.h create mode 100644 drivers/pci/controller/plda/pcie-starfive.c base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- 2.17.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2023-07-19 10:21 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-19 10:20 Minda Chen [this message] 2023-07-19 10:20 ` [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Minda Chen 2023-07-19 10:20 ` [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:52 ` Krzysztof Kozlowski 2023-07-19 10:52 ` Krzysztof Kozlowski 2023-07-20 6:59 ` Minda Chen 2023-07-20 6:59 ` Minda Chen 2023-07-19 22:31 ` Rob Herring 2023-07-19 22:31 ` Rob Herring 2023-07-20 6:47 ` Minda Chen 2023-07-20 6:47 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 2/9] dt-bindings: PCI: microchip: Remove the PLDA " Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:53 ` Krzysztof Kozlowski 2023-07-19 10:53 ` Krzysztof Kozlowski 2023-07-19 10:20 ` [PATCH v1 3/9] PCI: PLDA: Get PLDA common codes from Microchip PolarFire host Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 4/9] PCI: microchip: Move PCIe driver to PLDA directory Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-20 11:07 ` Conor Dooley 2023-07-20 11:07 ` Conor Dooley 2023-07-20 12:26 ` Conor Dooley 2023-07-20 12:26 ` Conor Dooley 2023-07-21 1:12 ` Minda Chen 2023-07-21 1:12 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 5/9] dt-bindings: PLDA: Add PLDA XpressRICH PCIe host controller Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:55 ` Krzysztof Kozlowski 2023-07-19 10:55 ` Krzysztof Kozlowski 2023-07-19 22:29 ` Rob Herring 2023-07-19 22:29 ` Rob Herring 2023-07-20 7:02 ` Minda Chen 2023-07-20 7:02 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 6/9] PCI: PLDA: Add host conroller platform driver Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 7/9] dt-bindings: PCI: Add StarFive JH7110 PCIe controller Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:56 ` Krzysztof Kozlowski 2023-07-19 10:56 ` Krzysztof Kozlowski 2023-07-19 10:20 ` [PATCH v1 8/9] PCI: PLDA: starfive: Add " Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 16:48 ` Bjorn Helgaas 2023-07-19 16:48 ` Bjorn Helgaas 2023-07-20 10:11 ` Kevin Xie 2023-07-20 10:11 ` Kevin Xie 2023-07-20 16:15 ` Bjorn Helgaas 2023-07-20 16:15 ` Bjorn Helgaas 2023-07-24 10:48 ` Kevin Xie 2023-07-24 10:48 ` Kevin Xie 2023-07-25 20:46 ` Bjorn Helgaas 2023-07-25 20:46 ` Bjorn Helgaas 2023-07-27 21:40 ` Bjorn Helgaas 2023-07-27 21:40 ` Bjorn Helgaas 2023-07-31 5:52 ` Kevin Xie 2023-07-31 5:52 ` Kevin Xie 2023-07-31 23:12 ` Bjorn Helgaas 2023-07-31 23:12 ` Bjorn Helgaas 2023-08-01 7:05 ` Pali Rohár 2023-08-01 7:05 ` Pali Rohár 2023-08-01 7:05 ` Kevin Xie 2023-08-01 7:05 ` Kevin Xie 2023-08-01 7:14 ` Pali Rohár 2023-08-01 7:14 ` Pali Rohár 2023-08-02 17:14 ` Bjorn Helgaas 2023-08-02 17:14 ` Bjorn Helgaas 2023-08-02 17:18 ` Bjorn Helgaas 2023-08-02 17:18 ` Bjorn Helgaas 2023-08-03 2:23 ` Kevin Xie 2023-08-03 2:23 ` Kevin Xie 2023-08-03 6:58 ` Pali Rohár 2023-08-03 6:58 ` Pali Rohár 2023-08-03 7:43 ` Kevin Xie 2023-08-03 7:43 ` Kevin Xie 2023-07-20 11:14 ` Conor Dooley 2023-07-20 11:14 ` Conor Dooley 2023-07-21 1:03 ` Minda Chen 2023-07-21 1:03 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 9/9] riscv: dts: starfive: add PCIe dts configuration for JH7110 Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 15:26 ` [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Bjorn Helgaas 2023-07-19 15:26 ` Bjorn Helgaas 2023-07-20 2:15 ` Minda Chen 2023-07-20 2:15 ` Minda Chen 2023-07-20 12:12 ` Conor Dooley 2023-07-20 12:12 ` Conor Dooley 2023-07-21 9:34 ` Minda Chen 2023-07-21 9:34 ` Minda Chen 2023-07-21 9:55 ` Minda Chen 2023-07-21 9:55 ` Minda Chen 2023-07-19 16:58 ` Conor Dooley 2023-07-19 16:58 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230719102057.22329-1-minda.chen@starfivetech.com \ --to=minda.chen@starfivetech.com \ --cc=aou@eecs.berkeley.edu \ --cc=bhelgaas@google.com \ --cc=conor@kernel.org \ --cc=daire.mcnamara@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=emil.renner.berthing@canonical.com \ --cc=kevin.xie@starfivetech.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kw@linux.com \ --cc=leyfoon.tan@starfivetech.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=lpieralisi@kernel.org \ --cc=mason.huo@starfivetech.com \ --cc=p.zabel@pengutronix.de \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.