From: Minda Chen <minda.chen@starfivetech.com> To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Daire McNamara" <daire.mcnamara@microchip.com>, "Conor Dooley" <conor@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Emil Renner Berthing" <emil.renner.berthing@canonical.com> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>, <linux-pci@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Mason Huo <mason.huo@starfivetech.com>, Leyfoon Tan <leyfoon.tan@starfivetech.com>, Kevin Xie <kevin.xie@starfivetech.com> Subject: Re: [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Date: Thu, 20 Jul 2023 14:59:21 +0800 [thread overview] Message-ID: <5e4d5920-f346-a6ae-8548-f70d9fa911fe@starfivetech.com> (raw) In-Reply-To: <c1dea7c8-2bc4-a113-0d40-098228fe3860@linaro.org> On 2023/7/19 18:52, Krzysztof Kozlowski wrote: > On 19/07/2023 12:20, Minda Chen wrote: >> Add PLDA XpressRICH PCIe host common properties dt-binding doc. >> Microchip PolarFire PCIe host using PLDA IP. >> Extract properties from Microchip PolarFire PCIe host. >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> >> Reviewed-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> .../pci/plda,xpressrich-pcie-common.yaml | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml > > How is it related with existing plda,xpressrich3-axi? > yes, I just found plda,xpressrich3-axi. It is same IP in ARM juno soc. But it is firmware-initialized while microchip and starfive not. maybe I can rename this file to plda,xpressrich3-axi-common.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> new file mode 100644 >> index 000000000000..3627a846c5d1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/plda,xpressrich-pcie-common.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: PLDA XpressRICH PCIe host common properties >> + >> +maintainers: >> + - Daire McNamara <daire.mcnamara@microchip.com> >> + - Minda Chen <minda.chen@starfivetech.com> >> + >> +description: >> + Generic PLDA XpressRICH PCIe host common properties. >> + >> +select: false > > This should not be needed. > ok >> + >> +properties: >> + reg: >> + description: >> + At least host IP register set and configuration space are > > "At least" does not fit here since you do not allow anything else. > I will delete "At least" >> + required for normal controller work. >> + maxItems: 2 >> + >> + reg-names: >> + oneOf: >> + - items: >> + - const: cfg >> + - const: apb >> + - items: >> + - const: host >> + - const: cfg > > Maybe keep similar order, so cfg followed by host? > I will follow cfg, apb > Best regards, > Krzysztof >
WARNING: multiple messages have this Message-ID (diff)
From: Minda Chen <minda.chen@starfivetech.com> To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Daire McNamara" <daire.mcnamara@microchip.com>, "Conor Dooley" <conor@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Emil Renner Berthing" <emil.renner.berthing@canonical.com> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>, <linux-pci@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Mason Huo <mason.huo@starfivetech.com>, Leyfoon Tan <leyfoon.tan@starfivetech.com>, Kevin Xie <kevin.xie@starfivetech.com> Subject: Re: [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Date: Thu, 20 Jul 2023 14:59:21 +0800 [thread overview] Message-ID: <5e4d5920-f346-a6ae-8548-f70d9fa911fe@starfivetech.com> (raw) In-Reply-To: <c1dea7c8-2bc4-a113-0d40-098228fe3860@linaro.org> On 2023/7/19 18:52, Krzysztof Kozlowski wrote: > On 19/07/2023 12:20, Minda Chen wrote: >> Add PLDA XpressRICH PCIe host common properties dt-binding doc. >> Microchip PolarFire PCIe host using PLDA IP. >> Extract properties from Microchip PolarFire PCIe host. >> >> Signed-off-by: Minda Chen <minda.chen@starfivetech.com> >> Reviewed-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> .../pci/plda,xpressrich-pcie-common.yaml | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml > > How is it related with existing plda,xpressrich3-axi? > yes, I just found plda,xpressrich3-axi. It is same IP in ARM juno soc. But it is firmware-initialized while microchip and starfive not. maybe I can rename this file to plda,xpressrich3-axi-common.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> new file mode 100644 >> index 000000000000..3627a846c5d1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/plda,xpressrich-pcie-common.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: PLDA XpressRICH PCIe host common properties >> + >> +maintainers: >> + - Daire McNamara <daire.mcnamara@microchip.com> >> + - Minda Chen <minda.chen@starfivetech.com> >> + >> +description: >> + Generic PLDA XpressRICH PCIe host common properties. >> + >> +select: false > > This should not be needed. > ok >> + >> +properties: >> + reg: >> + description: >> + At least host IP register set and configuration space are > > "At least" does not fit here since you do not allow anything else. > I will delete "At least" >> + required for normal controller work. >> + maxItems: 2 >> + >> + reg-names: >> + oneOf: >> + - items: >> + - const: cfg >> + - const: apb >> + - items: >> + - const: host >> + - const: cfg > > Maybe keep similar order, so cfg followed by host? > I will follow cfg, apb > Best regards, > Krzysztof > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-20 6:59 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-19 10:20 [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:52 ` Krzysztof Kozlowski 2023-07-19 10:52 ` Krzysztof Kozlowski 2023-07-20 6:59 ` Minda Chen [this message] 2023-07-20 6:59 ` Minda Chen 2023-07-19 22:31 ` Rob Herring 2023-07-19 22:31 ` Rob Herring 2023-07-20 6:47 ` Minda Chen 2023-07-20 6:47 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 2/9] dt-bindings: PCI: microchip: Remove the PLDA " Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:53 ` Krzysztof Kozlowski 2023-07-19 10:53 ` Krzysztof Kozlowski 2023-07-19 10:20 ` [PATCH v1 3/9] PCI: PLDA: Get PLDA common codes from Microchip PolarFire host Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 4/9] PCI: microchip: Move PCIe driver to PLDA directory Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-20 11:07 ` Conor Dooley 2023-07-20 11:07 ` Conor Dooley 2023-07-20 12:26 ` Conor Dooley 2023-07-20 12:26 ` Conor Dooley 2023-07-21 1:12 ` Minda Chen 2023-07-21 1:12 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 5/9] dt-bindings: PLDA: Add PLDA XpressRICH PCIe host controller Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:55 ` Krzysztof Kozlowski 2023-07-19 10:55 ` Krzysztof Kozlowski 2023-07-19 22:29 ` Rob Herring 2023-07-19 22:29 ` Rob Herring 2023-07-20 7:02 ` Minda Chen 2023-07-20 7:02 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 6/9] PCI: PLDA: Add host conroller platform driver Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 7/9] dt-bindings: PCI: Add StarFive JH7110 PCIe controller Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 10:56 ` Krzysztof Kozlowski 2023-07-19 10:56 ` Krzysztof Kozlowski 2023-07-19 10:20 ` [PATCH v1 8/9] PCI: PLDA: starfive: Add " Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 16:48 ` Bjorn Helgaas 2023-07-19 16:48 ` Bjorn Helgaas 2023-07-20 10:11 ` Kevin Xie 2023-07-20 10:11 ` Kevin Xie 2023-07-20 16:15 ` Bjorn Helgaas 2023-07-20 16:15 ` Bjorn Helgaas 2023-07-24 10:48 ` Kevin Xie 2023-07-24 10:48 ` Kevin Xie 2023-07-25 20:46 ` Bjorn Helgaas 2023-07-25 20:46 ` Bjorn Helgaas 2023-07-27 21:40 ` Bjorn Helgaas 2023-07-27 21:40 ` Bjorn Helgaas 2023-07-31 5:52 ` Kevin Xie 2023-07-31 5:52 ` Kevin Xie 2023-07-31 23:12 ` Bjorn Helgaas 2023-07-31 23:12 ` Bjorn Helgaas 2023-08-01 7:05 ` Pali Rohár 2023-08-01 7:05 ` Pali Rohár 2023-08-01 7:05 ` Kevin Xie 2023-08-01 7:05 ` Kevin Xie 2023-08-01 7:14 ` Pali Rohár 2023-08-01 7:14 ` Pali Rohár 2023-08-02 17:14 ` Bjorn Helgaas 2023-08-02 17:14 ` Bjorn Helgaas 2023-08-02 17:18 ` Bjorn Helgaas 2023-08-02 17:18 ` Bjorn Helgaas 2023-08-03 2:23 ` Kevin Xie 2023-08-03 2:23 ` Kevin Xie 2023-08-03 6:58 ` Pali Rohár 2023-08-03 6:58 ` Pali Rohár 2023-08-03 7:43 ` Kevin Xie 2023-08-03 7:43 ` Kevin Xie 2023-07-20 11:14 ` Conor Dooley 2023-07-20 11:14 ` Conor Dooley 2023-07-21 1:03 ` Minda Chen 2023-07-21 1:03 ` Minda Chen 2023-07-19 10:20 ` [PATCH v1 9/9] riscv: dts: starfive: add PCIe dts configuration for JH7110 Minda Chen 2023-07-19 10:20 ` Minda Chen 2023-07-19 15:26 ` [PATCH v1 0/9] Refactoring Microchip PolarFire PCIe driver Bjorn Helgaas 2023-07-19 15:26 ` Bjorn Helgaas 2023-07-20 2:15 ` Minda Chen 2023-07-20 2:15 ` Minda Chen 2023-07-20 12:12 ` Conor Dooley 2023-07-20 12:12 ` Conor Dooley 2023-07-21 9:34 ` Minda Chen 2023-07-21 9:34 ` Minda Chen 2023-07-21 9:55 ` Minda Chen 2023-07-21 9:55 ` Minda Chen 2023-07-19 16:58 ` Conor Dooley 2023-07-19 16:58 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5e4d5920-f346-a6ae-8548-f70d9fa911fe@starfivetech.com \ --to=minda.chen@starfivetech.com \ --cc=aou@eecs.berkeley.edu \ --cc=bhelgaas@google.com \ --cc=conor@kernel.org \ --cc=daire.mcnamara@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=emil.renner.berthing@canonical.com \ --cc=kevin.xie@starfivetech.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=kw@linux.com \ --cc=leyfoon.tan@starfivetech.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=lpieralisi@kernel.org \ --cc=mason.huo@starfivetech.com \ --cc=p.zabel@pengutronix.de \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.