From: Ross Lagerwall <ross.lagerwall@citrix.com> To: grub-devel@gnu.org Cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel Kiper <daniel.kiper@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com> Subject: [PATCH 6/7] efi: Allow loading multiboot modules without verification Date: Wed, 13 Mar 2024 15:07:47 +0000 [thread overview] Message-ID: <20240313150748.791236-7-ross.lagerwall@citrix.com> (raw) In-Reply-To: <20240313150748.791236-1-ross.lagerwall@citrix.com> GRUB doesn't do anything with multiboot modules except loading them and passing a pointer to the multiboot kernel. Therefore GRUB itself doesn't need to verify the module. Multiboot modules may contain code that needs to be verified. If this is the case, the expectation is that the multiboot kernel verifies the modules. For example, with Xen, the first multiboot module contains the dom0 kernel binary and Xen verifies it before starting it. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> --- grub-core/kern/efi/sb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/kern/efi/sb.c b/grub-core/kern/efi/sb.c index 8d3e413608bb..f76290d65e9f 100644 --- a/grub-core/kern/efi/sb.c +++ b/grub-core/kern/efi/sb.c @@ -171,6 +171,7 @@ shim_lock_verifier_init (grub_file_t io __attribute__ ((unused)), case GRUB_FILE_TYPE_LOADENV: case GRUB_FILE_TYPE_SAVEENV: case GRUB_FILE_TYPE_VERIFY_SIGNATURE: + case GRUB_FILE_TYPE_MULTIBOOT_MODULE: *flags = GRUB_VERIFY_FLAGS_SKIP_VERIFICATION; return GRUB_ERR_NONE; -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Ross Lagerwall via Grub-devel <grub-devel@gnu.org> To: grub-devel@gnu.org Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel Kiper <daniel.kiper@oracle.com> Subject: [PATCH 6/7] efi: Allow loading multiboot modules without verification Date: Wed, 13 Mar 2024 15:07:47 +0000 [thread overview] Message-ID: <20240313150748.791236-7-ross.lagerwall@citrix.com> (raw) In-Reply-To: <20240313150748.791236-1-ross.lagerwall@citrix.com> GRUB doesn't do anything with multiboot modules except loading them and passing a pointer to the multiboot kernel. Therefore GRUB itself doesn't need to verify the module. Multiboot modules may contain code that needs to be verified. If this is the case, the expectation is that the multiboot kernel verifies the modules. For example, with Xen, the first multiboot module contains the dom0 kernel binary and Xen verifies it before starting it. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> --- grub-core/kern/efi/sb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/kern/efi/sb.c b/grub-core/kern/efi/sb.c index 8d3e413608bb..f76290d65e9f 100644 --- a/grub-core/kern/efi/sb.c +++ b/grub-core/kern/efi/sb.c @@ -171,6 +171,7 @@ shim_lock_verifier_init (grub_file_t io __attribute__ ((unused)), case GRUB_FILE_TYPE_LOADENV: case GRUB_FILE_TYPE_SAVEENV: case GRUB_FILE_TYPE_VERIFY_SIGNATURE: + case GRUB_FILE_TYPE_MULTIBOOT_MODULE: *flags = GRUB_VERIFY_FLAGS_SKIP_VERIFICATION; return GRUB_ERR_NONE; -- 2.43.0 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2024-03-13 15:07 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-13 15:07 [PATCH 0/7] GRUB: Supporting Secure Boot of xen.gz Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-14 7:24 ` Jan Beulich 2024-03-14 7:24 ` Jan Beulich via Grub-devel 2024-03-14 8:12 ` Damien Zammit via Grub-devel 2024-03-14 8:12 ` Damien Zammit 2024-03-14 8:49 ` Vladimir 'phcoder' Serbinenko 2024-03-14 9:30 ` Ross Lagerwall 2024-03-14 9:30 ` Ross Lagerwall via Grub-devel 2024-03-14 13:37 ` Jan Beulich 2024-03-14 13:37 ` Jan Beulich via Grub-devel 2024-03-14 14:24 ` Ross Lagerwall 2024-03-14 14:24 ` Ross Lagerwall via Grub-devel 2024-03-14 14:33 ` Jan Beulich 2024-03-14 14:33 ` Jan Beulich via Grub-devel 2024-03-19 12:12 ` Roger Pau Monné 2024-03-19 12:12 ` Roger Pau Monné via Grub-devel 2024-03-19 13:18 ` Roger Pau Monné 2024-03-19 13:18 ` Roger Pau Monné via Grub-devel 2024-03-19 14:46 ` Ross Lagerwall 2024-03-19 14:46 ` Ross Lagerwall via Grub-devel 2024-03-20 11:04 ` Roger Pau Monné 2024-03-20 11:04 ` Roger Pau Monné via Grub-devel 2024-03-13 15:07 ` [PATCH 2/7] multiboot2: Allow 64-bit entry tags Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-19 10:07 ` Roger Pau Monné 2024-03-19 10:07 ` Roger Pau Monné via Grub-devel 2024-03-28 15:05 ` Ross Lagerwall 2024-03-28 15:05 ` Ross Lagerwall via Grub-devel 2024-03-28 15:41 ` Roger Pau Monné 2024-03-28 15:41 ` Roger Pau Monné via Grub-devel 2024-03-13 15:07 ` [PATCH 3/7] multiboot2: Add support for the load type header tag Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-15 7:30 ` Vladimir 'phcoder' Serbinenko 2024-03-15 7:30 ` Vladimir 'phcoder' Serbinenko 2024-03-28 14:58 ` Ross Lagerwall 2024-03-28 14:58 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 4/7] multiboot2: Add PE load support Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 5/7] multiboot2: Add support for 64-bit entry addresses Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` Ross Lagerwall [this message] 2024-03-13 15:07 ` [PATCH 6/7] efi: Allow loading multiboot modules without verification Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 7/7] verifiers: Verify after decompression Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-15 3:50 ` Michael Chang 2024-03-15 3:50 ` Michael Chang via Grub-devel 2024-03-15 7:25 ` Vladimir 'phcoder' Serbinenko 2024-03-28 14:55 ` Ross Lagerwall via Grub-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240313150748.791236-7-ross.lagerwall@citrix.com \ --to=ross.lagerwall@citrix.com \ --cc=andrew.cooper3@citrix.com \ --cc=daniel.kiper@oracle.com \ --cc=grub-devel@gnu.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.