From: Michael Chang <mchang@suse.com> To: The development of GNU GRUB <grub-devel@gnu.org> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel Kiper <daniel.kiper@oracle.com> Subject: Re: [PATCH 7/7] verifiers: Verify after decompression Date: Fri, 15 Mar 2024 11:50:02 +0800 [thread overview] Message-ID: <ujgt7gs7t37xqfffqet6yjnqz32xahkh75ed6h2zwqw5ukihsk@hkdpks6ipkcr> (raw) In-Reply-To: <20240313150748.791236-8-ross.lagerwall@citrix.com> On Wed, Mar 13, 2024 at 03:07:48PM +0000, Ross Lagerwall via Grub-devel wrote: > It is convenient and common to have binaries stored in gzip archives > (e.g. xen.gz). Verification should be run after decompression rather > than before so reorder the file filter list as appropriate. The proposed change would result in the disruption of the tpm and pgp clients within the verifier framework. Specifically, the tpm pcr prediction software relies on the integrity of raw files rather than decompressed ones. Additionally, pgp detached signatures are designed to target original files, thus necessitating the current structure to maintain functionality. Thanks, Michael > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> > --- > include/grub/file.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/file.h b/include/grub/file.h > index a5bf3a792d6f..a1ef3582bc7b 100644 > --- a/include/grub/file.h > +++ b/include/grub/file.h > @@ -182,10 +182,10 @@ extern grub_disk_read_hook_t EXPORT_VAR(grub_file_progress_hook); > /* Filters with lower ID are executed first. */ > typedef enum grub_file_filter_id > { > - GRUB_FILE_FILTER_VERIFY, > GRUB_FILE_FILTER_GZIO, > GRUB_FILE_FILTER_XZIO, > GRUB_FILE_FILTER_LZOPIO, > + GRUB_FILE_FILTER_VERIFY, > GRUB_FILE_FILTER_MAX, > GRUB_FILE_FILTER_COMPRESSION_FIRST = GRUB_FILE_FILTER_GZIO, > GRUB_FILE_FILTER_COMPRESSION_LAST = GRUB_FILE_FILTER_LZOPIO, > -- > 2.43.0 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel
WARNING: multiple messages have this Message-ID (diff)
From: Michael Chang via Grub-devel <grub-devel@gnu.org> To: The development of GNU GRUB <grub-devel@gnu.org> Cc: Michael Chang <mchang@suse.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel Kiper <daniel.kiper@oracle.com> Subject: Re: [PATCH 7/7] verifiers: Verify after decompression Date: Fri, 15 Mar 2024 11:50:02 +0800 [thread overview] Message-ID: <ujgt7gs7t37xqfffqet6yjnqz32xahkh75ed6h2zwqw5ukihsk@hkdpks6ipkcr> (raw) In-Reply-To: <20240313150748.791236-8-ross.lagerwall@citrix.com> On Wed, Mar 13, 2024 at 03:07:48PM +0000, Ross Lagerwall via Grub-devel wrote: > It is convenient and common to have binaries stored in gzip archives > (e.g. xen.gz). Verification should be run after decompression rather > than before so reorder the file filter list as appropriate. The proposed change would result in the disruption of the tpm and pgp clients within the verifier framework. Specifically, the tpm pcr prediction software relies on the integrity of raw files rather than decompressed ones. Additionally, pgp detached signatures are designed to target original files, thus necessitating the current structure to maintain functionality. Thanks, Michael > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> > --- > include/grub/file.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/file.h b/include/grub/file.h > index a5bf3a792d6f..a1ef3582bc7b 100644 > --- a/include/grub/file.h > +++ b/include/grub/file.h > @@ -182,10 +182,10 @@ extern grub_disk_read_hook_t EXPORT_VAR(grub_file_progress_hook); > /* Filters with lower ID are executed first. */ > typedef enum grub_file_filter_id > { > - GRUB_FILE_FILTER_VERIFY, > GRUB_FILE_FILTER_GZIO, > GRUB_FILE_FILTER_XZIO, > GRUB_FILE_FILTER_LZOPIO, > + GRUB_FILE_FILTER_VERIFY, > GRUB_FILE_FILTER_MAX, > GRUB_FILE_FILTER_COMPRESSION_FIRST = GRUB_FILE_FILTER_GZIO, > GRUB_FILE_FILTER_COMPRESSION_LAST = GRUB_FILE_FILTER_LZOPIO, > -- > 2.43.0 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2024-03-15 3:50 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-13 15:07 [PATCH 0/7] GRUB: Supporting Secure Boot of xen.gz Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-14 7:24 ` Jan Beulich 2024-03-14 7:24 ` Jan Beulich via Grub-devel 2024-03-14 8:12 ` Damien Zammit via Grub-devel 2024-03-14 8:12 ` Damien Zammit 2024-03-14 8:49 ` Vladimir 'phcoder' Serbinenko 2024-03-14 9:30 ` Ross Lagerwall 2024-03-14 9:30 ` Ross Lagerwall via Grub-devel 2024-03-14 13:37 ` Jan Beulich 2024-03-14 13:37 ` Jan Beulich via Grub-devel 2024-03-14 14:24 ` Ross Lagerwall 2024-03-14 14:24 ` Ross Lagerwall via Grub-devel 2024-03-14 14:33 ` Jan Beulich 2024-03-14 14:33 ` Jan Beulich via Grub-devel 2024-03-19 12:12 ` Roger Pau Monné 2024-03-19 12:12 ` Roger Pau Monné via Grub-devel 2024-03-19 13:18 ` Roger Pau Monné 2024-03-19 13:18 ` Roger Pau Monné via Grub-devel 2024-03-19 14:46 ` Ross Lagerwall 2024-03-19 14:46 ` Ross Lagerwall via Grub-devel 2024-03-20 11:04 ` Roger Pau Monné 2024-03-20 11:04 ` Roger Pau Monné via Grub-devel 2024-03-13 15:07 ` [PATCH 2/7] multiboot2: Allow 64-bit entry tags Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-19 10:07 ` Roger Pau Monné 2024-03-19 10:07 ` Roger Pau Monné via Grub-devel 2024-03-28 15:05 ` Ross Lagerwall 2024-03-28 15:05 ` Ross Lagerwall via Grub-devel 2024-03-28 15:41 ` Roger Pau Monné 2024-03-28 15:41 ` Roger Pau Monné via Grub-devel 2024-03-13 15:07 ` [PATCH 3/7] multiboot2: Add support for the load type header tag Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-15 7:30 ` Vladimir 'phcoder' Serbinenko 2024-03-15 7:30 ` Vladimir 'phcoder' Serbinenko 2024-03-28 14:58 ` Ross Lagerwall 2024-03-28 14:58 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 4/7] multiboot2: Add PE load support Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 5/7] multiboot2: Add support for 64-bit entry addresses Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 6/7] efi: Allow loading multiboot modules without verification Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-13 15:07 ` [PATCH 7/7] verifiers: Verify after decompression Ross Lagerwall 2024-03-13 15:07 ` Ross Lagerwall via Grub-devel 2024-03-15 3:50 ` Michael Chang [this message] 2024-03-15 3:50 ` Michael Chang via Grub-devel 2024-03-15 7:25 ` Vladimir 'phcoder' Serbinenko 2024-03-28 14:55 ` Ross Lagerwall via Grub-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ujgt7gs7t37xqfffqet6yjnqz32xahkh75ed6h2zwqw5ukihsk@hkdpks6ipkcr \ --to=mchang@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=daniel.kiper@oracle.com \ --cc=grub-devel@gnu.org \ --cc=ross.lagerwall@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.