From: Tomasz Figa <t.figa@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Doug Anderson" <dianders@chromium.org>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Heiko Stübner" <heiko@sntech.de>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thomas Abraham" <thomas.abraham@linaro.org>,
"Prathyush K" <prathyush.k@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers
Date: Fri, 24 May 2013 11:23:23 +0200 [thread overview]
Message-ID: <2032031.lFyZLmqevW@amdc1227> (raw)
In-Reply-To: <CACRpkdbN4Nxg2VSr0bf+h4Y2U=CmX9mijdZz+=tom9V0-i-69g@mail.gmail.com>
Hi Linus,
On Friday 24 of May 2013 11:12:00 Linus Walleij wrote:
> On Wed, May 22, 2013 at 4:03 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > Some GPIO EINT control registers needs to be preserved across
> > suspend/resume cycle. This patch extends the driver to take care of
> > this.
> >
> > Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >
> > Changes since v2:
> > - Fixed error path
> >
> > Changes since v1:
> > - Added optional debugging messages
> > - Added proper error path in initialization
>
> v2 version applied for fixes.
I posted v3 two days ago. It fixes a stupid mistake in error path I made in a
hurry and also addresses some suggestions from Doug.
> Again confirm you must really have all this. It is not looking
> good with diffstats like this for fixing regressions.
Yes. The whole series is necessary to have correct suspend/resume support of
DT-enabled Exynos boards.
Best regards,
--
Tomasz Figa
Linux Kernel Developer
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers
Date: Fri, 24 May 2013 11:23:23 +0200 [thread overview]
Message-ID: <2032031.lFyZLmqevW@amdc1227> (raw)
In-Reply-To: <CACRpkdbN4Nxg2VSr0bf+h4Y2U=CmX9mijdZz+=tom9V0-i-69g@mail.gmail.com>
Hi Linus,
On Friday 24 of May 2013 11:12:00 Linus Walleij wrote:
> On Wed, May 22, 2013 at 4:03 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > Some GPIO EINT control registers needs to be preserved across
> > suspend/resume cycle. This patch extends the driver to take care of
> > this.
> >
> > Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >
> > Changes since v2:
> > - Fixed error path
> >
> > Changes since v1:
> > - Added optional debugging messages
> > - Added proper error path in initialization
>
> v2 version applied for fixes.
I posted v3 two days ago. It fixes a stupid mistake in error path I made in a
hurry and also addresses some suggestions from Doug.
> Again confirm you must really have all this. It is not looking
> good with diffstats like this for fixing regressions.
Yes. The whole series is necessary to have correct suspend/resume support of
DT-enabled Exynos boards.
Best regards,
--
Tomasz Figa
Linux Kernel Developer
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-05-24 9:23 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 16:24 [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 16:24 ` [PATCH 1/6] pinctrl: exynos: Add support for set_irq_wake of wake-up EINTs Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:17 ` Doug Anderson
2013-05-17 19:17 ` Doug Anderson
2013-05-21 11:25 ` Linus Walleij
2013-05-21 11:25 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:22 ` Doug Anderson
2013-05-17 19:22 ` Doug Anderson
2013-05-17 19:49 ` Tomasz Figa
2013-05-17 19:49 ` Tomasz Figa
2013-05-21 11:27 ` Linus Walleij
2013-05-21 11:27 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-17 20:23 ` Tomasz Figa
2013-05-17 20:23 ` Tomasz Figa
2013-05-17 20:56 ` Doug Anderson
2013-05-17 20:56 ` Doug Anderson
2013-05-17 21:07 ` Tomasz Figa
2013-05-17 21:07 ` Tomasz Figa
2013-05-21 11:29 ` Linus Walleij
2013-05-21 11:29 ` Linus Walleij
2013-05-21 13:15 ` Tomasz Figa
2013-05-21 13:15 ` Tomasz Figa
2013-05-21 17:06 ` Tomasz Figa
2013-05-21 17:06 ` Tomasz Figa
2013-06-10 14:45 ` Tomasz Figa
2013-06-10 14:45 ` Tomasz Figa
2013-06-10 16:13 ` Linus Walleij
2013-06-10 16:13 ` Linus Walleij
2013-06-11 7:45 ` Olof Johansson
2013-06-11 7:45 ` Olof Johansson
2013-06-11 8:21 ` Olof Johansson
2013-06-11 8:21 ` Olof Johansson
2013-06-12 0:15 ` Tomasz Figa
2013-06-12 0:15 ` Tomasz Figa
2013-06-12 0:20 ` Olof Johansson
2013-06-12 0:20 ` Olof Johansson
2013-05-17 16:24 ` [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-17 20:51 ` Tomasz Figa
2013-05-17 20:51 ` Tomasz Figa
2013-05-24 9:07 ` Linus Walleij
2013-05-24 9:07 ` Linus Walleij
2013-05-24 9:20 ` Tomasz Figa
2013-05-24 9:20 ` Tomasz Figa
2013-05-17 16:24 ` [PATCH 5/6] pinctrl: samsung: Allow per-bank SoC-specific private data Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-24 9:09 ` Linus Walleij
2013-05-24 9:09 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:25 ` Doug Anderson
2013-05-17 19:25 ` Doug Anderson
2013-05-17 20:34 ` Tomasz Figa
2013-05-17 20:34 ` Tomasz Figa
2013-05-17 21:18 ` Doug Anderson
2013-05-17 21:18 ` Doug Anderson
2013-05-21 17:05 ` [PATCH v2 " Tomasz Figa
2013-05-21 17:05 ` Tomasz Figa
2013-05-22 4:46 ` Doug Anderson
2013-05-22 4:46 ` Doug Anderson
2013-05-22 13:32 ` Tomasz Figa
2013-05-22 13:32 ` Tomasz Figa
2013-05-22 14:03 ` [PATCH v3 " Tomasz Figa
2013-05-22 14:03 ` Tomasz Figa
2013-05-22 15:57 ` Doug Anderson
2013-05-22 15:57 ` Doug Anderson
2013-05-24 9:12 ` Linus Walleij
2013-05-24 9:12 ` Linus Walleij
2013-05-24 9:23 ` Tomasz Figa [this message]
2013-05-24 9:23 ` Tomasz Figa
2013-05-20 9:35 ` [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tushar Behera
2013-05-20 9:35 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2032031.lFyZLmqevW@amdc1227 \
--to=t.figa@samsung.com \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=prathyush.k@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.