From: Doug Anderson <dianders@chromium.org> To: Tomasz Figa <tomasz.figa@gmail.com> Cc: "Tomasz Figa" <t.figa@samsung.com>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Kukjin Kim" <kgene.kim@samsung.com>, "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>, "Heiko Stübner" <heiko@sntech.de>, "Stephen Warren" <swarren@wwwdotorg.org>, "Thomas Abraham" <thomas.abraham@linaro.org>, "Linus Walleij" <linus.walleij@linaro.org>, "Prathyush K" <prathyush.k@samsung.com>, "Kyungmin Park" <kyungmin.park@samsung.com> Subject: Re: [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Date: Fri, 17 May 2013 13:56:39 -0700 [thread overview] Message-ID: <CAD=FV=XcmzogZc9mWQ+FSr9dg9jML-ACUJY2M2-s+_rBw9gMzQ@mail.gmail.com> (raw) In-Reply-To: <4241187.TFCdy2kUT6@flatron> Tomasz, On Fri, May 17, 2013 at 1:23 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> I'd rather see you modify patch set #2 to provide some function to >> retrieve just the eint mask and then use it here. Your patch removes >> this test and doesn't replace it with anything. If you moved this >> test to pinctrl directly you'd lose the test against intallow. > > Well, looking from the perspective of status before my patch, it just > bypasses a test that is incorrect on DT-enabled platforms. True. What was there before was broken and this avoids the broken code. > I agree that this test is rather reasonable to have, but it would require > defining a new interface and moving all platforms to it, which for now > would be a bit of overkill. It seems like you could use the same type of solution as patch set #2? ...oh, but that's only for exynos! I guess we would need something similar for other platforms. ...and until we do those other platforms (including S3C64xx, I think) are still using the old s3c_irqwake_eintmask, right? ...so overall your patch series only fully fixes exynos, though it does make other platforms less broken which is a plus. :) > IMHO a separate series that sanitizes the whole PM handling in plat- > samsung, including a rework of this check to make it cover all platforms > in a generic and multiplatform-friendly way. What do you think? Sure, I think that would be OK. >> Ah, the important part here is the "saved", not the "save"! The >> "save" should get a NULL chip for all GPIOs and effectively be a >> no-op. >> >> Skipping the "saved" is important of s3c64xx and s5p64x0 where the >> "saved" seems to transition things over to powerdown mode. Hopefully >> a future patch of yours adds that back for those platforms in the >> pinmux world. ...same for restore. > > S3C64xx can be switched to power down pin configuration manually, but if > you don't do it, it will activate it automatically after entering sleep > mode. How would restore work in that case? I'd imagine that it would automatically switch out of the powerdown config at wakeup before running software? That doesn't seem like a great idea. I think that to make S3C64xx work properly we'd need to solve. I wouldn't be opposed to a re-spin to address some of the above, but I also won't object to this landing and remaining issues being addressed in future patches. This patch definitely does make things better and no worse. :) On exynos5250-snow (pinmux backported to 3.8): Tested-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Doug Anderson <dianders@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Date: Fri, 17 May 2013 13:56:39 -0700 [thread overview] Message-ID: <CAD=FV=XcmzogZc9mWQ+FSr9dg9jML-ACUJY2M2-s+_rBw9gMzQ@mail.gmail.com> (raw) In-Reply-To: <4241187.TFCdy2kUT6@flatron> Tomasz, On Fri, May 17, 2013 at 1:23 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> I'd rather see you modify patch set #2 to provide some function to >> retrieve just the eint mask and then use it here. Your patch removes >> this test and doesn't replace it with anything. If you moved this >> test to pinctrl directly you'd lose the test against intallow. > > Well, looking from the perspective of status before my patch, it just > bypasses a test that is incorrect on DT-enabled platforms. True. What was there before was broken and this avoids the broken code. > I agree that this test is rather reasonable to have, but it would require > defining a new interface and moving all platforms to it, which for now > would be a bit of overkill. It seems like you could use the same type of solution as patch set #2? ...oh, but that's only for exynos! I guess we would need something similar for other platforms. ...and until we do those other platforms (including S3C64xx, I think) are still using the old s3c_irqwake_eintmask, right? ...so overall your patch series only fully fixes exynos, though it does make other platforms less broken which is a plus. :) > IMHO a separate series that sanitizes the whole PM handling in plat- > samsung, including a rework of this check to make it cover all platforms > in a generic and multiplatform-friendly way. What do you think? Sure, I think that would be OK. >> Ah, the important part here is the "saved", not the "save"! The >> "save" should get a NULL chip for all GPIOs and effectively be a >> no-op. >> >> Skipping the "saved" is important of s3c64xx and s5p64x0 where the >> "saved" seems to transition things over to powerdown mode. Hopefully >> a future patch of yours adds that back for those platforms in the >> pinmux world. ...same for restore. > > S3C64xx can be switched to power down pin configuration manually, but if > you don't do it, it will activate it automatically after entering sleep > mode. How would restore work in that case? I'd imagine that it would automatically switch out of the powerdown config at wakeup before running software? That doesn't seem like a great idea. I think that to make S3C64xx work properly we'd need to solve. I wouldn't be opposed to a re-spin to address some of the above, but I also won't object to this landing and remaining issues being addressed in future patches. This patch definitely does make things better and no worse. :) On exynos5250-snow (pinmux backported to 3.8): Tested-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Doug Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2013-05-17 20:56 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-17 16:24 [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 16:24 ` [PATCH 1/6] pinctrl: exynos: Add support for set_irq_wake of wake-up EINTs Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:17 ` Doug Anderson 2013-05-17 19:17 ` Doug Anderson 2013-05-21 11:25 ` Linus Walleij 2013-05-21 11:25 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:22 ` Doug Anderson 2013-05-17 19:22 ` Doug Anderson 2013-05-17 19:49 ` Tomasz Figa 2013-05-17 19:49 ` Tomasz Figa 2013-05-21 11:27 ` Linus Walleij 2013-05-21 11:27 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-17 20:23 ` Tomasz Figa 2013-05-17 20:23 ` Tomasz Figa 2013-05-17 20:56 ` Doug Anderson [this message] 2013-05-17 20:56 ` Doug Anderson 2013-05-17 21:07 ` Tomasz Figa 2013-05-17 21:07 ` Tomasz Figa 2013-05-21 11:29 ` Linus Walleij 2013-05-21 11:29 ` Linus Walleij 2013-05-21 13:15 ` Tomasz Figa 2013-05-21 13:15 ` Tomasz Figa 2013-05-21 17:06 ` Tomasz Figa 2013-05-21 17:06 ` Tomasz Figa 2013-06-10 14:45 ` Tomasz Figa 2013-06-10 14:45 ` Tomasz Figa 2013-06-10 16:13 ` Linus Walleij 2013-06-10 16:13 ` Linus Walleij 2013-06-11 7:45 ` Olof Johansson 2013-06-11 7:45 ` Olof Johansson 2013-06-11 8:21 ` Olof Johansson 2013-06-11 8:21 ` Olof Johansson 2013-06-12 0:15 ` Tomasz Figa 2013-06-12 0:15 ` Tomasz Figa 2013-06-12 0:20 ` Olof Johansson 2013-06-12 0:20 ` Olof Johansson 2013-05-17 16:24 ` [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-17 20:51 ` Tomasz Figa 2013-05-17 20:51 ` Tomasz Figa 2013-05-24 9:07 ` Linus Walleij 2013-05-24 9:07 ` Linus Walleij 2013-05-24 9:20 ` Tomasz Figa 2013-05-24 9:20 ` Tomasz Figa 2013-05-17 16:24 ` [PATCH 5/6] pinctrl: samsung: Allow per-bank SoC-specific private data Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:24 ` Doug Anderson 2013-05-17 19:24 ` Doug Anderson 2013-05-24 9:09 ` Linus Walleij 2013-05-24 9:09 ` Linus Walleij 2013-05-17 16:24 ` [PATCH 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers Tomasz Figa 2013-05-17 16:24 ` Tomasz Figa 2013-05-17 19:25 ` Doug Anderson 2013-05-17 19:25 ` Doug Anderson 2013-05-17 20:34 ` Tomasz Figa 2013-05-17 20:34 ` Tomasz Figa 2013-05-17 21:18 ` Doug Anderson 2013-05-17 21:18 ` Doug Anderson 2013-05-21 17:05 ` [PATCH v2 " Tomasz Figa 2013-05-21 17:05 ` Tomasz Figa 2013-05-22 4:46 ` Doug Anderson 2013-05-22 4:46 ` Doug Anderson 2013-05-22 13:32 ` Tomasz Figa 2013-05-22 13:32 ` Tomasz Figa 2013-05-22 14:03 ` [PATCH v3 " Tomasz Figa 2013-05-22 14:03 ` Tomasz Figa 2013-05-22 15:57 ` Doug Anderson 2013-05-22 15:57 ` Doug Anderson 2013-05-24 9:12 ` Linus Walleij 2013-05-24 9:12 ` Linus Walleij 2013-05-24 9:23 ` Tomasz Figa 2013-05-24 9:23 ` Tomasz Figa 2013-05-20 9:35 ` [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tushar Behera 2013-05-20 9:35 ` Tushar Behera
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=XcmzogZc9mWQ+FSr9dg9jML-ACUJY2M2-s+_rBw9gMzQ@mail.gmail.com' \ --to=dianders@chromium.org \ --cc=arnd@arndb.de \ --cc=heiko@sntech.de \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=olof@lixom.net \ --cc=prathyush.k@samsung.com \ --cc=swarren@wwwdotorg.org \ --cc=t.figa@samsung.com \ --cc=thomas.abraham@linaro.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.