From: Doug Anderson <dianders@chromium.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: "Tomasz Figa" <tomasz.figa@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Heiko Stübner" <heiko@sntech.de>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thomas Abraham" <thomas.abraham@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Prathyush K" <prathyush.k@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers
Date: Tue, 21 May 2013 21:46:35 -0700 [thread overview]
Message-ID: <CAD=FV=VYhBP+V6SQt5SkFZszdVxSJ6AZk-C-zx1Di-RZBYhGvw@mail.gmail.com> (raw)
In-Reply-To: <4536937.hnhaYZLnaG@amdc1227>
Tomasz,
On Tue, May 21, 2013 at 10:05 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> return 0;
> +
> +err_domains:
> + bank = d->ctrl->pin_banks;
> + for (undo = 0; undo < i; ++undo) {
++bank is missing, I think. This will free the same bank many times.
optional: could also avoid extra 'undo' variable and remove in reverse
order by changing i to signed and counting down to 0.
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers
Date: Tue, 21 May 2013 21:46:35 -0700 [thread overview]
Message-ID: <CAD=FV=VYhBP+V6SQt5SkFZszdVxSJ6AZk-C-zx1Di-RZBYhGvw@mail.gmail.com> (raw)
In-Reply-To: <4536937.hnhaYZLnaG@amdc1227>
Tomasz,
On Tue, May 21, 2013 at 10:05 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> return 0;
> +
> +err_domains:
> + bank = d->ctrl->pin_banks;
> + for (undo = 0; undo < i; ++undo) {
++bank is missing, I think. This will free the same bank many times.
optional: could also avoid extra 'undo' variable and remove in reverse
order by changing i to signed and counting down to 0.
-Doug
next prev parent reply other threads:[~2013-05-22 4:46 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 16:24 [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 16:24 ` [PATCH 1/6] pinctrl: exynos: Add support for set_irq_wake of wake-up EINTs Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:17 ` Doug Anderson
2013-05-17 19:17 ` Doug Anderson
2013-05-21 11:25 ` Linus Walleij
2013-05-21 11:25 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:22 ` Doug Anderson
2013-05-17 19:22 ` Doug Anderson
2013-05-17 19:49 ` Tomasz Figa
2013-05-17 19:49 ` Tomasz Figa
2013-05-21 11:27 ` Linus Walleij
2013-05-21 11:27 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-17 20:23 ` Tomasz Figa
2013-05-17 20:23 ` Tomasz Figa
2013-05-17 20:56 ` Doug Anderson
2013-05-17 20:56 ` Doug Anderson
2013-05-17 21:07 ` Tomasz Figa
2013-05-17 21:07 ` Tomasz Figa
2013-05-21 11:29 ` Linus Walleij
2013-05-21 11:29 ` Linus Walleij
2013-05-21 13:15 ` Tomasz Figa
2013-05-21 13:15 ` Tomasz Figa
2013-05-21 17:06 ` Tomasz Figa
2013-05-21 17:06 ` Tomasz Figa
2013-06-10 14:45 ` Tomasz Figa
2013-06-10 14:45 ` Tomasz Figa
2013-06-10 16:13 ` Linus Walleij
2013-06-10 16:13 ` Linus Walleij
2013-06-11 7:45 ` Olof Johansson
2013-06-11 7:45 ` Olof Johansson
2013-06-11 8:21 ` Olof Johansson
2013-06-11 8:21 ` Olof Johansson
2013-06-12 0:15 ` Tomasz Figa
2013-06-12 0:15 ` Tomasz Figa
2013-06-12 0:20 ` Olof Johansson
2013-06-12 0:20 ` Olof Johansson
2013-05-17 16:24 ` [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-17 20:51 ` Tomasz Figa
2013-05-17 20:51 ` Tomasz Figa
2013-05-24 9:07 ` Linus Walleij
2013-05-24 9:07 ` Linus Walleij
2013-05-24 9:20 ` Tomasz Figa
2013-05-24 9:20 ` Tomasz Figa
2013-05-17 16:24 ` [PATCH 5/6] pinctrl: samsung: Allow per-bank SoC-specific private data Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:24 ` Doug Anderson
2013-05-17 19:24 ` Doug Anderson
2013-05-24 9:09 ` Linus Walleij
2013-05-24 9:09 ` Linus Walleij
2013-05-17 16:24 ` [PATCH 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers Tomasz Figa
2013-05-17 16:24 ` Tomasz Figa
2013-05-17 19:25 ` Doug Anderson
2013-05-17 19:25 ` Doug Anderson
2013-05-17 20:34 ` Tomasz Figa
2013-05-17 20:34 ` Tomasz Figa
2013-05-17 21:18 ` Doug Anderson
2013-05-17 21:18 ` Doug Anderson
2013-05-21 17:05 ` [PATCH v2 " Tomasz Figa
2013-05-21 17:05 ` Tomasz Figa
2013-05-22 4:46 ` Doug Anderson [this message]
2013-05-22 4:46 ` Doug Anderson
2013-05-22 13:32 ` Tomasz Figa
2013-05-22 13:32 ` Tomasz Figa
2013-05-22 14:03 ` [PATCH v3 " Tomasz Figa
2013-05-22 14:03 ` Tomasz Figa
2013-05-22 15:57 ` Doug Anderson
2013-05-22 15:57 ` Doug Anderson
2013-05-24 9:12 ` Linus Walleij
2013-05-24 9:12 ` Linus Walleij
2013-05-24 9:23 ` Tomasz Figa
2013-05-24 9:23 ` Tomasz Figa
2013-05-20 9:35 ` [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tushar Behera
2013-05-20 9:35 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VYhBP+V6SQt5SkFZszdVxSJ6AZk-C-zx1Di-RZBYhGvw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=prathyush.k@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.