From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Hui Wang <jason77.wang@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 07:22:14 +0200 [thread overview]
Message-ID: <20459.59910.783086.760997@ipc1.ka-ro> (raw)
In-Reply-To: <1340853701-4488-3-git-send-email-shawn.guo@linaro.org>
Hi,
Shawn Guo writes:
> The flexcan driver has function pointer transceiver_switch defined in
> flexcan_platform_data for platform codes to hook up their transceiver
> switch implementation. However this does not cope with device tree
> probe.
>
> It's been observed that platforms mostly use gpios to control the
> switch of flexcan transceiver, like enable and standby. The patch
> adds transceiver switch gpios support into flexcan driver, so that
> platforms booting from device tree can just define properties
> phy-enable-gpios and phy-standby-gpios to have flexcan driver control
> the gpios.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> .../devicetree/bindings/net/can/fsl-flexcan.txt | 2 +
> drivers/net/can/flexcan.c | 62 ++++++++++++++++++++
> 2 files changed, 64 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 8ff324e..e0dbac7 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -15,6 +15,8 @@ Required properties:
> Optional properties:
>
> - clock-frequency : The oscillator frequency driving the flexcan device
> +- phy-enable-gpios : Specify the gpio used to enable phy
> +- phy-standby-gpios : Specify the gpio used to put phy into STANDBY mode
>
Why the plural form 'gpios'? It's just one gpio.
s/gpios/gpio/ ?
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support
Date: Thu, 28 Jun 2012 07:22:14 +0200 [thread overview]
Message-ID: <20459.59910.783086.760997@ipc1.ka-ro> (raw)
In-Reply-To: <1340853701-4488-3-git-send-email-shawn.guo@linaro.org>
Hi,
Shawn Guo writes:
> The flexcan driver has function pointer transceiver_switch defined in
> flexcan_platform_data for platform codes to hook up their transceiver
> switch implementation. However this does not cope with device tree
> probe.
>
> It's been observed that platforms mostly use gpios to control the
> switch of flexcan transceiver, like enable and standby. The patch
> adds transceiver switch gpios support into flexcan driver, so that
> platforms booting from device tree can just define properties
> phy-enable-gpios and phy-standby-gpios to have flexcan driver control
> the gpios.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> .../devicetree/bindings/net/can/fsl-flexcan.txt | 2 +
> drivers/net/can/flexcan.c | 62 ++++++++++++++++++++
> 2 files changed, 64 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 8ff324e..e0dbac7 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -15,6 +15,8 @@ Required properties:
> Optional properties:
>
> - clock-frequency : The oscillator frequency driving the flexcan device
> +- phy-enable-gpios : Specify the gpio used to enable phy
> +- phy-standby-gpios : Specify the gpio used to put phy into STANDBY mode
>
Why the plural form 'gpios'? It's just one gpio.
s/gpios/gpio/ ?
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2012-06-28 5:22 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 3:21 [PATCH v2 0/2] flexcan driver updates Shawn Guo
2012-06-28 3:21 ` Shawn Guo
2012-06-28 3:21 ` [PATCH v2 1/2] net: flexcan: clock-frequency is optional for device tree probe Shawn Guo
2012-06-28 3:21 ` Shawn Guo
2012-06-28 11:23 ` Dong Aisheng
2012-06-28 11:23 ` Dong Aisheng
2012-06-28 3:21 ` [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support Shawn Guo
2012-06-28 3:21 ` Shawn Guo
2012-06-28 5:22 ` Lothar Waßmann [this message]
2012-06-28 5:22 ` Lothar Waßmann
2012-06-28 5:30 ` Shawn Guo
2012-06-28 5:30 ` Shawn Guo
2012-06-28 6:14 ` Hui Wang
2012-06-28 6:14 ` Hui Wang
2012-06-28 6:34 ` Shawn Guo
2012-06-28 6:34 ` Shawn Guo
2012-06-28 7:01 ` Hui Wang
2012-06-28 7:01 ` Hui Wang
2012-06-28 10:32 ` Marc Kleine-Budde
2012-06-28 10:32 ` Marc Kleine-Budde
2012-06-28 10:31 ` Marc Kleine-Budde
2012-06-28 10:31 ` Marc Kleine-Budde
2012-06-28 11:21 ` Shawn Guo
2012-06-28 11:21 ` Shawn Guo
2012-06-28 11:29 ` Marc Kleine-Budde
2012-06-28 11:29 ` Marc Kleine-Budde
2012-06-28 11:41 ` Shawn Guo
2012-06-28 11:41 ` Shawn Guo
2012-06-28 11:52 ` Shawn Guo
2012-06-28 11:52 ` Shawn Guo
2012-06-28 12:05 ` Shawn Guo
2012-06-28 12:05 ` Shawn Guo
2012-06-28 12:11 ` Dong Aisheng
2012-06-28 12:11 ` Dong Aisheng
2012-06-28 12:19 ` Lothar Waßmann
2012-06-28 12:19 ` Lothar Waßmann
2012-06-28 12:07 ` Lothar Waßmann
2012-06-28 12:07 ` Lothar Waßmann
2012-06-28 12:13 ` Shawn Guo
2012-06-28 12:13 ` Shawn Guo
2012-06-28 12:24 ` Lothar Waßmann
2012-06-28 12:24 ` Lothar Waßmann
2012-07-02 2:55 ` Hui Wang
2012-07-02 2:55 ` Hui Wang
2012-06-28 12:08 ` Kurt Van Dijck
2012-06-28 12:08 ` Kurt Van Dijck
2012-06-28 12:10 ` Marc Kleine-Budde
2012-06-28 12:10 ` Marc Kleine-Budde
2012-06-28 12:16 ` Shawn Guo
2012-06-28 12:16 ` Shawn Guo
2012-06-28 11:39 ` Dong Aisheng
2012-06-28 11:39 ` Dong Aisheng
2012-06-28 11:33 ` Dong Aisheng
2012-06-28 11:33 ` Dong Aisheng
2012-06-28 11:46 ` Shawn Guo
2012-06-28 11:46 ` Shawn Guo
2012-06-28 11:48 ` Dong Aisheng
2012-06-28 11:48 ` Dong Aisheng
2012-06-28 12:00 ` Shawn Guo
2012-06-28 12:00 ` Shawn Guo
2012-06-28 12:02 ` Dong Aisheng
2012-06-28 12:02 ` Dong Aisheng
2012-06-28 12:19 ` Shawn Guo
2012-06-28 12:19 ` Shawn Guo
2012-06-28 12:05 ` Marc Kleine-Budde
2012-06-28 12:05 ` Marc Kleine-Budde
2012-06-28 12:18 ` Dong Aisheng
2012-06-28 12:18 ` Dong Aisheng
2012-06-28 12:32 ` Lothar Waßmann
2012-06-28 12:32 ` Lothar Waßmann
2012-06-28 12:40 ` Shawn Guo
2012-06-28 12:40 ` Shawn Guo
2012-06-28 12:47 ` Dong Aisheng
2012-06-28 12:47 ` Dong Aisheng
2012-06-28 12:39 ` Shawn Guo
2012-06-28 12:39 ` Shawn Guo
2012-06-29 9:27 ` Marc Kleine-Budde
2012-06-29 9:27 ` Marc Kleine-Budde
[not found] ` <502226AB.4050205@gmail.com>
2012-08-08 9:55 ` Marc Kleine-Budde
2012-08-09 2:39 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20459.59910.783086.760997@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=davem@davemloft.net \
--cc=jason77.wang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.