From: Arnd Bergmann <arnd@arndb.de>
To: Bintian Wang <bintian.wang@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
khilman@linaro.org, mturquette@linaro.org,
rob.herring@linaro.org, zhangfei.gao@linaro.org,
haojian.zhuang@linaro.org, xuwei5@hisilicon.com,
jh80.chung@samsung.com, olof@lixom.net, yanhaifeng@gmail.com,
sboyd@codeaurora.org, xuejiancheng@huawei.com,
sledge.yanwei@huawei.com, tomeu.vizoso@collabora.com,
linux@arm.linux.org.uk, guodong.xu@linaro.org,
jorge.ramirez-ortiz@linaro.org, tyler.baker@linaro.org,
xuyiping@hisilicon.com, wangbinghui@hisilicon.com,
zhenwei.wang@hisilicon.com, victor.lixin@hisilicon.com,
puck.chen@hisilicon.com, dan.zhao@hisilicon.com,
huxinwei@huawei.com, z.liuxinliang@huawei.com,
heyunlei@huawei.com, kong.kongxinwei@hisilicon.com,
btw@mail.itp.ac.cn, w.f@huawei.com, liguozhu@hisilicon.com
Subject: Re: [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC
Date: Mon, 13 Apr 2015 15:30:23 +0200 [thread overview]
Message-ID: <2254597.TWaxeZsKvK@wuerfel> (raw)
In-Reply-To: <1428916660-25910-5-git-send-email-bintian.wang@huawei.com>
On Monday 13 April 2015 17:17:38 Bintian Wang wrote:
> +#define HI6220_CFG_CSI2PHY 8
> +#define HI6220_ISP_SCLK_GATE 9
> +#define HI6220_ISP_SCLK_GATE1 10
> +#define HI6220_ADE_CORE_GATE 11
> +#define HI6220_CODEC_VPU_GATE 12
> +#define HI6220_MED_SYSPLL 13
> +
> +/* mux clocks */
> +#define HI6220_1440_1200 20
> +#define HI6220_1000_1200 21
> +#define HI6220_1000_1440 22
> +
> +/* divider clocks */
> +#define HI6220_CODEC_JPEG 30
> +#define HI6220_ISP_SCLK_SRC 31
> +#define HI6220_ISP_SCLK1 32
>
The numbers seem rather arbitrary, and you have both holes as well as duplicate
numbers here. I would suggest you do one of two things instead:
a) have a separate header file per clock driver and make all the
numbers unique and consecutive within that header
b) use the same numbers as the hardware registers so you can put the
numbers directly into the dts and don't need a header to create
an artificial ABI between the clock driver and the boot loader.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Bintian Wang <bintian.wang@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
khilman@linaro.org, mturquette@linaro.org,
rob.herring@linaro.org, zhangfei.gao@linaro.org,
haojian.zhuang@linaro.org, xuwei5@hisilicon.com,
jh80.chung@samsung.com, olof@lixom.net, yanhaifeng@gmail.com,
sboyd@codeaurora.org, xuejiancheng@huawei.com,
sledge.yanwei@huawei.com, tomeu.vizoso@collabora.com,
linux@arm.linux.org.uk, guodong.xu@linaro.org,
jorge.ramirez-ortiz@linaro.org, tyler.baker@linaro.org,
xuyiping@hisilicon.com, wangbinghui@hisilicon.com,
zhenwei.wang@hisilicon.com, victor.lixin@hisilicon.com,
puck.chen@hisilicon.com, dan.zhao@hisilicon.com,
huxinwei@huawei.com, z.liuxinliang@huawei.com, heyunlei@huawe
Subject: Re: [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC
Date: Mon, 13 Apr 2015 15:30:23 +0200 [thread overview]
Message-ID: <2254597.TWaxeZsKvK@wuerfel> (raw)
In-Reply-To: <1428916660-25910-5-git-send-email-bintian.wang@huawei.com>
On Monday 13 April 2015 17:17:38 Bintian Wang wrote:
> +#define HI6220_CFG_CSI2PHY 8
> +#define HI6220_ISP_SCLK_GATE 9
> +#define HI6220_ISP_SCLK_GATE1 10
> +#define HI6220_ADE_CORE_GATE 11
> +#define HI6220_CODEC_VPU_GATE 12
> +#define HI6220_MED_SYSPLL 13
> +
> +/* mux clocks */
> +#define HI6220_1440_1200 20
> +#define HI6220_1000_1200 21
> +#define HI6220_1000_1440 22
> +
> +/* divider clocks */
> +#define HI6220_CODEC_JPEG 30
> +#define HI6220_ISP_SCLK_SRC 31
> +#define HI6220_ISP_SCLK1 32
>
The numbers seem rather arbitrary, and you have both holes as well as duplicate
numbers here. I would suggest you do one of two things instead:
a) have a separate header file per clock driver and make all the
numbers unique and consecutive within that header
b) use the same numbers as the hardware registers so you can put the
numbers directly into the dts and don't need a header to create
an artificial ABI between the clock driver and the boot loader.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC
Date: Mon, 13 Apr 2015 15:30:23 +0200 [thread overview]
Message-ID: <2254597.TWaxeZsKvK@wuerfel> (raw)
In-Reply-To: <1428916660-25910-5-git-send-email-bintian.wang@huawei.com>
On Monday 13 April 2015 17:17:38 Bintian Wang wrote:
> +#define HI6220_CFG_CSI2PHY 8
> +#define HI6220_ISP_SCLK_GATE 9
> +#define HI6220_ISP_SCLK_GATE1 10
> +#define HI6220_ADE_CORE_GATE 11
> +#define HI6220_CODEC_VPU_GATE 12
> +#define HI6220_MED_SYSPLL 13
> +
> +/* mux clocks */
> +#define HI6220_1440_1200 20
> +#define HI6220_1000_1200 21
> +#define HI6220_1000_1440 22
> +
> +/* divider clocks */
> +#define HI6220_CODEC_JPEG 30
> +#define HI6220_ISP_SCLK_SRC 31
> +#define HI6220_ISP_SCLK1 32
>
The numbers seem rather arbitrary, and you have both holes as well as duplicate
numbers here. I would suggest you do one of two things instead:
a) have a separate header file per clock driver and make all the
numbers unique and consecutive within that header
b) use the same numbers as the hardware registers so you can put the
numbers directly into the dts and don't need a header to create
an artificial ABI between the clock driver and the boot loader.
Arnd
next prev parent reply other threads:[~2015-04-13 13:31 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 9:17 [PATCH v2 0/6] arm64,hi6220: Enable Hisilicon Hi6220 SoC Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` [PATCH v2 1/6] arm64: Enable Hisilicon ARMv8 SoC family in Kconfig and defconfig Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-20 21:10 ` Kevin Hilman
2015-04-20 21:10 ` Kevin Hilman
2015-04-20 21:10 ` Kevin Hilman
2015-04-21 0:39 ` Bintian
2015-04-21 0:39 ` Bintian
2015-04-21 0:39 ` Bintian
2015-04-13 9:17 ` [PATCH v2 2/6] arm64: hi6220: Document devicetree bindings for Hisilicon hi6220 SoC Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 15:32 ` Arnd Bergmann
2015-04-13 15:32 ` Arnd Bergmann
2015-04-13 15:32 ` Arnd Bergmann
2015-04-14 3:35 ` Bintian
2015-04-14 3:35 ` Bintian
2015-04-14 3:35 ` Bintian
2015-04-14 10:19 ` Arnd Bergmann
2015-04-14 10:19 ` Arnd Bergmann
2015-04-14 10:19 ` Arnd Bergmann
2015-04-14 12:37 ` Bintian
2015-04-14 12:37 ` Bintian
2015-04-14 12:37 ` Bintian
2015-04-14 13:20 ` Arnd Bergmann
2015-04-14 13:20 ` Arnd Bergmann
2015-04-14 13:20 ` Arnd Bergmann
2015-04-14 14:37 ` Brent Wang
2015-04-14 14:37 ` Brent Wang
2015-04-14 14:37 ` Brent Wang
2015-04-13 9:17 ` [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 11:56 ` Paul Bolle
2015-04-13 11:56 ` Paul Bolle
2015-04-13 11:56 ` Paul Bolle
2015-04-13 13:17 ` Bintian
2015-04-13 13:17 ` Bintian
2015-04-13 13:17 ` Bintian
2015-04-13 14:15 ` Paul Bolle
2015-04-13 14:15 ` Paul Bolle
2015-04-13 14:15 ` Paul Bolle
2015-04-13 13:30 ` Arnd Bergmann [this message]
2015-04-13 13:30 ` Arnd Bergmann
2015-04-13 13:30 ` Arnd Bergmann
2015-04-13 13:57 ` Bintian
2015-04-13 13:57 ` Bintian
2015-04-13 13:57 ` Bintian
2015-04-13 15:34 ` Arnd Bergmann
2015-04-13 15:34 ` Arnd Bergmann
2015-04-13 15:34 ` Arnd Bergmann
2015-04-14 8:53 ` YiPing Xu
2015-04-14 8:53 ` YiPing Xu
2015-04-14 8:53 ` YiPing Xu
2015-04-13 9:17 ` [PATCH v2 5/6] arm64: Kconfig: Add clock support to ARCH_HISI Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` [PATCH v2 6/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-13 9:17 ` Bintian Wang
2015-04-14 14:44 ` Arnd Bergmann
2015-04-14 14:44 ` Arnd Bergmann
2015-04-14 14:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2254597.TWaxeZsKvK@wuerfel \
--to=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=btw@mail.itp.ac.cn \
--cc=catalin.marinas@arm.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=heyunlei@huawei.com \
--cc=huxinwei@huawei.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khilman@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=puck.chen@hisilicon.com \
--cc=rob.herring@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sledge.yanwei@huawei.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tyler.baker@linaro.org \
--cc=victor.lixin@hisilicon.com \
--cc=w.f@huawei.com \
--cc=wangbinghui@hisilicon.com \
--cc=will.deacon@arm.com \
--cc=xuejiancheng@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yanhaifeng@gmail.com \
--cc=z.liuxinliang@huawei.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhenwei.wang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.