All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Bintian <bintian.wang@huawei.com>,
	mark.rutland@arm.com, dan.zhao@hisilicon.com, btw@mail.itp.ac.cn,
	catalin.marinas@arm.com, wangbinghui@hisilicon.com,
	will.deacon@arm.com, huxinwei@huawei.com,
	haojian.zhuang@linaro.org, yanhaifeng@gmail.com,
	rob.herring@linaro.org, mturquette@linaro.org,
	xuwei5@hisilicon.com, jh80.chung@samsung.com,
	sledge.yanwei@huawei.com, kong.kongxinwei@hisilicon.com,
	heyunlei@huawei.com, w.f@huawei.com, zhangfei.gao@linaro.org,
	z.liuxinliang@huawei.com, devicetree@vger.kernel.org,
	khilman@linaro.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, puck.chen@hisilicon.com,
	xuejiancheng@huawei.com, robh+dt@kernel.org,
	linux@arm.linux.org.uk, tyler.baker@linaro.org,
	zhenwei.wang@hisilicon.com, guodong.xu@linaro.org,
	victor.lixin@hisilicon.com, sboyd@codeaurora.org,
	linux-kernel@vger.kernel.org, tomeu.vizoso@collabora.com,
	galak@codeaurora.org, olof@lixom.net,
	jorge.ramirez-ortiz@linaro.org, xuyiping@hisilicon.com,
	liguozhu@hisilicon.com
Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock
Date: Tue, 14 Apr 2015 15:20:28 +0200	[thread overview]
Message-ID: <5065055.RUNnjWsHWj@wuerfel> (raw)
In-Reply-To: <552D09F7.7080603@huawei.com>

On Tuesday 14 April 2015 20:37:11 Bintian wrote:
> It's really a smart fix!
> 
> For the four system controllers, how about change the following strings:
> +       - "hisilicon,aoctrl"
> +       - "hisilicon,sysctrl"
> +       - "hisilicon,mediactrl"
> +       - "hisilicon,pmctrl"
> 
> to
> +       - "hisilicon,hi6220-aoctrl"
> +       - "hisilicon,hi6220-sysctrl"
> +       - "hisilicon,hi6220-mediactrl"
> +       - "hisilicon,hi6220-pmctrl"

Yes, that works.

> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ?

Seems fine to me, though I'd have to look at the bigger picture to see
any potential problems. At the moment, I don't see any.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Bintian <bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	btw-aAikPa0K0u50tdys+9eLAQ@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	wangbinghui-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	huxinwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	yanhaifeng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	rob.herring-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	heyunlei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	w.f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	z.liuxinliang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	zhenwei.wang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	victor.lixin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock
Date: Tue, 14 Apr 2015 15:20:28 +0200	[thread overview]
Message-ID: <5065055.RUNnjWsHWj@wuerfel> (raw)
In-Reply-To: <552D09F7.7080603-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Tuesday 14 April 2015 20:37:11 Bintian wrote:
> It's really a smart fix!
> 
> For the four system controllers, how about change the following strings:
> +       - "hisilicon,aoctrl"
> +       - "hisilicon,sysctrl"
> +       - "hisilicon,mediactrl"
> +       - "hisilicon,pmctrl"
> 
> to
> +       - "hisilicon,hi6220-aoctrl"
> +       - "hisilicon,hi6220-sysctrl"
> +       - "hisilicon,hi6220-mediactrl"
> +       - "hisilicon,hi6220-pmctrl"

Yes, that works.

> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ?

Seems fine to me, though I'd have to look at the bigger picture to see
any potential problems. At the moment, I don't see any.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock
Date: Tue, 14 Apr 2015 15:20:28 +0200	[thread overview]
Message-ID: <5065055.RUNnjWsHWj@wuerfel> (raw)
In-Reply-To: <552D09F7.7080603@huawei.com>

On Tuesday 14 April 2015 20:37:11 Bintian wrote:
> It's really a smart fix!
> 
> For the four system controllers, how about change the following strings:
> +       - "hisilicon,aoctrl"
> +       - "hisilicon,sysctrl"
> +       - "hisilicon,mediactrl"
> +       - "hisilicon,pmctrl"
> 
> to
> +       - "hisilicon,hi6220-aoctrl"
> +       - "hisilicon,hi6220-sysctrl"
> +       - "hisilicon,hi6220-mediactrl"
> +       - "hisilicon,hi6220-pmctrl"

Yes, that works.

> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ?

Seems fine to me, though I'd have to look at the bigger picture to see
any potential problems. At the moment, I don't see any.

	Arnd

  reply	other threads:[~2015-04-14 13:25 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13  9:17 [PATCH v2 0/6] arm64,hi6220: Enable Hisilicon Hi6220 SoC Bintian Wang
2015-04-13  9:17 ` Bintian Wang
2015-04-13  9:17 ` Bintian Wang
2015-04-13  9:17 ` [PATCH v2 1/6] arm64: Enable Hisilicon ARMv8 SoC family in Kconfig and defconfig Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-20 21:10   ` Kevin Hilman
2015-04-20 21:10     ` Kevin Hilman
2015-04-20 21:10     ` Kevin Hilman
2015-04-21  0:39     ` Bintian
2015-04-21  0:39       ` Bintian
2015-04-21  0:39       ` Bintian
2015-04-13  9:17 ` [PATCH v2 2/6] arm64: hi6220: Document devicetree bindings for Hisilicon hi6220 SoC Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17 ` [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13 15:32   ` Arnd Bergmann
2015-04-13 15:32     ` Arnd Bergmann
2015-04-13 15:32     ` Arnd Bergmann
2015-04-14  3:35     ` Bintian
2015-04-14  3:35       ` Bintian
2015-04-14  3:35       ` Bintian
2015-04-14 10:19       ` Arnd Bergmann
2015-04-14 10:19         ` Arnd Bergmann
2015-04-14 10:19         ` Arnd Bergmann
2015-04-14 12:37         ` Bintian
2015-04-14 12:37           ` Bintian
2015-04-14 12:37           ` Bintian
2015-04-14 13:20           ` Arnd Bergmann [this message]
2015-04-14 13:20             ` Arnd Bergmann
2015-04-14 13:20             ` Arnd Bergmann
2015-04-14 14:37             ` Brent Wang
2015-04-14 14:37               ` Brent Wang
2015-04-14 14:37               ` Brent Wang
2015-04-13  9:17 ` [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13 11:56   ` Paul Bolle
2015-04-13 11:56     ` Paul Bolle
2015-04-13 11:56     ` Paul Bolle
2015-04-13 13:17     ` Bintian
2015-04-13 13:17       ` Bintian
2015-04-13 13:17       ` Bintian
2015-04-13 14:15       ` Paul Bolle
2015-04-13 14:15         ` Paul Bolle
2015-04-13 14:15         ` Paul Bolle
2015-04-13 13:30   ` Arnd Bergmann
2015-04-13 13:30     ` Arnd Bergmann
2015-04-13 13:30     ` Arnd Bergmann
2015-04-13 13:57     ` Bintian
2015-04-13 13:57       ` Bintian
2015-04-13 13:57       ` Bintian
2015-04-13 15:34       ` Arnd Bergmann
2015-04-13 15:34         ` Arnd Bergmann
2015-04-13 15:34         ` Arnd Bergmann
2015-04-14  8:53         ` YiPing Xu
2015-04-14  8:53           ` YiPing Xu
2015-04-14  8:53           ` YiPing Xu
2015-04-13  9:17 ` [PATCH v2 5/6] arm64: Kconfig: Add clock support to ARCH_HISI Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17 ` [PATCH v2 6/6] arm64: dts: Add dts files for Hisilicon Hi6220 SoC Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-13  9:17   ` Bintian Wang
2015-04-14 14:44   ` Arnd Bergmann
2015-04-14 14:44     ` Arnd Bergmann
2015-04-14 14:44     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5065055.RUNnjWsHWj@wuerfel \
    --to=arnd@arndb.de \
    --cc=bintian.wang@huawei.com \
    --cc=btw@mail.itp.ac.cn \
    --cc=catalin.marinas@arm.com \
    --cc=dan.zhao@hisilicon.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=guodong.xu@linaro.org \
    --cc=haojian.zhuang@linaro.org \
    --cc=heyunlei@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jh80.chung@samsung.com \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=khilman@linaro.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=liguozhu@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=olof@lixom.net \
    --cc=pawel.moll@arm.com \
    --cc=puck.chen@hisilicon.com \
    --cc=rob.herring@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sledge.yanwei@huawei.com \
    --cc=tomeu.vizoso@collabora.com \
    --cc=tyler.baker@linaro.org \
    --cc=victor.lixin@hisilicon.com \
    --cc=w.f@huawei.com \
    --cc=wangbinghui@hisilicon.com \
    --cc=will.deacon@arm.com \
    --cc=xuejiancheng@huawei.com \
    --cc=xuwei5@hisilicon.com \
    --cc=xuyiping@hisilicon.com \
    --cc=yanhaifeng@gmail.com \
    --cc=z.liuxinliang@huawei.com \
    --cc=zhangfei.gao@linaro.org \
    --cc=zhenwei.wang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.