Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock

From: Brent Wang <wangbintian@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Bintian <bintian.wang@huawei.com>,
	Mark Rutland <mark.rutland@arm.com>,
	"dan.zhao@hisilicon.com" <dan.zhao@hisilicon.com>,
	"btw@mail.itp.ac.cn" <btw@mail.itp.ac.cn>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"wangbinghui@hisilicon.com" <wangbinghui@hisilicon.com>,
	Will Deacon <will.deacon@arm.com>,
	"huxinwei@huawei.com" <huxinwei@huawei.com>,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Haifeng Yan <yanhaifeng@gmail.com>,
	Rob Herring <rob.herring@linaro.org>,
	Mike Turquette <mturquette@linaro.org>,
	Xu Wei <xuwei5@hisilicon.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	"sledge.yanwei@huawei.com" <sledge.yanwei@huawei.com>,
	XinWei Kong <kong.kongxinwei@hisilicon.com>,
	"heyunlei@huawei.com" <heyunlei@huawei.com>,
	"w.f@huawei.com" <w.f@huawei.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	"z.liuxinliang@huawei.com" <z.liuxinliang@huawei.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Kevin Hilman <khilman@linaro.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
	"xuejiancheng@huawei.com" <xuejiancheng@huawei.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Tyler Baker <tyler.baker@linaro.org>,
	"zhenwei.wang@hisilicon.com" <zhenwei.wang@hisilicon.com>,
	Guodong Xu <guodong.xu@linaro.org>,
	"victor.lixin@hisilicon.com" <victor.lixin@hisilicon.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Kumar Gala <galak@codeaurora.org>,
	Olof Johansson <olof@lixom.net>,
	jorge.ramirez-ortiz@linaro.org,
	"xuyiping@hisilicon.com" <xuyiping@hisilicon.com>,
	"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>
Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock
Date: Tue, 14 Apr 2015 22:37:34 +0800	[thread overview]
Message-ID: <CAAS=xmip9WeN2AXH+YpQK9Un1TCaXkHbK-cRFcr3fMcFvrfhPQ@mail.gmail.com> (raw)
In-Reply-To: <5065055.RUNnjWsHWj@wuerfel>

Hello Arnd,

2015-04-14 21:20 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday 14 April 2015 20:37:11 Bintian wrote:
>> It's really a smart fix!
>>
>> For the four system controllers, how about change the following strings:
>> +       - "hisilicon,aoctrl"
>> +       - "hisilicon,sysctrl"
>> +       - "hisilicon,mediactrl"
>> +       - "hisilicon,pmctrl"
>>
>> to
>> +       - "hisilicon,hi6220-aoctrl"
>> +       - "hisilicon,hi6220-sysctrl"
>> +       - "hisilicon,hi6220-mediactrl"
>> +       - "hisilicon,hi6220-pmctrl"
>
> Yes, that works.
Thanks, will fix in next version.

>
>> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ?
>
> Seems fine to me, though I'd have to look at the bigger picture to see
> any potential problems. At the moment, I don't see any.
Sure, please also help to review the 6/6 patch of this patch set, many thanks!

BR,

Bintian

>
>         Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/