From: Julien Grall <julien.grall@arm.com> To: Suzuki K Poulose <suzuki.poulose@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: christoffer.dall@arm.com, james.morse@arm.com, marc.zyngier@arm.com, julien.thierry@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it Date: Thu, 21 Mar 2019 17:27:40 +0000 [thread overview] Message-ID: <247efb35-2082-289a-43cf-3342b586b1d8@arm.com> (raw) In-Reply-To: <ad32ff02-a88f-ee8a-3296-f859638d66b9@arm.com> On 3/21/19 5:03 PM, Suzuki K Poulose wrote: > Hi Julien, Hi Suzuki, > On 21/03/2019 16:36, Julien Grall wrote: >> In an attempt to make the ASID allocator generic, create a new structure >> asid_info to store all the information necessary for the allocator. >> >> For now, move the variables asid_generation and asid_map to the new >> structure >> asid_info. Follow-up patches will move more variables. >> >> Note to avoid more renaming aftwards, a local variable 'info' has been >> created and is a pointer to the ASID allocator structure. >> >> Signed-off-by: Julien Grall <julien.grall@arm.com> >> --- >> arch/arm64/mm/context.c | 46 >> ++++++++++++++++++++++++++-------------------- >> 1 file changed, 26 insertions(+), 20 deletions(-) >> >> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c >> index 1f0ea2facf24..34db54f1a39a 100644 >> --- a/arch/arm64/mm/context.c >> +++ b/arch/arm64/mm/context.c >> @@ -30,8 +30,11 @@ >> static u32 asid_bits; >> static DEFINE_RAW_SPINLOCK(cpu_asid_lock); >> -static atomic64_t asid_generation; >> -static unsigned long *asid_map; >> +struct asid_info >> +{ >> + atomic64_t generation; >> + unsigned long *map; >> +} asid_info; > > Shouldn't this be static ? Rest looks fine. Yes it should be static. I have updated my code. Thank you for the review! Cheers, > > Cheers > Suzuki -- Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Suzuki K Poulose <suzuki.poulose@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: julien.thierry@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, christoffer.dall@arm.com, james.morse@arm.com Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it Date: Thu, 21 Mar 2019 17:27:40 +0000 [thread overview] Message-ID: <247efb35-2082-289a-43cf-3342b586b1d8@arm.com> (raw) In-Reply-To: <ad32ff02-a88f-ee8a-3296-f859638d66b9@arm.com> On 3/21/19 5:03 PM, Suzuki K Poulose wrote: > Hi Julien, Hi Suzuki, > On 21/03/2019 16:36, Julien Grall wrote: >> In an attempt to make the ASID allocator generic, create a new structure >> asid_info to store all the information necessary for the allocator. >> >> For now, move the variables asid_generation and asid_map to the new >> structure >> asid_info. Follow-up patches will move more variables. >> >> Note to avoid more renaming aftwards, a local variable 'info' has been >> created and is a pointer to the ASID allocator structure. >> >> Signed-off-by: Julien Grall <julien.grall@arm.com> >> --- >> arch/arm64/mm/context.c | 46 >> ++++++++++++++++++++++++++-------------------- >> 1 file changed, 26 insertions(+), 20 deletions(-) >> >> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c >> index 1f0ea2facf24..34db54f1a39a 100644 >> --- a/arch/arm64/mm/context.c >> +++ b/arch/arm64/mm/context.c >> @@ -30,8 +30,11 @@ >> static u32 asid_bits; >> static DEFINE_RAW_SPINLOCK(cpu_asid_lock); >> -static atomic64_t asid_generation; >> -static unsigned long *asid_map; >> +struct asid_info >> +{ >> + atomic64_t generation; >> + unsigned long *map; >> +} asid_info; > > Shouldn't this be static ? Rest looks fine. Yes it should be static. I have updated my code. Thank you for the review! Cheers, > > Cheers > Suzuki -- Julien Grall _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-21 17:27 UTC|newest] Thread overview: 211+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-21 16:36 [PATCH RFC 00/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 17:03 ` Suzuki K Poulose 2019-03-21 17:03 ` Suzuki K Poulose 2019-03-21 17:27 ` Julien Grall [this message] 2019-03-21 17:27 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 02/14] arm64/mm: Move active_asids and reserved_asids to asid_info Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 03/14] arm64/mm: Move bits " Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 04/14] arm64/mm: Move the variable lock and tlb_flush_pending " Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 05/14] arm64/mm: Remove dependency on MM in new_context Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 06/14] arm64/mm: Store the number of asid allocated per context Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 07/14] arm64/mm: Introduce NUM_ASIDS Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 08/14] arm64/mm: Split asid_inits in 2 parts Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 09/14] arm64/mm: Split the function check_and_switch_context in 3 parts Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 10/14] arm64/mm: Introduce a callback to flush the local context Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 11/14] arm64: Move the ASID allocator code in a separate file Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-06-05 16:56 ` Julien Grall 2019-06-05 16:56 ` Julien Grall 2019-06-05 16:56 ` Julien Grall 2019-06-05 16:56 ` Julien Grall 2019-06-05 20:41 ` Palmer Dabbelt 2019-06-05 20:41 ` Palmer Dabbelt 2019-06-05 20:41 ` Palmer Dabbelt 2019-06-05 20:41 ` Palmer Dabbelt 2019-06-11 1:56 ` Gary Guo 2019-06-11 1:56 ` Gary Guo 2019-06-11 1:56 ` Gary Guo 2019-06-11 1:56 ` Gary Guo 2019-06-19 8:07 ` Guo Ren 2019-06-19 8:07 ` Guo Ren 2019-06-19 8:07 ` Guo Ren 2019-06-19 8:07 ` Guo Ren 2019-06-19 8:54 ` Julien Grall 2019-06-19 8:54 ` Julien Grall 2019-06-19 8:54 ` Julien Grall 2019-06-19 8:54 ` Julien Grall 2019-06-19 9:12 ` Will Deacon 2019-06-19 9:12 ` Will Deacon 2019-06-19 9:12 ` Will Deacon 2019-06-19 9:12 ` Will Deacon 2019-06-19 12:18 ` Guo Ren 2019-06-19 12:18 ` Guo Ren 2019-06-19 12:18 ` Guo Ren 2019-06-19 12:18 ` Guo Ren 2019-06-19 12:39 ` Will Deacon 2019-06-19 12:39 ` Will Deacon 2019-06-19 12:39 ` Will Deacon 2019-06-19 12:39 ` Will Deacon 2019-06-20 9:33 ` Guo Ren 2019-06-20 9:33 ` Guo Ren 2019-06-20 9:33 ` Guo Ren 2019-06-20 9:33 ` Guo Ren 2019-06-24 10:40 ` Will Deacon 2019-06-24 10:40 ` Will Deacon 2019-06-24 10:40 ` Will Deacon 2019-06-24 10:40 ` Will Deacon 2019-06-25 7:25 ` Palmer Dabbelt 2019-06-25 7:25 ` Palmer Dabbelt 2019-06-25 7:25 ` Palmer Dabbelt 2019-06-25 7:25 ` Palmer Dabbelt 2019-09-07 23:52 ` Guo Ren 2019-09-07 23:52 ` Guo Ren 2019-09-07 23:52 ` Guo Ren 2019-09-07 23:52 ` Guo Ren 2019-09-07 23:52 ` Guo Ren 2019-09-12 14:02 ` Will Deacon 2019-09-12 14:02 ` Will Deacon 2019-09-12 14:02 ` Will Deacon 2019-09-12 14:02 ` Will Deacon 2019-09-12 14:02 ` Will Deacon 2019-09-12 14:59 ` Guo Ren 2019-09-12 14:59 ` Guo Ren 2019-09-12 14:59 ` Guo Ren 2019-09-12 14:59 ` Guo Ren 2019-09-12 14:59 ` Guo Ren 2019-09-13 7:13 ` Guo Ren 2019-09-13 7:13 ` Guo Ren 2019-09-14 8:49 ` Guo Ren 2019-09-14 8:49 ` Guo Ren 2019-09-14 8:49 ` Guo Ren 2019-09-14 8:49 ` Guo Ren 2019-09-14 8:49 ` Guo Ren 2019-09-16 12:57 ` Jean-Philippe Brucker 2019-09-16 12:57 ` Jean-Philippe Brucker 2019-09-16 12:57 ` Jean-Philippe Brucker 2019-09-16 12:57 ` Jean-Philippe Brucker 2019-09-16 12:57 ` Jean-Philippe Brucker 2019-09-19 13:07 ` Guo Ren 2019-09-19 13:07 ` Guo Ren 2019-09-19 13:07 ` Guo Ren 2019-09-19 13:07 ` Guo Ren 2019-09-19 13:07 ` Guo Ren 2019-09-19 15:18 ` Jean-Philippe Brucker 2019-09-19 15:18 ` Jean-Philippe Brucker 2019-09-19 15:18 ` Jean-Philippe Brucker 2019-09-19 15:18 ` Jean-Philippe Brucker 2019-09-19 15:18 ` Jean-Philippe Brucker 2019-09-20 0:07 ` Guo Ren 2019-09-20 0:07 ` Guo Ren 2019-09-20 0:07 ` Guo Ren 2019-09-20 0:07 ` Guo Ren 2019-09-20 0:07 ` Guo Ren 2019-09-20 7:18 ` Jean-Philippe Brucker 2019-09-20 7:18 ` Jean-Philippe Brucker 2019-09-20 7:18 ` Jean-Philippe Brucker 2019-09-20 7:18 ` Jean-Philippe Brucker 2019-09-20 7:18 ` Jean-Philippe Brucker 2019-09-14 14:01 ` Palmer Dabbelt 2019-09-14 14:01 ` Palmer Dabbelt 2019-09-14 14:01 ` Palmer Dabbelt 2019-09-14 14:01 ` Palmer Dabbelt 2019-09-14 14:01 ` Palmer Dabbelt 2019-09-15 5:03 ` Anup Patel 2019-09-15 5:03 ` Anup Patel 2019-09-15 5:03 ` Anup Patel 2019-09-15 5:03 ` Anup Patel 2019-09-15 5:03 ` Anup Patel 2019-09-16 18:18 ` Will Deacon 2019-09-16 18:18 ` Will Deacon 2019-09-16 18:18 ` Will Deacon 2019-09-16 18:18 ` Will Deacon 2019-09-16 18:18 ` Will Deacon 2019-09-16 18:28 ` Palmer Dabbelt 2019-09-16 18:28 ` Palmer Dabbelt 2019-09-16 18:28 ` Palmer Dabbelt 2019-09-16 18:28 ` Palmer Dabbelt 2019-09-16 18:28 ` Palmer Dabbelt 2019-09-17 3:42 ` Anup Patel 2019-09-17 3:42 ` Anup Patel 2019-09-17 3:42 ` Anup Patel 2019-09-17 3:42 ` Anup Patel 2019-09-17 3:42 ` Anup Patel 2019-09-19 13:36 ` Guo Ren 2019-09-19 13:36 ` Guo Ren 2019-09-19 13:36 ` Guo Ren 2019-09-19 13:36 ` Guo Ren 2019-09-19 13:36 ` Guo Ren 2019-06-19 11:51 ` Guo Ren 2019-06-19 11:51 ` Guo Ren 2019-06-19 11:51 ` Guo Ren 2019-06-19 11:51 ` Guo Ren 2019-06-19 12:52 ` Julien Grall 2019-06-19 12:52 ` Julien Grall 2019-06-19 12:52 ` Julien Grall 2019-06-19 12:52 ` Julien Grall 2019-06-21 14:16 ` Catalin Marinas 2019-06-21 14:16 ` Catalin Marinas 2019-06-21 14:16 ` Catalin Marinas 2019-06-21 14:16 ` Catalin Marinas 2019-06-23 16:35 ` Guo Ren 2019-06-23 16:35 ` Guo Ren 2019-06-23 16:35 ` Guo Ren 2019-06-23 16:35 ` Guo Ren 2019-06-24 10:22 ` Will Deacon 2019-06-24 10:22 ` Will Deacon 2019-06-24 10:22 ` Will Deacon 2019-06-24 10:22 ` Will Deacon 2019-06-27 9:41 ` qi.fuli 2019-06-27 9:41 ` qi.fuli 2019-06-27 9:41 ` qi.fuli 2019-06-27 9:41 ` qi.fuli 2019-06-27 10:26 ` Will Deacon 2019-06-27 10:26 ` Will Deacon 2019-06-27 10:26 ` Will Deacon 2019-06-27 10:26 ` Will Deacon 2019-06-24 15:38 ` Catalin Marinas 2019-06-24 15:38 ` Catalin Marinas 2019-06-24 15:38 ` Catalin Marinas 2019-06-24 15:38 ` Catalin Marinas 2019-06-30 4:29 ` Guo Ren 2019-06-30 4:29 ` Guo Ren 2019-06-30 4:29 ` Guo Ren 2019-06-30 4:29 ` Guo Ren 2019-07-01 9:17 ` Catalin Marinas 2019-07-01 9:17 ` Catalin Marinas 2019-07-01 9:17 ` Catalin Marinas 2019-07-01 9:17 ` Catalin Marinas 2019-07-16 3:31 ` Guo Ren 2019-07-16 3:31 ` Guo Ren 2019-07-16 3:31 ` Guo Ren 2019-07-16 3:31 ` Guo Ren 2019-07-22 16:38 ` Catalin Marinas 2019-07-22 16:38 ` Catalin Marinas 2019-07-22 16:38 ` Catalin Marinas 2019-07-22 16:38 ` Catalin Marinas 2019-03-21 16:36 ` [PATCH RFC 12/14] arm64/lib: asid: Allow user to update the context under the lock Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 13/14] arm/kvm: Introduce a new VMID allocator Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` [PATCH RFC 14/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Julien Grall 2019-03-21 16:36 ` Julien Grall 2019-03-21 16:36 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=247efb35-2082-289a-43cf-3342b586b1d8@arm.com \ --to=julien.grall@arm.com \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@arm.com \ --cc=james.morse@arm.com \ --cc=julien.thierry@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.