From: Stefan Agner <stefan@agner.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de,
linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de,
jason@lakedaemon.net, olof@lixom.net, daniel.lezcano@linaro.org,
tglx@linutronix.de, mark.rutland@arm.com, pawel.moll@arm.com,
robh+dt@kernel.org, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] irqchip: nvic: support routable irq domain ops
Date: Wed, 03 Dec 2014 18:32:22 +0100 [thread overview]
Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> (raw)
In-Reply-To: <4576226.8jDcZiCptE@wuerfel>
On 2014-12-03 11:49, Arnd Bergmann wrote:
> On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote:
>> +#ifdef CONFIG_ARM_NVIC
>> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops;
>> +static inline void __init register_routable_domain_ops
>> + (const struct irq_domain_ops *ops)
>> +{
>> + nvic_routable_irq_domain_ops = ops;
>> +}
>> +#endif /* CONFIG_ARM_NVIC */
>>
>
> As you mentioned, this conflicts with the gic specific declaration.
> Why not remove the #ifdef here and rename the function to
> nvic_register_routable_domain_ops() ?
>
> If that doesn't work, I guess we need something more generic
> and move the routable_irq_domain_ops to some common location.
>
This would move the ifdef to the MSCM driver code. I thought of having a
generic function to call, no matter what base IRQ chip is used.
Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ
domain hierarchy stuff...
--
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 04/12] irqchip: nvic: support routable irq domain ops
Date: Wed, 03 Dec 2014 18:32:22 +0100 [thread overview]
Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> (raw)
In-Reply-To: <4576226.8jDcZiCptE@wuerfel>
On 2014-12-03 11:49, Arnd Bergmann wrote:
> On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote:
>> +#ifdef CONFIG_ARM_NVIC
>> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops;
>> +static inline void __init register_routable_domain_ops
>> + (const struct irq_domain_ops *ops)
>> +{
>> + nvic_routable_irq_domain_ops = ops;
>> +}
>> +#endif /* CONFIG_ARM_NVIC */
>>
>
> As you mentioned, this conflicts with the gic specific declaration.
> Why not remove the #ifdef here and rename the function to
> nvic_register_routable_domain_ops() ?
>
> If that doesn't work, I guess we need something more generic
> and move the routable_irq_domain_ops to some common location.
>
This would move the ifdef to the MSCM driver code. I thought of having a
generic function to call, no matter what base IRQ chip is used.
Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ
domain hierarchy stuff...
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] irqchip: nvic: support routable irq domain ops
Date: Wed, 03 Dec 2014 18:32:22 +0100 [thread overview]
Message-ID: <2586ebb42daf66877335adaad4b4d3e6@agner.ch> (raw)
In-Reply-To: <4576226.8jDcZiCptE@wuerfel>
On 2014-12-03 11:49, Arnd Bergmann wrote:
> On Wednesday 03 December 2014 01:12:03 Stefan Agner wrote:
>> +#ifdef CONFIG_ARM_NVIC
>> +extern const struct irq_domain_ops *nvic_routable_irq_domain_ops;
>> +static inline void __init register_routable_domain_ops
>> + (const struct irq_domain_ops *ops)
>> +{
>> + nvic_routable_irq_domain_ops = ops;
>> +}
>> +#endif /* CONFIG_ARM_NVIC */
>>
>
> As you mentioned, this conflicts with the gic specific declaration.
> Why not remove the #ifdef here and rename the function to
> nvic_register_routable_domain_ops() ?
>
> If that doesn't work, I guess we need something more generic
> and move the routable_irq_domain_ops to some common location.
>
This would move the ifdef to the MSCM driver code. I thought of having a
generic function to call, no matter what base IRQ chip is used.
Anyway, as tglx suggested in patch 3/12, I will try to use the IRQ
domain hierarchy stuff...
--
Stefan
next prev parent reply other threads:[~2014-12-03 17:30 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 0:11 [PATCH 00/12] ARM: vf610m4: Add Vybrid Cortex-M4 support Stefan Agner
2014-12-03 0:11 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 01/12] ARM: dts: vf610: add routable-irqs property for gic node Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 02/12] ARM: dts: vf610: add Miscellaneous System Control Module (MSCM) Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 03/12] irqchip: gic: define register_routable_domain_ops conditional Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 10:46 ` Arnd Bergmann
2014-12-03 10:46 ` Arnd Bergmann
2014-12-03 10:46 ` Arnd Bergmann
2014-12-03 13:04 ` Thomas Gleixner
2014-12-03 13:04 ` Thomas Gleixner
2014-12-03 13:04 ` Thomas Gleixner
2014-12-03 17:28 ` Stefan Agner
2014-12-03 17:28 ` Stefan Agner
2014-12-03 19:04 ` Marc Zyngier
2014-12-03 19:04 ` Marc Zyngier
2014-12-03 19:04 ` Marc Zyngier
2014-12-04 0:03 ` Thomas Gleixner
2014-12-04 0:03 ` Thomas Gleixner
2014-12-04 0:03 ` Thomas Gleixner
2014-12-04 13:35 ` Stefan Agner
2014-12-04 13:35 ` Stefan Agner
2014-12-04 13:35 ` Stefan Agner
2014-12-04 13:42 ` Marc Zyngier
2014-12-04 13:42 ` Marc Zyngier
2014-12-04 13:42 ` Marc Zyngier
2014-12-04 13:50 ` Stefan Agner
2014-12-04 13:50 ` Stefan Agner
2014-12-04 13:50 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 04/12] irqchip: nvic: support routable irq domain ops Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 9:39 ` Uwe Kleine-König
2014-12-03 9:39 ` Uwe Kleine-König
2014-12-03 9:39 ` Uwe Kleine-König
2014-12-03 10:49 ` Arnd Bergmann
2014-12-03 10:49 ` Arnd Bergmann
2014-12-03 10:49 ` Arnd Bergmann
2014-12-03 17:32 ` Stefan Agner [this message]
2014-12-03 17:32 ` Stefan Agner
2014-12-03 17:32 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 05/12] irqchip: nvic: increase number of external interrupts to 112 Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 8:12 ` Uwe Kleine-König
2014-12-03 8:12 ` Uwe Kleine-König
2014-12-03 8:12 ` Uwe Kleine-König
2014-12-03 17:40 ` Stefan Agner
2014-12-03 17:40 ` Stefan Agner
2014-12-03 17:40 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 06/12] ARM: imx: add support for MSCM interrupt router Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 10:51 ` Arnd Bergmann
2014-12-03 10:51 ` Arnd Bergmann
2014-12-03 0:12 ` [PATCH 07/12] Documentation: dt: imx: add MSCM documentation Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 10:52 ` Arnd Bergmann
2014-12-03 10:52 ` Arnd Bergmann
2014-12-03 10:52 ` Arnd Bergmann
2014-12-03 17:49 ` Stefan Agner
2014-12-03 17:49 ` Stefan Agner
2014-12-03 17:49 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 08/12] clocksource: add dependencies for Vybrid pit clocksource Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 09/12] ARM: unify MMU/!MMU addruart calls Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 10:53 ` Arnd Bergmann
2014-12-03 10:53 ` Arnd Bergmann
2014-12-03 10:53 ` Arnd Bergmann
2014-12-03 0:12 ` [PATCH 10/12] ARM: vf610m4: add new machine and SoC for Vybrid on Cortex-M4 Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 10:56 ` Arnd Bergmann
2014-12-03 10:56 ` Arnd Bergmann
2014-12-03 10:56 ` Arnd Bergmann
2014-12-03 18:00 ` Stefan Agner
2014-12-03 18:00 ` Stefan Agner
2014-12-03 18:00 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 11/12] ARM: dts: add support for Vybrid running " Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 11:03 ` Arnd Bergmann
2014-12-03 11:03 ` Arnd Bergmann
2014-12-16 22:19 ` Stefan Agner
2014-12-16 22:19 ` Stefan Agner
2014-12-16 22:19 ` Stefan Agner
2014-12-17 10:57 ` Arnd Bergmann
2014-12-17 10:57 ` Arnd Bergmann
2014-12-17 10:57 ` Arnd Bergmann
2014-12-16 23:41 ` Stefan Agner
2014-12-16 23:41 ` Stefan Agner
2014-12-17 12:31 ` Arnd Bergmann
2014-12-17 12:31 ` Arnd Bergmann
2014-12-18 20:36 ` Stefan Agner
2014-12-18 20:36 ` Stefan Agner
2014-12-18 20:36 ` Stefan Agner
2014-12-18 22:44 ` Arnd Bergmann
2014-12-18 22:44 ` Arnd Bergmann
2014-12-18 22:44 ` Arnd Bergmann
2014-12-20 18:49 ` Stefan Agner
2014-12-20 18:49 ` Stefan Agner
2014-12-03 0:12 ` [PATCH 12/12] ARM: vf610m4: add defconfig for Linux on Vybrids Cortex-M4 Stefan Agner
2014-12-03 0:12 ` Stefan Agner
2014-12-03 0:12 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2586ebb42daf66877335adaad4b4d3e6@agner.ch \
--to=stefan@agner.ch \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.