All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
@ 2018-09-26 11:55 ` Thomas Zimmermann
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2018-09-26 11:55 UTC (permalink / raw)
  To: laurent.pinchart, kieran.bingham+renesas
  Cc: dri-devel, linux-renesas-soc, Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting
of struct drm_device. The resulting code is more aligned with the rest
of the Linux kernel interfaces.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
index 6ececad6f845..8554102a6ead 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
@@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
 	drm_kms_helper_poll_fini(ddev);
 	drm_mode_config_cleanup(ddev);
 	drm_irq_uninstall(ddev);
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);

 	return 0;
 }
@@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
 	drm_kms_helper_poll_fini(ddev);
 	drm_mode_config_cleanup(ddev);
 err_free_drm_dev:
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);

 	return ret;
 }
--
2.19.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
@ 2018-09-26 11:55 ` Thomas Zimmermann
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2018-09-26 11:55 UTC (permalink / raw)
  To: laurent.pinchart, kieran.bingham+renesas
  Cc: linux-renesas-soc, Thomas Zimmermann, dri-devel

This patch unifies the naming of DRM functions for reference counting
of struct drm_device. The resulting code is more aligned with the rest
of the Linux kernel interfaces.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
index 6ececad6f845..8554102a6ead 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
@@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
 	drm_kms_helper_poll_fini(ddev);
 	drm_mode_config_cleanup(ddev);
 	drm_irq_uninstall(ddev);
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);

 	return 0;
 }
@@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
 	drm_kms_helper_poll_fini(ddev);
 	drm_mode_config_cleanup(ddev);
 err_free_drm_dev:
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);

 	return ret;
 }
--
2.19.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
  2018-09-26 11:55 ` Thomas Zimmermann
@ 2018-09-26 12:14   ` Kieran Bingham
  -1 siblings, 0 replies; 8+ messages in thread
From: Kieran Bingham @ 2018-09-26 12:14 UTC (permalink / raw)
  To: Thomas Zimmermann, laurent.pinchart; +Cc: dri-devel, linux-renesas-soc

Hi Thomas,

Thank you for the patch,

On 26/09/18 12:55, Thomas Zimmermann wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> index 6ececad6f845..8554102a6ead 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
>  	drm_kms_helper_poll_fini(ddev);
>  	drm_mode_config_cleanup(ddev);
>  	drm_irq_uninstall(ddev);
> -	drm_dev_unref(ddev);
> +	drm_dev_put(ddev);
> 
>  	return 0;
>  }
> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
>  	drm_kms_helper_poll_fini(ddev);
>  	drm_mode_config_cleanup(ddev);
>  err_free_drm_dev:
> -	drm_dev_unref(ddev);
> +	drm_dev_put(ddev);
> 
>  	return ret;
>  }
> --
> 2.19.0
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
@ 2018-09-26 12:14   ` Kieran Bingham
  0 siblings, 0 replies; 8+ messages in thread
From: Kieran Bingham @ 2018-09-26 12:14 UTC (permalink / raw)
  To: Thomas Zimmermann, laurent.pinchart; +Cc: linux-renesas-soc, dri-devel

Hi Thomas,

Thank you for the patch,

On 26/09/18 12:55, Thomas Zimmermann wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> index 6ececad6f845..8554102a6ead 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
>  	drm_kms_helper_poll_fini(ddev);
>  	drm_mode_config_cleanup(ddev);
>  	drm_irq_uninstall(ddev);
> -	drm_dev_unref(ddev);
> +	drm_dev_put(ddev);
> 
>  	return 0;
>  }
> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
>  	drm_kms_helper_poll_fini(ddev);
>  	drm_mode_config_cleanup(ddev);
>  err_free_drm_dev:
> -	drm_dev_unref(ddev);
> +	drm_dev_put(ddev);
> 
>  	return ret;
>  }
> --
> 2.19.0
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
  2018-09-26 12:14   ` Kieran Bingham
@ 2018-09-26 12:26     ` Thomas Zimmermann
  -1 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2018-09-26 12:26 UTC (permalink / raw)
  To: kieran.bingham+renesas, laurent.pinchart; +Cc: linux-renesas-soc, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 2025 bytes --]

Hi,

thanks for reviewing the patch and the one for rcar-du. Please also add
them to your tree.

Best regards
Thomas

Am 26.09.18 um 14:14 schrieb Kieran Bingham:
> Hi Thomas,
> 
> Thank you for the patch,
> 
> On 26/09/18 12:55, Thomas Zimmermann wrote:
>> This patch unifies the naming of DRM functions for reference counting
>> of struct drm_device. The resulting code is more aligned with the rest
>> of the Linux kernel interfaces.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
>> ---
>>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> index 6ececad6f845..8554102a6ead 100644
>> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
>>  	drm_kms_helper_poll_fini(ddev);
>>  	drm_mode_config_cleanup(ddev);
>>  	drm_irq_uninstall(ddev);
>> -	drm_dev_unref(ddev);
>> +	drm_dev_put(ddev);
>>
>>  	return 0;
>>  }
>> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
>>  	drm_kms_helper_poll_fini(ddev);
>>  	drm_mode_config_cleanup(ddev);
>>  err_free_drm_dev:
>> -	drm_dev_unref(ddev);
>> +	drm_dev_put(ddev);
>>
>>  	return ret;
>>  }
>> --
>> 2.19.0
>>
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
@ 2018-09-26 12:26     ` Thomas Zimmermann
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2018-09-26 12:26 UTC (permalink / raw)
  To: kieran.bingham+renesas, laurent.pinchart; +Cc: linux-renesas-soc, dri-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 2025 bytes --]

Hi,

thanks for reviewing the patch and the one for rcar-du. Please also add
them to your tree.

Best regards
Thomas

Am 26.09.18 um 14:14 schrieb Kieran Bingham:
> Hi Thomas,
> 
> Thank you for the patch,
> 
> On 26/09/18 12:55, Thomas Zimmermann wrote:
>> This patch unifies the naming of DRM functions for reference counting
>> of struct drm_device. The resulting code is more aligned with the rest
>> of the Linux kernel interfaces.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
>> ---
>>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> index 6ececad6f845..8554102a6ead 100644
>> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
>> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
>>  	drm_kms_helper_poll_fini(ddev);
>>  	drm_mode_config_cleanup(ddev);
>>  	drm_irq_uninstall(ddev);
>> -	drm_dev_unref(ddev);
>> +	drm_dev_put(ddev);
>>
>>  	return 0;
>>  }
>> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
>>  	drm_kms_helper_poll_fini(ddev);
>>  	drm_mode_config_cleanup(ddev);
>>  err_free_drm_dev:
>> -	drm_dev_unref(ddev);
>> +	drm_dev_put(ddev);
>>
>>  	return ret;
>>  }
>> --
>> 2.19.0
>>
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
  2018-09-26 12:26     ` Thomas Zimmermann
@ 2018-09-26 12:53       ` Laurent Pinchart
  -1 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2018-09-26 12:53 UTC (permalink / raw)
  To: Thomas Zimmermann; +Cc: kieran.bingham+renesas, linux-renesas-soc, dri-devel

Hi Thomas,

On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote:
> Hi,
> 
> thanks for reviewing the patch and the one for rcar-du. Please also add
> them to your tree.

I took both patches in my tree. Thank you.

> Am 26.09.18 um 14:14 schrieb Kieran Bingham:
> > On 26/09/18 12:55, Thomas Zimmermann wrote:
> >> This patch unifies the naming of DRM functions for reference counting
> >> of struct drm_device. The resulting code is more aligned with the rest
> >> of the Linux kernel interfaces.
> >> 
> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > 
> >> ---
> >> 
> >>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index
> >> 6ececad6f845..8554102a6ead 100644
> >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device
> >> *pdev)
> >>  	drm_kms_helper_poll_fini(ddev);
> >>  	drm_mode_config_cleanup(ddev);
> >>  	drm_irq_uninstall(ddev);
> >> -	drm_dev_unref(ddev);
> >> +	drm_dev_put(ddev);
> >> 
> >>  	return 0;
> >>  }
> >> 
> >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device
> >> *pdev)
> >>  	drm_kms_helper_poll_fini(ddev);
> >>  	drm_mode_config_cleanup(ddev);
> >>  
> >>  err_free_drm_dev:
> >> -	drm_dev_unref(ddev);
> >> +	drm_dev_put(ddev);
> >>  	return ret;
> >>  }
> >> 

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put
@ 2018-09-26 12:53       ` Laurent Pinchart
  0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2018-09-26 12:53 UTC (permalink / raw)
  To: Thomas Zimmermann; +Cc: linux-renesas-soc, kieran.bingham+renesas, dri-devel

Hi Thomas,

On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote:
> Hi,
> 
> thanks for reviewing the patch and the one for rcar-du. Please also add
> them to your tree.

I took both patches in my tree. Thank you.

> Am 26.09.18 um 14:14 schrieb Kieran Bingham:
> > On 26/09/18 12:55, Thomas Zimmermann wrote:
> >> This patch unifies the naming of DRM functions for reference counting
> >> of struct drm_device. The resulting code is more aligned with the rest
> >> of the Linux kernel interfaces.
> >> 
> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > 
> >> ---
> >> 
> >>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index
> >> 6ececad6f845..8554102a6ead 100644
> >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device
> >> *pdev)
> >>  	drm_kms_helper_poll_fini(ddev);
> >>  	drm_mode_config_cleanup(ddev);
> >>  	drm_irq_uninstall(ddev);
> >> -	drm_dev_unref(ddev);
> >> +	drm_dev_put(ddev);
> >> 
> >>  	return 0;
> >>  }
> >> 
> >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device
> >> *pdev)
> >>  	drm_kms_helper_poll_fini(ddev);
> >>  	drm_mode_config_cleanup(ddev);
> >>  
> >>  err_free_drm_dev:
> >> -	drm_dev_unref(ddev);
> >> +	drm_dev_put(ddev);
> >>  	return ret;
> >>  }
> >> 

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-26 19:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 11:55 [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann
2018-09-26 11:55 ` Thomas Zimmermann
2018-09-26 12:14 ` Kieran Bingham
2018-09-26 12:14   ` Kieran Bingham
2018-09-26 12:26   ` Thomas Zimmermann
2018-09-26 12:26     ` Thomas Zimmermann
2018-09-26 12:53     ` Laurent Pinchart
2018-09-26 12:53       ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.