From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Leo Yan <leo.yan@linaro.org>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Mike Leach <mike.leach@linaro.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Daniel Kiss <Daniel.Kiss@arm.com>, Denis Nikitin <denik@chromium.org>, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 5/7] perf cs-etm: Fixup PID_FMT when it is zero Date: Mon, 11 Jan 2021 09:47:31 +0000 [thread overview] Message-ID: <27c8f898-93f3-6a2d-5e9e-b5b1225df1c9@arm.com> (raw) In-Reply-To: <20210109074435.626855-6-leo.yan@linaro.org> On 1/9/21 7:44 AM, Leo Yan wrote: > If the metadata item CS_ETM_PID_FMT/CS_ETMV4_PID_FMT is zero, this means > the perf data file is recorded with old version tool and the tool has > not extended to support the item. > > For this case, this patch fixes up PID_FMT entry to set the value as > BIT(ETM_OPT_CTXTID), this info will be delivered to the decoder to > extract PID from packet's field "context_id". > > Signed-off-by: Leo Yan <leo.yan@linaro.org> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > tools/perf/util/cs-etm.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 763085db29ae..8c125134a756 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -7,6 +7,7 @@ > */ > > #include <linux/bitops.h> > +#include <linux/coresight-pmu.h> > #include <linux/err.h> > #include <linux/kernel.h> > #include <linux/log2.h> > @@ -2577,6 +2578,15 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > for (k = 0; k < metadata_cpu_array_size; k++) > metadata[j][k] = ptr[i + k]; > > + /* > + * If the data in CS_ETM_PID_FMT is zero, means the > + * information isn't stored in the data file, this is > + * because the old perf tool hasn't yet supported > + * CS_ETM_PID_FMT. Fixup the item to option "CTXTID". > + */ > + if (!metadata[j][CS_ETM_PID_FMT]) > + metadata[j][CS_ETM_PID_FMT] = BIT(ETM_OPT_CTXTID); > + > /* The traceID is our handle */ > idx = metadata[j][CS_ETM_ETMTRACEIDR]; > i += metadata_cpu_array_size; > @@ -2590,6 +2600,15 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > for (k = 0; k < metadata_cpu_array_size; k++) > metadata[j][k] = ptr[i + k]; > > + /* > + * If the data in CS_ETMV4_PID_FMT is zero, means the > + * information isn't stored in the data file, this is > + * because the old perf tool hasn't yet supported > + * CS_ETMV4_PID_FMT. Fixup the item to option "CTXTID". > + */ > + if (!metadata[j][CS_ETMV4_PID_FMT]) > + metadata[j][CS_ETMV4_PID_FMT] = BIT(ETM_OPT_CTXTID); > + > /* The traceID is our handle */ > idx = metadata[j][CS_ETMV4_TRCTRACEIDR]; > i += metadata_cpu_array_size; >
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Leo Yan <leo.yan@linaro.org>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Mike Leach <mike.leach@linaro.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Daniel Kiss <Daniel.Kiss@arm.com>, Denis Nikitin <denik@chromium.org>, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 5/7] perf cs-etm: Fixup PID_FMT when it is zero Date: Mon, 11 Jan 2021 09:47:31 +0000 [thread overview] Message-ID: <27c8f898-93f3-6a2d-5e9e-b5b1225df1c9@arm.com> (raw) In-Reply-To: <20210109074435.626855-6-leo.yan@linaro.org> On 1/9/21 7:44 AM, Leo Yan wrote: > If the metadata item CS_ETM_PID_FMT/CS_ETMV4_PID_FMT is zero, this means > the perf data file is recorded with old version tool and the tool has > not extended to support the item. > > For this case, this patch fixes up PID_FMT entry to set the value as > BIT(ETM_OPT_CTXTID), this info will be delivered to the decoder to > extract PID from packet's field "context_id". > > Signed-off-by: Leo Yan <leo.yan@linaro.org> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > tools/perf/util/cs-etm.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 763085db29ae..8c125134a756 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -7,6 +7,7 @@ > */ > > #include <linux/bitops.h> > +#include <linux/coresight-pmu.h> > #include <linux/err.h> > #include <linux/kernel.h> > #include <linux/log2.h> > @@ -2577,6 +2578,15 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > for (k = 0; k < metadata_cpu_array_size; k++) > metadata[j][k] = ptr[i + k]; > > + /* > + * If the data in CS_ETM_PID_FMT is zero, means the > + * information isn't stored in the data file, this is > + * because the old perf tool hasn't yet supported > + * CS_ETM_PID_FMT. Fixup the item to option "CTXTID". > + */ > + if (!metadata[j][CS_ETM_PID_FMT]) > + metadata[j][CS_ETM_PID_FMT] = BIT(ETM_OPT_CTXTID); > + > /* The traceID is our handle */ > idx = metadata[j][CS_ETM_ETMTRACEIDR]; > i += metadata_cpu_array_size; > @@ -2590,6 +2600,15 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > for (k = 0; k < metadata_cpu_array_size; k++) > metadata[j][k] = ptr[i + k]; > > + /* > + * If the data in CS_ETMV4_PID_FMT is zero, means the > + * information isn't stored in the data file, this is > + * because the old perf tool hasn't yet supported > + * CS_ETMV4_PID_FMT. Fixup the item to option "CTXTID". > + */ > + if (!metadata[j][CS_ETMV4_PID_FMT]) > + metadata[j][CS_ETMV4_PID_FMT] = BIT(ETM_OPT_CTXTID); > + > /* The traceID is our handle */ > idx = metadata[j][CS_ETMV4_TRCTRACEIDR]; > i += metadata_cpu_array_size; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-11 9:48 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-09 7:44 [PATCH v1 0/7] coresight: etm-perf: Fix pid tracing with VHE Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-09 7:44 ` [PATCH v1 1/7] coresight: etm-perf: Add support for PID tracing for kernel at EL2 Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-09 10:05 ` kernel test robot 2021-01-10 1:24 ` [PATCH] " Suzuki K Poulose 2021-01-10 1:41 ` Leo Yan 2021-01-10 22:34 ` Suzuki K Poulose 2021-01-11 0:05 ` Leo Yan 2021-01-09 11:24 ` [PATCH v1 1/7] " kernel test robot 2021-01-11 16:22 ` Mike Leach 2021-01-11 16:22 ` Mike Leach 2021-01-12 7:22 ` Leo Yan 2021-01-12 7:22 ` Leo Yan 2021-01-12 8:58 ` Leo Yan 2021-01-12 8:58 ` Leo Yan 2021-01-12 11:03 ` Suzuki K Poulose 2021-01-12 11:03 ` Suzuki K Poulose 2021-01-12 11:23 ` Mike Leach 2021-01-12 11:23 ` Mike Leach 2021-01-12 14:14 ` Leo Yan 2021-01-12 14:14 ` Leo Yan 2021-01-12 23:43 ` Mike Leach 2021-01-12 23:43 ` Mike Leach 2021-01-15 22:30 ` Mathieu Poirier 2021-01-15 22:30 ` Mathieu Poirier 2021-01-19 7:05 ` Suzuki K Poulose 2021-01-19 7:05 ` Suzuki K Poulose 2021-01-09 7:44 ` [PATCH v1 2/7] perf cs_etm: Use pid tracing explicitly instead of contextid Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-15 22:44 ` Mathieu Poirier 2021-01-15 22:44 ` Mathieu Poirier 2021-01-19 2:32 ` Leo Yan 2021-01-19 2:32 ` Leo Yan 2021-01-09 7:44 ` [PATCH v1 3/7] perf cs-etm: Calculate per CPU metadata array size Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-11 7:28 ` Suzuki K Poulose 2021-01-11 7:28 ` Suzuki K Poulose 2021-01-11 12:09 ` Mike Leach 2021-01-11 12:09 ` Mike Leach 2021-01-11 15:06 ` Leo Yan 2021-01-11 15:06 ` Leo Yan 2021-01-13 0:00 ` Mike Leach 2021-01-13 0:00 ` Mike Leach 2021-01-13 2:27 ` Leo Yan 2021-01-13 2:27 ` Leo Yan 2021-01-15 22:46 ` Mathieu Poirier 2021-01-15 22:46 ` Mathieu Poirier 2021-01-16 0:50 ` Leo Yan 2021-01-16 0:50 ` Leo Yan 2021-01-09 7:44 ` [PATCH v1 4/7] perf cs-etm: Add PID format into metadata Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-11 9:45 ` Suzuki K Poulose 2021-01-11 9:45 ` Suzuki K Poulose 2021-01-11 13:12 ` Leo Yan 2021-01-11 13:12 ` Leo Yan 2021-01-09 7:44 ` [PATCH v1 5/7] perf cs-etm: Fixup PID_FMT when it is zero Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-11 9:47 ` Suzuki K Poulose [this message] 2021-01-11 9:47 ` Suzuki K Poulose 2021-01-09 7:44 ` [PATCH v1 6/7] perf cs-etm: Add helper cs_etm__get_pid_fmt() Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-11 9:55 ` Suzuki K Poulose 2021-01-11 9:55 ` Suzuki K Poulose 2021-01-09 7:44 ` [PATCH v1 7/7] perf cs-etm: Detect pid in VMID for kernel running at EL2 Leo Yan 2021-01-09 7:44 ` Leo Yan 2021-01-11 10:07 ` Suzuki K Poulose 2021-01-11 10:07 ` Suzuki K Poulose 2021-01-11 13:10 ` Leo Yan 2021-01-11 13:10 ` Leo Yan 2021-01-11 18:16 ` [PATCH v1 0/7] coresight: etm-perf: Fix pid tracing with VHE Mathieu Poirier 2021-01-11 18:16 ` Mathieu Poirier 2021-01-12 7:23 ` Leo Yan 2021-01-12 7:23 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=27c8f898-93f3-6a2d-5e9e-b5b1225df1c9@arm.com \ --to=suzuki.poulose@arm.com \ --cc=Daniel.Kiss@arm.com \ --cc=acme@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=denik@chromium.org \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.