From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "PERIER Romain" <romain.perier@gmail.com>,
"Naoki FUKAUMI" <naobsd@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
netdev <netdev@vger.kernel.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards
Date: Wed, 03 Sep 2014 19:45:50 +0200 [thread overview]
Message-ID: <2909336.qILuPbXDGe@wuerfel> (raw)
In-Reply-To: <CABgxDoJOJ9bM2CgXyXjPvsv2DN_QO+HPAzCwfjdyKFDpUAOtOw@mail.gmail.com>
On Wednesday 03 September 2014 18:37:16 PERIER Romain wrote:
> It is an optional property used by arc-emac (the core driver), if it
> is not present the core driver generates one for you.
> Problem being that with this property two radxa rock boards connected
> on the same local network might have the same mac address.
>
> In this case it would be probably better to remove this property. What
> do you think ?
>
It would typically be filled in by the boot loader, and be all-zeroes
in the kernel-supplied dts file. I don't see a point in hardcoding
a particular MAC address in the dts file, since that won't work
unless it's the only device of that type in the network segment.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards
Date: Wed, 03 Sep 2014 19:45:50 +0200 [thread overview]
Message-ID: <2909336.qILuPbXDGe@wuerfel> (raw)
In-Reply-To: <CABgxDoJOJ9bM2CgXyXjPvsv2DN_QO+HPAzCwfjdyKFDpUAOtOw@mail.gmail.com>
On Wednesday 03 September 2014 18:37:16 PERIER Romain wrote:
> It is an optional property used by arc-emac (the core driver), if it
> is not present the core driver generates one for you.
> Problem being that with this property two radxa rock boards connected
> on the same local network might have the same mac address.
>
> In this case it would be probably better to remove this property. What
> do you think ?
>
It would typically be filled in by the boot loader, and be all-zeroes
in the kernel-supplied dts file. I don't see a point in hardcoding
a particular MAC address in the dts file, since that won't work
unless it's the only device of that type in the network segment.
Arnd
next prev parent reply other threads:[~2014-09-03 17:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 10:27 [PATCH v4 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 10:27 ` [PATCH 2/4] dt-bindings: Document EMAC Rockchip Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 14:26 ` Heiko Stübner
2014-09-03 14:26 ` Heiko Stübner
2014-09-03 10:27 ` [PATCH 3/4] ARM: dts: Add emac nodes to the rk3188 device tree Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 10:27 ` [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 15:29 ` Naoki FUKAUMI
2014-09-03 15:29 ` Naoki FUKAUMI
2014-09-03 16:37 ` PERIER Romain
2014-09-03 16:37 ` PERIER Romain
2014-09-03 17:45 ` Arnd Bergmann [this message]
2014-09-03 17:45 ` Arnd Bergmann
2014-09-03 10:42 ` [PATCH v4 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Varka Bhadram
2014-09-03 10:42 ` Varka Bhadram
2014-09-03 11:14 ` Arnd Bergmann
2014-09-03 11:14 ` Arnd Bergmann
2014-09-03 12:20 ` Heiko Stübner
2014-09-03 12:20 ` Heiko Stübner
2014-09-03 12:50 ` Arnd Bergmann
2014-09-03 12:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2909336.qILuPbXDGe@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naobsd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.