From: PERIER Romain <romain.perier@gmail.com>
To: Naoki FUKAUMI <naobsd@gmail.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards
Date: Wed, 3 Sep 2014 18:37:16 +0200 [thread overview]
Message-ID: <CABgxDoJOJ9bM2CgXyXjPvsv2DN_QO+HPAzCwfjdyKFDpUAOtOw@mail.gmail.com> (raw)
In-Reply-To: <CAFnsNoSmHwN3nJ5ZJL5fc_-kaECCoLBvpdBYQxkyLcUzLx5MTw@mail.gmail.com>
It is an optional property used by arc-emac (the core driver), if it
is not present the core driver generates one for you.
Problem being that with this property two radxa rock boards connected
on the same local network might have the same mac address.
In this case it would be probably better to remove this property. What
do you think ?
2014-09-03 17:29 GMT+02:00 Naoki FUKAUMI <naobsd@gmail.com>:
> On Wed, Sep 3, 2014 at 7:27 PM, Romain Perier <romain.perier@gmail.com> wrote:
>> This enables EMAC Rockchip support on radxa rock boards.
>>
>> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>> ---
>> arch/arm/boot/dts/rk3188-radxarock.dts | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
>> index 5e4e3c23..e1358d3 100644
>> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
>> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
>> @@ -76,6 +76,24 @@
>> };
>> };
>>
>> +&emac {
>> + status = "okay";
>> + compatible = "rockchip,rk3188-emac";
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
>> +
>> + mac-address = [ c6 ef 91 8e 60 4b ];
>
> is "mac-address" required?
WARNING: multiple messages have this Message-ID (diff)
From: romain.perier@gmail.com (PERIER Romain)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards
Date: Wed, 3 Sep 2014 18:37:16 +0200 [thread overview]
Message-ID: <CABgxDoJOJ9bM2CgXyXjPvsv2DN_QO+HPAzCwfjdyKFDpUAOtOw@mail.gmail.com> (raw)
In-Reply-To: <CAFnsNoSmHwN3nJ5ZJL5fc_-kaECCoLBvpdBYQxkyLcUzLx5MTw@mail.gmail.com>
It is an optional property used by arc-emac (the core driver), if it
is not present the core driver generates one for you.
Problem being that with this property two radxa rock boards connected
on the same local network might have the same mac address.
In this case it would be probably better to remove this property. What
do you think ?
2014-09-03 17:29 GMT+02:00 Naoki FUKAUMI <naobsd@gmail.com>:
> On Wed, Sep 3, 2014 at 7:27 PM, Romain Perier <romain.perier@gmail.com> wrote:
>> This enables EMAC Rockchip support on radxa rock boards.
>>
>> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>> ---
>> arch/arm/boot/dts/rk3188-radxarock.dts | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
>> index 5e4e3c23..e1358d3 100644
>> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
>> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
>> @@ -76,6 +76,24 @@
>> };
>> };
>>
>> +&emac {
>> + status = "okay";
>> + compatible = "rockchip,rk3188-emac";
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
>> +
>> + mac-address = [ c6 ef 91 8e 60 4b ];
>
> is "mac-address" required?
next prev parent reply other threads:[~2014-09-03 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 10:27 [PATCH v4 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 10:27 ` [PATCH 2/4] dt-bindings: Document EMAC Rockchip Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 14:26 ` Heiko Stübner
2014-09-03 14:26 ` Heiko Stübner
2014-09-03 10:27 ` [PATCH 3/4] ARM: dts: Add emac nodes to the rk3188 device tree Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 10:27 ` [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards Romain Perier
2014-09-03 10:27 ` Romain Perier
2014-09-03 15:29 ` Naoki FUKAUMI
2014-09-03 15:29 ` Naoki FUKAUMI
2014-09-03 16:37 ` PERIER Romain [this message]
2014-09-03 16:37 ` PERIER Romain
2014-09-03 17:45 ` Arnd Bergmann
2014-09-03 17:45 ` Arnd Bergmann
2014-09-03 10:42 ` [PATCH v4 1/4] ethernet: arc: Add support for Rockchip SoC layer device tree bindings Varka Bhadram
2014-09-03 10:42 ` Varka Bhadram
2014-09-03 11:14 ` Arnd Bergmann
2014-09-03 11:14 ` Arnd Bergmann
2014-09-03 12:20 ` Heiko Stübner
2014-09-03 12:20 ` Heiko Stübner
2014-09-03 12:50 ` Arnd Bergmann
2014-09-03 12:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgxDoJOJ9bM2CgXyXjPvsv2DN_QO+HPAzCwfjdyKFDpUAOtOw@mail.gmail.com \
--to=romain.perier@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naobsd@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.