From: <Conor.Dooley@microchip.com>
To: <broonie@kernel.org>
Cc: <linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
<robh+dt@kernel.org>, <jassisinghbrar@gmail.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>, <gregkh@linuxfoundation.org>,
<thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
<lee.jones@linaro.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-crypto@vger.kernel.org>,
<linux-rtc@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <krzysztof.kozlowski@canonical.com>,
<geert@linux-m68k.org>, <bin.meng@windriver.com>,
<heiko@sntech.de>, <Lewis.Hanly@microchip.com>,
<Daire.McNamara@microchip.com>, <Ivan.Griffin@microchip.com>,
<atish.patra@wdc.com>
Subject: Re: [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip mpfs spi
Date: Mon, 20 Dec 2021 08:05:13 +0000 [thread overview]
Message-ID: <2981d13d-13c7-f455-722e-778fb07f170f@microchip.com> (raw)
In-Reply-To: <Ybx3+3QaVe2lCcQP@sirena.org.uk>
On 17/12/2021 11:43, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe
>
> On Fri, Dec 17, 2021 at 11:40:29AM +0000, Conor.Dooley@microchip.com
wrote:
>> On 17/12/2021 11:17, Mark Brown wrote:
>>> Why do you need this property in the DT - isn't the number of chip
>>> selects in the IP a fixes property?
>>
>> Nope! It's an IP that's intended for use in FPGAs so the number of
>> selects may (and does) vary based on implementation.
>
> That doesn't explain why the number is needed in the binding - why do
> you need this property in the DT?
Took another look at the IP core configuration & I think you're right
and that property can be dropped. The register responsible for CS
control will not be optimised away even if the CS is not used & the
worst outcome is that nothing will happen.
WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <broonie@kernel.org>
Cc: <linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
<robh+dt@kernel.org>, <jassisinghbrar@gmail.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>, <gregkh@linuxfoundation.org>,
<thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
<lee.jones@linaro.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-crypto@vger.kernel.org>,
<linux-rtc@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <krzysztof.kozlowski@canonical.com>,
<geert@linux-m68k.org>, <bin.meng@windriver.com>,
<heiko@sntech.de>, <Lewis.Hanly@microchip.com>,
<Daire.McNamara@microchip.com>, <Ivan.Griffin@microchip.com>,
<atish.patra@wdc.com>
Subject: Re: [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip mpfs spi
Date: Mon, 20 Dec 2021 08:05:13 +0000 [thread overview]
Message-ID: <2981d13d-13c7-f455-722e-778fb07f170f@microchip.com> (raw)
In-Reply-To: <Ybx3+3QaVe2lCcQP@sirena.org.uk>
On 17/12/2021 11:43, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe
>
> On Fri, Dec 17, 2021 at 11:40:29AM +0000, Conor.Dooley@microchip.com
wrote:
>> On 17/12/2021 11:17, Mark Brown wrote:
>>> Why do you need this property in the DT - isn't the number of chip
>>> selects in the IP a fixes property?
>>
>> Nope! It's an IP that's intended for use in FPGAs so the number of
>> selects may (and does) vary based on implementation.
>
> That doesn't explain why the number is needed in the binding - why do
> you need this property in the DT?
Took another look at the IP core configuration & I think you're right
and that property can be dropped. The register responsible for CS
control will not be optimised away even if the CS is not used & the
worst outcome is that nothing will happen.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-12-20 8:05 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 9:33 [PATCH v2 00/17] Update the Icicle Kit device tree conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 9:33 ` [PATCH v2 01/17] dt-bindings: interrupt-controller: create a header for RISC-V interrupts conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-21 17:47 ` Rob Herring
2021-12-21 17:47 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 02/17] dt-bindings: soc/microchip: update syscontroller compatibles conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 13:24 ` Geert Uytterhoeven
2021-12-17 13:24 ` Geert Uytterhoeven
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 03/17] dt-bindings: soc/microchip: make systemcontroller a mfd conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-21 17:55 ` Rob Herring
2021-12-21 17:55 ` Rob Herring
2021-12-21 23:50 ` conor dooley
2021-12-21 23:50 ` conor dooley
2021-12-17 9:33 ` [PATCH v2 04/17] mailbox: change mailbox-mpfs compatible string conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 13:25 ` Geert Uytterhoeven
2021-12-17 13:25 ` Geert Uytterhoeven
2021-12-17 9:33 ` [PATCH v2 05/17] dt-bindings: i2c: add bindings for microchip mpfs i2c conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 06/17] dt-bindings: rng: add bindings for microchip mpfs rng conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:53 ` Krzysztof Kozlowski
2021-12-17 14:53 ` Krzysztof Kozlowski
2021-12-17 15:07 ` Krzysztof Kozlowski
2021-12-17 15:07 ` Krzysztof Kozlowski
2021-12-17 15:22 ` Conor.Dooley
2021-12-17 15:22 ` Conor.Dooley
2021-12-17 15:47 ` Krzysztof Kozlowski
2021-12-17 15:47 ` Krzysztof Kozlowski
2021-12-17 16:26 ` conor dooley
2021-12-17 16:26 ` conor dooley
2021-12-17 9:33 ` [PATCH v2 07/17] dt-bindings: rtc: add bindings for microchip mpfs rtc conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-20 14:37 ` Rob Herring
2021-12-20 14:37 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 08/17] dt-bindings: soc/microchip: add bindings for mpfs system services conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 9:33 ` [PATCH v2 09/17] dt-bindings: gpio: add bindings for microchip mpfs gpio conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip mpfs spi conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 11:17 ` Mark Brown
2021-12-17 11:17 ` Mark Brown
2021-12-17 11:40 ` Conor.Dooley
2021-12-17 11:40 ` Conor.Dooley
2021-12-17 11:43 ` Mark Brown
2021-12-17 11:43 ` Mark Brown
2021-12-20 8:05 ` Conor.Dooley [this message]
2021-12-20 8:05 ` Conor.Dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 11/17] dt-bindings: usb: add bindings for microchip mpfs musb conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-21 13:32 ` Rob Herring
2021-12-21 13:32 ` Rob Herring
2021-12-17 9:33 ` [PATCH v2 12/17] dt-bindings: pwm: add microchip corePWM binding conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:21 ` Rob Herring
2021-12-17 14:58 ` Krzysztof Kozlowski
2021-12-17 14:58 ` Krzysztof Kozlowski
2021-12-17 9:33 ` [PATCH v2 13/17] riscv: dts: microchip: use hart and clk defines for icicle kit conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 13:40 ` Geert Uytterhoeven
2021-12-17 13:40 ` Geert Uytterhoeven
2021-12-17 9:33 ` [PATCH v2 14/17] riscv: dts: microchip: add fpga fabric section to " conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 13:43 ` Geert Uytterhoeven
2021-12-17 13:43 ` Geert Uytterhoeven
2021-12-17 15:32 ` Conor.Dooley
2021-12-17 15:32 ` Conor.Dooley
2021-12-17 16:00 ` Geert Uytterhoeven
2021-12-17 16:00 ` Geert Uytterhoeven
2022-01-12 9:38 ` Conor.Dooley
2022-01-12 9:38 ` Conor.Dooley
2022-01-14 13:35 ` Conor.Dooley
2022-01-14 13:35 ` Conor.Dooley
2021-12-17 14:59 ` Krzysztof Kozlowski
2021-12-17 14:59 ` Krzysztof Kozlowski
2021-12-17 9:33 ` [PATCH v2 15/17] riscv: dts: microchip: refactor icicle kit device tree conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 15:04 ` Krzysztof Kozlowski
2021-12-17 15:04 ` Krzysztof Kozlowski
2021-12-17 15:23 ` Conor.Dooley
2021-12-17 15:23 ` Conor.Dooley
2021-12-17 9:33 ` [PATCH v2 16/17] riscv: dts: microchip: update peripherals in " conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 9:33 ` [PATCH v2 17/17] MAINTAINERS: update riscv/microchip entry conor.dooley
2021-12-17 9:33 ` conor.dooley
2021-12-17 15:09 ` Krzysztof Kozlowski
2021-12-17 15:09 ` Krzysztof Kozlowski
2021-12-23 14:56 ` Conor.Dooley
2021-12-23 14:56 ` Conor.Dooley
2021-12-23 17:36 ` Palmer Dabbelt
2021-12-23 17:36 ` Palmer Dabbelt
2022-01-12 13:32 ` Lewis.Hanly
2022-01-12 13:32 ` Lewis.Hanly
2021-12-17 9:48 ` [PATCH v2 00/17] Update the Icicle Kit device tree Geert Uytterhoeven
2021-12-17 9:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2981d13d-13c7-f455-722e-778fb07f170f@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Ivan.Griffin@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=bin.meng@windriver.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.