From: Marc Zyngier <maz@kernel.org> To: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> Cc: tglx@linutronix.de, jason@lakedaemon.net, s-anna@ti.com, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts Date: Thu, 02 Jul 2020 18:44:30 +0100 [thread overview] Message-ID: <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> (raw) In-Reply-To: <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> On 2020-07-02 15:17, Grzegorz Jaszczyk wrote: > From: Suman Anna <s-anna@ti.com> > > The PRUSS INTC has a fixed number of output interrupt lines that are > connected to a number of processors or other PRUSS instances or other > devices (like DMA) on the SoC. The output interrupt lines 2 through 9 > are usually connected to the main Arm host processor and are referred > to as host interrupts 0 through 7 from ARM/MPU perspective. > > All of these 8 host interrupts are not always exclusively connected > to the Arm interrupt controller. Some SoCs have some interrupt lines > not connected to the Arm interrupt controller at all, while a few > others > have the interrupt lines connected to multiple processors in which they > need to be partitioned as per SoC integration needs. For example, > AM437x > and 66AK2G SoCs have 2 PRUSS instances each and have the host interrupt > 5 > connected to the other PRUSS, while AM335x has host interrupt 0 shared > between MPU and TSC_ADC and host interrupts 6 & 7 shared between MPU > and > a DMA controller. > > Add support to the PRUSS INTC driver to allow both these shared and > invalid interrupts by not returning a failure if any of these > interrupts > are skipped from the corresponding INTC DT node. That's not exactly "adding support", is it? It really is "ignore these interrupts because they are useless from the main CPU's perspective", right? > > Signed-off-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > --- > v2->v3: > - Extra checks for (intc->irqs[i]) in error/remove path was moved from > "irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS > interrupts" to this patch > v1->v2: > - https://patchwork.kernel.org/patch/11069757/ > --- > drivers/irqchip/irq-pruss-intc.c | 73 > +++++++++++++++++++++++++++++++++++++--- > 1 file changed, 68 insertions(+), 5 deletions(-) > > diff --git a/drivers/irqchip/irq-pruss-intc.c > b/drivers/irqchip/irq-pruss-intc.c > index fb3dda3..49c936f 100644 > --- a/drivers/irqchip/irq-pruss-intc.c > +++ b/drivers/irqchip/irq-pruss-intc.c > @@ -65,11 +65,15 @@ > * @irqs: kernel irq numbers corresponding to PRUSS host interrupts > * @base: base virtual address of INTC register space > * @domain: irq domain for this interrupt controller > + * @shared_intr: bit-map denoting if the MPU host interrupt is shared nit: bitmap > + * @invalid_intr: bit-map denoting if host interrupt is not connected > to MPU > */ > struct pruss_intc { > unsigned int irqs[MAX_NUM_HOST_IRQS]; > void __iomem *base; > struct irq_domain *domain; > + u16 shared_intr; > + u16 invalid_intr; Please represent bitmaps as an unsigned long. > }; > > static inline u32 pruss_intc_read_reg(struct pruss_intc *intc, > unsigned int reg) > @@ -222,7 +226,8 @@ static int pruss_intc_probe(struct platform_device > *pdev) > "host_intr4", "host_intr5", "host_intr6", "host_intr7", }; > struct device *dev = &pdev->dev; > struct pruss_intc *intc; > - int i, irq; > + int i, irq, count; > + u8 temp_intr[MAX_NUM_HOST_IRQS] = { 0 }; > > intc = devm_kzalloc(dev, sizeof(*intc), GFP_KERNEL); > if (!intc) > @@ -235,6 +240,52 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return PTR_ERR(intc->base); > } > > + count = of_property_read_variable_u8_array(dev->of_node, > + "ti,irqs-reserved", > + temp_intr, 0, > + MAX_NUM_HOST_IRQS); > + /* > + * The irqs-reserved is used only for some SoC's therefore not having > + * this property is still valid > + */ > + if (count == -EINVAL) > + count = 0; > + if (count < 0) > + return count; > + > + for (i = 0; i < count; i++) { > + if (temp_intr[i] >= MAX_NUM_HOST_IRQS) { > + dev_warn(dev, "ignoring invalid reserved irq %d\n", > + temp_intr[i]); > + continue; > + } > + > + intc->invalid_intr |= BIT(temp_intr[i]); > + } > + > + count = of_property_read_variable_u8_array(dev->of_node, > + "ti,irqs-shared", > + temp_intr, 0, > + MAX_NUM_HOST_IRQS); > + /* > + * The irqs-shared is used only for some SoC's therefore not having > + * this property is still valid > + */ > + if (count == -EINVAL) > + count = 0; > + if (count < 0) > + return count; > + > + for (i = 0; i < count; i++) { > + if (temp_intr[i] >= MAX_NUM_HOST_IRQS) { > + dev_warn(dev, "ignoring invalid shared irq %d\n", > + temp_intr[i]); > + continue; > + } > + > + intc->shared_intr |= BIT(temp_intr[i]); > + } > + You probably want to move this in a separate function, since you populate a common structure. > pruss_intc_init(intc); > > /* always 64 events */ > @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return -ENOMEM; > > for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { > + if (intc->invalid_intr & BIT(i)) > + continue; > + > irq = platform_get_irq_byname(pdev, irq_names[i]); > if (irq <= 0) { > + if (intc->shared_intr & BIT(i)) > + continue; I don't really understand why you are treating these "shared" interrupts differently from the invalid ones. In all cases, they shouldn't be used. > + > dev_err(dev, "platform_get_irq_byname failed for %s : %d\n", > irq_names[i], irq); > goto fail_irq; > @@ -259,8 +316,11 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return 0; > > fail_irq: > - while (--i >= 0) > - irq_set_chained_handler_and_data(intc->irqs[i], NULL, NULL); > + while (--i >= 0) { > + if (intc->irqs[i]) > + irq_set_chained_handler_and_data(intc->irqs[i], NULL, > + NULL); > + } > > irq_domain_remove(intc->domain); > > @@ -273,8 +333,11 @@ static int pruss_intc_remove(struct > platform_device *pdev) > unsigned int hwirq; > int i; > > - for (i = 0; i < MAX_NUM_HOST_IRQS; i++) > - irq_set_chained_handler_and_data(intc->irqs[i], NULL, NULL); > + for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { > + if (intc->irqs[i]) > + irq_set_chained_handler_and_data(intc->irqs[i], NULL, > + NULL); > + } > > for (hwirq = 0; hwirq < MAX_PRU_SYS_EVENTS; hwirq++) > irq_dispose_mapping(irq_find_mapping(intc->domain, hwirq)); Thanks, M. -- Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, jason@lakedaemon.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, tglx@linutronix.de, lee.jones@linaro.org, wmills@ti.com, linux-arm-kernel@lists.infradead.org, david@lechnology.com Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts Date: Thu, 02 Jul 2020 18:44:30 +0100 [thread overview] Message-ID: <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> (raw) In-Reply-To: <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> On 2020-07-02 15:17, Grzegorz Jaszczyk wrote: > From: Suman Anna <s-anna@ti.com> > > The PRUSS INTC has a fixed number of output interrupt lines that are > connected to a number of processors or other PRUSS instances or other > devices (like DMA) on the SoC. The output interrupt lines 2 through 9 > are usually connected to the main Arm host processor and are referred > to as host interrupts 0 through 7 from ARM/MPU perspective. > > All of these 8 host interrupts are not always exclusively connected > to the Arm interrupt controller. Some SoCs have some interrupt lines > not connected to the Arm interrupt controller at all, while a few > others > have the interrupt lines connected to multiple processors in which they > need to be partitioned as per SoC integration needs. For example, > AM437x > and 66AK2G SoCs have 2 PRUSS instances each and have the host interrupt > 5 > connected to the other PRUSS, while AM335x has host interrupt 0 shared > between MPU and TSC_ADC and host interrupts 6 & 7 shared between MPU > and > a DMA controller. > > Add support to the PRUSS INTC driver to allow both these shared and > invalid interrupts by not returning a failure if any of these > interrupts > are skipped from the corresponding INTC DT node. That's not exactly "adding support", is it? It really is "ignore these interrupts because they are useless from the main CPU's perspective", right? > > Signed-off-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > --- > v2->v3: > - Extra checks for (intc->irqs[i]) in error/remove path was moved from > "irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS > interrupts" to this patch > v1->v2: > - https://patchwork.kernel.org/patch/11069757/ > --- > drivers/irqchip/irq-pruss-intc.c | 73 > +++++++++++++++++++++++++++++++++++++--- > 1 file changed, 68 insertions(+), 5 deletions(-) > > diff --git a/drivers/irqchip/irq-pruss-intc.c > b/drivers/irqchip/irq-pruss-intc.c > index fb3dda3..49c936f 100644 > --- a/drivers/irqchip/irq-pruss-intc.c > +++ b/drivers/irqchip/irq-pruss-intc.c > @@ -65,11 +65,15 @@ > * @irqs: kernel irq numbers corresponding to PRUSS host interrupts > * @base: base virtual address of INTC register space > * @domain: irq domain for this interrupt controller > + * @shared_intr: bit-map denoting if the MPU host interrupt is shared nit: bitmap > + * @invalid_intr: bit-map denoting if host interrupt is not connected > to MPU > */ > struct pruss_intc { > unsigned int irqs[MAX_NUM_HOST_IRQS]; > void __iomem *base; > struct irq_domain *domain; > + u16 shared_intr; > + u16 invalid_intr; Please represent bitmaps as an unsigned long. > }; > > static inline u32 pruss_intc_read_reg(struct pruss_intc *intc, > unsigned int reg) > @@ -222,7 +226,8 @@ static int pruss_intc_probe(struct platform_device > *pdev) > "host_intr4", "host_intr5", "host_intr6", "host_intr7", }; > struct device *dev = &pdev->dev; > struct pruss_intc *intc; > - int i, irq; > + int i, irq, count; > + u8 temp_intr[MAX_NUM_HOST_IRQS] = { 0 }; > > intc = devm_kzalloc(dev, sizeof(*intc), GFP_KERNEL); > if (!intc) > @@ -235,6 +240,52 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return PTR_ERR(intc->base); > } > > + count = of_property_read_variable_u8_array(dev->of_node, > + "ti,irqs-reserved", > + temp_intr, 0, > + MAX_NUM_HOST_IRQS); > + /* > + * The irqs-reserved is used only for some SoC's therefore not having > + * this property is still valid > + */ > + if (count == -EINVAL) > + count = 0; > + if (count < 0) > + return count; > + > + for (i = 0; i < count; i++) { > + if (temp_intr[i] >= MAX_NUM_HOST_IRQS) { > + dev_warn(dev, "ignoring invalid reserved irq %d\n", > + temp_intr[i]); > + continue; > + } > + > + intc->invalid_intr |= BIT(temp_intr[i]); > + } > + > + count = of_property_read_variable_u8_array(dev->of_node, > + "ti,irqs-shared", > + temp_intr, 0, > + MAX_NUM_HOST_IRQS); > + /* > + * The irqs-shared is used only for some SoC's therefore not having > + * this property is still valid > + */ > + if (count == -EINVAL) > + count = 0; > + if (count < 0) > + return count; > + > + for (i = 0; i < count; i++) { > + if (temp_intr[i] >= MAX_NUM_HOST_IRQS) { > + dev_warn(dev, "ignoring invalid shared irq %d\n", > + temp_intr[i]); > + continue; > + } > + > + intc->shared_intr |= BIT(temp_intr[i]); > + } > + You probably want to move this in a separate function, since you populate a common structure. > pruss_intc_init(intc); > > /* always 64 events */ > @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return -ENOMEM; > > for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { > + if (intc->invalid_intr & BIT(i)) > + continue; > + > irq = platform_get_irq_byname(pdev, irq_names[i]); > if (irq <= 0) { > + if (intc->shared_intr & BIT(i)) > + continue; I don't really understand why you are treating these "shared" interrupts differently from the invalid ones. In all cases, they shouldn't be used. > + > dev_err(dev, "platform_get_irq_byname failed for %s : %d\n", > irq_names[i], irq); > goto fail_irq; > @@ -259,8 +316,11 @@ static int pruss_intc_probe(struct platform_device > *pdev) > return 0; > > fail_irq: > - while (--i >= 0) > - irq_set_chained_handler_and_data(intc->irqs[i], NULL, NULL); > + while (--i >= 0) { > + if (intc->irqs[i]) > + irq_set_chained_handler_and_data(intc->irqs[i], NULL, > + NULL); > + } > > irq_domain_remove(intc->domain); > > @@ -273,8 +333,11 @@ static int pruss_intc_remove(struct > platform_device *pdev) > unsigned int hwirq; > int i; > > - for (i = 0; i < MAX_NUM_HOST_IRQS; i++) > - irq_set_chained_handler_and_data(intc->irqs[i], NULL, NULL); > + for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { > + if (intc->irqs[i]) > + irq_set_chained_handler_and_data(intc->irqs[i], NULL, > + NULL); > + } > > for (hwirq = 0; hwirq < MAX_PRU_SYS_EVENTS; hwirq++) > irq_dispose_mapping(irq_find_mapping(intc->domain, hwirq)); Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-02 17:44 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 14:17 [PATCHv3 0/6] Add TI PRUSS Local Interrupt Controller IRQChip driver Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-02 14:17 ` [PATCHv3 1/6] dt-bindings: irqchip: Add PRU-ICSS interrupt controller bindings Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-13 21:25 ` Rob Herring 2020-07-13 21:25 ` Rob Herring 2020-07-16 9:25 ` Grzegorz Jaszczyk 2020-07-16 9:25 ` Grzegorz Jaszczyk 2020-07-02 14:17 ` [PATCHv3 2/6] irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS interrupts Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-02 17:24 ` Marc Zyngier 2020-07-02 17:24 ` Marc Zyngier 2020-07-03 14:28 ` Grzegorz Jaszczyk 2020-07-03 14:28 ` Grzegorz Jaszczyk 2020-07-04 9:39 ` Marc Zyngier 2020-07-04 9:39 ` Marc Zyngier 2020-07-05 13:26 ` Grzegorz Jaszczyk 2020-07-05 13:26 ` Grzegorz Jaszczyk 2020-07-05 20:45 ` Marc Zyngier 2020-07-05 20:45 ` Marc Zyngier 2020-07-08 7:04 ` Grzegorz Jaszczyk 2020-07-08 7:04 ` Grzegorz Jaszczyk 2020-07-08 10:47 ` Marc Zyngier 2020-07-08 10:47 ` Marc Zyngier 2020-07-10 23:03 ` Suman Anna 2020-07-10 23:03 ` Suman Anna 2020-07-15 13:38 ` Grzegorz Jaszczyk 2020-07-15 13:38 ` Grzegorz Jaszczyk 2020-07-17 12:36 ` Marc Zyngier 2020-07-17 12:36 ` Marc Zyngier 2020-07-21 9:27 ` Grzegorz Jaszczyk 2020-07-21 9:27 ` Grzegorz Jaszczyk 2020-07-21 10:10 ` Marc Zyngier 2020-07-21 10:10 ` Marc Zyngier 2020-07-21 13:59 ` Grzegorz Jaszczyk 2020-07-21 13:59 ` Grzegorz Jaszczyk 2020-07-02 14:17 ` [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-02 17:44 ` Marc Zyngier [this message] 2020-07-02 17:44 ` Marc Zyngier 2020-07-10 20:59 ` Suman Anna 2020-07-10 20:59 ` Suman Anna 2020-07-17 11:02 ` Marc Zyngier 2020-07-17 11:02 ` Marc Zyngier 2020-07-25 15:57 ` Suman Anna 2020-07-25 15:57 ` Suman Anna 2020-07-25 16:27 ` Marc Zyngier 2020-07-25 16:27 ` Marc Zyngier 2020-07-25 16:39 ` Suman Anna 2020-07-25 16:39 ` Suman Anna 2020-07-02 14:17 ` [PATCHv3 4/6] irqchip/irq-pruss-intc: Implement irq_{get,set}_irqchip_state ops Grzegorz Jaszczyk 2020-07-02 14:17 ` [PATCHv3 4/6] irqchip/irq-pruss-intc: Implement irq_{get, set}_irqchip_state ops Grzegorz Jaszczyk 2020-07-02 17:54 ` [PATCHv3 4/6] irqchip/irq-pruss-intc: Implement irq_{get,set}_irqchip_state ops Marc Zyngier 2020-07-02 17:54 ` Marc Zyngier 2020-07-03 17:04 ` Grzegorz Jaszczyk 2020-07-03 17:04 ` Grzegorz Jaszczyk 2020-07-10 21:04 ` Suman Anna 2020-07-10 21:04 ` Suman Anna 2020-07-02 14:17 ` [PATCHv3 5/6] irqchip/irq-pruss-intc: Add support for ICSSG INTC on K3 SoCs Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-02 17:59 ` Marc Zyngier 2020-07-02 17:59 ` Marc Zyngier 2020-07-03 17:05 ` Grzegorz Jaszczyk 2020-07-03 17:05 ` Grzegorz Jaszczyk 2020-07-10 21:13 ` Suman Anna 2020-07-10 21:13 ` Suman Anna 2020-07-02 14:17 ` [PATCHv3 6/6] irqchip/irq-pruss-intc: Add event mapping support Grzegorz Jaszczyk 2020-07-02 14:17 ` Grzegorz Jaszczyk 2020-07-02 16:24 ` Suman Anna 2020-07-02 16:24 ` Suman Anna 2020-07-05 13:39 ` Grzegorz Jaszczyk 2020-07-05 13:39 ` Grzegorz Jaszczyk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2a6b0391f1395eb0aa15ffee6769184e@kernel.org \ --to=maz@kernel.org \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=grzegorz.jaszczyk@linaro.org \ --cc=jason@lakedaemon.net \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s-anna@ti.com \ --cc=tglx@linutronix.de \ --cc=wmills@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.