All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	platform-driver-x86@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>,
	Marco Chiappero <marco@absence.it>,
	Matthew Garrett <mjg@redhat.com>,
	Mattia Dongili <malattia@linux.it>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Andy Shevchenko <andy@infradead.org>
Subject: Re: Sony-laptop: Adjustments for sony_nc_setup_rfkill()
Date: Sun, 5 Nov 2017 15:20:09 +0100	[thread overview]
Message-ID: <2c1996c5-0833-dcd3-c747-62eca46a433d@users.sourceforge.net> (raw)
In-Reply-To: <CAHp75VeyLnKG43g0LiDqirkehH4bLK7x216NV1+C8Oktp7D5UQ@mail.gmail.com>

>> Do you find the following details useful for further clarification?
>>
>> text: -32
>> data: 0
>> bss:  0
> 
> ...but kernel is compiled with -O2 which,

Did you try to compare results for my update suggestion also with
the default build configuration?


> I suppose, will eliminate these repeats.

My build results did not fit to your expectations.


> So, the main question is "WHY" you are doing this change.
> 
> I didn't find any convinced explanation (yet?).

Do you find a reduction of 32 bytes for the object code not interesting
enough just by achieving such a small effect because of the replacement
of three function calls “rfkill_destroy” with goto statements?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	platform-driver-x86@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>,
	Marco Chiappero <marco@absence.it>,
	Matthew Garrett <mjg@redhat.com>,
	Mattia Dongili <malattia@linux.it>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Andy Shevchenko <andy@infradead.org>
Subject: Re: Sony-laptop: Adjustments for sony_nc_setup_rfkill()
Date: Sun, 05 Nov 2017 14:20:09 +0000	[thread overview]
Message-ID: <2c1996c5-0833-dcd3-c747-62eca46a433d@users.sourceforge.net> (raw)
In-Reply-To: <CAHp75VeyLnKG43g0LiDqirkehH4bLK7x216NV1+C8Oktp7D5UQ@mail.gmail.com>

>> Do you find the following details useful for further clarification?
>>
>> text: -32
>> data: 0
>> bss:  0
> 
> ...but kernel is compiled with -O2 which,

Did you try to compare results for my update suggestion also with
the default build configuration?


> I suppose, will eliminate these repeats.

My build results did not fit to your expectations.


> So, the main question is "WHY" you are doing this change.
> 
> I didn't find any convinced explanation (yet?).

Do you find a reduction of 32 bytes for the object code not interesting
enough just by achieving such a small effect because of the replacement
of three function calls “rfkill_destroy” with goto statements?

Regards,
Markus

  reply	other threads:[~2017-11-05 14:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 20:15 [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring
2017-10-30 20:15 ` SF Markus Elfring
2017-10-31 13:33 ` Andy Shevchenko
2017-10-31 13:33   ` Andy Shevchenko
2017-10-31 14:24   ` SF Markus Elfring
2017-10-31 14:24     ` SF Markus Elfring
2017-10-31 16:35     ` Andy Shevchenko
2017-10-31 16:35       ` Andy Shevchenko
2017-10-31 16:56       ` SF Markus Elfring
2017-10-31 16:56         ` SF Markus Elfring
2017-11-01 18:45   ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:45     ` SF Markus Elfring
2017-11-01 18:46     ` [PATCH v2 1/3] Sony-laptop: Fix exception handling in sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:46       ` SF Markus Elfring
2017-11-03 12:00       ` Andy Shevchenko
2017-11-03 12:00         ` Andy Shevchenko
2017-11-01 18:47     ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-11-01 18:47       ` SF Markus Elfring
2017-11-03 12:00       ` Andy Shevchenko
2017-11-03 12:00         ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkil Andy Shevchenko
2017-11-01 18:49     ` [PATCH v2 3/3] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:49       ` SF Markus Elfring
2017-11-03 12:02     ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() Andy Shevchenko
2017-11-03 12:02       ` Andy Shevchenko
2017-11-03 13:23       ` SF Markus Elfring
2017-11-03 13:23         ` SF Markus Elfring
2017-11-05 13:24         ` Andy Shevchenko
2017-11-05 13:24           ` Andy Shevchenko
2017-11-05 14:20           ` SF Markus Elfring [this message]
2017-11-05 14:20             ` SF Markus Elfring
2017-11-07 12:49             ` Andy Shevchenko
2017-11-07 12:49               ` Andy Shevchenko
2017-11-07 13:00               ` SF Markus Elfring
2017-11-07 13:00                 ` SF Markus Elfring
2017-11-07 13:18                 ` Andy Shevchenko
2017-11-07 13:18                   ` Andy Shevchenko
2017-11-07 13:54                   ` SF Markus Elfring
2017-11-07 13:54                     ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c1996c5-0833-dcd3-c747-62eca46a433d@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=marco@absence.it \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.