From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Mattia Dongili <malattia@linux.it>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill()
Date: Tue, 31 Oct 2017 18:35:02 +0200 [thread overview]
Message-ID: <CAHp75VeDYakxD_g+N0RcmXFmGR3Du+p2yRaTiYhNxgr+0SQ9og@mail.gmail.com> (raw)
In-Reply-To: <dadb7068-e4ed-b91d-ce31-aca2d6afd9f3@users.sourceforge.net>
On Tue, Oct 31, 2017 at 4:24 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> Apparently this patch done without reading the actual code.
>
> I performed another simple software refactoring.
Which is _useless_ per se by the reasons you had been told already
_several_ times about.
Either you do a real fix (propagate correct error codes to upper
layers), or just don't bother at all.
>> NAK.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Mattia Dongili <malattia@linux.it>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill()
Date: Tue, 31 Oct 2017 16:35:02 +0000 [thread overview]
Message-ID: <CAHp75VeDYakxD_g+N0RcmXFmGR3Du+p2yRaTiYhNxgr+0SQ9og@mail.gmail.com> (raw)
In-Reply-To: <dadb7068-e4ed-b91d-ce31-aca2d6afd9f3@users.sourceforge.net>
On Tue, Oct 31, 2017 at 4:24 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> Apparently this patch done without reading the actual code.
>
> I performed another simple software refactoring.
Which is _useless_ per se by the reasons you had been told already
_several_ times about.
Either you do a real fix (propagate correct error codes to upper
layers), or just don't bother at all.
>> NAK.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-10-31 16:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 20:15 [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring
2017-10-30 20:15 ` SF Markus Elfring
2017-10-31 13:33 ` Andy Shevchenko
2017-10-31 13:33 ` Andy Shevchenko
2017-10-31 14:24 ` SF Markus Elfring
2017-10-31 14:24 ` SF Markus Elfring
2017-10-31 16:35 ` Andy Shevchenko [this message]
2017-10-31 16:35 ` Andy Shevchenko
2017-10-31 16:56 ` SF Markus Elfring
2017-10-31 16:56 ` SF Markus Elfring
2017-11-01 18:45 ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:45 ` SF Markus Elfring
2017-11-01 18:46 ` [PATCH v2 1/3] Sony-laptop: Fix exception handling in sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:46 ` SF Markus Elfring
2017-11-03 12:00 ` Andy Shevchenko
2017-11-03 12:00 ` Andy Shevchenko
2017-11-01 18:47 ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-11-01 18:47 ` SF Markus Elfring
2017-11-03 12:00 ` Andy Shevchenko
2017-11-03 12:00 ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkil Andy Shevchenko
2017-11-01 18:49 ` [PATCH v2 3/3] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring
2017-11-01 18:49 ` SF Markus Elfring
2017-11-03 12:02 ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() Andy Shevchenko
2017-11-03 12:02 ` Andy Shevchenko
2017-11-03 13:23 ` SF Markus Elfring
2017-11-03 13:23 ` SF Markus Elfring
2017-11-05 13:24 ` Andy Shevchenko
2017-11-05 13:24 ` Andy Shevchenko
2017-11-05 14:20 ` SF Markus Elfring
2017-11-05 14:20 ` SF Markus Elfring
2017-11-07 12:49 ` Andy Shevchenko
2017-11-07 12:49 ` Andy Shevchenko
2017-11-07 13:00 ` SF Markus Elfring
2017-11-07 13:00 ` SF Markus Elfring
2017-11-07 13:18 ` Andy Shevchenko
2017-11-07 13:18 ` Andy Shevchenko
2017-11-07 13:54 ` SF Markus Elfring
2017-11-07 13:54 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeDYakxD_g+N0RcmXFmGR3Du+p2yRaTiYhNxgr+0SQ9og@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.