From: SF Markus Elfring <elfring@users.sourceforge.net> To: Andy Shevchenko <andy.shevchenko@gmail.com>, platform-driver-x86@vger.kernel.org Cc: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>, Mattia Dongili <malattia@linux.it>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() Date: Tue, 31 Oct 2017 15:24:05 +0100 [thread overview] Message-ID: <dadb7068-e4ed-b91d-ce31-aca2d6afd9f3@users.sourceforge.net> (raw) In-Reply-To: <CAHp75VcMkXCioCzmLE0+BTmkqc5RSOx9yPO0ectVHMrMvewgwg@mail.gmail.com> > Apparently this patch done without reading the actual code. I performed another simple software refactoring. > NAK. > > -1 is EPERM which sounds wrong here. If you would like to fix it, > propagate a real error codes from sony_call_snc_handle(). I do not know at the moment why an error code which you find questionable was suggested by Marco Chiappero on 2012-05-19 and committed by Matthew Garrett on 2012-05-31 (according the commit d6f15ed876b83a1a0eba1d0473eef58acc95444a: use soft rfkill status stored in hw). >> if (!rfk) >> return -ENOMEM; > > Okay error code. Can any other identifier make more sense there? >> - } >> + if (sony_call_snc_handle(sony_rfkill_handle, 0x200, &result) < 0) >> + goto destroy_rfk; >> + >> hwblock = !(result & 0x1); >> >> if (sony_call_snc_handle(sony_rfkill_handle, >> - sony_rfkill_address[nc_type], >> - &result) < 0) { >> - rfkill_destroy(rfk); >> - return -1; > > Not okay and it might be different from previous case. The shown function call was repeated with an other parameter. Which error reporting would you find more appropriate then? > P.S. Don't bother us with patches on which you didn't do your home work. Do we occasionally need to distinguish better between an ordinary refactoring and the adjustments for additional software improvements? Regards, Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: Andy Shevchenko <andy.shevchenko@gmail.com>, platform-driver-x86@vger.kernel.org Cc: Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>, Mattia Dongili <malattia@linux.it>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() Date: Tue, 31 Oct 2017 14:24:05 +0000 [thread overview] Message-ID: <dadb7068-e4ed-b91d-ce31-aca2d6afd9f3@users.sourceforge.net> (raw) In-Reply-To: <CAHp75VcMkXCioCzmLE0+BTmkqc5RSOx9yPO0ectVHMrMvewgwg@mail.gmail.com> > Apparently this patch done without reading the actual code. I performed another simple software refactoring. > NAK. > > -1 is EPERM which sounds wrong here. If you would like to fix it, > propagate a real error codes from sony_call_snc_handle(). I do not know at the moment why an error code which you find questionable was suggested by Marco Chiappero on 2012-05-19 and committed by Matthew Garrett on 2012-05-31 (according the commit d6f15ed876b83a1a0eba1d0473eef58acc95444a: use soft rfkill status stored in hw). >> if (!rfk) >> return -ENOMEM; > > Okay error code. Can any other identifier make more sense there? >> - } >> + if (sony_call_snc_handle(sony_rfkill_handle, 0x200, &result) < 0) >> + goto destroy_rfk; >> + >> hwblock = !(result & 0x1); >> >> if (sony_call_snc_handle(sony_rfkill_handle, >> - sony_rfkill_address[nc_type], >> - &result) < 0) { >> - rfkill_destroy(rfk); >> - return -1; > > Not okay and it might be different from previous case. The shown function call was repeated with an other parameter. Which error reporting would you find more appropriate then? > P.S. Don't bother us with patches on which you didn't do your home work. Do we occasionally need to distinguish better between an ordinary refactoring and the adjustments for additional software improvements? Regards, Markus
next prev parent reply other threads:[~2017-10-31 14:24 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-30 20:15 [PATCH] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring 2017-10-30 20:15 ` SF Markus Elfring 2017-10-31 13:33 ` Andy Shevchenko 2017-10-31 13:33 ` Andy Shevchenko 2017-10-31 14:24 ` SF Markus Elfring [this message] 2017-10-31 14:24 ` SF Markus Elfring 2017-10-31 16:35 ` Andy Shevchenko 2017-10-31 16:35 ` Andy Shevchenko 2017-10-31 16:56 ` SF Markus Elfring 2017-10-31 16:56 ` SF Markus Elfring 2017-11-01 18:45 ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() SF Markus Elfring 2017-11-01 18:45 ` SF Markus Elfring 2017-11-01 18:46 ` [PATCH v2 1/3] Sony-laptop: Fix exception handling in sony_nc_setup_rfkill() SF Markus Elfring 2017-11-01 18:46 ` SF Markus Elfring 2017-11-03 12:00 ` Andy Shevchenko 2017-11-03 12:00 ` Andy Shevchenko 2017-11-01 18:47 ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation " SF Markus Elfring 2017-11-01 18:47 ` SF Markus Elfring 2017-11-03 12:00 ` Andy Shevchenko 2017-11-03 12:00 ` [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkil Andy Shevchenko 2017-11-01 18:49 ` [PATCH v2 3/3] Sony-laptop: Use common error handling code in sony_nc_setup_rfkill() SF Markus Elfring 2017-11-01 18:49 ` SF Markus Elfring 2017-11-03 12:02 ` [PATCH v2 0/3] Sony-laptop: Adjustments for sony_nc_setup_rfkill() Andy Shevchenko 2017-11-03 12:02 ` Andy Shevchenko 2017-11-03 13:23 ` SF Markus Elfring 2017-11-03 13:23 ` SF Markus Elfring 2017-11-05 13:24 ` Andy Shevchenko 2017-11-05 13:24 ` Andy Shevchenko 2017-11-05 14:20 ` SF Markus Elfring 2017-11-05 14:20 ` SF Markus Elfring 2017-11-07 12:49 ` Andy Shevchenko 2017-11-07 12:49 ` Andy Shevchenko 2017-11-07 13:00 ` SF Markus Elfring 2017-11-07 13:00 ` SF Markus Elfring 2017-11-07 13:18 ` Andy Shevchenko 2017-11-07 13:18 ` Andy Shevchenko 2017-11-07 13:54 ` SF Markus Elfring 2017-11-07 13:54 ` SF Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dadb7068-e4ed-b91d-ce31-aca2d6afd9f3@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=andy.shevchenko@gmail.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=malattia@linux.it \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.