* [PATCH 1/1] xilinx: disable Unicode capitalization
@ 2021-05-16 9:17 Heinrich Schuchardt
2021-05-17 6:39 ` Michal Simek
0 siblings, 1 reply; 10+ messages in thread
From: Heinrich Schuchardt @ 2021-05-16 9:17 UTC (permalink / raw)
To: u-boot
Save some KiB when building xilinx_versal_virt_defconfig by disabling
Unicode capitalization support. This avoids build failures when adding new
features for the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
It would be preferable to have a size check for the u-boot binary.
This would avoid seeing problems only during execution.
---
configs/xilinx_versal_virt_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig
index 707693713a..8bc2ff4a4c 100644
--- a/configs/xilinx_versal_virt_defconfig
+++ b/configs/xilinx_versal_virt_defconfig
@@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
CONFIG_USB_GADGET_DOWNLOAD=y
CONFIG_USB_FUNCTION_THOR=y
CONFIG_OF_LIBFDT_OVERLAY=y
+# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-16 9:17 [PATCH 1/1] xilinx: disable Unicode capitalization Heinrich Schuchardt
@ 2021-05-17 6:39 ` Michal Simek
2021-05-17 8:01 ` Heinrich Schuchardt
0 siblings, 1 reply; 10+ messages in thread
From: Michal Simek @ 2021-05-17 6:39 UTC (permalink / raw)
To: u-boot
On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
> Save some KiB when building xilinx_versal_virt_defconfig by disabling
> Unicode capitalization support. This avoids build failures when adding new
> features for the UEFI sub-system.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> It would be preferable to have a size check for the u-boot binary.
> This would avoid seeing problems only during execution.
> ---
> configs/xilinx_versal_virt_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig
> index 707693713a..8bc2ff4a4c 100644
> --- a/configs/xilinx_versal_virt_defconfig
> +++ b/configs/xilinx_versal_virt_defconfig
> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
> CONFIG_USB_GADGET_DOWNLOAD=y
> CONFIG_USB_FUNCTION_THOR=y
> CONFIG_OF_LIBFDT_OVERLAY=y
> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
> --
> 2.30.2
>
What's the build issue? Any log? U-Boot is getting bigger and bigger and
we are enabling more and more features for our generic targets that's
why fixing that problem is better than disabling some options.
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 6:39 ` Michal Simek
@ 2021-05-17 8:01 ` Heinrich Schuchardt
2021-05-17 9:04 ` Stefan Roese
0 siblings, 1 reply; 10+ messages in thread
From: Heinrich Schuchardt @ 2021-05-17 8:01 UTC (permalink / raw)
To: u-boot
On 17.05.21 08:39, Michal Simek wrote:
>
>
> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>> Save some KiB when building xilinx_versal_virt_defconfig by disabling
>> Unicode capitalization support. This avoids build failures when adding new
>> features for the UEFI sub-system.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>> It would be preferable to have a size check for the u-boot binary.
>> This would avoid seeing problems only during execution.
>> ---
>> configs/xilinx_versal_virt_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig
>> index 707693713a..8bc2ff4a4c 100644
>> --- a/configs/xilinx_versal_virt_defconfig
>> +++ b/configs/xilinx_versal_virt_defconfig
>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>> CONFIG_USB_GADGET_DOWNLOAD=y
>> CONFIG_USB_FUNCTION_THOR=y
>> CONFIG_OF_LIBFDT_OVERLAY=y
>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>> --
>> 2.30.2
>>
>
> What's the build issue? Any log? U-Boot is getting bigger and bigger and
Hello Michal,
this job failed:
https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
> we are enabling more and more features for our generic targets that's
> why fixing that problem is better than disabling some options.
I do not understand what you mean here.
CONFIG_EFI_UNICODE_CAPITALIZATION is enabled since years.
Best regards
Heinrich
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 8:01 ` Heinrich Schuchardt
@ 2021-05-17 9:04 ` Stefan Roese
2021-05-17 9:37 ` Michal Simek
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Roese @ 2021-05-17 9:04 UTC (permalink / raw)
To: u-boot
Added Tom to Cc.
On 17.05.21 10:01, Heinrich Schuchardt wrote:
> On 17.05.21 08:39, Michal Simek wrote:
>>
>>
>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>> Save some KiB when building xilinx_versal_virt_defconfig by disabling
>>> Unicode capitalization support. This avoids build failures when adding new
>>> features for the UEFI sub-system.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> ---
>>> It would be preferable to have a size check for the u-boot binary.
>>> This would avoid seeing problems only during execution.
>>> ---
>>> configs/xilinx_versal_virt_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/xilinx_versal_virt_defconfig b/configs/xilinx_versal_virt_defconfig
>>> index 707693713a..8bc2ff4a4c 100644
>>> --- a/configs/xilinx_versal_virt_defconfig
>>> +++ b/configs/xilinx_versal_virt_defconfig
>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>> CONFIG_USB_GADGET_DOWNLOAD=y
>>> CONFIG_USB_FUNCTION_THOR=y
>>> CONFIG_OF_LIBFDT_OVERLAY=y
>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>> --
>>> 2.30.2
>>>
>>
>> What's the build issue? Any log? U-Boot is getting bigger and bigger and
>
> Hello Michal,
>
> this job failed:
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>
> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
I had a similar, most likely related issue a few days ago:
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
Tom git bi-sected this to this commit, which only adds a bit tiny bit
of image size I assume:
"I bisected this down to:
commit 368b3f6db4540f913c436e5287be8356bc9a2891
Author: Stefan Chulski <stefanc@marvell.com>
Date: Mon May 3 08:08:44 2021 +0200
phy: introduce 1000BaseX and 2500BaseX modes
Signed-off-by: Stefan Chulski <stefanc@marvell.com>
Signed-off-by: Stefan Roese <sr@denx.de>
And while I'm not sure off-hand how it does it, it's causing the
breakage. Maybe something is overflowing now?"
Thanks,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 9:04 ` Stefan Roese
@ 2021-05-17 9:37 ` Michal Simek
2021-05-17 9:40 ` Stefan Roese
0 siblings, 1 reply; 10+ messages in thread
From: Michal Simek @ 2021-05-17 9:37 UTC (permalink / raw)
To: u-boot
Hi,
On 5/17/21 11:04 AM, Stefan Roese wrote:
> Added Tom to Cc.
>
> On 17.05.21 10:01, Heinrich Schuchardt wrote:
>> On 17.05.21 08:39, Michal Simek wrote:
>>>
>>>
>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>>> Save some KiB when building? xilinx_versal_virt_defconfig by disabling
>>>> Unicode capitalization support. This avoids build failures when
>>>> adding new
>>>> features for the UEFI sub-system.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>> ---
>>>> It would be preferable to have a size check for the u-boot binary.
>>>> This would avoid seeing problems only during execution.
>>>> ---
>>>> ? configs/xilinx_versal_virt_defconfig | 1 +
>>>> ? 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/configs/xilinx_versal_virt_defconfig
>>>> b/configs/xilinx_versal_virt_defconfig
>>>> index 707693713a..8bc2ff4a4c 100644
>>>> --- a/configs/xilinx_versal_virt_defconfig
>>>> +++ b/configs/xilinx_versal_virt_defconfig
>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>> ? CONFIG_USB_GADGET_DOWNLOAD=y
>>>> ? CONFIG_USB_FUNCTION_THOR=y
>>>> ? CONFIG_OF_LIBFDT_OVERLAY=y
>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>>> --
>>>> 2.30.2
>>>>
>>>
>>> What's the build issue? Any log? U-Boot is getting bigger and bigger and
>>
>> Hello Michal,
>>
>> this job failed:
>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>>
>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
>
> I had a similar, most likely related issue a few days ago:
>
> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
>
> Tom git bi-sected this to this commit, which only adds a bit tiny bit
> of image size I assume:
>
> "I bisected this down to:
> commit 368b3f6db4540f913c436e5287be8356bc9a2891
> Author: Stefan Chulski <stefanc@marvell.com>
> Date:?? Mon May 3 08:08:44 2021 +0200
>
> ??? phy: introduce 1000BaseX and 2500BaseX modes
>
> ??? Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> ??? Signed-off-by: Stefan Roese <sr@denx.de>
>
> And while I'm not sure off-hand how it does it, it's causing the
> breakage.? Maybe something is overflowing now?"
I have rebase Heinrich patches on the top of HEAD + my queue and I can't
see any issue
https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
It means likely what Stefan mentioned is likely correct.
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 9:37 ` Michal Simek
@ 2021-05-17 9:40 ` Stefan Roese
2021-05-17 9:47 ` Michal Simek
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Roese @ 2021-05-17 9:40 UTC (permalink / raw)
To: u-boot
Hi Michal,
On 17.05.21 11:37, Michal Simek wrote:
> Hi,
>
> On 5/17/21 11:04 AM, Stefan Roese wrote:
>> Added Tom to Cc.
>>
>> On 17.05.21 10:01, Heinrich Schuchardt wrote:
>>> On 17.05.21 08:39, Michal Simek wrote:
>>>>
>>>>
>>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>>>> Save some KiB when building? xilinx_versal_virt_defconfig by disabling
>>>>> Unicode capitalization support. This avoids build failures when
>>>>> adding new
>>>>> features for the UEFI sub-system.
>>>>>
>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>> ---
>>>>> It would be preferable to have a size check for the u-boot binary.
>>>>> This would avoid seeing problems only during execution.
>>>>> ---
>>>>> ? configs/xilinx_versal_virt_defconfig | 1 +
>>>>> ? 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/configs/xilinx_versal_virt_defconfig
>>>>> b/configs/xilinx_versal_virt_defconfig
>>>>> index 707693713a..8bc2ff4a4c 100644
>>>>> --- a/configs/xilinx_versal_virt_defconfig
>>>>> +++ b/configs/xilinx_versal_virt_defconfig
>>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>>> ? CONFIG_USB_GADGET_DOWNLOAD=y
>>>>> ? CONFIG_USB_FUNCTION_THOR=y
>>>>> ? CONFIG_OF_LIBFDT_OVERLAY=y
>>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>>>> --
>>>>> 2.30.2
>>>>>
>>>>
>>>> What's the build issue? Any log? U-Boot is getting bigger and bigger and
>>>
>>> Hello Michal,
>>>
>>> this job failed:
>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>>>
>>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
>>
>> I had a similar, most likely related issue a few days ago:
>>
>> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
>>
>> Tom git bi-sected this to this commit, which only adds a bit tiny bit
>> of image size I assume:
>>
>> "I bisected this down to:
>> commit 368b3f6db4540f913c436e5287be8356bc9a2891
>> Author: Stefan Chulski <stefanc@marvell.com>
>> Date:?? Mon May 3 08:08:44 2021 +0200
>>
>> ??? phy: introduce 1000BaseX and 2500BaseX modes
>>
>> ??? Signed-off-by: Stefan Chulski <stefanc@marvell.com>
>> ??? Signed-off-by: Stefan Roese <sr@denx.de>
>>
>> And while I'm not sure off-hand how it does it, it's causing the
>> breakage.? Maybe something is overflowing now?"
>
> I have rebase Heinrich patches on the top of HEAD + my queue and I can't
> see any issue
> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
>
> It means likely what Stefan mentioned is likely correct.
The mentioned PHY patch was not pushed to mainline (yet). Please add
it:
http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/
and run the test again.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 9:40 ` Stefan Roese
@ 2021-05-17 9:47 ` Michal Simek
2021-05-17 10:54 ` Heinrich Schuchardt
2021-05-18 4:43 ` Stefan Roese
0 siblings, 2 replies; 10+ messages in thread
From: Michal Simek @ 2021-05-17 9:47 UTC (permalink / raw)
To: u-boot
Hi Stefan,
On 5/17/21 11:40 AM, Stefan Roese wrote:
> Hi Michal,
>
> On 17.05.21 11:37, Michal Simek wrote:
>> Hi,
>>
>> On 5/17/21 11:04 AM, Stefan Roese wrote:
>>> Added Tom to Cc.
>>>
>>> On 17.05.21 10:01, Heinrich Schuchardt wrote:
>>>> On 17.05.21 08:39, Michal Simek wrote:
>>>>>
>>>>>
>>>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>>>>> Save some KiB when building? xilinx_versal_virt_defconfig by
>>>>>> disabling
>>>>>> Unicode capitalization support. This avoids build failures when
>>>>>> adding new
>>>>>> features for the UEFI sub-system.
>>>>>>
>>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>>> ---
>>>>>> It would be preferable to have a size check for the u-boot binary.
>>>>>> This would avoid seeing problems only during execution.
>>>>>> ---
>>>>>> ?? configs/xilinx_versal_virt_defconfig | 1 +
>>>>>> ?? 1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/configs/xilinx_versal_virt_defconfig
>>>>>> b/configs/xilinx_versal_virt_defconfig
>>>>>> index 707693713a..8bc2ff4a4c 100644
>>>>>> --- a/configs/xilinx_versal_virt_defconfig
>>>>>> +++ b/configs/xilinx_versal_virt_defconfig
>>>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>>>> ?? CONFIG_USB_GADGET_DOWNLOAD=y
>>>>>> ?? CONFIG_USB_FUNCTION_THOR=y
>>>>>> ?? CONFIG_OF_LIBFDT_OVERLAY=y
>>>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>>>>> --?
>>>>>> 2.30.2
>>>>>>
>>>>>
>>>>> What's the build issue? Any log? U-Boot is getting bigger and
>>>>> bigger and
>>>>
>>>> Hello Michal,
>>>>
>>>> this job failed:
>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>>>>
>>>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
>>>
>>> I had a similar, most likely related issue a few days ago:
>>>
>>> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
>>>
>>>
>>> Tom git bi-sected this to this commit, which only adds a bit tiny bit
>>> of image size I assume:
>>>
>>> "I bisected this down to:
>>> commit 368b3f6db4540f913c436e5287be8356bc9a2891
>>> Author: Stefan Chulski <stefanc@marvell.com>
>>> Date:?? Mon May 3 08:08:44 2021 +0200
>>>
>>> ???? phy: introduce 1000BaseX and 2500BaseX modes
>>>
>>> ???? Signed-off-by: Stefan Chulski <stefanc@marvell.com>
>>> ???? Signed-off-by: Stefan Roese <sr@denx.de>
>>>
>>> And while I'm not sure off-hand how it does it, it's causing the
>>> breakage.? Maybe something is overflowing now?"
>>
>> I have rebase Heinrich patches on the top of HEAD + my queue and I can't
>> see any issue
>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
>>
>>
>> It means likely what Stefan mentioned is likely correct.
>
> The mentioned PHY patch was not pushed to mainline (yet). Please add
> it:
>
> http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/
>
> and run the test again.
https://pastebin.com/pd9i8LEi
I have applied this patch and I can't see any issue.
Also pipeline passed without any issue.
https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/7558
Can you apply this one and try on your end?
http://patchwork.ozlabs.org/project/uboot/patch/7a7c5d657a968190e0676251dbd85a947433d592.1620822936.git.michal.simek at xilinx.com/
it is in my queue and when u-boot is bigger then certain limit it can
cause issue with early stack allocation.
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 9:47 ` Michal Simek
@ 2021-05-17 10:54 ` Heinrich Schuchardt
2021-05-17 11:21 ` Michal Simek
2021-05-18 4:43 ` Stefan Roese
1 sibling, 1 reply; 10+ messages in thread
From: Heinrich Schuchardt @ 2021-05-17 10:54 UTC (permalink / raw)
To: u-boot
On 5/17/21 11:47 AM, Michal Simek wrote:
> Hi Stefan,
>
> On 5/17/21 11:40 AM, Stefan Roese wrote:
>> Hi Michal,
>>
>> On 17.05.21 11:37, Michal Simek wrote:
>>> Hi,
>>>
>>> On 5/17/21 11:04 AM, Stefan Roese wrote:
>>>> Added Tom to Cc.
>>>>
>>>> On 17.05.21 10:01, Heinrich Schuchardt wrote:
>>>>> On 17.05.21 08:39, Michal Simek wrote:
>>>>>>
>>>>>>
>>>>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>>>>>> Save some KiB when building? xilinx_versal_virt_defconfig by
>>>>>>> disabling
>>>>>>> Unicode capitalization support. This avoids build failures when
>>>>>>> adding new
>>>>>>> features for the UEFI sub-system.
>>>>>>>
>>>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>>>> ---
>>>>>>> It would be preferable to have a size check for the u-boot binary.
>>>>>>> This would avoid seeing problems only during execution.
>>>>>>> ---
>>>>>>> ?? configs/xilinx_versal_virt_defconfig | 1 +
>>>>>>> ?? 1 file changed, 1 insertion(+)
>>>>>>>
>>>>>>> diff --git a/configs/xilinx_versal_virt_defconfig
>>>>>>> b/configs/xilinx_versal_virt_defconfig
>>>>>>> index 707693713a..8bc2ff4a4c 100644
>>>>>>> --- a/configs/xilinx_versal_virt_defconfig
>>>>>>> +++ b/configs/xilinx_versal_virt_defconfig
>>>>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>>>>> ?? CONFIG_USB_GADGET_DOWNLOAD=y
>>>>>>> ?? CONFIG_USB_FUNCTION_THOR=y
>>>>>>> ?? CONFIG_OF_LIBFDT_OVERLAY=y
>>>>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>>>>>> --
>>>>>>> 2.30.2
>>>>>>>
>>>>>>
>>>>>> What's the build issue? Any log? U-Boot is getting bigger and
>>>>>> bigger and
>>>>>
>>>>> Hello Michal,
>>>>>
>>>>> this job failed:
>>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>>>>>
>>>>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
>>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
>>>>
>>>> I had a similar, most likely related issue a few days ago:
>>>>
>>>> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
>>>>
>>>>
>>>> Tom git bi-sected this to this commit, which only adds a bit tiny bit
>>>> of image size I assume:
>>>>
>>>> "I bisected this down to:
>>>> commit 368b3f6db4540f913c436e5287be8356bc9a2891
>>>> Author: Stefan Chulski <stefanc@marvell.com>
>>>> Date:?? Mon May 3 08:08:44 2021 +0200
>>>>
>>>> ???? phy: introduce 1000BaseX and 2500BaseX modes
>>>>
>>>> ???? Signed-off-by: Stefan Chulski <stefanc@marvell.com>
>>>> ???? Signed-off-by: Stefan Roese <sr@denx.de>
>>>>
>>>> And while I'm not sure off-hand how it does it, it's causing the
>>>> breakage.? Maybe something is overflowing now?"
>>>
>>> I have rebase Heinrich patches on the top of HEAD + my queue and I can't
>>> see any issue
>>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
>>>
>>>
>>> It means likely what Stefan mentioned is likely correct.
>>
>> The mentioned PHY patch was not pushed to mainline (yet). Please add
>> it:
>>
>> http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/
>>
>> and run the test again.
>
> https://pastebin.com/pd9i8LEi
> I have applied this patch and I can't see any issue.
> Also pipeline passed without any issue.
> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/7558
>
> Can you apply this one and try on your end?
> http://patchwork.ozlabs.org/project/uboot/patch/7a7c5d657a968190e0676251dbd85a947433d592.1620822936.git.michal.simek at xilinx.com/
>
> it is in my queue and when u-boot is bigger then certain limit it can
> cause issue with early stack allocation.
>
> Thanks,
> Michal
>
>
>
The patch "xilinx: versal: Enable CONFIG_POSITION_INDEPENDENT" with
CONFIG_SYS_INIT_SP_BSS_OFFSET=1572864
solves the problem:
https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269920
Please, consider adding it to a pull request for v2021.07-rc3.
Best regards
Heinrich
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 10:54 ` Heinrich Schuchardt
@ 2021-05-17 11:21 ` Michal Simek
0 siblings, 0 replies; 10+ messages in thread
From: Michal Simek @ 2021-05-17 11:21 UTC (permalink / raw)
To: u-boot
Hi,
On 5/17/21 12:54 PM, Heinrich Schuchardt wrote:
> On 5/17/21 11:47 AM, Michal Simek wrote:
>> Hi Stefan,
>>
>> On 5/17/21 11:40 AM, Stefan Roese wrote:
>>> Hi Michal,
>>>
>>> On 17.05.21 11:37, Michal Simek wrote:
>>>> Hi,
>>>>
>>>> On 5/17/21 11:04 AM, Stefan Roese wrote:
>>>>> Added Tom to Cc.
>>>>>
>>>>> On 17.05.21 10:01, Heinrich Schuchardt wrote:
>>>>>> On 17.05.21 08:39, Michal Simek wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 5/16/21 11:17 AM, Heinrich Schuchardt wrote:
>>>>>>>> Save some KiB when building? xilinx_versal_virt_defconfig by
>>>>>>>> disabling
>>>>>>>> Unicode capitalization support. This avoids build failures when
>>>>>>>> adding new
>>>>>>>> features for the UEFI sub-system.
>>>>>>>>
>>>>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>>>>> ---
>>>>>>>> It would be preferable to have a size check for the u-boot binary.
>>>>>>>> This would avoid seeing problems only during execution.
>>>>>>>> ---
>>>>>>>> ??? configs/xilinx_versal_virt_defconfig | 1 +
>>>>>>>> ??? 1 file changed, 1 insertion(+)
>>>>>>>>
>>>>>>>> diff --git a/configs/xilinx_versal_virt_defconfig
>>>>>>>> b/configs/xilinx_versal_virt_defconfig
>>>>>>>> index 707693713a..8bc2ff4a4c 100644
>>>>>>>> --- a/configs/xilinx_versal_virt_defconfig
>>>>>>>> +++ b/configs/xilinx_versal_virt_defconfig
>>>>>>>> @@ -111,3 +111,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
>>>>>>>> ??? CONFIG_USB_GADGET_DOWNLOAD=y
>>>>>>>> ??? CONFIG_USB_FUNCTION_THOR=y
>>>>>>>> ??? CONFIG_OF_LIBFDT_OVERLAY=y
>>>>>>>> +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set
>>>>>>>> --
>>>>>>>> 2.30.2
>>>>>>>>
>>>>>>>
>>>>>>> What's the build issue? Any log? U-Boot is getting bigger and
>>>>>>> bigger and
>>>>>>
>>>>>> Hello Michal,
>>>>>>
>>>>>> this job failed:
>>>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269614
>>>>>>
>>>>>> After deactivating CONFIG_EFI_UNICODE_CAPITALIZATION I get success:
>>>>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269620
>>>>>
>>>>> I had a similar, most likely related issue a few days ago:
>>>>>
>>>>> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=87&view=results
>>>>>
>>>>>
>>>>>
>>>>> Tom git bi-sected this to this commit, which only adds a bit tiny bit
>>>>> of image size I assume:
>>>>>
>>>>> "I bisected this down to:
>>>>> commit 368b3f6db4540f913c436e5287be8356bc9a2891
>>>>> Author: Stefan Chulski <stefanc@marvell.com>
>>>>> Date:?? Mon May 3 08:08:44 2021 +0200
>>>>>
>>>>> ????? phy: introduce 1000BaseX and 2500BaseX modes
>>>>>
>>>>> ????? Signed-off-by: Stefan Chulski <stefanc@marvell.com>
>>>>> ????? Signed-off-by: Stefan Roese <sr@denx.de>
>>>>>
>>>>> And while I'm not sure off-hand how it does it, it's causing the
>>>>> breakage.? Maybe something is overflowing now?"
>>>>
>>>> I have rebase Heinrich patches on the top of HEAD + my queue and I
>>>> can't
>>>> see any issue
>>>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
>>>>
>>>>
>>>>
>>>> It means likely what Stefan mentioned is likely correct.
>>>
>>> The mentioned PHY patch was not pushed to mainline (yet). Please add
>>> it:
>>>
>>> http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/
>>>
>>>
>>> and run the test again.
>>
>> https://pastebin.com/pd9i8LEi
>> I have applied this patch and I can't see any issue.
>> Also pipeline passed without any issue.
>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/7558
>>
>>
>> Can you apply this one and try on your end?
>> http://patchwork.ozlabs.org/project/uboot/patch/7a7c5d657a968190e0676251dbd85a947433d592.1620822936.git.michal.simek at xilinx.com/
>>
>>
>> it is in my queue and when u-boot is bigger then certain limit it can
>> cause issue with early stack allocation.
>>
>> Thanks,
>> Michal
>>
>>
>>
>
> The patch "xilinx: versal: Enable CONFIG_POSITION_INDEPENDENT" with
> CONFIG_SYS_INIT_SP_BSS_OFFSET=1572864
> solves the problem:
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/269920
>
> Please, consider adding it to a pull request for v2021.07-rc3.
That's the plan.
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] xilinx: disable Unicode capitalization
2021-05-17 9:47 ` Michal Simek
2021-05-17 10:54 ` Heinrich Schuchardt
@ 2021-05-18 4:43 ` Stefan Roese
1 sibling, 0 replies; 10+ messages in thread
From: Stefan Roese @ 2021-05-18 4:43 UTC (permalink / raw)
To: u-boot
Hi Michael,
On 17.05.21 11:47, Michal Simek wrote:
<snip>
>>> I have rebase Heinrich patches on the top of HEAD + my queue and I can't
>>> see any issue
>>> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/tree/for-heinrich
>>>
>>>
>>> It means likely what Stefan mentioned is likely correct.
>>
>> The mentioned PHY patch was not pushed to mainline (yet). Please add
>> it:
>>
>> http://patchwork.ozlabs.org/project/uboot/patch/20210503060853.3743626-2-sr at denx.de/
>>
>> and run the test again.
>
> https://pastebin.com/pd9i8LEi
> I have applied this patch and I can't see any issue.
> Also pipeline passed without any issue.
> https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/7558
>
> Can you apply this one and try on your end?
> http://patchwork.ozlabs.org/project/uboot/patch/7a7c5d657a968190e0676251dbd85a947433d592.1620822936.git.michal.simek at xilinx.com/
>
> it is in my queue and when u-boot is bigger then certain limit it can
> cause issue with early stack allocation.
Yes, I can confirm that this patch fixes the build issue.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-18 4:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 9:17 [PATCH 1/1] xilinx: disable Unicode capitalization Heinrich Schuchardt
2021-05-17 6:39 ` Michal Simek
2021-05-17 8:01 ` Heinrich Schuchardt
2021-05-17 9:04 ` Stefan Roese
2021-05-17 9:37 ` Michal Simek
2021-05-17 9:40 ` Stefan Roese
2021-05-17 9:47 ` Michal Simek
2021-05-17 10:54 ` Heinrich Schuchardt
2021-05-17 11:21 ` Michal Simek
2021-05-18 4:43 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.