All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <thinh.nguyen@synopsys.com>
To: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver
Date: Mon, 5 Nov 2018 18:49:59 +0000	[thread overview]
Message-ID: <30102591E157244384E984126FC3CB4F639A0308@us01wembx1.internal.synopsys.com> (raw)
In-Reply-To: 8faa039d80ba1f8ab2c7192a237ff8431d5cdc4a.1541209477.git.thinhn@synopsys.com

++ linux-usb
++ Greg

On 11/2/2018 6:47 PM, Thinh Nguyen wrote:
> Synopsys USB 3.x host HAPS platform has a class code of
> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> devices should use dwc3-haps driver. Set driver_override to dwc3-haps
> for these platforms.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  drivers/pci/quirks.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 6bc27b7fd452..5f7c3ade7749 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -618,6 +618,27 @@ static void quirk_amd_nl_class(struct pci_dev *pdev)
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_NL_USB,
>  		quirk_amd_nl_class);
>  
> +/*
> + * Synopsys USB 3.x host HAPS platform has a class code of
> + * PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> + * devices should use dwc3-haps driver. Set driver_override to dwc3-haps for
> + * these platforms.
> + */
> +static void quirk_synopsys_haps(struct pci_dev *pdev)
> +{
> +	/* Use dwc3-haps driver instead of xhci-pci */
> +	pdev->driver_override = "dwc3-haps";
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3,
> +			quirk_synopsys_haps);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI,
> +			quirk_synopsys_haps);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31,
> +			quirk_synopsys_haps);
> +
>  /*
>   * Let's make the southbridge information explicit instead of having to
>   * worry about people probing the ACPI areas, for example.. (Yes, it



WARNING: multiple messages have this Message-ID (diff)
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: USB <linux-usb@vger.kernel.org>
Subject: [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs
Date: Mon, 5 Nov 2018 18:49:59 +0000	[thread overview]
Message-ID: <30102591E157244384E984126FC3CB4F639A0308@us01wembx1.internal.synopsys.com> (raw)

++ linux-usb
++ Greg

On 11/2/2018 6:47 PM, Thinh Nguyen wrote:
> Synopsys USB 3.x host HAPS platform has a class code of
> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> devices should use dwc3-haps driver. Set driver_override to dwc3-haps
> for these platforms.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  drivers/pci/quirks.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 6bc27b7fd452..5f7c3ade7749 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -618,6 +618,27 @@ static void quirk_amd_nl_class(struct pci_dev *pdev)
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_NL_USB,
>  		quirk_amd_nl_class);
>  
> +/*
> + * Synopsys USB 3.x host HAPS platform has a class code of
> + * PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> + * devices should use dwc3-haps driver. Set driver_override to dwc3-haps for
> + * these platforms.
> + */
> +static void quirk_synopsys_haps(struct pci_dev *pdev)
> +{
> +	/* Use dwc3-haps driver instead of xhci-pci */
> +	pdev->driver_override = "dwc3-haps";
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3,
> +			quirk_synopsys_haps);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI,
> +			quirk_synopsys_haps);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SYNOPSYS,
> +			PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31,
> +			quirk_synopsys_haps);
> +
>  /*
>   * Let's make the southbridge information explicit instead of having to
>   * worry about people probing the ACPI areas, for example.. (Yes, it

  reply	other threads:[~2018-11-05 18:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03  1:47 [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03  1:47 ` [1/2] " Thinh Nguyen
2018-11-03  1:47 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-11-05 18:49   ` Thinh Nguyen [this message]
2018-11-05 18:49     ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-06  8:43     ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Felipe Balbi
2018-11-06  8:43       ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Felipe Balbi
2018-12-08  2:49       ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-08  2:49         ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-12-10 18:54         ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Bjorn Helgaas
2018-12-10 18:54           ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Bjorn Helgaas
2018-12-10 21:51           ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-10 21:51             ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03  6:25 ` [PATCH 1/2] " Greg KH
2018-11-03  6:25   ` [1/2] " Greg Kroah-Hartman
2018-11-05 18:46   ` [PATCH 1/2] " Thinh Nguyen
2018-11-05 18:46     ` [1/2] " Thinh Nguyen
2018-11-05 18:56     ` [PATCH 1/2] " Greg KH
2018-11-05 18:56       ` [1/2] " Greg Kroah-Hartman
2018-12-10 18:49 ` [PATCH 1/2] " Bjorn Helgaas
2018-12-10 18:49   ` [1/2] " Bjorn Helgaas
2018-12-10 21:49   ` [PATCH 1/2] " Thinh Nguyen
2018-12-10 21:49     ` [1/2] " Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30102591E157244384E984126FC3CB4F639A0308@us01wembx1.internal.synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.