All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <thinh.nguyen@synopsys.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Thinh Nguyen <thinh.nguyen@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	John Youn <john.youn@synopsys.com>
Subject: Re: [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs
Date: Mon, 10 Dec 2018 21:49:31 +0000	[thread overview]
Message-ID: <30102591E157244384E984126FC3CB4F639A8E68@us01wembx1.internal.synopsys.com> (raw)
In-Reply-To: 20181210184954.GA47246@google.com

Hi Bjorn,

On 12/10/2018 10:49 AM, Bjorn Helgaas wrote:
> On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote:
>> Move Synopsys HAPS platform device IDs to pci_ids.h.
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> 1) Run "git log --oneline include/linux/pci_ids.h" and follow the
> style convention for patch subject.
>
> 2) Explain in the changelog why we're moving this to pci_ids.h.  Note
> the comment at the top of pci_ids.h.  I think the move is fine because
> you're using the definition in two places, so just mention that in the
> changelog.
>
> Thanks!

Thanks for the review! I'll fix it.

Thinh 


WARNING: multiple messages have this Message-ID (diff)
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Thinh Nguyen <thinh.nguyen@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	John Youn <john.youn@synopsys.com>
Subject: [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs
Date: Mon, 10 Dec 2018 21:49:31 +0000	[thread overview]
Message-ID: <30102591E157244384E984126FC3CB4F639A8E68@us01wembx1.internal.synopsys.com> (raw)

Hi Bjorn,

On 12/10/2018 10:49 AM, Bjorn Helgaas wrote:
> On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote:
>> Move Synopsys HAPS platform device IDs to pci_ids.h.
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> 1) Run "git log --oneline include/linux/pci_ids.h" and follow the
> style convention for patch subject.
>
> 2) Explain in the changelog why we're moving this to pci_ids.h.  Note
> the comment at the top of pci_ids.h.  I think the move is fine because
> you're using the definition in two places, so just mention that in the
> changelog.
>
> Thanks!

Thanks for the review! I'll fix it.

Thinh

  reply	other threads:[~2018-12-10 21:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03  1:47 [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03  1:47 ` [1/2] " Thinh Nguyen
2018-11-03  1:47 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-11-05 18:49   ` Thinh Nguyen
2018-11-05 18:49     ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-06  8:43     ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Felipe Balbi
2018-11-06  8:43       ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Felipe Balbi
2018-12-08  2:49       ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-08  2:49         ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-12-10 18:54         ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Bjorn Helgaas
2018-12-10 18:54           ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Bjorn Helgaas
2018-12-10 21:51           ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-10 21:51             ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03  6:25 ` [PATCH 1/2] " Greg KH
2018-11-03  6:25   ` [1/2] " Greg Kroah-Hartman
2018-11-05 18:46   ` [PATCH 1/2] " Thinh Nguyen
2018-11-05 18:46     ` [1/2] " Thinh Nguyen
2018-11-05 18:56     ` [PATCH 1/2] " Greg KH
2018-11-05 18:56       ` [1/2] " Greg Kroah-Hartman
2018-12-10 18:49 ` [PATCH 1/2] " Bjorn Helgaas
2018-12-10 18:49   ` [1/2] " Bjorn Helgaas
2018-12-10 21:49   ` Thinh Nguyen [this message]
2018-12-10 21:49     ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30102591E157244384E984126FC3CB4F639A8E68@us01wembx1.internal.synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=john.youn@synopsys.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.