* [PATCH] ARM: bcm2835: remove unused __packet
@ 2016-06-07 17:49 ` Ben Dooks
0 siblings, 0 replies; 8+ messages in thread
From: Ben Dooks @ 2016-06-07 17:49 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Eric Anholt, Ulf Hansson, Alexander Aring,
Kevin Hilman, linux-kernel, linux-arm-kernel
The driver defines a variable called __packet but then never
uses it, and does not export it for others to use either. Fix
the warning about undeclared variable by removing it.
drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Eric Anholt <eric@anholt.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Kevin Hilman <khilman@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index fe96a8b..f7ed118 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -45,7 +45,7 @@ struct rpi_power_domains {
struct rpi_power_domain_packet {
u32 domain;
u32 on;
-} __packet;
+};
/*
* Asks the firmware to enable or disable power on a specific power
--
2.8.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: bcm2835: remove unused __packet
@ 2016-06-07 17:49 ` Ben Dooks
0 siblings, 0 replies; 8+ messages in thread
From: Ben Dooks @ 2016-06-07 17:49 UTC (permalink / raw)
To: linux-arm-kernel
The driver defines a variable called __packet but then never
uses it, and does not export it for others to use either. Fix
the warning about undeclared variable by removing it.
drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Eric Anholt <eric@anholt.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Kevin Hilman <khilman@linaro.org>
Cc: linux-kernel at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index fe96a8b..f7ed118 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -45,7 +45,7 @@ struct rpi_power_domains {
struct rpi_power_domain_packet {
u32 domain;
u32 on;
-} __packet;
+};
/*
* Asks the firmware to enable or disable power on a specific power
--
2.8.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: bcm2835: remove unused __packet
2016-06-07 17:49 ` Ben Dooks
@ 2016-06-07 20:30 ` Eric Anholt
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Anholt @ 2016-06-07 20:30 UTC (permalink / raw)
To: Ben Dooks, linux-kernel
Cc: Ben Dooks, Ulf Hansson, Alexander Aring, Kevin Hilman,
linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
Ben Dooks <ben.dooks@codethink.co.uk> writes:
> The driver defines a variable called __packet but then never
> uses it, and does not export it for others to use either. Fix
> the warning about undeclared variable by removing it.
>
> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
Reviewed-by: Eric Anholt <eric@anholt.net>
PM folks: I'd be happy to see this go through your trees, but either way
is fine with me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: bcm2835: remove unused __packet
@ 2016-06-07 20:30 ` Eric Anholt
0 siblings, 0 replies; 8+ messages in thread
From: Eric Anholt @ 2016-06-07 20:30 UTC (permalink / raw)
To: linux-arm-kernel
Ben Dooks <ben.dooks@codethink.co.uk> writes:
> The driver defines a variable called __packet but then never
> uses it, and does not export it for others to use either. Fix
> the warning about undeclared variable by removing it.
>
> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
Reviewed-by: Eric Anholt <eric@anholt.net>
PM folks: I'd be happy to see this go through your trees, but either way
is fine with me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/e7c75853/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: bcm2835: remove unused __packet
2016-06-07 20:30 ` Eric Anholt
@ 2016-06-10 22:11 ` Kevin Hilman
-1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2016-06-10 22:11 UTC (permalink / raw)
To: Eric Anholt
Cc: Ben Dooks, linux-kernel, Ulf Hansson, Alexander Aring,
linux-kernel, linux-arm-kernel
Eric Anholt <eric@anholt.net> writes:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
>
>> The driver defines a variable called __packet but then never
>> uses it, and does not export it for others to use either. Fix
>> the warning about undeclared variable by removing it.
>>
>> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> PM folks: I'd be happy to see this go through your trees, but either way
> is fine with me.
Since this is in drivers/soc, just include it in your cleanup branch for
arm-soc.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: bcm2835: remove unused __packet
@ 2016-06-10 22:11 ` Kevin Hilman
0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2016-06-10 22:11 UTC (permalink / raw)
To: linux-arm-kernel
Eric Anholt <eric@anholt.net> writes:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
>
>> The driver defines a variable called __packet but then never
>> uses it, and does not export it for others to use either. Fix
>> the warning about undeclared variable by removing it.
>>
>> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> PM folks: I'd be happy to see this go through your trees, but either way
> is fine with me.
Since this is in drivers/soc, just include it in your cleanup branch for
arm-soc.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: bcm2835: remove unused __packet
2016-06-07 17:49 ` Ben Dooks
@ 2016-06-13 15:55 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-06-13 15:55 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Ben Dooks, linux-kernel, Ulf Hansson, Kevin Hilman,
Alexander Aring, linux-kernel, Eric Anholt
On Tuesday, June 7, 2016 6:49:33 PM CEST Ben Dooks wrote:
> The driver defines a variable called __packet but then never
> uses it, and does not export it for others to use either. Fix
> the warning about undeclared variable by removing it.
>
> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
The patch looks good, but it's probably worth mentioning here that
this was intended to be the '__packed' attribute instead of a local
variable. The attribute is useless here, as the variables both
still get the default stack alignment, even if rpi_firmware_property
only requires byte-aligned data.
Arnd
> diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
> index fe96a8b..f7ed118 100644
> --- a/drivers/soc/bcm/raspberrypi-power.c
> +++ b/drivers/soc/bcm/raspberrypi-power.c
> @@ -45,7 +45,7 @@ struct rpi_power_domains {
> struct rpi_power_domain_packet {
> u32 domain;
> u32 on;
> -} __packet;
> +};
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: bcm2835: remove unused __packet
@ 2016-06-13 15:55 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-06-13 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, June 7, 2016 6:49:33 PM CEST Ben Dooks wrote:
> The driver defines a variable called __packet but then never
> uses it, and does not export it for others to use either. Fix
> the warning about undeclared variable by removing it.
>
> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
The patch looks good, but it's probably worth mentioning here that
this was intended to be the '__packed' attribute instead of a local
variable. The attribute is useless here, as the variables both
still get the default stack alignment, even if rpi_firmware_property
only requires byte-aligned data.
Arnd
> diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
> index fe96a8b..f7ed118 100644
> --- a/drivers/soc/bcm/raspberrypi-power.c
> +++ b/drivers/soc/bcm/raspberrypi-power.c
> @@ -45,7 +45,7 @@ struct rpi_power_domains {
> struct rpi_power_domain_packet {
> u32 domain;
> u32 on;
> -} __packet;
> +};
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-13 15:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 17:49 [PATCH] ARM: bcm2835: remove unused __packet Ben Dooks
2016-06-07 17:49 ` Ben Dooks
2016-06-07 20:30 ` Eric Anholt
2016-06-07 20:30 ` Eric Anholt
2016-06-10 22:11 ` Kevin Hilman
2016-06-10 22:11 ` Kevin Hilman
2016-06-13 15:55 ` Arnd Bergmann
2016-06-13 15:55 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.