From: Christian Eggers <ceggers@arri.de> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Oleksij Rempel" <linux@rempel-privat.de>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "NXP Linux Team" <linux-imx@nxp.com>, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/3] i2c: imx: Check for I2SR_IAL after every byte Date: Mon, 5 Oct 2020 11:25:13 +0200 [thread overview] Message-ID: <3765943.G7FBkpUTMe@n95hx1g2> (raw) In-Reply-To: <20201005080725.GB7135@kozik-lap> On Monday, 5 October 2020, 10:07:25 CEST, Krzysztof Kozlowski wrote: > The I2C on Vybrid VF500 still works fine. I did not test this actual > condition (arbitration) but only a regular I2C driver (BQ27xxx fuel > gauge). Obviously this only proves that regular operation is not > broken... thank you very much for testing on Vybrid. > Alternatively if you have a specific testing procedure (reproduction of > a problem), please share. The IAL errors happen due to noise on our I2C bus. We have our power supply connected via I2C. The hardware designers wanted to make sure that no high currents flow through the ground pins of the I2C interface. So they added a series resistor (30 Ohm) in the GND line between the power supply and the i.MX board. If you have an I2C device on an external PCB, adding some small series resistance in the GND line may cause IAL errors. On the other hand, if everything else works fine, also handling if IAL should work on Vybrid. > Best regards, > Krzysztof Best regards Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Eggers <ceggers@arri.de> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Oleksij Rempel" <linux@rempel-privat.de>, "NXP Linux Team" <linux-imx@nxp.com>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v2 2/3] i2c: imx: Check for I2SR_IAL after every byte Date: Mon, 5 Oct 2020 11:25:13 +0200 [thread overview] Message-ID: <3765943.G7FBkpUTMe@n95hx1g2> (raw) In-Reply-To: <20201005080725.GB7135@kozik-lap> On Monday, 5 October 2020, 10:07:25 CEST, Krzysztof Kozlowski wrote: > The I2C on Vybrid VF500 still works fine. I did not test this actual > condition (arbitration) but only a regular I2C driver (BQ27xxx fuel > gauge). Obviously this only proves that regular operation is not > broken... thank you very much for testing on Vybrid. > Alternatively if you have a specific testing procedure (reproduction of > a problem), please share. The IAL errors happen due to noise on our I2C bus. We have our power supply connected via I2C. The hardware designers wanted to make sure that no high currents flow through the ground pins of the I2C interface. So they added a series resistor (30 Ohm) in the GND line between the power supply and the i.MX board. If you have an I2C device on an external PCB, adding some small series resistance in the GND line may cause IAL errors. On the other hand, if everything else works fine, also handling if IAL should work on Vybrid. > Best regards, > Krzysztof Best regards Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-05 9:26 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-02 15:23 [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers 2020-10-02 15:23 ` Christian Eggers 2020-10-02 15:23 ` [PATCH v2 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers 2020-10-02 15:23 ` Christian Eggers 2020-10-05 8:05 ` Krzysztof Kozlowski 2020-10-05 8:05 ` Krzysztof Kozlowski 2020-10-06 6:05 ` Uwe Kleine-König 2020-10-06 6:05 ` Uwe Kleine-König 2020-10-06 10:51 ` [PATCH v3 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers 2020-10-06 10:51 ` Christian Eggers 2020-10-06 10:51 ` [PATCH v3 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers 2020-10-06 10:51 ` Christian Eggers 2020-10-06 12:06 ` David Laight 2020-10-06 12:06 ` David Laight 2020-10-06 12:30 ` Christian Eggers 2020-10-06 12:30 ` Christian Eggers 2020-10-06 12:46 ` Uwe Kleine-König 2020-10-06 12:46 ` Uwe Kleine-König 2020-10-06 12:52 ` David Laight 2020-10-06 12:52 ` David Laight 2020-10-06 10:51 ` [PATCH v3 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers 2020-10-06 10:51 ` Christian Eggers 2020-10-06 10:51 ` [PATCH v3 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers 2020-10-06 10:51 ` Christian Eggers 2020-10-02 15:23 ` [PATCH v2 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers 2020-10-02 15:23 ` Christian Eggers 2020-10-05 8:07 ` Krzysztof Kozlowski 2020-10-05 8:07 ` Krzysztof Kozlowski 2020-10-05 9:25 ` Christian Eggers [this message] 2020-10-05 9:25 ` Christian Eggers 2020-10-02 15:23 ` [PATCH v2 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers 2020-10-02 15:23 ` Christian Eggers 2020-10-05 8:16 ` Krzysztof Kozlowski 2020-10-05 8:16 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3765943.G7FBkpUTMe@n95hx1g2 \ --to=ceggers@arri.de \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rempel-privat.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=stable@vger.kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.