From: Christian Eggers <ceggers@arri.de>
To: "Oleksij Rempel" <linux@rempel-privat.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss
Date: Fri, 2 Oct 2020 17:23:02 +0200 [thread overview]
Message-ID: <20201002152305.4963-1-ceggers@arri.de> (raw)
Changes in v2:
---------------
- Don't accidently clear additional status flags on Vybrid
(reported by Uwe Kleine-Koenig)
On my (noisy) system, I2C arbitration losses happen quite often. In it's
current implementation, the IAL flag is partly handled, but has a
number of shortcomings:
1. The driver runs unnecessarily in a timeout when waiting for an
interrupt.
2. The driver performs 500 ms busy-waiting without any value.
3. Arbitration loss errors may be reported one transfer later than they
occured.
Best regards
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Eggers <ceggers@arri.de>
To: "Oleksij Rempel" <linux@rempel-privat.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org
Subject: [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss
Date: Fri, 2 Oct 2020 17:23:02 +0200 [thread overview]
Message-ID: <20201002152305.4963-1-ceggers@arri.de> (raw)
Changes in v2:
---------------
- Don't accidently clear additional status flags on Vybrid
(reported by Uwe Kleine-Koenig)
On my (noisy) system, I2C arbitration losses happen quite often. In it's
current implementation, the IAL flag is partly handled, but has a
number of shortcomings:
1. The driver runs unnecessarily in a timeout when waiting for an
interrupt.
2. The driver performs 500 ms busy-waiting without any value.
3. Arbitration loss errors may be reported one transfer later than they
occured.
Best regards
Christian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-10-02 15:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 15:23 Christian Eggers [this message]
2020-10-02 15:23 ` [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers
2020-10-02 15:23 ` [PATCH v2 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers
2020-10-02 15:23 ` Christian Eggers
2020-10-05 8:05 ` Krzysztof Kozlowski
2020-10-05 8:05 ` Krzysztof Kozlowski
2020-10-06 6:05 ` Uwe Kleine-König
2020-10-06 6:05 ` Uwe Kleine-König
2020-10-06 10:51 ` [PATCH v3 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers
2020-10-06 10:51 ` Christian Eggers
2020-10-06 10:51 ` [PATCH v3 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers
2020-10-06 10:51 ` Christian Eggers
2020-10-06 12:06 ` David Laight
2020-10-06 12:06 ` David Laight
2020-10-06 12:30 ` Christian Eggers
2020-10-06 12:30 ` Christian Eggers
2020-10-06 12:46 ` Uwe Kleine-König
2020-10-06 12:46 ` Uwe Kleine-König
2020-10-06 12:52 ` David Laight
2020-10-06 12:52 ` David Laight
2020-10-06 10:51 ` [PATCH v3 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers
2020-10-06 10:51 ` Christian Eggers
2020-10-06 10:51 ` [PATCH v3 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers
2020-10-06 10:51 ` Christian Eggers
2020-10-02 15:23 ` [PATCH v2 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers
2020-10-02 15:23 ` Christian Eggers
2020-10-05 8:07 ` Krzysztof Kozlowski
2020-10-05 8:07 ` Krzysztof Kozlowski
2020-10-05 9:25 ` Christian Eggers
2020-10-05 9:25 ` Christian Eggers
2020-10-02 15:23 ` [PATCH v2 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers
2020-10-02 15:23 ` Christian Eggers
2020-10-05 8:16 ` Krzysztof Kozlowski
2020-10-05 8:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002152305.4963-1-ceggers@arri.de \
--to=ceggers@arri.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.