From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> To: Michael Ellerman <mpe@ellerman.id.au> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Boqun Feng <boqun.feng@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Paul Turner <pjt@google.com>, Andrew Hunter <ahh@google.com>, Andy Lutomirski <luto@amacapital.net>, Dave Watson <davejwatson@fb.com>, Josh Triplett <josh@joshtriplett.org>, Will Deacon <will.deacon@arm.com>, linux-kernel <linux-kernel@vger.kernel.org>, Russell King <linux@arm.linux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, shuah <shuah@kernel.org>, linux-kselftest <linux-kselftest@vger.kernel.org>, linux-api <linux-api@vger.kernel.org> Subject: Re: [RFC PATCH for 4.15 14/14] Restartable sequences: Provide self-tests Date: Mon, 16 Oct 2017 14:23:02 +0000 (UTC) [thread overview] Message-ID: <399058130.42156.1508163782335.JavaMail.zimbra@efficios.com> (raw) In-Reply-To: <871sm3n6sy.fsf@concordia.ellerman.id.au> ----- On Oct 15, 2017, at 10:51 PM, Michael Ellerman mpe@ellerman.id.au wrote: > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes: > >> Implements two basic tests of RSEQ functionality, and one more >> exhaustive parameterizable test. >> >> The first, "basic_test" only asserts that RSEQ works moderately >> correctly. >> E.g. that: >> - The CPUID pointer works >> - Code infinitely looping within a critical section will eventually be >> interrupted. >> - Critical sections are interrupted by signals. >> >> "basic_percpu_ops_test" is a slightly more "realistic" variant, >> implementing a few simple per-cpu operations and testing their >> correctness. >> >> "param_test" is a parametrizable restartable sequences test. See >> the "--help" output for usage. > > Thanks for providing selftests :) > > The Makefiles could use a little clean up: > - cpu-opv doesn't need libpthread > - you don't need to define your own rule just for building > - use TEST_GEN_PROGS to hook into the right parts of lib.mk > - .. which means you can use the clean rule in lib.mk > > > I notice you didn't add rseq or cpu-opv to the list of TARGETS in > tools/testing/selftests/Makefile, was that deliberate? No, I think I just copied some other selftest which perhaps did not have those rules back then. > > Feel free to squash this patch in if you're happy to. > > This still works with: > $ make -C tools/testing/selftests TARGETS=rseq > > and: > $ cd tools/testing/selftests/rseq; make Great ! I'll fold this patch in. Thanks! Mathieu > > cheers > > diff --git a/tools/testing/selftests/cpu-opv/Makefile > b/tools/testing/selftests/cpu-opv/Makefile > index 81d0596824ee..d41670ad5c43 100644 > --- a/tools/testing/selftests/cpu-opv/Makefile > +++ b/tools/testing/selftests/cpu-opv/Makefile > @@ -1,13 +1,9 @@ > CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ > -LDFLAGS += -lpthread > > -TESTS = basic_cpu_opv_test > +TEST_GEN_PROGS = basic_cpu_opv_test > > -all: $(TESTS) > -%: %.c cpu-op.c cpu-op.h > - $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) > +all: $(TEST_GEN_PROGS) > > -include ../lib.mk > +$(TEST_GEN_PROGS): cpu-op.c cpu-op.h > > -clean: > - $(RM) $(TESTS) > +include ../lib.mk > diff --git a/tools/testing/selftests/rseq/Makefile > b/tools/testing/selftests/rseq/Makefile > index 7f0153556b80..9f8257b4ce14 100644 > --- a/tools/testing/selftests/rseq/Makefile > +++ b/tools/testing/selftests/rseq/Makefile > @@ -1,13 +1,10 @@ > CFLAGS += -O2 -Wall -g -I./ -I../cpu-opv/ -I../../../../usr/include/ > -LDFLAGS += -lpthread > +LDLIBS += -lpthread > > -TESTS = basic_test basic_percpu_ops_test param_test > +TEST_GEN_PROGS = basic_test basic_percpu_ops_test param_test > > -all: $(TESTS) > -%: %.c rseq.h rseq-*.h rseq.c ../cpu-opv/cpu-op.c ../cpu-opv/cpu-op.h > - $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) > +all: $(TEST_GEN_PROGS) > > -include ../lib.mk > +$(TEST_GEN_PROGS): rseq.h rseq-*.h rseq.c ../cpu-opv/cpu-op.c > ../cpu-opv/cpu-op.h > > -clean: > - $(RM) $(TESTS) > +include ../lib.mk -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> To: Michael Ellerman <mpe@ellerman.id.au> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Boqun Feng <boqun.feng@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Paul Turner <pjt@google.com>, Andrew Hunter <ahh@google.com>, Andy Lutomirski <luto@amacapital.net>, Dave Watson <davejwatson@fb.com>, Josh Triplett <josh@joshtriplett.org>, Will Deacon <will.deacon@arm.com>, linux-kernel <linux-kernel@vger.kernel.org>, Russell King <linux@arm.linux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux> Subject: Re: [RFC PATCH for 4.15 14/14] Restartable sequences: Provide self-tests Date: Mon, 16 Oct 2017 14:23:02 +0000 (UTC) [thread overview] Message-ID: <399058130.42156.1508163782335.JavaMail.zimbra@efficios.com> (raw) In-Reply-To: <871sm3n6sy.fsf@concordia.ellerman.id.au> ----- On Oct 15, 2017, at 10:51 PM, Michael Ellerman mpe@ellerman.id.au wrote: > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes: > >> Implements two basic tests of RSEQ functionality, and one more >> exhaustive parameterizable test. >> >> The first, "basic_test" only asserts that RSEQ works moderately >> correctly. >> E.g. that: >> - The CPUID pointer works >> - Code infinitely looping within a critical section will eventually be >> interrupted. >> - Critical sections are interrupted by signals. >> >> "basic_percpu_ops_test" is a slightly more "realistic" variant, >> implementing a few simple per-cpu operations and testing their >> correctness. >> >> "param_test" is a parametrizable restartable sequences test. See >> the "--help" output for usage. > > Thanks for providing selftests :) > > The Makefiles could use a little clean up: > - cpu-opv doesn't need libpthread > - you don't need to define your own rule just for building > - use TEST_GEN_PROGS to hook into the right parts of lib.mk > - .. which means you can use the clean rule in lib.mk > > > I notice you didn't add rseq or cpu-opv to the list of TARGETS in > tools/testing/selftests/Makefile, was that deliberate? No, I think I just copied some other selftest which perhaps did not have those rules back then. > > Feel free to squash this patch in if you're happy to. > > This still works with: > $ make -C tools/testing/selftests TARGETS=rseq > > and: > $ cd tools/testing/selftests/rseq; make Great ! I'll fold this patch in. Thanks! Mathieu > > cheers > > diff --git a/tools/testing/selftests/cpu-opv/Makefile > b/tools/testing/selftests/cpu-opv/Makefile > index 81d0596824ee..d41670ad5c43 100644 > --- a/tools/testing/selftests/cpu-opv/Makefile > +++ b/tools/testing/selftests/cpu-opv/Makefile > @@ -1,13 +1,9 @@ > CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ > -LDFLAGS += -lpthread > > -TESTS = basic_cpu_opv_test > +TEST_GEN_PROGS = basic_cpu_opv_test > > -all: $(TESTS) > -%: %.c cpu-op.c cpu-op.h > - $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) > +all: $(TEST_GEN_PROGS) > > -include ../lib.mk > +$(TEST_GEN_PROGS): cpu-op.c cpu-op.h > > -clean: > - $(RM) $(TESTS) > +include ../lib.mk > diff --git a/tools/testing/selftests/rseq/Makefile > b/tools/testing/selftests/rseq/Makefile > index 7f0153556b80..9f8257b4ce14 100644 > --- a/tools/testing/selftests/rseq/Makefile > +++ b/tools/testing/selftests/rseq/Makefile > @@ -1,13 +1,10 @@ > CFLAGS += -O2 -Wall -g -I./ -I../cpu-opv/ -I../../../../usr/include/ > -LDFLAGS += -lpthread > +LDLIBS += -lpthread > > -TESTS = basic_test basic_percpu_ops_test param_test > +TEST_GEN_PROGS = basic_test basic_percpu_ops_test param_test > > -all: $(TESTS) > -%: %.c rseq.h rseq-*.h rseq.c ../cpu-opv/cpu-op.c ../cpu-opv/cpu-op.h > - $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) > +all: $(TEST_GEN_PROGS) > > -include ../lib.mk > +$(TEST_GEN_PROGS): rseq.h rseq-*.h rseq.c ../cpu-opv/cpu-op.c > ../cpu-opv/cpu-op.h > > -clean: > - $(RM) $(TESTS) > +include ../lib.mk -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
next prev parent reply other threads:[~2017-10-16 14:21 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-12 23:03 [RFC PATCH v9 for 4.15 00/14] Restartable sequences and CPU op vector system calls Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH v9 for 4.15 01/14] Restartable sequences system call Mathieu Desnoyers 2017-10-13 0:36 ` Linus Torvalds 2017-10-13 0:36 ` Linus Torvalds 2017-10-13 9:35 ` Ben Maurer 2017-10-13 9:35 ` Ben Maurer 2017-10-13 18:30 ` Linus Torvalds 2017-10-13 18:30 ` Linus Torvalds 2017-10-13 20:54 ` Paul E. McKenney 2017-10-13 20:54 ` Paul E. McKenney 2017-10-13 21:05 ` Linus Torvalds 2017-10-13 21:05 ` Linus Torvalds 2017-10-13 21:21 ` Paul E. McKenney 2017-10-13 21:21 ` Paul E. McKenney 2017-10-13 21:36 ` Mathieu Desnoyers 2017-10-13 21:36 ` Mathieu Desnoyers 2017-10-16 16:04 ` Carlos O'Donell 2017-10-16 16:04 ` Carlos O'Donell 2017-10-16 16:46 ` Andi Kleen 2017-10-16 16:46 ` Andi Kleen 2017-10-16 22:17 ` Mathieu Desnoyers 2017-10-16 22:17 ` Mathieu Desnoyers 2017-10-17 16:19 ` Ben Maurer 2017-10-17 16:19 ` Ben Maurer 2017-10-17 16:33 ` Mathieu Desnoyers 2017-10-17 16:33 ` Mathieu Desnoyers 2017-10-17 16:41 ` Ben Maurer 2017-10-17 16:41 ` Ben Maurer 2017-10-17 17:48 ` Mathieu Desnoyers 2017-10-17 17:48 ` Mathieu Desnoyers 2017-10-18 6:22 ` Greg KH 2017-10-18 6:22 ` Greg KH 2017-10-18 16:28 ` Mathieu Desnoyers 2017-10-18 16:28 ` Mathieu Desnoyers 2017-10-14 3:01 ` Andi Kleen 2017-10-14 3:01 ` Andi Kleen 2017-10-14 4:05 ` Linus Torvalds 2017-10-14 4:05 ` Linus Torvalds 2017-10-14 11:37 ` Mathieu Desnoyers 2017-10-14 11:37 ` Mathieu Desnoyers 2017-10-13 12:50 ` Florian Weimer 2017-10-13 13:40 ` Mathieu Desnoyers 2017-10-13 13:40 ` Mathieu Desnoyers 2017-10-13 13:56 ` Florian Weimer 2017-10-13 13:56 ` Florian Weimer 2017-10-13 14:27 ` Mathieu Desnoyers 2017-10-13 14:27 ` Mathieu Desnoyers 2017-10-13 17:24 ` Andy Lutomirski 2017-10-13 17:24 ` Andy Lutomirski 2017-10-13 17:53 ` Florian Weimer 2017-10-13 17:53 ` Florian Weimer 2017-10-13 18:17 ` Andy Lutomirski 2017-10-13 18:17 ` Andy Lutomirski 2017-10-14 11:53 ` Mathieu Desnoyers 2017-10-14 11:53 ` Mathieu Desnoyers 2017-10-18 16:41 ` Ben Maurer 2017-10-18 18:11 ` Mathieu Desnoyers 2017-10-18 18:11 ` Mathieu Desnoyers 2017-10-19 11:35 ` Mathieu Desnoyers 2017-10-19 11:35 ` Mathieu Desnoyers 2017-10-19 17:01 ` Florian Weimer 2017-10-19 17:01 ` Florian Weimer 2017-10-23 17:30 ` Ben Maurer 2017-10-23 17:30 ` Ben Maurer 2017-10-23 20:44 ` Mathieu Desnoyers 2017-10-23 20:44 ` Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 02/14] tracing: instrument restartable sequences Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 03/14] Restartable sequences: ARM 32 architecture support Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 04/14] Restartable sequences: wire up ARM 32 system call Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 05/14] Restartable sequences: x86 32/64 architecture support Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 06/14] Restartable sequences: wire up x86 32/64 system call Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 07/14] Restartable sequences: powerpc architecture support Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 08/14] Restartable sequences: Wire up powerpc system call Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 09/14] Provide cpu_opv " Mathieu Desnoyers 2017-10-13 13:57 ` Alan Cox 2017-10-13 13:57 ` Alan Cox 2017-10-13 14:50 ` Mathieu Desnoyers 2017-10-13 14:50 ` Mathieu Desnoyers 2017-10-14 14:22 ` Mathieu Desnoyers 2017-10-14 14:22 ` Mathieu Desnoyers 2017-10-13 17:20 ` Andy Lutomirski 2017-10-13 17:20 ` Andy Lutomirski 2017-10-14 2:50 ` Andi Kleen 2017-10-14 2:50 ` Andi Kleen 2017-10-14 13:35 ` Mathieu Desnoyers 2017-10-14 13:35 ` Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 10/14] cpu_opv: Wire up x86 32/64 " Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 11/14] cpu_opv: Wire up powerpc " Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 12/14] cpu_opv: Wire up ARM32 " Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 13/14] cpu_opv: Implement selftests Mathieu Desnoyers 2017-10-12 23:03 ` [RFC PATCH for 4.15 14/14] Restartable sequences: Provide self-tests Mathieu Desnoyers 2017-10-16 2:51 ` Michael Ellerman 2017-10-16 2:51 ` Michael Ellerman 2017-10-16 14:23 ` Mathieu Desnoyers [this message] 2017-10-16 14:23 ` Mathieu Desnoyers 2017-10-17 10:38 ` Michael Ellerman 2017-10-17 10:38 ` Michael Ellerman 2017-10-17 13:50 ` Mathieu Desnoyers 2017-10-17 13:50 ` Mathieu Desnoyers 2017-10-16 18:50 ` Mathieu Desnoyers 2017-10-16 18:50 ` Mathieu Desnoyers 2017-10-17 10:36 ` Michael Ellerman 2017-10-17 10:36 ` Michael Ellerman 2017-10-17 13:50 ` Mathieu Desnoyers 2017-10-17 13:50 ` Mathieu Desnoyers 2017-10-18 5:45 ` Michael Ellerman 2017-10-18 5:45 ` Michael Ellerman 2017-10-16 3:00 ` Michael Ellerman 2017-10-16 3:00 ` Michael Ellerman 2017-10-16 3:48 ` Boqun Feng 2017-10-16 3:48 ` Boqun Feng 2017-10-16 11:48 ` Michael Ellerman 2017-10-16 11:48 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=399058130.42156.1508163782335.JavaMail.zimbra@efficios.com \ --to=mathieu.desnoyers@efficios.com \ --cc=ahh@google.com \ --cc=akpm@linux-foundation.org \ --cc=andi@firstfloor.org \ --cc=bmaurer@fb.com \ --cc=boqun.feng@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=cl@linux.com \ --cc=davejwatson@fb.com \ --cc=hpa@zytor.com \ --cc=josh@joshtriplett.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=luto@amacapital.net \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=rostedt@goodmis.org \ --cc=shuah@kernel.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.