* [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
@ 2022-09-29 0:15 Christian Kohlschütter
2022-09-29 2:36 ` Simon Glass
2022-10-17 13:21 ` Kever Yang
0 siblings, 2 replies; 9+ messages in thread
From: Christian Kohlschütter @ 2022-09-29 0:15 UTC (permalink / raw)
To: u-boot, Xiaobo Tian, Simon Glass, Philipp Tomsich, Kever Yang
Cc: Christian Kohlschütter
Provide human-readable manufacturer and product names for the
FriendlyELEC NanoPi R4S.
Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
configs/nanopi-r4s-rk3399_defconfig | 2 ++
2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
index cd1642527b..69800cc368 100644
--- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
@@ -14,3 +14,25 @@
#include "rk3399-nanopi4-u-boot.dtsi"
#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+
+ smbios {
+ system {
+ manufacturer = "FriendlyELEC";
+ product = "NanoPi R4S";
+ };
+
+ baseboard {
+ manufacturer = "FriendlyELEC";
+ product = "NanoPi R4S";
+ };
+
+ chassis {
+ manufacturer = "FriendlyELEC";
+ };
+ };
+ };
+};
diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
index dd2579d2e0..502f007e6e 100644
--- a/configs/nanopi-r4s-rk3399_defconfig
+++ b/configs/nanopi-r4s-rk3399_defconfig
@@ -75,3 +75,5 @@ CONFIG_MISC=y
CONFIG_MISC_INIT_R=y
CONFIG_ROCKCHIP_EFUSE=y
CONFIG_ROCKCHIP_OTP=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
--
2.36.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-09-29 0:15 [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo Christian Kohlschütter
@ 2022-09-29 2:36 ` Simon Glass
2022-09-29 14:29 ` Christian Kohlschütter
2022-10-17 13:21 ` Kever Yang
1 sibling, 1 reply; 9+ messages in thread
From: Simon Glass @ 2022-09-29 2:36 UTC (permalink / raw)
To: Christian Kohlschütter
Cc: U-Boot Mailing List, Xiaobo Tian, Philipp Tomsich, Kever Yang
On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
<christian@kohlschutter.com> wrote:
>
> Provide human-readable manufacturer and product names for the
> FriendlyELEC NanoPi R4S.
>
> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> ---
> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/nanopi-r4s-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
>
> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> index cd1642527b..69800cc368 100644
> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> @@ -14,3 +14,25 @@
>
> #include "rk3399-nanopi4-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + baseboard {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + chassis {
> + manufacturer = "FriendlyELEC";
> + };
> + };
> + };
> +};
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index dd2579d2e0..502f007e6e 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -75,3 +75,5 @@ CONFIG_MISC=y
> CONFIG_MISC_INIT_R=y
> CONFIG_ROCKCHIP_EFUSE=y
> CONFIG_ROCKCHIP_OTP=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
Is the ordering right, here?
Regards,
Simon
> --
> 2.36.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-09-29 2:36 ` Simon Glass
@ 2022-09-29 14:29 ` Christian Kohlschütter
2022-09-29 23:55 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Christian Kohlschütter @ 2022-09-29 14:29 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List, Xiaobo Tian, Philipp Tomsich, Kever Yang
> On 29. Sep 2022, at 04:36, Simon Glass <sjg@chromium.org> wrote:
>
> On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
> <christian@kohlschutter.com> wrote:
>>
>> Provide human-readable manufacturer and product names for the
>> FriendlyELEC NanoPi R4S.
>>
>> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>>
>> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
>> ---
>> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
>> configs/nanopi-r4s-rk3399_defconfig | 2 ++
>> 2 files changed, 24 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
>>
>> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> index cd1642527b..69800cc368 100644
>> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> @@ -14,3 +14,25 @@
>>
>> #include "rk3399-nanopi4-u-boot.dtsi"
>> #include "rk3399-sdram-lpddr4-100.dtsi"
>> +
>> +/ {
>> + smbios {
>> + compatible = "u-boot,sysinfo-smbios";
>> +
>> + smbios {
>> + system {
>> + manufacturer = "FriendlyELEC";
>> + product = "NanoPi R4S";
>> + };
>> +
>> + baseboard {
>> + manufacturer = "FriendlyELEC";
>> + product = "NanoPi R4S";
>> + };
>> +
>> + chassis {
>> + manufacturer = "FriendlyELEC";
>> + };
>> + };
>> + };
>> +};
>> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
>> index dd2579d2e0..502f007e6e 100644
>> --- a/configs/nanopi-r4s-rk3399_defconfig
>> +++ b/configs/nanopi-r4s-rk3399_defconfig
>> @@ -75,3 +75,5 @@ CONFIG_MISC=y
>> CONFIG_MISC_INIT_R=y
>> CONFIG_ROCKCHIP_EFUSE=y
>> CONFIG_ROCKCHIP_OTP=y
>> +CONFIG_SYSINFO=y
>> +CONFIG_SYSINFO_SMBIOS=y
>
> Is the ordering right, here?
>
> Regards,
> Simon
Is there a tool to sort these values in a certain order? Should these not be in alphabetical order?
Thanks,
Christian
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-09-29 14:29 ` Christian Kohlschütter
@ 2022-09-29 23:55 ` Simon Glass
2022-09-30 22:18 ` Christian Kohlschütter
0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2022-09-29 23:55 UTC (permalink / raw)
To: Christian Kohlschütter
Cc: U-Boot Mailing List, Xiaobo Tian, Philipp Tomsich, Kever Yang
Hi Christian,
On Thu, 29 Sept 2022 at 08:30, Christian Kohlschütter
<christian@kohlschutter.com> wrote:
>
> > On 29. Sep 2022, at 04:36, Simon Glass <sjg@chromium.org> wrote:
> >
> > On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
> > <christian@kohlschutter.com> wrote:
> >>
> >> Provide human-readable manufacturer and product names for the
> >> FriendlyELEC NanoPi R4S.
> >>
> >> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
> >>
> >> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> >> ---
> >> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
> >> configs/nanopi-r4s-rk3399_defconfig | 2 ++
> >> 2 files changed, 24 insertions(+)
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> >>
> >> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> >> index cd1642527b..69800cc368 100644
> >> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> >> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> >> @@ -14,3 +14,25 @@
> >>
> >> #include "rk3399-nanopi4-u-boot.dtsi"
> >> #include "rk3399-sdram-lpddr4-100.dtsi"
> >> +
> >> +/ {
> >> + smbios {
> >> + compatible = "u-boot,sysinfo-smbios";
> >> +
> >> + smbios {
> >> + system {
> >> + manufacturer = "FriendlyELEC";
> >> + product = "NanoPi R4S";
> >> + };
> >> +
> >> + baseboard {
> >> + manufacturer = "FriendlyELEC";
> >> + product = "NanoPi R4S";
> >> + };
> >> +
> >> + chassis {
> >> + manufacturer = "FriendlyELEC";
> >> + };
> >> + };
> >> + };
> >> +};
> >> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> >> index dd2579d2e0..502f007e6e 100644
> >> --- a/configs/nanopi-r4s-rk3399_defconfig
> >> +++ b/configs/nanopi-r4s-rk3399_defconfig
> >> @@ -75,3 +75,5 @@ CONFIG_MISC=y
> >> CONFIG_MISC_INIT_R=y
> >> CONFIG_ROCKCHIP_EFUSE=y
> >> CONFIG_ROCKCHIP_OTP=y
> >> +CONFIG_SYSINFO=y
> >> +CONFIG_SYSINFO_SMBIOS=y
> >
> > Is the ordering right, here?
> >
> > Regards,
> > Simon
>
> Is there a tool to sort these values in a certain order?
$ echo nanopi-r4s-rk3399_defconfig >asc
$ ./tools/moveconfig.py -s -d asc
(it could use a new flag to just specific the board, if you want to
send a patch)
Should these not be in alphabetical order?
No it is in order of the Kconfig tree (use 'make menuconfig' or 'make
xconfig' to see it).
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-09-29 23:55 ` Simon Glass
@ 2022-09-30 22:18 ` Christian Kohlschütter
0 siblings, 0 replies; 9+ messages in thread
From: Christian Kohlschütter @ 2022-09-30 22:18 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List, Xiaobo Tian, Philipp Tomsich, Kever Yang
On 30. Sep 2022, at 01:55, Simon Glass <sjg@chromium.org> wrote:
...
>> Is there a tool to sort these values in a certain order?
>
> $ echo nanopi-r4s-rk3399_defconfig >asc
> $ ./tools/moveconfig.py -s -d asc
>
> (it could use a new flag to just specific the board, if you want to
> send a patch)
>
> Should these not be in alphabetical order?
>
> No it is in order of the Kconfig tree (use 'make menuconfig' or 'make
> xconfig' to see it).
>
> Regards,
> Simon
I tried the above commands to no avail. moveconfig hangs.
I assume you meant "cat" instead of "echo"? But even then it doesn't sort the values.
Fixing that I just got a bunch of "no defconfig matched" warnings.
What is the motivation of sorting these values in Kconfig order? Is it just for the sake of keeping comments in the right place?
Would sorting in alphabetical order cause other issues?
Should there perhaps be a make target to take care of automatically cleaning up defconfig files?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-09-29 0:15 [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo Christian Kohlschütter
2022-09-29 2:36 ` Simon Glass
@ 2022-10-17 13:21 ` Kever Yang
2022-10-17 13:25 ` Kever Yang
1 sibling, 1 reply; 9+ messages in thread
From: Kever Yang @ 2022-10-17 13:21 UTC (permalink / raw)
To: Christian Kohlschütter, u-boot, Xiaobo Tian, Simon Glass,
Philipp Tomsich
On 2022/9/29 08:15, Christian Kohlschütter wrote:
> Provide human-readable manufacturer and product names for the
> FriendlyELEC NanoPi R4S.
>
> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/nanopi-r4s-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> index cd1642527b..69800cc368 100644
> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> @@ -14,3 +14,25 @@
>
> #include "rk3399-nanopi4-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + baseboard {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + chassis {
> + manufacturer = "FriendlyELEC";
> + };
> + };
> + };
> +};
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index dd2579d2e0..502f007e6e 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -75,3 +75,5 @@ CONFIG_MISC=y
> CONFIG_MISC_INIT_R=y
> CONFIG_ROCKCHIP_EFUSE=y
> CONFIG_ROCKCHIP_OTP=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-10-17 13:21 ` Kever Yang
@ 2022-10-17 13:25 ` Kever Yang
2022-10-17 19:02 ` [PATCH v2] " Christian Kohlschütter
0 siblings, 1 reply; 9+ messages in thread
From: Kever Yang @ 2022-10-17 13:25 UTC (permalink / raw)
To: Christian Kohlschütter, u-boot, Xiaobo Tian, Simon Glass,
Philipp Tomsich
Hi Christian,
I got below error when try to apply:
Applying: arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
error: sha1 information is lacking or useless
(configs/nanopi-r4s-rk3399_defconfig).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 arm: dts: rockchip: rk3399: nanopi-r4s: Provide
smbios sysinfo
Could you resend this patch?
Thanks,
- Kever
On 2022/10/17 21:21, Kever Yang wrote:
>
> On 2022/9/29 08:15, Christian Kohlschütter wrote:
>> Provide human-readable manufacturer and product names for the
>> FriendlyELEC NanoPi R4S.
>>
>> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>>
>> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
>
> Thanks,
> - Kever
>> ---
>> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
>> configs/nanopi-r4s-rk3399_defconfig | 2 ++
>> 2 files changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> index cd1642527b..69800cc368 100644
>> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
>> @@ -14,3 +14,25 @@
>> #include "rk3399-nanopi4-u-boot.dtsi"
>> #include "rk3399-sdram-lpddr4-100.dtsi"
>> +
>> +/ {
>> + smbios {
>> + compatible = "u-boot,sysinfo-smbios";
>> +
>> + smbios {
>> + system {
>> + manufacturer = "FriendlyELEC";
>> + product = "NanoPi R4S";
>> + };
>> +
>> + baseboard {
>> + manufacturer = "FriendlyELEC";
>> + product = "NanoPi R4S";
>> + };
>> +
>> + chassis {
>> + manufacturer = "FriendlyELEC";
>> + };
>> + };
>> + };
>> +};
>> diff --git a/configs/nanopi-r4s-rk3399_defconfig
>> b/configs/nanopi-r4s-rk3399_defconfig
>> index dd2579d2e0..502f007e6e 100644
>> --- a/configs/nanopi-r4s-rk3399_defconfig
>> +++ b/configs/nanopi-r4s-rk3399_defconfig
>> @@ -75,3 +75,5 @@ CONFIG_MISC=y
>> CONFIG_MISC_INIT_R=y
>> CONFIG_ROCKCHIP_EFUSE=y
>> CONFIG_ROCKCHIP_OTP=y
>> +CONFIG_SYSINFO=y
>> +CONFIG_SYSINFO_SMBIOS=y
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-10-17 13:25 ` Kever Yang
@ 2022-10-17 19:02 ` Christian Kohlschütter
2023-02-22 6:38 ` Kever Yang
0 siblings, 1 reply; 9+ messages in thread
From: Christian Kohlschütter @ 2022-10-17 19:02 UTC (permalink / raw)
To: Xiaobo Tian, Simon Glass, Philipp Tomsich, Kever Yang
Cc: Christian Kohlschütter, u-boot
Provide human-readable manufacturer and product names for the
FriendlyELEC NanoPi R4S.
Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
configs/nanopi-r4s-rk3399_defconfig | 6 ++++++
2 files changed, 28 insertions(+)
diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
index cd1642527b..69800cc368 100644
--- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
@@ -14,3 +14,25 @@
#include "rk3399-nanopi4-u-boot.dtsi"
#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+
+ smbios {
+ system {
+ manufacturer = "FriendlyELEC";
+ product = "NanoPi R4S";
+ };
+
+ baseboard {
+ manufacturer = "FriendlyELEC";
+ product = "NanoPi R4S";
+ };
+
+ chassis {
+ manufacturer = "FriendlyELEC";
+ };
+ };
+ };
+};
diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
index d8854abbb1..502f007e6e 100644
--- a/configs/nanopi-r4s-rk3399_defconfig
+++ b/configs/nanopi-r4s-rk3399_defconfig
@@ -71,3 +71,9 @@ CONFIG_VIDEO_ROCKCHIP=y
CONFIG_DISPLAY_ROCKCHIP_HDMI=y
CONFIG_SPL_TINY_MEMSET=y
CONFIG_ERRNO_STR=y
+CONFIG_MISC=y
+CONFIG_MISC_INIT_R=y
+CONFIG_ROCKCHIP_EFUSE=y
+CONFIG_ROCKCHIP_OTP=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
--
2.36.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
2022-10-17 19:02 ` [PATCH v2] " Christian Kohlschütter
@ 2023-02-22 6:38 ` Kever Yang
0 siblings, 0 replies; 9+ messages in thread
From: Kever Yang @ 2023-02-22 6:38 UTC (permalink / raw)
To: Christian Kohlschütter, Xiaobo Tian, Simon Glass, Philipp Tomsich
Cc: u-boot
On 2022/10/18 03:02, Christian Kohlschütter wrote:
> Provide human-readable manufacturer and product names for the
> FriendlyELEC NanoPi R4S.
>
> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/nanopi-r4s-rk3399_defconfig | 6 ++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> index cd1642527b..69800cc368 100644
> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> @@ -14,3 +14,25 @@
>
> #include "rk3399-nanopi4-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + baseboard {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + chassis {
> + manufacturer = "FriendlyELEC";
> + };
> + };
> + };
> +};
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index d8854abbb1..502f007e6e 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -71,3 +71,9 @@ CONFIG_VIDEO_ROCKCHIP=y
> CONFIG_DISPLAY_ROCKCHIP_HDMI=y
> CONFIG_SPL_TINY_MEMSET=y
> CONFIG_ERRNO_STR=y
> +CONFIG_MISC=y
> +CONFIG_MISC_INIT_R=y
> +CONFIG_ROCKCHIP_EFUSE=y
> +CONFIG_ROCKCHIP_OTP=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-22 6:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 0:15 [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo Christian Kohlschütter
2022-09-29 2:36 ` Simon Glass
2022-09-29 14:29 ` Christian Kohlschütter
2022-09-29 23:55 ` Simon Glass
2022-09-30 22:18 ` Christian Kohlschütter
2022-10-17 13:21 ` Kever Yang
2022-10-17 13:25 ` Kever Yang
2022-10-17 19:02 ` [PATCH v2] " Christian Kohlschütter
2023-02-22 6:38 ` Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.