* [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode
@ 2009-11-09 2:59 ` Bob Copeland
0 siblings, 0 replies; 8+ messages in thread
From: Bob Copeland @ 2009-11-09 2:59 UTC (permalink / raw)
To: ath9k-devel
We should not zero out the multicast hash when configuring
the operating mode, since a zero value means all multicast
frames will get dropped. Also, ath5k_mode_setup() gets
called after any reset, so the hash already set up in
configure_filter() is lost.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/base.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 07c1e52..cb3dc89 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
/* configure operational mode */
ath5k_hw_set_opmode(ah);
- ath5k_hw_set_mcast_filter(ah, 0, 0);
ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] ath5k: add LED support for HP Compaq CQ60
2009-11-09 2:59 ` [ath9k-devel] " Bob Copeland
@ 2009-11-09 2:59 ` Bob Copeland
-1 siblings, 0 replies; 8+ messages in thread
From: Bob Copeland @ 2009-11-09 2:59 UTC (permalink / raw)
To: linville, jirislaby, mickflemm, lrodriguez
Cc: linux-wireless, ath5k-devel, ath9k-devel, Bob Copeland
Add GPIO configuration for the Compaq CQ60 laptop
Reported-by: David Dreggors <ddreggors@jumptv.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/led.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c
index 7ce98bd..fca0cfa 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/drivers/net/wireless/ath/ath5k/led.c
@@ -71,6 +71,8 @@ static const struct pci_device_id ath5k_led_devices[] = {
{ ATH_SDEVICE(PCI_VENDOR_ID_AZWAVE, 0x1026), ATH_LED(3, 0) },
/* IBM ThinkPad AR5BXB6 (legovini@spiro.fisica.unipd.it) */
{ ATH_SDEVICE(PCI_VENDOR_ID_IBM, 0x058a), ATH_LED(1, 0) },
+ /* HP Compaq CQ60-206US (ddreggors@jumptv.com) */
+ { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137a), ATH_LED(3, 1) },
/* HP Compaq C700 (nitrousnrg@gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
/* IBM-specific AR5212 (all others) */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [ath9k-devel] [PATCH 2/3] ath5k: add LED support for HP Compaq CQ60
@ 2009-11-09 2:59 ` Bob Copeland
0 siblings, 0 replies; 8+ messages in thread
From: Bob Copeland @ 2009-11-09 2:59 UTC (permalink / raw)
To: ath9k-devel
Add GPIO configuration for the Compaq CQ60 laptop
Reported-by: David Dreggors <ddreggors@jumptv.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/led.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c
index 7ce98bd..fca0cfa 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/drivers/net/wireless/ath/ath5k/led.c
@@ -71,6 +71,8 @@ static const struct pci_device_id ath5k_led_devices[] = {
{ ATH_SDEVICE(PCI_VENDOR_ID_AZWAVE, 0x1026), ATH_LED(3, 0) },
/* IBM ThinkPad AR5BXB6 (legovini at spiro.fisica.unipd.it) */
{ ATH_SDEVICE(PCI_VENDOR_ID_IBM, 0x058a), ATH_LED(1, 0) },
+ /* HP Compaq CQ60-206US (ddreggors at jumptv.com) */
+ { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137a), ATH_LED(3, 1) },
/* HP Compaq C700 (nitrousnrg at gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
/* IBM-specific AR5212 (all others) */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] ath5k: add LED definition for BenQ Joybook R55v
2009-11-09 2:59 ` [ath9k-devel] " Bob Copeland
@ 2009-11-09 2:59 ` Bob Copeland
-1 siblings, 0 replies; 8+ messages in thread
From: Bob Copeland @ 2009-11-09 2:59 UTC (permalink / raw)
To: linville, jirislaby, mickflemm, lrodriguez
Cc: linux-wireless, ath5k-devel, ath9k-devel, Bob Copeland
Setup the GPIOs for the BenQ Joybook netbook.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/led.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c
index fca0cfa..d495890 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/drivers/net/wireless/ath/ath5k/led.c
@@ -65,6 +65,8 @@ static const struct pci_device_id ath5k_led_devices[] = {
{ ATH_SDEVICE(PCI_VENDOR_ID_AMBIT, 0x0422), ATH_LED(1, 1) },
/* E-machines E510 (tuliom@gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_AMBIT, 0x0428), ATH_LED(3, 0) },
+ /* BenQ Joybook R55v (nowymarluk@wp.pl) */
+ { ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0100), ATH_LED(1, 0) },
/* Acer Extensa 5620z (nekoreeve@gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0105), ATH_LED(3, 0) },
/* Fukato Datacask Jupiter 1014a (mrb74@gmx.at) */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [ath9k-devel] [PATCH 3/3] ath5k: add LED definition for BenQ Joybook R55v
@ 2009-11-09 2:59 ` Bob Copeland
0 siblings, 0 replies; 8+ messages in thread
From: Bob Copeland @ 2009-11-09 2:59 UTC (permalink / raw)
To: ath9k-devel
Setup the GPIOs for the BenQ Joybook netbook.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/led.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c
index fca0cfa..d495890 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/drivers/net/wireless/ath/ath5k/led.c
@@ -65,6 +65,8 @@ static const struct pci_device_id ath5k_led_devices[] = {
{ ATH_SDEVICE(PCI_VENDOR_ID_AMBIT, 0x0422), ATH_LED(1, 1) },
/* E-machines E510 (tuliom at gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_AMBIT, 0x0428), ATH_LED(3, 0) },
+ /* BenQ Joybook R55v (nowymarluk at wp.pl) */
+ { ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0100), ATH_LED(1, 0) },
/* Acer Extensa 5620z (nekoreeve at gmail.com) */
{ ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0105), ATH_LED(3, 0) },
/* Fukato Datacask Jupiter 1014a (mrb74 at gmx.at) */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode
2009-11-09 2:59 ` [ath9k-devel] " Bob Copeland
@ 2009-11-09 3:05 ` Nick Kossifidis
-1 siblings, 0 replies; 8+ messages in thread
From: Nick Kossifidis @ 2009-11-09 3:05 UTC (permalink / raw)
To: Bob Copeland
Cc: linville, jirislaby, lrodriguez, linux-wireless, ath5k-devel,
ath9k-devel
2009/11/9 Bob Copeland <me@bobcopeland.com>:
> We should not zero out the multicast hash when configuring
> the operating mode, since a zero value means all multicast
> frames will get dropped. Also, ath5k_mode_setup() gets
> called after any reset, so the hash already set up in
> configure_filter() is lost.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
> drivers/net/wireless/ath/ath5k/base.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 07c1e52..cb3dc89 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
> /* configure operational mode */
> ath5k_hw_set_opmode(ah);
>
> - ath5k_hw_set_mcast_filter(ah, 0, 0);
> ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
> }
>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ath9k-devel] [PATCH 1/3] ath5k: don't reset mcast filter when configuring the mode
@ 2009-11-09 3:05 ` Nick Kossifidis
0 siblings, 0 replies; 8+ messages in thread
From: Nick Kossifidis @ 2009-11-09 3:05 UTC (permalink / raw)
To: ath9k-devel
2009/11/9 Bob Copeland <me@bobcopeland.com>:
> We should not zero out the multicast hash when configuring
> the operating mode, since a zero value means all multicast
> frames will get dropped. ?Also, ath5k_mode_setup() gets
> called after any reset, so the hash already set up in
> configure_filter() is lost.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
> ?drivers/net/wireless/ath/ath5k/base.c | ? ?1 -
> ?1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 07c1e52..cb3dc89 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1146,7 +1146,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
> ? ? ? ?/* configure operational mode */
> ? ? ? ?ath5k_hw_set_opmode(ah);
>
> - ? ? ? ath5k_hw_set_mcast_filter(ah, 0, 0);
> ? ? ? ?ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
> ?}
>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread