All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks
Date: Thu, 2 Jul 2020 09:19:33 +0200	[thread overview]
Message-ID: <41b48aa5-e5b2-0257-8b3d-07e1b86634b4@web.de> (raw)
In-Reply-To: <c7cc848a-1ce0-e877-aa44-ebafe4b5985c@loongson.cn>

>>> +++ b/drivers/irqchip/irq-csky-apb-intc.c
…
>> I suggest to recheck the parameter alignment for such a function call.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=7c30b859a947535f2213277e827d7ac7dcff9c84#n93
> 
> OK, thank you, like this:
> 
> -       ret = irq_alloc_domain_generic_chips(root_domain, 32, 1,
> -                       "csky_intc", handle_level_irq,
> -                       IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN, 0, 0);
> -       if (ret) {
> +       if (irq_alloc_domain_generic_chips(root_domain, 32, 1,
> +                                          "csky_intc", handle_level_irq,
> +                                          IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN, 0, 0)) {
>                 pr_err("C-SKY Intc irq_alloc_gc failed.\n");
…

Would you like to use also horizontal tab characters for the corresponding indentation?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks
Date: Thu, 02 Jul 2020 07:19:33 +0000	[thread overview]
Message-ID: <41b48aa5-e5b2-0257-8b3d-07e1b86634b4@web.de> (raw)
In-Reply-To: <c7cc848a-1ce0-e877-aa44-ebafe4b5985c@loongson.cn>

Pj4+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtY3NreS1hcGItaW50Yy5jDQrigKYNCj4+IEkg
c3VnZ2VzdCB0byByZWNoZWNrIHRoZSBwYXJhbWV0ZXIgYWxpZ25tZW50IGZvciBzdWNoIGEgZnVu
Y3Rpb24gY2FsbC4NCj4+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJu
ZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vcHJvY2Vzcy9jb2Rp
bmctc3R5bGUucnN0P2lkPTdjMzBiODU5YTk0NzUzNWYyMjEzMjc3ZTgyN2Q3YWM3ZGNmZjljODQj
bjkzDQo+IA0KPiBPSywgdGhhbmsgeW91LCBsaWtlIHRoaXM6DQo+IA0KPiAtwqDCoMKgwqDCoMKg
IHJldCA9IGlycV9hbGxvY19kb21haW5fZ2VuZXJpY19jaGlwcyhyb290X2RvbWFpbiwgMzIsIDEs
DQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiY3NreV9p
bnRjIiwgaGFuZGxlX2xldmVsX2lycSwNCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIElSUV9OT1JFUVVFU1QgfCBJUlFfTk9QUk9CRSB8IElSUV9OT0FVVE9F
TiwgMCwgMCk7DQo+IC3CoMKgwqDCoMKgwqAgaWYgKHJldCkgew0KPiArwqDCoMKgwqDCoMKgIGlm
IChpcnFfYWxsb2NfZG9tYWluX2dlbmVyaWNfY2hpcHMocm9vdF9kb21haW4sIDMyLCAxLA0KPiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiY3NreV9pbnRjIiwgaGFuZGxlX2xldmVsX2lycSwN
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgSVJRX05PUkVRVUVTVCB8IElSUV9OT1BST0JF
IHwgSVJRX05PQVVUT0VOLCAwLCAwKSkgew0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcHJfZXJyKCJDLVNLWSBJbnRjIGlycV9hbGxvY19nYyBmYWlsZWQuXG4iKTsNCuKApg0KDQpX
b3VsZCB5b3UgbGlrZSB0byB1c2UgYWxzbyBob3Jpem9udGFsIHRhYiBjaGFyYWN0ZXJzIGZvciB0
aGUgY29ycmVzcG9uZGluZyBpbmRlbnRhdGlvbj8NCg0KUmVnYXJkcywNCk1hcmt1cw0K

  parent reply	other threads:[~2020-07-02  7:19 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  2:16 [PATCH v4 00/14] irqchip: Fix potential resource leaks Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 01/14] irqchip/ath79-misc: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 02/14] irqchip/csky-apb-intc: " Tiezhu Yang
2020-07-01  8:40   ` Markus Elfring
2020-07-01  8:40     ` Markus Elfring
2020-07-01  9:35     ` Tiezhu Yang
2020-07-01  9:35       ` Tiezhu Yang
2020-07-01 13:04       ` Markus Elfring
2020-07-01 13:04         ` Markus Elfring
2020-07-02  1:18         ` Tiezhu Yang
2020-07-02  1:18           ` Tiezhu Yang
2020-07-02  7:19           ` Markus Elfring
2020-07-02  7:19             ` Markus Elfring
2020-07-02  7:19           ` Markus Elfring [this message]
2020-07-02  7:19             ` Markus Elfring
2020-07-02  8:05             ` Tiezhu Yang
2020-07-02  8:05               ` Tiezhu Yang
2020-07-02 11:53               ` Tiezhu Yang
2020-07-02 11:53                 ` Tiezhu Yang
2020-07-02 12:24                 ` [v4 " Markus Elfring
2020-07-02 12:24                   ` Markus Elfring
2020-07-02 12:35                   ` Tiezhu Yang
2020-07-02 12:35                     ` Tiezhu Yang
2020-07-02 15:00       ` [PATCH v4 " Dan Carpenter
2020-07-02 15:00         ` Dan Carpenter
2020-07-01  2:16 ` [PATCH v4 03/14] irqchip/csky-mpintc: " Tiezhu Yang
2020-07-01  7:49   ` Markus Elfring
2020-07-01  7:49     ` Markus Elfring
2020-07-01  9:23     ` Tiezhu Yang
2020-07-01  9:23       ` Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 04/14] irqchip/davinci-aintc: " Tiezhu Yang
2020-07-01  8:15   ` Markus Elfring
2020-07-01  8:15     ` Markus Elfring
2020-07-01  9:19     ` Tiezhu Yang
2020-07-01  9:19       ` Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 05/14] irqchip/davinci-cp-intc: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 06/14] irqchip/digicolor: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 07/14] irqchip/dw-apb-ictl: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 08/14] irqchip/ls1x: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 09/14] irqchip/mscc-ocelot: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 10/14] irqchip/nvic: " Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
2020-07-01  9:14   ` Markus Elfring
2020-07-01  9:14     ` Markus Elfring
2020-07-01  9:40     ` Tiezhu Yang
2020-07-01  9:40       ` Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 12/14] irqchip/riscv-intc: " Tiezhu Yang
2020-07-01  9:30   ` Markus Elfring
2020-07-01  9:30     ` Markus Elfring
2020-07-01  9:30     ` Markus Elfring
2020-07-01  9:43   ` Anup Patel
2020-07-01  2:16 ` [PATCH v4 13/14] irqchip/s3c24xx: Fix potential resource leaks Tiezhu Yang
2020-07-01  2:16 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Tiezhu Yang
2020-07-01  9:42   ` Markus Elfring
2020-07-01  9:42     ` Markus Elfring
2020-07-01  9:42     ` Markus Elfring
2020-07-01  9:58     ` Tiezhu Yang
2020-07-01  9:58       ` Tiezhu Yang
2020-07-01  9:58       ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41b48aa5-e5b2-0257-8b3d-07e1b86634b4@web.de \
    --to=markus.elfring@web.de \
    --cc=guoren@kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.