From: Markus Elfring <Markus.Elfring@web.de> To: Tiezhu Yang <yangtiezhu@loongson.cn>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>, linux-csky@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks Date: Wed, 1 Jul 2020 10:40:35 +0200 [thread overview] Message-ID: <564ffff9-6043-7191-2458-f425dd8d0c11@web.de> (raw) In-Reply-To: <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn> > … were not released in a few error cases. … Another small wording adjustment: … in two error cases. … … > +++ b/drivers/irqchip/irq-csky-apb-intc.c … > @@ -126,10 +127,17 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent) … > +err_iounmap: > + iounmap(reg_base); > + return ret; > } … How do you think about to use the statement “return -ENOMEM;”? Can the local variable “ret” be omitted in this function implementation? Regards, Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de> To: Tiezhu Yang <yangtiezhu@loongson.cn>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <maz@kernel.org>, Guo Ren <guoren@kernel.org>, linux-csky@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v4 02/14] irqchip/csky-apb-intc: Fix potential resource leaks Date: Wed, 01 Jul 2020 08:40:35 +0000 [thread overview] Message-ID: <564ffff9-6043-7191-2458-f425dd8d0c11@web.de> (raw) In-Reply-To: <1593569786-11500-3-git-send-email-yangtiezhu@loongson.cn> > … were not released in a few error cases. … Another small wording adjustment: … in two error cases. … … > +++ b/drivers/irqchip/irq-csky-apb-intc.c … > @@ -126,10 +127,17 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent) … > +err_iounmap: > + iounmap(reg_base); > + return ret; > } … How do you think about to use the statement “return -ENOMEM;”? Can the local variable “ret” be omitted in this function implementation? Regards, Markus
next prev parent reply other threads:[~2020-07-01 8:40 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-01 2:16 [PATCH v4 00/14] irqchip: Fix potential resource leaks Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 01/14] irqchip/ath79-misc: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 02/14] irqchip/csky-apb-intc: " Tiezhu Yang 2020-07-01 8:40 ` Markus Elfring [this message] 2020-07-01 8:40 ` Markus Elfring 2020-07-01 9:35 ` Tiezhu Yang 2020-07-01 9:35 ` Tiezhu Yang 2020-07-01 13:04 ` Markus Elfring 2020-07-01 13:04 ` Markus Elfring 2020-07-02 1:18 ` Tiezhu Yang 2020-07-02 1:18 ` Tiezhu Yang 2020-07-02 7:19 ` Markus Elfring 2020-07-02 7:19 ` Markus Elfring 2020-07-02 7:19 ` Markus Elfring 2020-07-02 7:19 ` Markus Elfring 2020-07-02 8:05 ` Tiezhu Yang 2020-07-02 8:05 ` Tiezhu Yang 2020-07-02 11:53 ` Tiezhu Yang 2020-07-02 11:53 ` Tiezhu Yang 2020-07-02 12:24 ` [v4 " Markus Elfring 2020-07-02 12:24 ` Markus Elfring 2020-07-02 12:35 ` Tiezhu Yang 2020-07-02 12:35 ` Tiezhu Yang 2020-07-02 15:00 ` [PATCH v4 " Dan Carpenter 2020-07-02 15:00 ` Dan Carpenter 2020-07-01 2:16 ` [PATCH v4 03/14] irqchip/csky-mpintc: " Tiezhu Yang 2020-07-01 7:49 ` Markus Elfring 2020-07-01 7:49 ` Markus Elfring 2020-07-01 9:23 ` Tiezhu Yang 2020-07-01 9:23 ` Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 04/14] irqchip/davinci-aintc: " Tiezhu Yang 2020-07-01 8:15 ` Markus Elfring 2020-07-01 8:15 ` Markus Elfring 2020-07-01 9:19 ` Tiezhu Yang 2020-07-01 9:19 ` Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 05/14] irqchip/davinci-cp-intc: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 06/14] irqchip/digicolor: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 07/14] irqchip/dw-apb-ictl: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 08/14] irqchip/ls1x: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 09/14] irqchip/mscc-ocelot: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 10/14] irqchip/nvic: " Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang 2020-07-01 9:14 ` Markus Elfring 2020-07-01 9:14 ` Markus Elfring 2020-07-01 9:40 ` Tiezhu Yang 2020-07-01 9:40 ` Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 12/14] irqchip/riscv-intc: " Tiezhu Yang 2020-07-01 9:30 ` Markus Elfring 2020-07-01 9:30 ` Markus Elfring 2020-07-01 9:30 ` Markus Elfring 2020-07-01 9:43 ` Anup Patel 2020-07-01 2:16 ` [PATCH v4 13/14] irqchip/s3c24xx: Fix potential resource leaks Tiezhu Yang 2020-07-01 2:16 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Tiezhu Yang 2020-07-01 9:42 ` Markus Elfring 2020-07-01 9:42 ` Markus Elfring 2020-07-01 9:42 ` Markus Elfring 2020-07-01 9:58 ` Tiezhu Yang 2020-07-01 9:58 ` Tiezhu Yang 2020-07-01 9:58 ` Tiezhu Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=564ffff9-6043-7191-2458-f425dd8d0c11@web.de \ --to=markus.elfring@web.de \ --cc=guoren@kernel.org \ --cc=jason@lakedaemon.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-csky@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=tglx@linutronix.de \ --cc=yangtiezhu@loongson.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.