From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak
Date: Wed, 1 Jul 2020 17:58:06 +0800 [thread overview]
Message-ID: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> (raw)
In-Reply-To: <e9aaa867-bb11-a469-a4b9-03fb68a18c56@web.de>
On 07/01/2020 05:42 PM, Markus Elfring wrote:
>> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
>> was not released in the error case. Thus add jump target for the completion
>> of the desired exception handling.
> Another small wording adjustment:
> … Thus add a jump target …
OK
>
>
> …
>> +++ b/drivers/irqchip/irq-xilinx-intc.c
> …
>> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>>
>> return 0;
>>
>> +error_domain_remove:
>> + irq_domain_remove(irqc->root_domain);
>> error:
>> iounmap(irqc->base);
> …
>
> Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Thank you, I will use "err_domain_remove" and "err_iounmap"
to keep consistence with other patches.
>
> Regards,
> Markus
WARNING: multiple messages have this Message-ID (diff)
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak
Date: Wed, 01 Jul 2020 09:58:06 +0000 [thread overview]
Message-ID: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> (raw)
In-Reply-To: <e9aaa867-bb11-a469-a4b9-03fb68a18c56@web.de>
On 07/01/2020 05:42 PM, Markus Elfring wrote:
>> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
>> was not released in the error case. Thus add jump target for the completion
>> of the desired exception handling.
> Another small wording adjustment:
> … Thus add a jump target …
OK
>
>
> …
>> +++ b/drivers/irqchip/irq-xilinx-intc.c
> …
>> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>>
>> return 0;
>>
>> +error_domain_remove:
>> + irq_domain_remove(irqc->root_domain);
>> error:
>> iounmap(irqc->base);
> …
>
> Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Thank you, I will use "err_domain_remove" and "err_iounmap"
to keep consistence with other patches.
>
> Regards,
> Markus
WARNING: multiple messages have this Message-ID (diff)
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak
Date: Wed, 1 Jul 2020 17:58:06 +0800 [thread overview]
Message-ID: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> (raw)
In-Reply-To: <e9aaa867-bb11-a469-a4b9-03fb68a18c56@web.de>
On 07/01/2020 05:42 PM, Markus Elfring wrote:
>> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
>> was not released in the error case. Thus add jump target for the completion
>> of the desired exception handling.
> Another small wording adjustment:
> … Thus add a jump target …
OK
>
>
> …
>> +++ b/drivers/irqchip/irq-xilinx-intc.c
> …
>> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>>
>> return 0;
>>
>> +error_domain_remove:
>> + irq_domain_remove(irqc->root_domain);
>> error:
>> iounmap(irqc->base);
> …
>
> Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Thank you, I will use "err_domain_remove" and "err_iounmap"
to keep consistence with other patches.
>
> Regards,
> Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-01 9:58 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 2:16 [PATCH v4 00/14] irqchip: Fix potential resource leaks Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 01/14] irqchip/ath79-misc: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 02/14] irqchip/csky-apb-intc: " Tiezhu Yang
2020-07-01 8:40 ` Markus Elfring
2020-07-01 8:40 ` Markus Elfring
2020-07-01 9:35 ` Tiezhu Yang
2020-07-01 9:35 ` Tiezhu Yang
2020-07-01 13:04 ` Markus Elfring
2020-07-01 13:04 ` Markus Elfring
2020-07-02 1:18 ` Tiezhu Yang
2020-07-02 1:18 ` Tiezhu Yang
2020-07-02 7:19 ` Markus Elfring
2020-07-02 7:19 ` Markus Elfring
2020-07-02 7:19 ` Markus Elfring
2020-07-02 7:19 ` Markus Elfring
2020-07-02 8:05 ` Tiezhu Yang
2020-07-02 8:05 ` Tiezhu Yang
2020-07-02 11:53 ` Tiezhu Yang
2020-07-02 11:53 ` Tiezhu Yang
2020-07-02 12:24 ` [v4 " Markus Elfring
2020-07-02 12:24 ` Markus Elfring
2020-07-02 12:35 ` Tiezhu Yang
2020-07-02 12:35 ` Tiezhu Yang
2020-07-02 15:00 ` [PATCH v4 " Dan Carpenter
2020-07-02 15:00 ` Dan Carpenter
2020-07-01 2:16 ` [PATCH v4 03/14] irqchip/csky-mpintc: " Tiezhu Yang
2020-07-01 7:49 ` Markus Elfring
2020-07-01 7:49 ` Markus Elfring
2020-07-01 9:23 ` Tiezhu Yang
2020-07-01 9:23 ` Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 04/14] irqchip/davinci-aintc: " Tiezhu Yang
2020-07-01 8:15 ` Markus Elfring
2020-07-01 8:15 ` Markus Elfring
2020-07-01 9:19 ` Tiezhu Yang
2020-07-01 9:19 ` Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 05/14] irqchip/davinci-cp-intc: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 06/14] irqchip/digicolor: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 07/14] irqchip/dw-apb-ictl: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 08/14] irqchip/ls1x: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 09/14] irqchip/mscc-ocelot: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 10/14] irqchip/nvic: " Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
2020-07-01 9:14 ` Markus Elfring
2020-07-01 9:14 ` Markus Elfring
2020-07-01 9:40 ` Tiezhu Yang
2020-07-01 9:40 ` Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 12/14] irqchip/riscv-intc: " Tiezhu Yang
2020-07-01 9:30 ` Markus Elfring
2020-07-01 9:30 ` Markus Elfring
2020-07-01 9:30 ` Markus Elfring
2020-07-01 9:43 ` Anup Patel
2020-07-01 2:16 ` [PATCH v4 13/14] irqchip/s3c24xx: Fix potential resource leaks Tiezhu Yang
2020-07-01 2:16 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Tiezhu Yang
2020-07-01 9:42 ` Markus Elfring
2020-07-01 9:42 ` Markus Elfring
2020-07-01 9:42 ` Markus Elfring
2020-07-01 9:58 ` Tiezhu Yang [this message]
2020-07-01 9:58 ` Tiezhu Yang
2020-07-01 9:58 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=Markus.Elfring@web.de \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.