All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-phy@lists.infradead.org, Niall Leonard <nl250060@ncr.com>
Cc: "Madalin Bucur" <madalin.bucur@nxp.com>,
	linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
	"Ioana Ciornei" <ioana.ciornei@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Camelia Alexandra Groza" <camelia.groza@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml
Date: Tue, 7 Mar 2023 10:35:40 -0500	[thread overview]
Message-ID: <42ccbac0-53e2-f599-fb3d-064b896bde4a@seco.com> (raw)
In-Reply-To: <4c039e53-e3ca-29d7-e5ea-f24e385d28b0@linaro.org>

Hi Krzysztof,

On 3/7/23 03:42, Krzysztof Kozlowski wrote:
> On 06/03/2023 20:15, Sean Anderson wrote:
>> This is a generic binding for simple MMIO GPIO controllers. Although we
>> have a single driver for these controllers, they were previously spread
>> over several files. Consolidate them. The register descriptions are
>> adapted from the comments in the source. There is no set order for the
>> registers, so I have not specified one.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> 
>> Changes in v10:
>> - New
>> 
>>  .../bindings/gpio/brcm,bcm6345-gpio.yaml      |  16 +--
>>  .../devicetree/bindings/gpio/gpio-mmio.yaml   | 136 ++++++++++++++++++
>>  .../bindings/gpio/ni,169445-nand-gpio.txt     |  38 -----
>>  .../devicetree/bindings/gpio/wd,mbl-gpio.txt  |  38 -----
>>  4 files changed, 137 insertions(+), 91 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> 
> https://lore.kernel.org/all/20230126-gpio-mmio-fix-v2-1-38397aace340@ncr.com/

Thanks for linking to that.

I believe this patch should be applied instead of that one because

- It documents all the registers, which were previously only documented
  in the driver
- It handles the endianness properties.
- It consolidates the various descriptions of this binding into one
  schema.

--Sean

WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@seco.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-phy@lists.infradead.org, Niall Leonard <nl250060@ncr.com>
Cc: "Madalin Bucur" <madalin.bucur@nxp.com>,
	linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
	"Ioana Ciornei" <ioana.ciornei@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Camelia Alexandra Groza" <camelia.groza@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml
Date: Tue, 7 Mar 2023 10:35:40 -0500	[thread overview]
Message-ID: <42ccbac0-53e2-f599-fb3d-064b896bde4a@seco.com> (raw)
In-Reply-To: <4c039e53-e3ca-29d7-e5ea-f24e385d28b0@linaro.org>

Hi Krzysztof,

On 3/7/23 03:42, Krzysztof Kozlowski wrote:
> On 06/03/2023 20:15, Sean Anderson wrote:
>> This is a generic binding for simple MMIO GPIO controllers. Although we
>> have a single driver for these controllers, they were previously spread
>> over several files. Consolidate them. The register descriptions are
>> adapted from the comments in the source. There is no set order for the
>> registers, so I have not specified one.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> 
>> Changes in v10:
>> - New
>> 
>>  .../bindings/gpio/brcm,bcm6345-gpio.yaml      |  16 +--
>>  .../devicetree/bindings/gpio/gpio-mmio.yaml   | 136 ++++++++++++++++++
>>  .../bindings/gpio/ni,169445-nand-gpio.txt     |  38 -----
>>  .../devicetree/bindings/gpio/wd,mbl-gpio.txt  |  38 -----
>>  4 files changed, 137 insertions(+), 91 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> 
> https://lore.kernel.org/all/20230126-gpio-mmio-fix-v2-1-38397aace340@ncr.com/

Thanks for linking to that.

I believe this patch should be applied instead of that one because

- It documents all the registers, which were previously only documented
  in the driver
- It handles the endianness properties.
- It consolidates the various descriptions of this binding into one
  schema.

--Sean

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@seco.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-phy@lists.infradead.org, Niall Leonard <nl250060@ncr.com>
Cc: devicetree@vger.kernel.org, "Fernández Rojas" <noltari@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Madalin Bucur" <madalin.bucur@nxp.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	linux-gpio@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Camelia Alexandra Groza" <camelia.groza@nxp.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Ioana Ciornei" <ioana.ciornei@nxp.com>,
	linuxppc-dev@lists.ozlabs.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml
Date: Tue, 7 Mar 2023 10:35:40 -0500	[thread overview]
Message-ID: <42ccbac0-53e2-f599-fb3d-064b896bde4a@seco.com> (raw)
In-Reply-To: <4c039e53-e3ca-29d7-e5ea-f24e385d28b0@linaro.org>

Hi Krzysztof,

On 3/7/23 03:42, Krzysztof Kozlowski wrote:
> On 06/03/2023 20:15, Sean Anderson wrote:
>> This is a generic binding for simple MMIO GPIO controllers. Although we
>> have a single driver for these controllers, they were previously spread
>> over several files. Consolidate them. The register descriptions are
>> adapted from the comments in the source. There is no set order for the
>> registers, so I have not specified one.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> 
>> Changes in v10:
>> - New
>> 
>>  .../bindings/gpio/brcm,bcm6345-gpio.yaml      |  16 +--
>>  .../devicetree/bindings/gpio/gpio-mmio.yaml   | 136 ++++++++++++++++++
>>  .../bindings/gpio/ni,169445-nand-gpio.txt     |  38 -----
>>  .../devicetree/bindings/gpio/wd,mbl-gpio.txt  |  38 -----
>>  4 files changed, 137 insertions(+), 91 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> 
> https://lore.kernel.org/all/20230126-gpio-mmio-fix-v2-1-38397aace340@ncr.com/

Thanks for linking to that.

I believe this patch should be applied instead of that one because

- It documents all the registers, which were previously only documented
  in the driver
- It handles the endianness properties.
- It consolidates the various descriptions of this binding into one
  schema.

--Sean

WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@seco.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-phy@lists.infradead.org, Niall Leonard <nl250060@ncr.com>
Cc: "Madalin Bucur" <madalin.bucur@nxp.com>,
	linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
	"Ioana Ciornei" <ioana.ciornei@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Camelia Alexandra Groza" <camelia.groza@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml
Date: Tue, 7 Mar 2023 10:35:40 -0500	[thread overview]
Message-ID: <42ccbac0-53e2-f599-fb3d-064b896bde4a@seco.com> (raw)
In-Reply-To: <4c039e53-e3ca-29d7-e5ea-f24e385d28b0@linaro.org>

Hi Krzysztof,

On 3/7/23 03:42, Krzysztof Kozlowski wrote:
> On 06/03/2023 20:15, Sean Anderson wrote:
>> This is a generic binding for simple MMIO GPIO controllers. Although we
>> have a single driver for these controllers, they were previously spread
>> over several files. Consolidate them. The register descriptions are
>> adapted from the comments in the source. There is no set order for the
>> registers, so I have not specified one.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> 
>> Changes in v10:
>> - New
>> 
>>  .../bindings/gpio/brcm,bcm6345-gpio.yaml      |  16 +--
>>  .../devicetree/bindings/gpio/gpio-mmio.yaml   | 136 ++++++++++++++++++
>>  .../bindings/gpio/ni,169445-nand-gpio.txt     |  38 -----
>>  .../devicetree/bindings/gpio/wd,mbl-gpio.txt  |  38 -----
>>  4 files changed, 137 insertions(+), 91 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/ni,169445-nand-gpio.txt
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt
> 
> https://lore.kernel.org/all/20230126-gpio-mmio-fix-v2-1-38397aace340@ncr.com/

Thanks for linking to that.

I believe this patch should be applied instead of that one because

- It documents all the registers, which were previously only documented
  in the driver
- It handles the endianness properties.
- It consolidates the various descriptions of this binding into one
  schema.

--Sean

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-07 15:36 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:15 [PATCH v10 00/13] phy: Add support for Lynx 10G SerDes Sean Anderson
2023-03-06 19:15 ` Sean Anderson
2023-03-06 19:15 ` Sean Anderson
2023-03-06 19:15 ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 01/13] dt-bindings: phy: Add 2500BASE-X and 10GBASE-R Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 02/13] dt-bindings: phy: Add Lynx 10G phy binding Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-07 19:14   ` Sean Anderson
2023-03-07 19:14     ` Sean Anderson
2023-03-07 19:14     ` Sean Anderson
2023-03-07 19:14     ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 20:51   ` Jonas Gorski
2023-03-06 20:51     ` Jonas Gorski
2023-03-06 20:51     ` Jonas Gorski
2023-03-06 20:51     ` Jonas Gorski
2023-03-06 21:27     ` Sean Anderson
2023-03-06 21:27       ` Sean Anderson
2023-03-06 21:27       ` Sean Anderson
2023-03-06 21:27       ` Sean Anderson
2023-03-10 10:33       ` Jonas Gorski
2023-03-10 10:33         ` Jonas Gorski
2023-03-10 10:33         ` Jonas Gorski
2023-03-10 10:33         ` Jonas Gorski
2023-03-06 22:04   ` Linus Walleij
2023-03-06 22:04     ` Linus Walleij
2023-03-06 22:04     ` Linus Walleij
2023-03-06 22:04     ` Linus Walleij
2023-03-07  8:42   ` Krzysztof Kozlowski
2023-03-07  8:42     ` Krzysztof Kozlowski
2023-03-07  8:42     ` Krzysztof Kozlowski
2023-03-07  8:42     ` Krzysztof Kozlowski
2023-03-07 15:35     ` Sean Anderson [this message]
2023-03-07 15:35       ` Sean Anderson
2023-03-07 15:35       ` Sean Anderson
2023-03-07 15:35       ` Sean Anderson
2023-03-08  8:48       ` Krzysztof Kozlowski
2023-03-08  8:48         ` Krzysztof Kozlowski
2023-03-08  8:48         ` Krzysztof Kozlowski
2023-03-08  8:48         ` Krzysztof Kozlowski
2023-03-09  9:16       ` Linus Walleij
2023-03-09  9:16         ` Linus Walleij
2023-03-09  9:16         ` Linus Walleij
2023-03-09  9:16         ` Linus Walleij
2023-03-13  8:53         ` Leonard, Niall
2023-03-13  8:53           ` Leonard, Niall
2023-03-13  8:53           ` Leonard, Niall
2023-03-13  8:53           ` Leonard, Niall
2023-03-13 15:19           ` Sean Anderson
2023-03-13 15:19             ` Sean Anderson
2023-03-13 15:19             ` Sean Anderson
2023-03-13 15:19             ` Sean Anderson
2023-03-13 22:13           ` Linus Walleij
2023-03-13 22:13             ` Linus Walleij
2023-03-13 22:13             ` Linus Walleij
2023-03-13 22:13             ` Linus Walleij
2023-03-08 23:10   ` Rob Herring
2023-03-08 23:10     ` Rob Herring
2023-03-08 23:10     ` Rob Herring
2023-03-08 23:10     ` Rob Herring
2023-03-09 16:03     ` Sean Anderson
2023-03-09 16:03       ` Sean Anderson
2023-03-09 16:03       ` Sean Anderson
2023-03-09 16:03       ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 04/13] dt-bindings: gpio-mmio: Add compatible for QIXIS Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-08 23:11   ` Rob Herring
2023-03-08 23:11     ` Rob Herring
2023-03-08 23:11     ` Rob Herring
2023-03-08 23:11     ` Rob Herring
2023-03-06 19:15 ` [PATCH v10 05/13] dt-bindings: clock: Add ids for Lynx 10g PLLs Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 06/13] clk: Add Lynx 10G SerDes PLL driver Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 07/13] phy: fsl: Add Lynx 10G SerDes driver Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 08/13] phy: lynx10g: Enable by default on Layerscape Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 09/13] arm64: dts: ls1046a: Add serdes nodes Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 10/13] arm64: dts: ls1046ardb: Add serdes descriptions Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 11/13] arm64: dts: ls1088a: Add serdes nodes Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 12/13] arm64: dts: ls1088a: Prevent PCSs from probing as phys Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15 ` [PATCH v10 13/13] arm64: dts: ls1088ardb: Add serdes descriptions Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson
2023-03-06 19:15   ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42ccbac0-53e2-f599-fb3d-064b896bde4a@seco.com \
    --to=sean.anderson@seco.com \
    --cc=bagasdotme@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=camelia.groza@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=jonas.gorski@gmail.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@nxp.com \
    --cc=nl250060@ncr.com \
    --cc=noltari@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.