From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org> Cc: Daniel Rosenberg <drosen@google.com>, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi <krisman@collabora.com>, kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Date: Sat, 5 Jun 2021 08:11:32 +0800 [thread overview] Message-ID: <452273b4-b386-3180-9b6e-f060bdbe3802@kernel.org> (raw) In-Reply-To: <YLm8aOs6Sc/CLaAv@google.com> On 2021/6/4 13:38, Jaegeuk Kim wrote: > On 06/03, Eric Biggers wrote: >> On Thu, Jun 03, 2021 at 09:45:25PM -0700, Jaegeuk Kim wrote: >>> On 06/03, Eric Biggers wrote: >>>> On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: >>>>> Older kernels don't support encryption with casefolding. This adds >>>>> the sysfs entry encrypted_casefold to show support for those combined >>>>> features. Support for this feature was originally added by >>>>> commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> >>>>> Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> Cc: stable@vger.kernel.org # v5.11+ >>>>> Signed-off-by: Daniel Rosenberg <drosen@google.com> >>>>> --- >>>>> fs/f2fs/sysfs.c | 15 +++++++++++++-- >>>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >>>>> index 09e3f258eb52..6604291a3cdf 100644 >>>>> --- a/fs/f2fs/sysfs.c >>>>> +++ b/fs/f2fs/sysfs.c >>>>> @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, >>>>> if (f2fs_sb_has_compression(sbi)) >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "compression"); >>>>> + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) >>>>> + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> + len ? ", " : "", "encrypted_casefold"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "pin_file"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); >>>>> @@ -579,6 +582,7 @@ enum feat_id { >>>>> FEAT_CASEFOLD, >>>>> FEAT_COMPRESSION, >>>>> FEAT_TEST_DUMMY_ENCRYPTION_V2, >>>>> + FEAT_ENCRYPTED_CASEFOLD, >>>>> }; >>>> >>>> Actually looking at it more closely, this patch is wrong. >>>> >>>> It only makes sense to declare "encrypted_casefold" as a feature of the >>>> filesystem implementation, i.e. /sys/fs/f2fs/features/encrypted_casefold. >>>> >>>> It does *not* make sense to declare it as a feature of a particular filesystem >>>> instance, i.e. /sys/fs/f2fs/$disk/features, as it is already implied by the >>>> filesystem instance having both the encryption and casefold features enabled. >>>> >>>> Can we add /sys/fs/f2fs/features/encrypted_casefold only? >>> >>> wait.. /sys/fs/f2fs/features/encrypted_casefold is on by >>> CONFIG_FS_ENCRYPTION && CONFIG_UNICODE. >>> OTOH, /sys/fs/f2fs/$dis/feature_list/encrypted_casefold is on by >>> on-disk features: F2FS_FEATURE_ENCRYPT and F2FS_FEATURE_CASEFOLD. >>> >> >> Yes, but in the on-disk case, encrypted_casefold is redundant because it simply >> means encrypt && casefold. There is no encrypted_casefold flag on-disk. > > I prefer to keep encrypted_casefold likewise kernel feature, which is more > intuitive to users. encrypted_casefold is a kernel feature support flag, not a disk one, IMO, it's not needed to add it in to per-disk feature list, it may mislead user that compatible encrypted casefold needs a extra disk layout support while disk has already encrypted and casefold feature enabled. Thanks, > >> >> - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org> Cc: Daniel Rosenberg <drosen@google.com>, Gabriel Krisman Bertazi <krisman@collabora.com>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, kernel-team@android.com Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Date: Sat, 5 Jun 2021 08:11:32 +0800 [thread overview] Message-ID: <452273b4-b386-3180-9b6e-f060bdbe3802@kernel.org> (raw) In-Reply-To: <YLm8aOs6Sc/CLaAv@google.com> On 2021/6/4 13:38, Jaegeuk Kim wrote: > On 06/03, Eric Biggers wrote: >> On Thu, Jun 03, 2021 at 09:45:25PM -0700, Jaegeuk Kim wrote: >>> On 06/03, Eric Biggers wrote: >>>> On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: >>>>> Older kernels don't support encryption with casefolding. This adds >>>>> the sysfs entry encrypted_casefold to show support for those combined >>>>> features. Support for this feature was originally added by >>>>> commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> >>>>> Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") >>>>> Cc: stable@vger.kernel.org # v5.11+ >>>>> Signed-off-by: Daniel Rosenberg <drosen@google.com> >>>>> --- >>>>> fs/f2fs/sysfs.c | 15 +++++++++++++-- >>>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >>>>> index 09e3f258eb52..6604291a3cdf 100644 >>>>> --- a/fs/f2fs/sysfs.c >>>>> +++ b/fs/f2fs/sysfs.c >>>>> @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, >>>>> if (f2fs_sb_has_compression(sbi)) >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "compression"); >>>>> + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) >>>>> + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> + len ? ", " : "", "encrypted_casefold"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", >>>>> len ? ", " : "", "pin_file"); >>>>> len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); >>>>> @@ -579,6 +582,7 @@ enum feat_id { >>>>> FEAT_CASEFOLD, >>>>> FEAT_COMPRESSION, >>>>> FEAT_TEST_DUMMY_ENCRYPTION_V2, >>>>> + FEAT_ENCRYPTED_CASEFOLD, >>>>> }; >>>> >>>> Actually looking at it more closely, this patch is wrong. >>>> >>>> It only makes sense to declare "encrypted_casefold" as a feature of the >>>> filesystem implementation, i.e. /sys/fs/f2fs/features/encrypted_casefold. >>>> >>>> It does *not* make sense to declare it as a feature of a particular filesystem >>>> instance, i.e. /sys/fs/f2fs/$disk/features, as it is already implied by the >>>> filesystem instance having both the encryption and casefold features enabled. >>>> >>>> Can we add /sys/fs/f2fs/features/encrypted_casefold only? >>> >>> wait.. /sys/fs/f2fs/features/encrypted_casefold is on by >>> CONFIG_FS_ENCRYPTION && CONFIG_UNICODE. >>> OTOH, /sys/fs/f2fs/$dis/feature_list/encrypted_casefold is on by >>> on-disk features: F2FS_FEATURE_ENCRYPT and F2FS_FEATURE_CASEFOLD. >>> >> >> Yes, but in the on-disk case, encrypted_casefold is redundant because it simply >> means encrypt && casefold. There is no encrypted_casefold flag on-disk. > > I prefer to keep encrypted_casefold likewise kernel feature, which is more > intuitive to users. encrypted_casefold is a kernel feature support flag, not a disk one, IMO, it's not needed to add it in to per-disk feature list, it may mislead user that compatible encrypted casefold needs a extra disk layout support while disk has already encrypted and casefold feature enabled. Thanks, > >> >> - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-05 0:11 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-03 9:50 [PATCH v2 0/2] Fix up casefolding sysfs entries for F2FS Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 9:50 ` [PATCH v2 1/2] f2fs: Show casefolding support only when supported Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 18:20 ` Eric Biggers 2021-06-03 18:20 ` [f2fs-dev] " Eric Biggers 2021-06-04 23:46 ` Chao Yu 2021-06-04 23:46 ` [f2fs-dev] " Chao Yu 2021-06-03 9:50 ` [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 10:04 ` Greg KH 2021-06-03 10:04 ` [f2fs-dev] " Greg KH 2021-06-03 15:40 ` Jaegeuk Kim 2021-06-03 15:40 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 17:26 ` Greg KH 2021-06-03 17:26 ` [f2fs-dev] " Greg KH 2021-06-03 17:53 ` Jaegeuk Kim 2021-06-03 17:53 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 18:12 ` Greg KH 2021-06-03 18:12 ` [f2fs-dev] " Greg KH 2021-06-03 19:20 ` Jaegeuk Kim 2021-06-03 19:20 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 20:54 ` David Laight 2021-06-03 20:54 ` [f2fs-dev] " David Laight 2021-06-03 18:26 ` Eric Biggers 2021-06-03 18:26 ` [f2fs-dev] " Eric Biggers 2021-06-03 23:21 ` Eric Biggers 2021-06-03 23:21 ` [f2fs-dev] " Eric Biggers 2021-06-04 4:45 ` Jaegeuk Kim 2021-06-04 4:45 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 5:01 ` Eric Biggers 2021-06-04 5:01 ` [f2fs-dev] " Eric Biggers 2021-06-04 5:38 ` Jaegeuk Kim 2021-06-04 5:38 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 5:54 ` Daniel Rosenberg 2021-06-04 5:54 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-04 18:58 ` Theodore Ts'o 2021-06-04 18:58 ` [f2fs-dev] " Theodore Ts'o 2021-06-05 0:11 ` Chao Yu [this message] 2021-06-05 0:11 ` Chao Yu 2021-06-05 0:15 ` Jaegeuk Kim 2021-06-05 0:15 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 8:27 ` David Laight 2021-06-04 8:27 ` [f2fs-dev] " David Laight 2021-06-04 8:33 ` Greg KH 2021-06-04 8:33 ` [f2fs-dev] " Greg KH 2021-06-04 23:46 ` Chao Yu 2021-06-04 23:46 ` [f2fs-dev] " Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=452273b4-b386-3180-9b6e-f060bdbe3802@kernel.org \ --to=chao@kernel.org \ --cc=drosen@google.com \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=kernel-team@android.com \ --cc=krisman@collabora.com \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.