* [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-07 5:47 ` Johnson Wang
0 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-07 5:47 UTC (permalink / raw)
To: ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group,
Johnson Wang
This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
platform.
Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 2a2e9fa8c188..3fbf33ad4f7c 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -32,6 +32,9 @@ properties:
- items:
- const: mediatek,mt8186-mmc
- const: mediatek,mt8183-mmc
+ - items:
+ - const: mediatek,mt8188-mmc
+ - const: mediatek,mt8183-mmc
- items:
- const: mediatek,mt8192-mmc
- const: mediatek,mt8183-mmc
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-07 5:47 ` Johnson Wang
0 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-07 5:47 UTC (permalink / raw)
To: ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group,
Johnson Wang
This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
platform.
Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 2a2e9fa8c188..3fbf33ad4f7c 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -32,6 +32,9 @@ properties:
- items:
- const: mediatek,mt8186-mmc
- const: mediatek,mt8183-mmc
+ - items:
+ - const: mediatek,mt8188-mmc
+ - const: mediatek,mt8183-mmc
- items:
- const: mediatek,mt8192-mmc
- const: mediatek,mt8183-mmc
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
2022-07-07 5:47 ` Johnson Wang
@ 2022-07-07 6:46 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:46 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 07/07/2022 07:47, Johnson Wang wrote:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
> - items:
> - const: mediatek,mt8186-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8188-mmc
You duplicate quite a lot. Use enum.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-07 6:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:46 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 07/07/2022 07:47, Johnson Wang wrote:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
> - items:
> - const: mediatek,mt8186-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8188-mmc
You duplicate quite a lot. Use enum.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
2022-07-07 6:46 ` Krzysztof Kozlowski
@ 2022-07-07 7:30 ` Johnson Wang
-1 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-07 7:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 07:47, Johnson Wang wrote:
> > This commit adds dt-binding documentation of mmc for MediaTek
> > MT8188 SoC
> > platform.
> >
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -32,6 +32,9 @@ properties:
> > - items:
> > - const: mediatek,mt8186-mmc
> > - const: mediatek,mt8183-mmc
> > + - items:
> > + - const: mediatek,mt8188-mmc
>
> You duplicate quite a lot. Use enum.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for you suggestion.
I will use 'enum' to place this compatible strings.
Just like this:
- items:
- enum:
- mediatek,mt8186-mmc
- mediatek,mt8188-mmc
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
Moreover, it seems that missing an "items:" between oneOf and enum in
the compatible property.
Is my understanding wrong?
BRs,
Johnson Wang
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-07 7:30 ` Johnson Wang
0 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-07 7:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 07:47, Johnson Wang wrote:
> > This commit adds dt-binding documentation of mmc for MediaTek
> > MT8188 SoC
> > platform.
> >
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -32,6 +32,9 @@ properties:
> > - items:
> > - const: mediatek,mt8186-mmc
> > - const: mediatek,mt8183-mmc
> > + - items:
> > + - const: mediatek,mt8188-mmc
>
> You duplicate quite a lot. Use enum.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for you suggestion.
I will use 'enum' to place this compatible strings.
Just like this:
- items:
- enum:
- mediatek,mt8186-mmc
- mediatek,mt8188-mmc
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
Moreover, it seems that missing an "items:" between oneOf and enum in
the compatible property.
Is my understanding wrong?
BRs,
Johnson Wang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
2022-07-07 5:47 ` Johnson Wang
@ 2022-07-07 9:51 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 12+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-07 9:51 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
Il 07/07/22 07:47, Johnson Wang ha scritto:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
> - items:
> - const: mediatek,mt8186-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8188-mmc
> + - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
>
Hello Johnson,
if I'm not wrong, this should be...
(check with dt_binding_check!)
properties:
compatible:
oneOf:
- enum:
- mediatek,mt2701-mmc
- .... everything else ....
- items:
- enum:
- mediatek,mt8186-mmc
- ... the others ...
- const: mediatek.mt8183-mmc
Cheers,
Angelo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-07 9:51 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 12+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-07 9:51 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
Il 07/07/22 07:47, Johnson Wang ha scritto:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
> - items:
> - const: mediatek,mt8186-mmc
> - const: mediatek,mt8183-mmc
> + - items:
> + - const: mediatek,mt8188-mmc
> + - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
>
Hello Johnson,
if I'm not wrong, this should be...
(check with dt_binding_check!)
properties:
compatible:
oneOf:
- enum:
- mediatek,mt2701-mmc
- .... everything else ....
- items:
- enum:
- mediatek,mt8186-mmc
- ... the others ...
- const: mediatek.mt8183-mmc
Cheers,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
2022-07-07 7:30 ` Johnson Wang
@ 2022-07-11 11:02 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-11 11:02 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 07/07/2022 09:30, Johnson Wang wrote:
> On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 07:47, Johnson Wang wrote:
>>> This commit adds dt-binding documentation of mmc for MediaTek
>>> MT8188 SoC
>>> platform.
>>>
>>> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 2a2e9fa8c188..3fbf33ad4f7c 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -32,6 +32,9 @@ properties:
>>> - items:
>>> - const: mediatek,mt8186-mmc
>>> - const: mediatek,mt8183-mmc
>>> + - items:
>>> + - const: mediatek,mt8188-mmc
>>
>> You duplicate quite a lot. Use enum.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> Thanks for you suggestion.
>
> I will use 'enum' to place this compatible strings.
>
> Just like this:
> - items:
> - enum:
> - mediatek,mt8186-mmc
> - mediatek,mt8188-mmc
> - mediatek,mt8192-mmc
> - mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
>
> Moreover, it seems that missing an "items:" between oneOf and enum in
> the compatible property.
> Is my understanding wrong?
I did not propose to remove items, so where are they missing? Not sure
what you are asking about...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-11 11:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-11 11:02 UTC (permalink / raw)
To: Johnson Wang, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 07/07/2022 09:30, Johnson Wang wrote:
> On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 07:47, Johnson Wang wrote:
>>> This commit adds dt-binding documentation of mmc for MediaTek
>>> MT8188 SoC
>>> platform.
>>>
>>> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 2a2e9fa8c188..3fbf33ad4f7c 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -32,6 +32,9 @@ properties:
>>> - items:
>>> - const: mediatek,mt8186-mmc
>>> - const: mediatek,mt8183-mmc
>>> + - items:
>>> + - const: mediatek,mt8188-mmc
>>
>> You duplicate quite a lot. Use enum.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> Thanks for you suggestion.
>
> I will use 'enum' to place this compatible strings.
>
> Just like this:
> - items:
> - enum:
> - mediatek,mt8186-mmc
> - mediatek,mt8188-mmc
> - mediatek,mt8192-mmc
> - mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
>
> Moreover, it seems that missing an "items:" between oneOf and enum in
> the compatible property.
> Is my understanding wrong?
I did not propose to remove items, so where are they missing? Not sure
what you are asking about...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
2022-07-11 11:02 ` Krzysztof Kozlowski
@ 2022-07-11 12:03 ` Johnson Wang
-1 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-11 12:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On Mon, 2022-07-11 at 13:02 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 09:30, Johnson Wang wrote:
> > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> > > On 07/07/2022 07:47, Johnson Wang wrote:
> > > > This commit adds dt-binding documentation of mmc for MediaTek
> > > > MT8188 SoC
> > > > platform.
> > > >
> > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > > > ---
> > > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > @@ -32,6 +32,9 @@ properties:
> > > > - items:
> > > > - const: mediatek,mt8186-mmc
> > > > - const: mediatek,mt8183-mmc
> > > > + - items:
> > > > + - const: mediatek,mt8188-mmc
> > >
> > > You duplicate quite a lot. Use enum.
> > >
> > > Best regards,
> > > Krzysztof
> >
> > Hi Krzysztof,
> >
> > Thanks for you suggestion.
> >
> > I will use 'enum' to place this compatible strings.
> >
> > Just like this:
> > - items:
> > - enum:
> > - mediatek,mt8186-mmc
> > - mediatek,mt8188-mmc
> > - mediatek,mt8192-mmc
> > - mediatek,mt8195-mmc
> > - const: mediatek,mt8183-mmc
> >
> > Moreover, it seems that missing an "items:" between oneOf and enum
> > in
> > the compatible property.
> > Is my understanding wrong?
>
> I did not propose to remove items, so where are they missing? Not
> sure
> what you are asking about...
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Sorry for the confusion.
That was my misunderstanding. Please ignore it...
BRs,
Johnson Wang
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
@ 2022-07-11 12:03 ` Johnson Wang
0 siblings, 0 replies; 12+ messages in thread
From: Johnson Wang @ 2022-07-11 12:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, ulf.hansson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-mmc, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On Mon, 2022-07-11 at 13:02 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 09:30, Johnson Wang wrote:
> > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> > > On 07/07/2022 07:47, Johnson Wang wrote:
> > > > This commit adds dt-binding documentation of mmc for MediaTek
> > > > MT8188 SoC
> > > > platform.
> > > >
> > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > > > ---
> > > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > @@ -32,6 +32,9 @@ properties:
> > > > - items:
> > > > - const: mediatek,mt8186-mmc
> > > > - const: mediatek,mt8183-mmc
> > > > + - items:
> > > > + - const: mediatek,mt8188-mmc
> > >
> > > You duplicate quite a lot. Use enum.
> > >
> > > Best regards,
> > > Krzysztof
> >
> > Hi Krzysztof,
> >
> > Thanks for you suggestion.
> >
> > I will use 'enum' to place this compatible strings.
> >
> > Just like this:
> > - items:
> > - enum:
> > - mediatek,mt8186-mmc
> > - mediatek,mt8188-mmc
> > - mediatek,mt8192-mmc
> > - mediatek,mt8195-mmc
> > - const: mediatek,mt8183-mmc
> >
> > Moreover, it seems that missing an "items:" between oneOf and enum
> > in
> > the compatible property.
> > Is my understanding wrong?
>
> I did not propose to remove items, so where are they missing? Not
> sure
> what you are asking about...
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Sorry for the confusion.
That was my misunderstanding. Please ignore it...
BRs,
Johnson Wang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-07-11 13:00 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 5:47 [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188 Johnson Wang
2022-07-07 5:47 ` Johnson Wang
2022-07-07 6:46 ` Krzysztof Kozlowski
2022-07-07 6:46 ` Krzysztof Kozlowski
2022-07-07 7:30 ` Johnson Wang
2022-07-07 7:30 ` Johnson Wang
2022-07-11 11:02 ` Krzysztof Kozlowski
2022-07-11 11:02 ` Krzysztof Kozlowski
2022-07-11 12:03 ` Johnson Wang
2022-07-11 12:03 ` Johnson Wang
2022-07-07 9:51 ` AngeloGioacchino Del Regno
2022-07-07 9:51 ` AngeloGioacchino Del Regno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.