From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/1] CLD: Introduce the "New CLD" API
Date: Sun, 07 Feb 2010 17:26:46 -0500 [thread overview]
Message-ID: <4B6F3E26.8000808@garzik.org> (raw)
In-Reply-To: <20100207121550.7ee94ff6@redhat.com>
On 02/07/2010 02:15 PM, Pete Zaitcev wrote:
> The "traditional" CLD API is too difficult to program. In particular,
> switching from a rigid "Group" policy to arbitrary paths in existing
> clients in Chunk and tabled turned out to be next to impossible.
> The issue is due to the fundamental nature of the API as based on very
> fine-grained events.
>
> So, in the interests of clients, introduce the "new" API. Its basic
> definition is in<ncld.h>. It presents a filesystem-like interface,
> extended with event callbacks for coarse events, such as an end of
> CLD session.
>
> The patch converts all in-tree clients from cldc_xxx to ncld_xxx and
> discards some of code that became unused (test/util.c).
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
At a quick glance, looks good. A few nits like the "if (log)" stuff and
indenting struct field names jump out, but nothing major. I'll give it
a thorough review and apply on Monday...
Jeff
next prev parent reply other threads:[~2010-02-07 22:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 19:15 [Patch 1/1] CLD: Introduce the "New CLD" API Pete Zaitcev
2010-02-07 22:26 ` Jeff Garzik [this message]
2010-02-08 12:32 ` Jeff Garzik
2010-02-09 0:30 ` Pete Zaitcev
2010-02-09 6:25 ` Jeff Garzik
2010-02-09 1:46 ` Pete Zaitcev
2010-02-09 2:06 ` Jeff Garzik
2010-02-09 2:17 ` Pete Zaitcev
2010-02-09 4:55 ` Jeff Garzik
2010-02-09 5:35 ` Pete Zaitcev
2010-02-09 6:03 ` Jeff Garzik
2010-02-14 0:52 ` Jeff Garzik
2010-02-18 0:05 ` Pete Zaitcev
2010-02-18 1:18 ` Jeff Garzik
2010-02-19 1:35 ` Pete Zaitcev
2010-02-19 2:41 ` Jeff Garzik
2010-02-19 22:23 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6F3E26.8000808@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.