From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/1] CLD: Introduce the "New CLD" API
Date: Mon, 08 Feb 2010 23:55:03 -0500 [thread overview]
Message-ID: <4B70EAA7.4060806@garzik.org> (raw)
In-Reply-To: <20100208191701.6e15b452@redhat.com>
On 02/08/2010 09:17 PM, Pete Zaitcev wrote:
> On Mon, 08 Feb 2010 21:06:17 -0500
> Jeff Garzik<jeff@garzik.org> wrote:
>
>>> - if (cldc_getaddr(&host_list, hostb, NULL))
>>> + if (cldc_getaddr(&host_list, hostb,&ncld_log))
>>> return 1001;
>
>> Logging pointer should be supplied by the caller... that is the larger
>> bug. Needing a no-op log function is just an indication of that.
>
> I did it before, but then every client, without exception, needed
> to include<stdarg.h> and provide the log. And what for? This is
> STUPID and proof is in the pudding: your getsrvinfo does not do
> anything of the sort.
Possibly true -- but it is worse to introduce internal inconsistencies.
It is far better to remove debugging statements completely than to
create inconsistent usage.
> Might as well replace cldc_getadd with getsrvinfo
> and then everyone becomes happy.
Seems a good fit :)
Jeff
next prev parent reply other threads:[~2010-02-09 4:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 19:15 [Patch 1/1] CLD: Introduce the "New CLD" API Pete Zaitcev
2010-02-07 22:26 ` Jeff Garzik
2010-02-08 12:32 ` Jeff Garzik
2010-02-09 0:30 ` Pete Zaitcev
2010-02-09 6:25 ` Jeff Garzik
2010-02-09 1:46 ` Pete Zaitcev
2010-02-09 2:06 ` Jeff Garzik
2010-02-09 2:17 ` Pete Zaitcev
2010-02-09 4:55 ` Jeff Garzik [this message]
2010-02-09 5:35 ` Pete Zaitcev
2010-02-09 6:03 ` Jeff Garzik
2010-02-14 0:52 ` Jeff Garzik
2010-02-18 0:05 ` Pete Zaitcev
2010-02-18 1:18 ` Jeff Garzik
2010-02-19 1:35 ` Pete Zaitcev
2010-02-19 2:41 ` Jeff Garzik
2010-02-19 22:23 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B70EAA7.4060806@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.