* [PATCH -next] optprobes: fix kconfig depends/selects @ 2010-08-12 19:26 Randy Dunlap 2010-08-17 14:55 ` Masami Hiramatsu 2010-09-12 10:49 ` Felipe Contreras 0 siblings, 2 replies; 16+ messages in thread From: Randy Dunlap @ 2010-08-12 19:26 UTC (permalink / raw) To: lkml, linux-next Cc: Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, akpm From: Randy Dunlap <randy.dunlap@oracle.com> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> --- arch/Kconfig | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20100810.orig/arch/Kconfig +++ linux-next-20100810/arch/Kconfig @@ -45,6 +45,8 @@ config OPTPROBES def_bool y depends on KPROBES && HAVE_OPTPROBES depends on !PREEMPT + depends on DEBUG_KERNEL + select KALLSYMS select KALLSYMS_ALL config HAVE_EFFICIENT_UNALIGNED_ACCESS ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-08-12 19:26 [PATCH -next] optprobes: fix kconfig depends/selects Randy Dunlap @ 2010-08-17 14:55 ` Masami Hiramatsu 2010-08-17 15:03 ` Masami Hiramatsu 2010-09-12 10:49 ` Felipe Contreras 1 sibling, 1 reply; 16+ messages in thread From: Masami Hiramatsu @ 2010-08-17 14:55 UTC (permalink / raw) To: Randy Dunlap Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. > KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. Indeed, Thanks for pointing it! Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > --- > arch/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20100810.orig/arch/Kconfig > +++ linux-next-20100810/arch/Kconfig > @@ -45,6 +45,8 @@ config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > depends on !PREEMPT > + depends on DEBUG_KERNEL > + select KALLSYMS > select KALLSYMS_ALL > > config HAVE_EFFICIENT_UNALIGNED_ACCESS ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-08-17 14:55 ` Masami Hiramatsu @ 2010-08-17 15:03 ` Masami Hiramatsu 0 siblings, 0 replies; 16+ messages in thread From: Masami Hiramatsu @ 2010-08-17 15:03 UTC (permalink / raw) To: Randy Dunlap Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm Masami Hiramatsu wrote: > Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. > > Indeed, Thanks for pointing it! > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Oops, I meant; Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Sorry:( > >> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> --- >> arch/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20100810.orig/arch/Kconfig >> +++ linux-next-20100810/arch/Kconfig >> @@ -45,6 +45,8 @@ config OPTPROBES >> def_bool y >> depends on KPROBES && HAVE_OPTPROBES >> depends on !PREEMPT >> + depends on DEBUG_KERNEL >> + select KALLSYMS >> select KALLSYMS_ALL >> >> config HAVE_EFFICIENT_UNALIGNED_ACCESS > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-08-12 19:26 [PATCH -next] optprobes: fix kconfig depends/selects Randy Dunlap 2010-08-17 14:55 ` Masami Hiramatsu @ 2010-09-12 10:49 ` Felipe Contreras 2010-09-12 18:34 ` Randy Dunlap 2010-09-13 1:06 ` Masami Hiramatsu 1 sibling, 2 replies; 16+ messages in thread From: Felipe Contreras @ 2010-09-12 10:49 UTC (permalink / raw) To: Randy Dunlap Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, akpm On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. > KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. > > warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > --- > arch/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20100810.orig/arch/Kconfig > +++ linux-next-20100810/arch/Kconfig > @@ -45,6 +45,8 @@ config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > depends on !PREEMPT > + depends on DEBUG_KERNEL > + select KALLSYMS > select KALLSYMS_ALL > > config HAVE_EFFICIENT_UNALIGNED_ACCESS > -- This causes another problem: arch/Kconfig:33:error: recursive dependency detected! arch/Kconfig:33: symbol KPROBES depends on KALLSYMS init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES arch/Kconfig:44: symbol OPTPROBES depends on KPROBES The 'select KALLSYMS' is redundant. Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> -- Felipe Contreras ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-12 10:49 ` Felipe Contreras @ 2010-09-12 18:34 ` Randy Dunlap 2010-09-12 18:41 ` Felipe Contreras 2010-09-13 1:06 ` Masami Hiramatsu 1 sibling, 1 reply; 16+ messages in thread From: Randy Dunlap @ 2010-09-12 18:34 UTC (permalink / raw) To: Felipe Contreras Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, akpm On 09/12/10 03:49, Felipe Contreras wrote: > On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >> >> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> --- >> arch/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20100810.orig/arch/Kconfig >> +++ linux-next-20100810/arch/Kconfig >> @@ -45,6 +45,8 @@ config OPTPROBES >> def_bool y >> depends on KPROBES && HAVE_OPTPROBES >> depends on !PREEMPT >> + depends on DEBUG_KERNEL >> + select KALLSYMS >> select KALLSYMS_ALL >> >> config HAVE_EFFICIENT_UNALIGNED_ACCESS >> -- > > This causes another problem: > > arch/Kconfig:33:error: recursive dependency detected! > arch/Kconfig:33: symbol KPROBES depends on KALLSYMS > init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES > arch/Kconfig:44: symbol OPTPROBES depends on KPROBES > > The 'select KALLSYMS' is redundant. > > Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Thanks for checking. I saw this problem just a day or two ago myself. Dropping the select does not eliminate the kconfig warning. I'll try something else. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-12 18:34 ` Randy Dunlap @ 2010-09-12 18:41 ` Felipe Contreras 2010-09-12 18:46 ` Randy Dunlap 0 siblings, 1 reply; 16+ messages in thread From: Felipe Contreras @ 2010-09-12 18:41 UTC (permalink / raw) To: Randy Dunlap Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, akpm On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > On 09/12/10 03:49, Felipe Contreras wrote: >> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >>> >>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >>> Cc: "David S. Miller" <davem@davemloft.net> >>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>> --- >>> arch/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> --- linux-next-20100810.orig/arch/Kconfig >>> +++ linux-next-20100810/arch/Kconfig >>> @@ -45,6 +45,8 @@ config OPTPROBES >>> def_bool y >>> depends on KPROBES && HAVE_OPTPROBES >>> depends on !PREEMPT >>> + depends on DEBUG_KERNEL >>> + select KALLSYMS >>> select KALLSYMS_ALL >>> >>> config HAVE_EFFICIENT_UNALIGNED_ACCESS >>> -- >> >> This causes another problem: >> >> arch/Kconfig:33:error: recursive dependency detected! >> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS >> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES >> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES >> >> The 'select KALLSYMS' is redundant. >> >> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > Thanks for checking. I saw this problem just a day or two ago myself. > > Dropping the select does not eliminate the kconfig warning. > I'll try something else. Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'. -- Felipe Contreras ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-12 18:41 ` Felipe Contreras @ 2010-09-12 18:46 ` Randy Dunlap 0 siblings, 0 replies; 16+ messages in thread From: Randy Dunlap @ 2010-09-12 18:46 UTC (permalink / raw) To: Felipe Contreras Cc: lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, Masami Hiramatsu, akpm On Sun, 12 Sep 2010 21:41:07 +0300 Felipe Contreras wrote: > On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > On 09/12/10 03:49, Felipe Contreras wrote: > >> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > >>> From: Randy Dunlap <randy.dunlap@oracle.com> > >>> > >>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. > >>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. > >>> > >>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) > >>> > >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > >>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > >>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > >>> Cc: "David S. Miller" <davem@davemloft.net> > >>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > >>> --- > >>> arch/Kconfig | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> --- linux-next-20100810.orig/arch/Kconfig > >>> +++ linux-next-20100810/arch/Kconfig > >>> @@ -45,6 +45,8 @@ config OPTPROBES > >>> def_bool y > >>> depends on KPROBES && HAVE_OPTPROBES > >>> depends on !PREEMPT > >>> + depends on DEBUG_KERNEL > >>> + select KALLSYMS > >>> select KALLSYMS_ALL > >>> > >>> config HAVE_EFFICIENT_UNALIGNED_ACCESS > >>> -- > >> > >> This causes another problem: > >> > >> arch/Kconfig:33:error: recursive dependency detected! > >> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS > >> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES > >> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES > >> > >> The 'select KALLSYMS' is redundant. > >> > >> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > > > Thanks for checking. I saw this problem just a day or two ago myself. > > > > Dropping the select does not eliminate the kconfig warning. > > I'll try something else. > > Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'. not so in my testing. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-12 10:49 ` Felipe Contreras 2010-09-12 18:34 ` Randy Dunlap @ 2010-09-13 1:06 ` Masami Hiramatsu 2010-09-13 7:15 ` Masami Hiramatsu 1 sibling, 1 reply; 16+ messages in thread From: Masami Hiramatsu @ 2010-09-13 1:06 UTC (permalink / raw) To: Felipe Contreras Cc: Randy Dunlap, lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm, 2nddept-manager (2010/09/12 19:49), Felipe Contreras wrote: > On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >> >> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> --- >> arch/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20100810.orig/arch/Kconfig >> +++ linux-next-20100810/arch/Kconfig >> @@ -45,6 +45,8 @@ config OPTPROBES >> def_bool y >> depends on KPROBES && HAVE_OPTPROBES >> depends on !PREEMPT >> + depends on DEBUG_KERNEL >> + select KALLSYMS >> select KALLSYMS_ALL >> >> config HAVE_EFFICIENT_UNALIGNED_ACCESS >> -- > > This causes another problem: > > arch/Kconfig:33:error: recursive dependency detected! > arch/Kconfig:33: symbol KPROBES depends on KALLSYMS > init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES > arch/Kconfig:44: symbol OPTPROBES depends on KPROBES > > The 'select KALLSYMS' is redundant. > > Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > Thanks, let me clear the dependency; Kprobes uses kallsyms_lookup for finding target function and checking instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS and CONFIG_KALLSYMS_ALL. Optprobe is a optional feature which is supported on x86 arch, and it also uses kallsyms_lookup for checking instructions in the target function. Anyway, since optprobe itself is depends on kprobes, it doesn't need to select both of KALLSYMS/KALLSYMS_ALL. Thank you, -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-13 1:06 ` Masami Hiramatsu @ 2010-09-13 7:15 ` Masami Hiramatsu 2010-09-13 9:41 ` Felipe Contreras 2010-09-13 10:25 ` Masami Hiramatsu 0 siblings, 2 replies; 16+ messages in thread From: Masami Hiramatsu @ 2010-09-13 7:15 UTC (permalink / raw) To: Felipe Contreras Cc: Randy Dunlap, lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm, 2nddept-manager (2010/09/13 10:06), Masami Hiramatsu wrote: > (2010/09/12 19:49), Felipe Contreras wrote: >> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >>> >>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >>> Cc: "David S. Miller" <davem@davemloft.net> >>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>> --- >>> arch/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> --- linux-next-20100810.orig/arch/Kconfig >>> +++ linux-next-20100810/arch/Kconfig >>> @@ -45,6 +45,8 @@ config OPTPROBES >>> def_bool y >>> depends on KPROBES && HAVE_OPTPROBES >>> depends on !PREEMPT >>> + depends on DEBUG_KERNEL >>> + select KALLSYMS >>> select KALLSYMS_ALL >>> >>> config HAVE_EFFICIENT_UNALIGNED_ACCESS >>> -- >> >> This causes another problem: >> >> arch/Kconfig:33:error: recursive dependency detected! >> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS >> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES >> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES >> >> The 'select KALLSYMS' is redundant. >> >> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> >> > > Thanks, let me clear the dependency; > Kprobes uses kallsyms_lookup for finding target function and checking > instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS > and CONFIG_KALLSYMS_ALL. > Optprobe is a optional feature which is supported on x86 arch, and > it also uses kallsyms_lookup for checking instructions in the target > function. Anyway, since optprobe itself is depends on kprobes, it doesn't > need to select both of KALLSYMS/KALLSYMS_ALL. Hmm, wait, I might misunderstand something here. I thought KALLSYMS_ALL added symbols of static functions. But, does KALLSYMS_ALL just add symbols of variables? If so, both of KPROBES and OPTPROBES require only KALLSYMS. It means that they don't need to care about CONFIG_DEBUG_KERNEL. Thank you, -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-13 7:15 ` Masami Hiramatsu @ 2010-09-13 9:41 ` Felipe Contreras 2010-09-13 10:14 ` Masami Hiramatsu 2010-09-13 10:25 ` Masami Hiramatsu 1 sibling, 1 reply; 16+ messages in thread From: Felipe Contreras @ 2010-09-13 9:41 UTC (permalink / raw) To: Masami Hiramatsu Cc: Randy Dunlap, lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm, 2nddept-manager On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > (2010/09/13 10:06), Masami Hiramatsu wrote: >> (2010/09/12 19:49), Felipe Contreras wrote: >>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>>> From: Randy Dunlap <randy.dunlap@oracle.com> >>>> >>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >>>> >>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >>>> >>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >>>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >>>> Cc: "David S. Miller" <davem@davemloft.net> >>>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>>> --- >>>> arch/Kconfig | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> --- linux-next-20100810.orig/arch/Kconfig >>>> +++ linux-next-20100810/arch/Kconfig >>>> @@ -45,6 +45,8 @@ config OPTPROBES >>>> def_bool y >>>> depends on KPROBES && HAVE_OPTPROBES >>>> depends on !PREEMPT >>>> + depends on DEBUG_KERNEL >>>> + select KALLSYMS >>>> select KALLSYMS_ALL >>>> >>>> config HAVE_EFFICIENT_UNALIGNED_ACCESS >>>> -- >>> >>> This causes another problem: >>> >>> arch/Kconfig:33:error: recursive dependency detected! >>> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS >>> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES >>> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES >>> >>> The 'select KALLSYMS' is redundant. >>> >>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> >>> >> >> Thanks, let me clear the dependency; >> Kprobes uses kallsyms_lookup for finding target function and checking >> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS >> and CONFIG_KALLSYMS_ALL. >> Optprobe is a optional feature which is supported on x86 arch, and >> it also uses kallsyms_lookup for checking instructions in the target >> function. Anyway, since optprobe itself is depends on kprobes, it doesn't >> need to select both of KALLSYMS/KALLSYMS_ALL. > > Hmm, wait, I might misunderstand something here. I thought > KALLSYMS_ALL added symbols of static functions. > But, does KALLSYMS_ALL just add symbols of variables? > If so, both of KPROBES and OPTPROBES require only KALLSYMS. > It means that they don't need to care about CONFIG_DEBUG_KERNEL. So: - select KALLSYMS_ALL + depends on KALLSYMS_ALL Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS. -- Felipe Contreras ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-13 9:41 ` Felipe Contreras @ 2010-09-13 10:14 ` Masami Hiramatsu 2010-09-13 11:11 ` Felipe Contreras 0 siblings, 1 reply; 16+ messages in thread From: Masami Hiramatsu @ 2010-09-13 10:14 UTC (permalink / raw) To: Felipe Contreras Cc: Randy Dunlap, lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm, 2nddept-manager (2010/09/13 18:41), Felipe Contreras wrote: > On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu > <masami.hiramatsu.pt@hitachi.com> wrote: >> (2010/09/13 10:06), Masami Hiramatsu wrote: >>> (2010/09/12 19:49), Felipe Contreras wrote: >>>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>>>> From: Randy Dunlap <randy.dunlap@oracle.com> >>>>> >>>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >>>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >>>>> >>>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >>>>> >>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>>>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >>>>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >>>>> Cc: "David S. Miller" <davem@davemloft.net> >>>>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>>>> --- >>>>> arch/Kconfig | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> --- linux-next-20100810.orig/arch/Kconfig >>>>> +++ linux-next-20100810/arch/Kconfig >>>>> @@ -45,6 +45,8 @@ config OPTPROBES >>>>> def_bool y >>>>> depends on KPROBES && HAVE_OPTPROBES >>>>> depends on !PREEMPT >>>>> + depends on DEBUG_KERNEL >>>>> + select KALLSYMS >>>>> select KALLSYMS_ALL >>>>> >>>>> config HAVE_EFFICIENT_UNALIGNED_ACCESS >>>>> -- >>>> >>>> This causes another problem: >>>> >>>> arch/Kconfig:33:error: recursive dependency detected! >>>> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS >>>> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES >>>> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES >>>> >>>> The 'select KALLSYMS' is redundant. >>>> >>>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> >>>> >>> >>> Thanks, let me clear the dependency; >>> Kprobes uses kallsyms_lookup for finding target function and checking >>> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS >>> and CONFIG_KALLSYMS_ALL. >>> Optprobe is a optional feature which is supported on x86 arch, and >>> it also uses kallsyms_lookup for checking instructions in the target >>> function. Anyway, since optprobe itself is depends on kprobes, it doesn't >>> need to select both of KALLSYMS/KALLSYMS_ALL. >> >> Hmm, wait, I might misunderstand something here. I thought >> KALLSYMS_ALL added symbols of static functions. >> But, does KALLSYMS_ALL just add symbols of variables? >> If so, both of KPROBES and OPTPROBES require only KALLSYMS. >> It means that they don't need to care about CONFIG_DEBUG_KERNEL. > > So: > - select KALLSYMS_ALL > + depends on KALLSYMS_ALL > > Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS. No, what I meant is; - select KALLSYMS_ALL :-) -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH -next] optprobes: fix kconfig depends/selects 2010-09-13 10:14 ` Masami Hiramatsu @ 2010-09-13 11:11 ` Felipe Contreras 0 siblings, 0 replies; 16+ messages in thread From: Felipe Contreras @ 2010-09-13 11:11 UTC (permalink / raw) To: Masami Hiramatsu Cc: Randy Dunlap, lkml, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm, 2nddept-manager On Mon, Sep 13, 2010 at 1:14 PM, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > (2010/09/13 18:41), Felipe Contreras wrote: >> On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu >> <masami.hiramatsu.pt@hitachi.com> wrote: >>> (2010/09/13 10:06), Masami Hiramatsu wrote: >>>> (2010/09/12 19:49), Felipe Contreras wrote: >>>>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >>>>>> From: Randy Dunlap <randy.dunlap@oracle.com> >>>>>> >>>>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency. >>>>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL. >>>>>> >>>>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) >>>>>> >>>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >>>>>> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> >>>>>> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> >>>>>> Cc: "David S. Miller" <davem@davemloft.net> >>>>>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>>>>> --- >>>>>> arch/Kconfig | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> --- linux-next-20100810.orig/arch/Kconfig >>>>>> +++ linux-next-20100810/arch/Kconfig >>>>>> @@ -45,6 +45,8 @@ config OPTPROBES >>>>>> def_bool y >>>>>> depends on KPROBES && HAVE_OPTPROBES >>>>>> depends on !PREEMPT >>>>>> + depends on DEBUG_KERNEL >>>>>> + select KALLSYMS >>>>>> select KALLSYMS_ALL >>>>>> >>>>>> config HAVE_EFFICIENT_UNALIGNED_ACCESS >>>>>> -- >>>>> >>>>> This causes another problem: >>>>> >>>>> arch/Kconfig:33:error: recursive dependency detected! >>>>> arch/Kconfig:33: symbol KPROBES depends on KALLSYMS >>>>> init/Kconfig:825: symbol KALLSYMS is selected by OPTPROBES >>>>> arch/Kconfig:44: symbol OPTPROBES depends on KPROBES >>>>> >>>>> The 'select KALLSYMS' is redundant. >>>>> >>>>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> >>>>> >>>> >>>> Thanks, let me clear the dependency; >>>> Kprobes uses kallsyms_lookup for finding target function and checking >>>> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS >>>> and CONFIG_KALLSYMS_ALL. >>>> Optprobe is a optional feature which is supported on x86 arch, and >>>> it also uses kallsyms_lookup for checking instructions in the target >>>> function. Anyway, since optprobe itself is depends on kprobes, it doesn't >>>> need to select both of KALLSYMS/KALLSYMS_ALL. >>> >>> Hmm, wait, I might misunderstand something here. I thought >>> KALLSYMS_ALL added symbols of static functions. >>> But, does KALLSYMS_ALL just add symbols of variables? >>> If so, both of KPROBES and OPTPROBES require only KALLSYMS. >>> It means that they don't need to care about CONFIG_DEBUG_KERNEL. >> >> So: >> - select KALLSYMS_ALL >> + depends on KALLSYMS_ALL >> >> Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS. > > No, what I meant is; > - select KALLSYMS_ALL > > :-) Ohh, I didn't notice the _ALL. Makes sense. -- Felipe Contreras ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH -next,-tip ] kprobes: Fix Kconfig dependency 2010-09-13 7:15 ` Masami Hiramatsu @ 2010-09-13 10:25 ` Masami Hiramatsu 2010-09-13 10:25 ` Masami Hiramatsu 1 sibling, 0 replies; 16+ messages in thread From: Masami Hiramatsu @ 2010-09-13 10:25 UTC (permalink / raw) To: Ingo Molnar Cc: Ananth N Mavinakayanahalli, linux-kernel, 2nddept-manager, Masami Hiramatsu, Felipe Contreras, Randy Dunlap, linux-kernel, linux-next, Ananth N Mavinakayanahalli, Anil S Keshavamurthy, David S. Miller, akpm Fix Kconfig dependency among Kprobes, optprobe and kallsyms. Kprobes uses kallsyms_lookup for finding target function and checking instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS. Optprobe is an optional feature which is supported on x86 arch, and it also uses kallsyms_lookup for checking instructions in the target function. Since KALLSYMS_ALL just adds symbols of kernel variables, it doesn't need to select KALLSYMS_ALL. Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Felipe Contreras <felipe.contreras@gmail.com> Cc: Randy Dunlap <randy.dunlap@oracle.com>, Cc: linux-kernel@vger.kernel.org, Cc: linux-next@vger.kernel.org, Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>, Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Cc: "David S. Miller" <davem@davemloft.net>, Cc: akpm <akpm@linux-foundation.org> --- arch/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index 4877a8c..fe48fc7 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -32,8 +32,9 @@ config HAVE_OPROFILE config KPROBES bool "Kprobes" - depends on KALLSYMS && MODULES + depends on MODULES depends on HAVE_KPROBES + select KALLSYMS help Kprobes allows you to trap at almost any kernel address and execute a callback function. register_kprobe() establishes @@ -45,7 +46,6 @@ config OPTPROBES def_bool y depends on KPROBES && HAVE_OPTPROBES depends on !PREEMPT - select KALLSYMS_ALL config HAVE_EFFICIENT_UNALIGNED_ACCESS bool ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH -next,-tip ] kprobes: Fix Kconfig dependency @ 2010-09-13 10:25 ` Masami Hiramatsu 0 siblings, 0 replies; 16+ messages in thread From: Masami Hiramatsu @ 2010-09-13 10:25 UTC (permalink / raw) To: Ingo Molnar Cc: Ananth N Mavinakayanahalli, linux-kernel, 2nddept-manager, Masami Hiramatsu, Felipe Contreras, Randy Dunlap Fix Kconfig dependency among Kprobes, optprobe and kallsyms. Kprobes uses kallsyms_lookup for finding target function and checking instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS. Optprobe is an optional feature which is supported on x86 arch, and it also uses kallsyms_lookup for checking instructions in the target function. Since KALLSYMS_ALL just adds symbols of kernel variables, it doesn't need to select KALLSYMS_ALL. Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Felipe Contreras <felipe.contreras@gmail.com> Cc: Randy Dunlap <randy.dunlap@oracle.com>, Cc: linux-kernel@vger.kernel.org, Cc: linux-next@vger.kernel.org, Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>, Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Cc: "David S. Miller" <davem@davemloft.net>, Cc: akpm <akpm@linux-foundation.org> --- arch/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index 4877a8c..fe48fc7 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -32,8 +32,9 @@ config HAVE_OPROFILE config KPROBES bool "Kprobes" - depends on KALLSYMS && MODULES + depends on MODULES depends on HAVE_KPROBES + select KALLSYMS help Kprobes allows you to trap at almost any kernel address and execute a callback function. register_kprobe() establishes @@ -45,7 +46,6 @@ config OPTPROBES def_bool y depends on KPROBES && HAVE_OPTPROBES depends on !PREEMPT - select KALLSYMS_ALL config HAVE_EFFICIENT_UNALIGNED_ACCESS bool ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH -next,-tip ] kprobes: Fix Kconfig dependency 2010-09-13 10:25 ` Masami Hiramatsu (?) @ 2010-09-13 16:33 ` Randy Dunlap -1 siblings, 0 replies; 16+ messages in thread From: Randy Dunlap @ 2010-09-13 16:33 UTC (permalink / raw) To: Masami Hiramatsu Cc: Ingo Molnar, Ananth N Mavinakayanahalli, linux-kernel, 2nddept-manager, Felipe Contreras, linux-next, Anil S Keshavamurthy, David S. Miller, akpm On 09/13/10 03:25, Masami Hiramatsu wrote: > Fix Kconfig dependency among Kprobes, optprobe and kallsyms. > > Kprobes uses kallsyms_lookup for finding target function and checking > instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS. > > Optprobe is an optional feature which is supported on x86 arch, and > it also uses kallsyms_lookup for checking instructions in the target > function. Since KALLSYMS_ALL just adds symbols of kernel variables, > it doesn't need to select KALLSYMS_ALL. > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Cc: Felipe Contreras <felipe.contreras@gmail.com> > Cc: Randy Dunlap <randy.dunlap@oracle.com>, > Cc: linux-kernel@vger.kernel.org, > Cc: linux-next@vger.kernel.org, > Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>, > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, > Cc: "David S. Miller" <davem@davemloft.net>, > Cc: akpm <akpm@linux-foundation.org> > --- > > arch/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 4877a8c..fe48fc7 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -32,8 +32,9 @@ config HAVE_OPROFILE > > config KPROBES > bool "Kprobes" > - depends on KALLSYMS && MODULES > + depends on MODULES > depends on HAVE_KPROBES > + select KALLSYMS > help > Kprobes allows you to trap at almost any kernel address and > execute a callback function. register_kprobe() establishes > @@ -45,7 +46,6 @@ config OPTPROBES > def_bool y > depends on KPROBES && HAVE_OPTPROBES > depends on !PREEMPT > - select KALLSYMS_ALL > > config HAVE_EFFICIENT_UNALIGNED_ACCESS > bool > Fixes the kconfig dependency problem. Thanks. Acked-by: Randy Dunlap <randy.dunlap@oracle.com> -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 16+ messages in thread
* [tip:perf/urgent] kprobes: Fix Kconfig dependency 2010-09-13 10:25 ` Masami Hiramatsu (?) (?) @ 2010-09-13 19:54 ` tip-bot for Masami Hiramatsu -1 siblings, 0 replies; 16+ messages in thread From: tip-bot for Masami Hiramatsu @ 2010-09-13 19:54 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, randy.dunlap, davem, anil.s.keshavamurthy, ananth, masami.hiramatsu.pt, akpm, tglx, felipe.contreras, mingo Commit-ID: 05ed160e89baf7f5fb3432d527fec467d2493626 Gitweb: http://git.kernel.org/tip/05ed160e89baf7f5fb3432d527fec467d2493626 Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> AuthorDate: Mon, 13 Sep 2010 19:25:41 +0900 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Mon, 13 Sep 2010 20:41:31 +0200 kprobes: Fix Kconfig dependency Fix Kconfig dependency among Kprobes, optprobe and kallsyms. Kprobes uses kallsyms_lookup for finding target function and checking instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS. Optprobe is an optional feature which is supported on x86 arch, and it also uses kallsyms_lookup for checking instructions in the target function. Since KALLSYMS_ALL just adds symbols of kernel variables, it doesn't need to select KALLSYMS_ALL. Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>, Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Felipe Contreras <felipe.contreras@gmail.com> Cc: Randy Dunlap <randy.dunlap@oracle.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: David S. Miller <davem@davemloft.net> Cc: akpm <akpm@linux-foundation.org> LKML-Reference: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index 4877a8c..fe48fc7 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -32,8 +32,9 @@ config HAVE_OPROFILE config KPROBES bool "Kprobes" - depends on KALLSYMS && MODULES + depends on MODULES depends on HAVE_KPROBES + select KALLSYMS help Kprobes allows you to trap at almost any kernel address and execute a callback function. register_kprobe() establishes @@ -45,7 +46,6 @@ config OPTPROBES def_bool y depends on KPROBES && HAVE_OPTPROBES depends on !PREEMPT - select KALLSYMS_ALL config HAVE_EFFICIENT_UNALIGNED_ACCESS bool ^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2010-09-13 19:56 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-08-12 19:26 [PATCH -next] optprobes: fix kconfig depends/selects Randy Dunlap 2010-08-17 14:55 ` Masami Hiramatsu 2010-08-17 15:03 ` Masami Hiramatsu 2010-09-12 10:49 ` Felipe Contreras 2010-09-12 18:34 ` Randy Dunlap 2010-09-12 18:41 ` Felipe Contreras 2010-09-12 18:46 ` Randy Dunlap 2010-09-13 1:06 ` Masami Hiramatsu 2010-09-13 7:15 ` Masami Hiramatsu 2010-09-13 9:41 ` Felipe Contreras 2010-09-13 10:14 ` Masami Hiramatsu 2010-09-13 11:11 ` Felipe Contreras 2010-09-13 10:25 ` [PATCH -next,-tip ] kprobes: Fix Kconfig dependency Masami Hiramatsu 2010-09-13 10:25 ` Masami Hiramatsu 2010-09-13 16:33 ` Randy Dunlap 2010-09-13 19:54 ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.